for the pad
device for obvious reasons ;)). At this point in time, there is absolutely
no reason to store a second copy of the strip values in oldTilt[XY].
Signed-off-by: Jason Gerecke killert...@gmail.com
Reviewed-by: Ping Cheng pi...@wacom.com
Ping
---
src/wcmCommon.c | 15
On Thu, Apr 10, 2014 at 10:25 AM, Jason Gerecke killert...@gmail.comwrote:
The use of each of these variables was eradicated around the turn
of 2010 (commits d7dcb7d, 57fdd26, and f934866).
Signed-off-by: Jason Gerecke killert...@gmail.com
Acked-by: Ping Cheng pi...@wacom.com
Mapping
Hi Bob,
Thank you for purchasing Intuos Pro. The USB interface does not have
problem. If there is anything that requires extra work from end users, I'd
say that is an open source/Linux feature :-).
Depends on the version of Linux kernel your system is running, you may need
to update Wacom driver
wcmTouchDevice for touch interface
Support hardware touch switch
Ping Cheng (1):
Improve wcmLinkTouchAndPen device matching
include/wacom-properties.h | 3 +
man/xsetwacom.man | 6 ++
src/wcmConfig.c| 177
+++--
src/wcmUSB.c
Signed-off-by: Ping Cheng pi...@wacom.com
---
data/dtu-1031.tablet | 37 +
1 file changed, 37 insertions(+)
create mode 100644 data/dtu-1031.tablet
diff --git a/data/dtu-1031.tablet b/data/dtu-1031.tablet
new file mode 100644
index 000..236383e
--- /dev
bustype that matches.
The output is 39kb now vs 100kb before. If that was the goal, then:
Tested-by: Ping Cheng pingli...@gmail.com
Ping
tools/list-devices.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/list-devices.c b/tools/list-devices.c
index 79d13e8
On Wed, Feb 5, 2014 at 5:31 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Wed, Feb 05, 2014 at 03:40:19PM -0800, Ping Cheng wrote:
On Tue, Feb 4, 2014 at 8:04 PM, Peter Hutterer peter.hutte...@who-t.net
wrote:
...
device-num_strips = g_key_file_get_integer(keyfile
Reuse the routine that links tools with the same product ID devices
for different product ID devices to avoid duplicated code.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmConfig.c | 79 +
1 file changed, 35 insertions(+), 44
interface is a touch tool. Assign it to wcmTouchDevice to avoid
looping through the tool list everytime when we need to access it.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmConfig.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/src/wcmConfig.c
.
HardwareTouch, a new xsetwacom option, is added. This option
is read-only since the state can only be changed by end users.
This option is independent from the existing Touch option,
which can be considered as a software touch switch.
Signed-off-by: Ping Cheng pi...@wacom.com
---
include/wacom
On Mon, Feb 3, 2014 at 5:51 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Mon, Feb 03, 2014 at 04:22:11PM -0800, Ping Cheng wrote:
New Intuos series introduced a hardware switch to turn touch
events on/off. This patch retrieves its state from kernel by
checking if SW_MUTE_DEVICE
On Tue, Jan 28, 2014 at 7:01 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Fri, Jan 24, 2014 at 05:23:47PM -0800, Ping Cheng wrote:
Tools defined for devices that support both pen and touch need
to access the touch tool for arbitration and touch switch state
updates. Initially
On Thu, Jan 23, 2014 at 10:45 PM, Peter Hutterer
peter.hutte...@who-t.netwrote:
On Wed, Jan 22, 2014 at 08:28:23PM -0800, Ping Cheng wrote:
On Tue, Jan 21, 2014 at 8:01 PM, Peter Hutterer
peter.hutte...@who-t.netjavascript:_e({}, 'cvml',
'peter.hutte...@who-t.net');
wrote:
On Fri
Tools defined for devices that support both pen and touch need
to access the touch tool for arbitration and touch switch state
updates. Initially searching for the touch tool and storing it
to common-wcmTouchDevice saves time later when we need to access it.
TabletFeature is updated with
On Tue, Jan 21, 2014 at 8:01 PM, Peter Hutterer
peter.hutte...@who-t.netjavascript:_e({}, 'cvml',
'peter.hutte...@who-t.net');
wrote:
On Fri, Jan 17, 2014 at 05:54:33PM -0800, Ping Cheng wrote:
On Thu, Jan 16, 2014 at 8:49 PM, Peter Hutterer
peter.hutte...@who-t.net javascript:_e({}, 'cvml
A new key word, Touchswitch, is added to wacom.example to
indicate if the device has touch switch or not.
SVG file names are added in [Device] Layout= as comments.
But they are not included in this commit. We need people
with Inkscape experience to create the SVG files.
Signed-off-by: Ping Cheng
On Sun, Jan 12, 2014 at 8:58 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Thu, Jan 09, 2014 at 02:15:14PM -0800, Ping Cheng wrote:
A new key word, Touchswitch, is added to wacom.example to
indicate if the device has touch switch or not. SVG file names
are added in [Device] Layout
On Mon, Jan 13, 2014 at 1:45 AM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Wed, Jan 08, 2014 at 02:50:11PM -0800, Ping Cheng wrote:
wcmLinkTouchAndPen only assigned touch to tablet (pen) interface.
New Intuos series requires another tool (pad in this case) on the
same interface
is necessary to guarantee we link pen and touch
tools.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmConfig.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/wcmConfig.c b/src/wcmConfig.c
index 2d19944..6891ca6 100644
--- a/src/wcmConfig.c
+++ b/src
by end user through touch switch.
A new xsetwacom option, HardwareTouch, is also added. This
option is read-only since the state can only be changed by end
users. This option is independent from the existing Touch option,
which can be considered as a software touch switch.
Signed-off-by: Ping
On Sun, Jan 5, 2014 at 8:55 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Tue, Dec 24, 2013 at 10:04:34AM -0800, Ping Cheng wrote:
New Intuos series introduced a hardware switch to turn touch
events on/off. This patch retrieves its state from kernel by
checking if SW_MUTE_DEVICE
by end user through
touch switch.
A new xsetwacom option, HardwareTouch, is also added. This
option is read-only since the state can only be changed by end
users. This option is independent from the existing Touch option,
which can be considered as a software touch switch.
Signed-off-by: Ping
On Mon, Nov 18, 2013 at 11:09 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
Avoids a warning about uneven ifdef/endif pairs
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Acked-by: Ping Cheng pi...@wacom.com for both patches.
Ping
---
libwacom/libwacom.h | 2 ++
1 file
On Wed, Oct 9, 2013 at 9:05 PM, Peter Hutterer peter.hutte...@who-t.net wrote:
On Wed, Oct 09, 2013 at 05:42:39PM -0700, Ping Cheng wrote:
On Wed, Oct 9, 2013 at 4:59 PM, Peter Hutterer peter.hutte...@who-t.net
wrote:
On Wed, Oct 09, 2013 at 09:19:28AM -0700, Ping Cheng wrote:
On Tue, Oct
This patch also removes redundant device name in X_PROBED messages.
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2: Update commit comments
---
src/wcmCommon.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git
killert...@gmail.com
Acked-by: Peter Hutterer peter.hutte...@who-t.net
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2: Update commit comments
---
src/wcmUSB.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index eaaf854
INPUT_PROP_DIRECT is defined.
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2: Incorporate review comments from Peter Hutterer
---
src/wcmValidateDevice.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
index 1a5e722..0dbfdb4 100644
On Wed, Oct 9, 2013 at 7:12 AM, Bastien Nocera had...@hadess.net wrote:
On Tue, 2013-10-08 at 11:36 -0700, Jason Gerecke wrote:
On Tue, Oct 8, 2013 at 11:18 AM, Bastien Nocera had...@hadess.net wrote:
On Tue, 2013-10-08 at 11:08 -0700, Ping Cheng wrote:
On Tue, Oct 8, 2013 at 12:07 AM
On Wednesday, October 9, 2013, Peter Hutterer wrote:
On Wed, Oct 09, 2013 at 05:42:39PM -0700, Ping Cheng wrote:
On Wed, Oct 9, 2013 at 4:59 PM, Peter Hutterer
peter.hutte...@who-t.netjavascript:;
wrote:
On Wed, Oct 09, 2013 at 09:19:28AM -0700, Ping Cheng wrote:
On Tue, Oct 8, 2013
On Tuesday, October 8, 2013, Peter Hutterer wrote:
On Mon, Oct 07, 2013 at 11:57:16AM -0700, Ping Cheng wrote:
On Sunday, October 6, 2013, Peter Hutterer wrote:
On Thu, Oct 03, 2013 at 05:18:26PM -0700, Ping Cheng wrote:
Some devices send expresskeys on its own interface
On Thu, Oct 3, 2013 at 9:59 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Thu, Oct 03, 2013 at 05:17:48PM -0700, Ping Cheng wrote:
And wcmThreshold applies to pen (stylus and eraser) tools.
Signed-off-by: Ping Cheng pi...@wacom.com
---
please swap the two commit sentences around
On Fri, Oct 4, 2013 at 11:53 AM, Jason Gerecke killert...@gmail.com wrote:
On Thu, Oct 3, 2013 at 5:18 PM, Ping Cheng pingli...@gmail.com wrote:
On touch enabled devices, we miss pad events when nothing touches
tablet.
This commit message needs to be expanded. I have no idea what what
On Fri, Oct 4, 2013 at 11:59 AM, Jason Gerecke killert...@gmail.com wrote:
On Thu, Oct 3, 2013 at 5:18 PM, Ping Cheng pingli...@gmail.com wrote:
Some devices send expresskeys on its own interface, that is, there
is no motion/pointer events associated with the pad interface.
This patch handles
And wcmThreshold applies to pen (stylus and eraser) tools.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmCommon.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index c81310f..df71842 100644
--- a/src/wcmCommon.c
+++ b
Some devices send expresskeys on its own interface, that is, there
is no motion/pointer events associated with the pad interface.
This patch handles above case.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmUSB.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src
On touch enabled devices, we miss pad events when nothing touches
tablet.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmUSB.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index eaaf854..634eb1c 100644
kernel 3.7 introduced INPUT_PROP_DIRECT to indicate a device is
a direct touch (onscreen pointer) device. Use it so we do not
have to add individual devcies for that feature.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmValidateDevice.c | 13 +
1 file changed, 13 insertions
On Thursday, October 3, 2013, Peter Hutterer wrote:
On Thu, Oct 03, 2013 at 05:18:41PM -0700, Ping Cheng wrote:
kernel 3.7 introduced INPUT_PROP_DIRECT to indicate a device is
a direct touch (onscreen pointer) device. Use it so we do not
have to add individual devcies for that feature
On Fri, Sep 27, 2013 at 11:32 AM, Jason Gerecke killert...@gmail.comwrote:
On Fri, Sep 27, 2013 at 10:35 AM, Chris Bagwell ch...@cnpbagwell.com
wrote:
Hi Jason,
I'd be happy to review these patches if you want it but can you give a
little more context for the series on them?
For
On Mon, Sep 16, 2013 at 8:42 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Wed, Sep 11, 2013 at 06:01:49PM -0700, Ping Cheng wrote:
New Cintiq/Intuos Pro Pen looks very close to the existing Classic
Pen. Use the Classic image so we do not have to create a new one
for Pro Pen since
On Sun, Sep 15, 2013 at 11:48 PM, Peter Hutterer
peter.hutte...@who-t.netwrote:
On Fri, Sep 13, 2013 at 11:02:02AM -0700, Jason Gerecke wrote:
On Thu, Sep 12, 2013 at 4:20 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Wed, Sep 11, 2013 at 06:01:49PM -0700, Ping Cheng wrote:
New
On Thu, Sep 12, 2013 at 9:18 AM, Jason Gerecke killert...@gmail.com wrote:
On Wed, Sep 11, 2013 at 6:01 PM, Ping Cheng pingli...@gmail.com wrote:
New Cintiq/Intuos Pro Pen looks very close to the existing Classic
Pen. Use the Classic image so we do not have to create a new one
for Pro Pen
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2: updated to fix make check error.
---
data/intuos-pro-l.tablet | 67 +++
data/intuos-pro-m.tablet | 67 +++
data/intuos-pro-s.tablet | 65 +++
data/layouts/intuos-pro-l.svg | 263
New Cintiq/Intuos Pro Pen looks very close to the existing Classic
Pen. Use the Classic image so we do not have to create a new one
for Pro Pen since the person who planned to add an image for Pro
Pen does not have time to work on this project any more.
Signed-off-by: Ping Cheng pi...@wacom.com
:
Reviewed-by: Ping Cheng pi...@wacom.com
Thanks,
Ping
--
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2: updated to new WacomModelDesc format
---
src/wcmUSB.c| 4
src/wcmValidateDevice.c | 3 +++
2 files changed, 7 insertions(+)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index
On Tuesday, September 10, 2013, Peter Hutterer wrote:
On Fri, Sep 06, 2013 at 05:59:11PM -0700, Ping Cheng wrote:
Signed-off-by: Ping Cheng pi...@wacom.com
---
data/intuos-pro-l.tablet | 67 +++
data/intuos-pro-m.tablet | 67 +++
data/intuos-pro-s.tablet
On Tuesday, September 10, 2013, Arjuna Rao Chavala wrote:
Ping,
2013/8/15 Ping Cheng pingli...@gmail.com javascript:_e({}, 'cvml',
'pingli...@gmail.com');
--cut--
It is nice to know everything works alright now. Thank you Arjuna for
your kindly offer. There are two models in this series
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmUSB.c| 5 +
src/wcmValidateDevice.c | 3 +++
2 files changed, 8 insertions(+)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index f1504cf..f2df87e 100644
--- a/src/wcmUSB.c
+++ b/src/wcmUSB.c
@@ -97,6 +97,7 @@ DEFINE_MODEL
Signed-off-by: Ping Cheng pi...@wacom.com
---
data/intuos-pro-l.tablet | 67 +++
data/intuos-pro-m.tablet | 67 +++
data/intuos-pro-s.tablet | 65 +++
data/layouts/intuos-pro-l.svg | 263 ++
data/layouts/intuos-pro
On Mon, Sep 2, 2013 at 8:16 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
On Mon, Sep 02, 2013 at 07:43:42PM -0700, Ping Cheng wrote:
On Friday, August 30, 2013, Peter Hutterer wrote:
When the driver starts, print the list of supported models. This should
help with any questions
?
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Acked-by: Ping Cheng pi...@wacom.com
Thank you for fixing the issue.
Ping
---
src/wcmValidateDevice.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
index
On Friday, August 30, 2013, Peter Hutterer wrote:
When the driver starts, print the list of supported models. This should
help with any questions like does my driver support this or that model.
For those models that don't have a defined name, print usb:1234:5678
instead, so users can at
Hi Nicolas, hi Hendrik,
I do not have an E6 system to test with. So, I tested it with an E3 system,
which has the same pen and touch models as E6. Except item 4, everything
else looked fine.
Even for item 4, it is not a bug, at least from driver's point of view ;-).
It was designed that way.
We
Hi Hendrik,
Before testing the issues, I'd like to make sure we work on the same
environment. Please give me the versions of the following from your system:
XInput; X server; Linux kernel; and Wacom kernel driver.
Thanks,
Ping
On Tue, Aug 20, 2013 at 1:58 PM, Hendrik Woidt
On Wed, Aug 14, 2013 at 10:27 PM, Arjuna Rao Chavala
arjunar...@gmail.comwrote:
Hi Chris and Ping,
Thanks for your quick replies
2013/8/15 Ping Cheng pingli...@gmail.com
Hi Arjuna,
Please see my comments inline.
On Wed, Aug 14, 2013 at 10:05 AM, Arjuna Rao Chavala
arjunar
On Sunday, June 2, 2013, Peter Hutterer peter.hutte...@who-t.net wrote:
On Wed, May 22, 2013 at 08:18:25PM -0700, Ping Cheng wrote:
On Wednesday, May 22, 2013, Peter Hutterer wrote:
On Wed, May 22, 2013 at 12:38:05PM -0700, Ping Cheng wrote:
5 new styli are added for Cintiq 21UX2, 22HD
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2: Updated [Buttons] for Cintiq 13HD.
Thanks go to Peter's insight review.
---
data/cintiq-13hd.tablet | 42 ++
data/dth-2242.tablet| 39 +++
data/dtk-2241.tablet| 38
From: Joaquim Rocha jro...@redhat.com
Signed-off-by: Joaquim Rocha jro...@redhat.com
---
data/layouts/cintiq-13hd.svg | 233 +++
1 file changed, 233 insertions(+)
create mode 100644 data/layouts/cintiq-13hd.svg
diff --git a/data/layouts/cintiq-13hd.svg
From: Joaquim Rocha jro...@redhat.com
Signed-off-by: Joaquim Rocha jro...@redhat.com
Signed-off-by: Ping Cheng pi...@wacom.com
---
data/layouts/dth-2242.svg | 139 ++
1 file changed, 139 insertions(+)
create mode 100644 data/layouts/dth-2242.svg
diff
5 new styli are added for Cintiq 21UX2, 22HD, 24HD and Intuos 4 and 5.
Signed-off-by: Ping Cheng pi...@wacom.com
---
data/cintiq-21ux2.tablet | 2 +-
data/cintiq-22hd.tablet | 2 +-
data/cintiq-24hd-touch.tablet | 2 +-
data/cintiq-24hd.tablet | 2 +-
data/intuos4-12x19
Signed-off-by: Ping Cheng pi...@wacom.com
---
data/cintiq-13hd.tablet | 42 ++
data/dth-2242.tablet| 39 +++
data/dtk-2241.tablet| 38 ++
3 files changed, 119 insertions
From: Joaquim Rocha jro...@redhat.com
Signed-off-by: Joaquim Rocha jro...@redhat.com
---
data/layouts/cintiq-13hd.svg | 233 +++
1 file changed, 233 insertions(+)
create mode 100644 data/layouts/cintiq-13hd.svg
diff --git a/data/layouts/cintiq-13hd.svg
On Wednesday, May 22, 2013, Peter Hutterer wrote:
On Wed, May 22, 2013 at 12:38:05PM -0700, Ping Cheng wrote:
5 new styli are added for Cintiq 21UX2, 22HD, 24HD and Intuos 4 and 5.
Signed-off-by: Ping Cheng pi...@wacom.com javascript:;
---
data/cintiq-13hd.tablet | 2 +-
data
I'll fix that.
--
Joaquim Rocha
http://www.joaquimrocha.com
- Original Message -
From: Ping Cheng pingli...@gmail.com
To: Joaquim Rocha jro...@redhat.com
Cc: linuxwacom-devel@lists.sourceforge.net
Sent: Monday, May 20, 2013 7:10:07 AM
Subject: Re: [Linuxwacom-devel] New layouts
Signed-off-by: Ping Cheng pi...@wacom.com
---
data/cintiq-13hd.tablet | 43 +++
data/dth-2242.tablet| 40
data/dtk-2241.tablet| 39 +++
3 files changed, 122 insertions
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmUSB.c| 4
src/wcmValidateDevice.c | 8 +++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index 3751de9..af0f357 100644
--- a/src/wcmUSB.c
+++ b/src/wcmUSB.c
@@ -277,6 +277,10
-by (and your reviewed-by) to the patch:
Acked-by: Ping Cheng pingli...@gmail.com
Ping
Hopefully you'll also find it useful and we'll include it in the next
release.
Best regards,
--
Joaquim Rocha
http://www.joaquimrocha.com
On Thursday, May 16, 2013, Joaquim Rocha wrote:
I know, it would be very helpful if I had attached the actual patches so
here it goes.
The SVGs look good. Three new data files go with these SVGs will be posted
tomorrow. xf86-input-wacom will also be updated.
Ping
--
Joaquim Rocha
-by: Peter Hutterer peter.hutte...@who-t.net javascript:;
With your commit comments, both sets of 3 patches look good. I assume
you've tested the driver already. So,
Reviewed-by: Ping Cheng pingli...@gmail.com for both patch sets.
Ping
---
src/xf86Wacom.c | 21 +++--
1 file
On Mon, May 6, 2013 at 9:22 AM, Alexander Maret-Huskinson a...@maret.dewrote:
Am Montag, 6. Mai 2013, 10:07:46 schrieb Peter Hutterer:
On Sat, May 04, 2013 at 09:32:28PM +0200, Alexander Maret-Huskinson
wrote:
Hi,
when using xsetwacom 0.21.0 to set express key shortcuts it is
On Mon, May 6, 2013 at 10:28 AM, Alexander Maret-Huskinson a...@maret.dewrote:
**
Thanks for the clarification about the symbols. It seems that on Ubuntu
12.04
not all symbols can be resolved even though they are listed in
keysymdef.h.
About the crash:
I
On Wed, May 1, 2013 at 4:40 PM, Peter Hutterer peter.hutte...@who-t.netwrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Ping Cheng pingli...@gmail.com
Thank you Peter for the clarification.
Ping
---
man/xsetwacom.man | 8
1 file changed, 8 insertions
,
Acked-by: Ping Cheng pingli...@gmail.com
Ping
---
src/wcmValidateDevice.c | 4
src/xf86WacomDefs.h | 1 -
2 files changed, 5 deletions(-)
diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
index 81e9a2a..8e27bb1 100644
--- a/src/wcmValidateDevice.c
+++ b/src
On Sun, Apr 28, 2013 at 10:18 PM, Peter Hutterer
peter.hutte...@who-t.netwrote:
Punctuation marks and others map to XK_* keysyms but only in their named
form, not in their single-character symbol form.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Reviewed-by: Ping Cheng pingli
It is a Wacom device found in Fujitsu Lifebook T902.
Signed-off-by: Stephan Frank sfr...@cs.tu-berlin.de
Acked-by: Ping Cheng pi...@wacom.com
---
src/wcmUSB.c|1 +
src/wcmValidateDevice.c |1 +
2 files changed, 2 insertions(+)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index
Make room to report pen and touch events simultaneously
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2: added comments as Chris' suggested.
---
src/xf86WacomDefs.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h
index
usbInitToolType retrieves device type from the kernel when tool
is on the tablet at X server startup. No need to do it again later.
Since kernel does not have a specific device type for PAD, we have
to check the actual events to set its type.
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2
The extra wcmEvent call was to deal with generic PAD events received
without motion events in the same packet. Those PAD events would be
filtered out by the device type retrieving code later.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmUSB.c | 13 -
1 file changed, 13
On Thu, Feb 28, 2013 at 11:36 AM, Chris Bagwell ch...@cnpbagwell.com wrote:
On Tue, Feb 26, 2013 at 3:07 PM, Ping Cheng pingli...@gmail.com wrote:
Make room to report pen and touch events simultaneously
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/xf86WacomDefs.h |6 +++---
1
Make room to report pen and touch events simultaneously
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2: added comments as Chris' suggested.
---
src/xf86WacomDefs.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h
index
Make room to report pen and touch events simultaneously
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/xf86WacomDefs.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h
index fe078ec..091e5c8 100644
--- a/src/xf86WacomDefs.h
usbInitToolType retrieves device type from the kernel when tool
is on the tablet when X server starts. No need to do it again later.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmUSB.c | 72 --
1 file changed, 5 insertions(+), 67
is repeated instead of
combined.
Signed-off-by: Ping Cheng pi...@wacom.com
v2: return as soon as the device is linked. Updated Copyright.
---
src/wcmConfig.c | 40 ++--
1 file changed, 34 insertions(+), 6 deletions(-)
diff --git a/src/wcmConfig.c b/src/wcmConfig.c
Arbitration did not work as expected since common is meant for tools
on the same logical port, not for tools of the same physical device
or of the same product id. Plus, not all devices support touch.
Signed-off-by: Ping Cheng pi...@wacom.com
---
v2: make sure the device support touch
---
src
We do not allow finger competes with CURSOR.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmCommon.c | 10 +-
src/wcmConfig.c | 10 +-
src/wcmUSB.c| 21 +++--
src/xf86WacomDefs.h |1 +
4 files changed, 22 insertions(+), 20 deletions
is repeated instead of
combined.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmConfig.c | 44 +++-
1 file changed, 39 insertions(+), 5 deletions(-)
diff --git a/src/wcmConfig.c b/src/wcmConfig.c
index 1c9eae7..b0bf671 100644
--- a/src/wcmConfig.c
+++ b
From: ping Cheng pi...@wacom.com
We do not allow finger competes with CURSOR.
Signed-off-by: Ping Cheng pi...@wacom.com
---
src/wcmCommon.c | 12 ++--
src/wcmConfig.c | 10 +-
src/wcmUSB.c| 21 +++--
src/xf86WacomDefs.h |1 +
4 files
manpage is also updated accordingly.
Reported-by: Nikolai Neff gefrierbr...@users.sf.net
Signed-off-by: Ping Cheng pingli...@gmail.com
---
man/wacom.man |6 +++---
man/xsetwacom.man |5 +
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/man/wacom.man b/man/wacom.man
On Monday, January 21, 2013, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net javascript:;
Thank you, Peter. This patch is
Reviewed-by: Ping Cheng pingli...@gmail.com.
Ping
---
This one is necessary to pass errors in the button properties up the stack
e.g
On Sunday, January 20, 2013, Peter Hutterer wrote:
The server doesn't interpret %g, use %f instead. tbh, right now it doesn't
interpret %f either, but there's patches on the way for that.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net javascript:;
Acked-by: Ping Cheng pingli
instead.
If you say so, it is, so ;-)
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
Acked-by: Ping Cheng pingli...@gmail.com
Ping
---
test/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/Makefile.am b/test/Makefile.am
index 8011ddb
BTNChannel is static for all devices, not just geneic devices.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmUSB.c |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index 4c83cf3..3089581 100644
--- a/src/wcmUSB.c
+++ b/src
DOUBLETAP and TRIPLETAP are duplicated events in type-B MT format.
We do not use them in this driver. Plus, they could be confused
by fake MT events on older kernels.
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmUSB.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/src
On Sun, Dec 16, 2012 at 1:40 PM, Chris Bagwell ch...@cnpbagwell.com wrote:
On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng pingli...@gmail.com wrote:
If we wait until we finish other verifications, we could miss
PAD events since they will be filtered out when there are no
motion events sent
, 2012 at 2:16 PM, Ping Cheng pingli...@gmail.com wrote:
We use true MT protocol for MT devices in kernel now. This code
was introduced to deal with ABS_TOOL_*TAP events loss issue. It
is uncessary any more. And its existence makes it hard to support
generic PAD cleanly.
I can't think of any
On Sunday, December 16, 2012, Chris Bagwell wrote:
On Sun, Dec 16, 2012 at 7:17 PM, Ping Cheng
pingli...@gmail.comjavascript:_e({}, 'cvml', 'pingli...@gmail.com');
wrote:
On Sun, Dec 16, 2012 at 1:40 PM, Chris Bagwell
ch...@cnpbagwell.comjavascript:_e({}, 'cvml', 'ch...@cnpbagwell.com
On Sunday, December 16, 2012, Ping Cheng wrote:
On Sunday, December 16, 2012, Chris Bagwell wrote:
On Sun, Dec 16, 2012 at 7:17 PM, Ping Cheng pingli...@gmail.com wrote:
On Sun, Dec 16, 2012 at 1:40 PM, Chris Bagwell ch...@cnpbagwell.comwrote:
On Thu, Dec 13, 2012 at 2:18 PM, Ping
On Sunday, December 16, 2012, Peter Hutterer wrote:
On Thu, Dec 13, 2012 at 10:19:09PM -0800, Ping Cheng wrote:
On Thursday, December 13, 2012, Peter Hutterer wrote:
On Thu, Dec 13, 2012 at 12:16:52PM -0800, Ping Cheng wrote:
We use true MT protocol for MT devices in kernel now
at 9:37 PM, Peter Hutterer
peter.hutte...@who-t.netwrote:
On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote:
On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke killert...@gmail.com
wrote:
It certainly doesn't hurt :) I think my biggest problem is that I
never
really understood
101 - 200 of 780 matches
Mail list logo
