Re: [Linuxwacom-devel] [PATCH 4/4] Interpret threshold for button click relative to pressure curve.

2011-02-07 Thread Jason Gerecke
Is [0..2024] really the normalized pressure range? Wouldn't [0..2048] be correct since its the range of the pressure curve mapping? (Also applies to patch 3/4 as well) Sorry about the dupe Peter... Looks like I missed the 'Reply All' button... Jason On Mon, Feb 7, 2011 at 9:06 PM, Peter

[Linuxwacom-devel] Retiring CVS

2011-02-16 Thread Jason Gerecke
After consulting with Ping, the CVS repositories are going to be retired. With SourceForge hinting at a possible end-of-life for CVS service it seems like a good idea to take a preemptive step and consolidate everything under Git. However, while preparing the pull the plug I've run into a small

Re: [Linuxwacom-devel] Heading towards regular releases

2011-02-17 Thread Jason Gerecke
On Wed, Feb 16, 2011 at 7:45 PM, Peter Hutterer peter.hutte...@who-t.net wrote: What I'd like to commit to is regular releases. While the misc cleanup is still going strong, we can't and shouldn't just line up with X server releases. So what I propose is an approcimately monthly release with a

Re: [Linuxwacom-devel] Retiring CVS

2011-02-17 Thread Jason Gerecke
CVS IS DEAD! input-wacom and linuxwacom-dev have both been imported to Git. If for some reason you have an old copy of the linuxwacom Git repo lying around (for posterity??) you should probably nuke it since the history was rewritten. ... looks like I missed 'Reply to All' yet again ... Sorry

[Linuxwacom-devel] [PATCH] Require PROP_FLAG_BOOLEAN params to be 'off' or 'on'

2011-03-07 Thread Jason Gerecke
Do some additional checking to ensure the user provides valid values for boolean parameters. Also, provide a helpful error if the user goes astray. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions

[Linuxwacom-devel] [PATCH] Fix minor doc style inconsitencies

2011-03-07 Thread Jason Gerecke
Add/move periods and whitespace, make defaults consistent, and clarify where necessary. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 46 +++--- 1 files changed, 23 insertions(+), 23 deletions(-) diff --git a/tools

[Linuxwacom-devel] RawFilter option broken (and duplicated?)

2011-03-07 Thread Jason Gerecke
While making my last two patches, I noticed that the RawFilter option is broken for me on master. What I see: xsetwacom --set Wacom Cintiq 21UX stylus rawfilter on RawFilter = format mismatch (32) xsetwacom --set Wacom Cintiq 21UX stylus rawfilter off RawFilter =

[Linuxwacom-devel] [PATCH v2] Require PROP_FLAG_BOOLEAN params to be 'off' or 'on'

2011-03-08 Thread Jason Gerecke
Do additional checking to ensure the user provides valid values for boolean parameters. Also, provide a helpful error if the user goes astray. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes to previous version: - convert_value_from_user now returns conversion success

[Linuxwacom-devel] [PATCH v2] Fix minor doc style inconsitencies

2011-03-08 Thread Jason Gerecke
Add/move periods and whitespace, make defaults consistent, and clarify where necessary. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes - Now with 100% less linewrapping! (...hopefully...) tools/xsetwacom.c | 46 +++--- 1 files changed

[Linuxwacom-devel] [PATCH 2/4] Remove RawFilter from xsetwacom

2011-03-08 Thread Jason Gerecke
With support for the option completely removed from the driver, remove it from xsetwacom as well. Also modify the deprecation warning to handle cases like this where we don't want a replacement. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 23

[Linuxwacom-devel] [PATCH 4/4] Require RawSample to be at least 1

2011-03-08 Thread Jason Gerecke
I made the mistake of setting this to zero and then bringing my pen into proximity. Ooops. X crashed. Looks like mathematics still can't handle getting the average of zero things ;) Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmXCommand.c |2 +- 1 files changed, 1 insertions

[Linuxwacom-devel] [PATCH 4/4 v2] Perform bounds checking on RawSample

2011-03-09 Thread Jason Gerecke
I made the mistake of setting this to zero and then bringing my pen into proximity. Ooops. X crashed. Looks like mathematics still can't handle getting the average of zero things ;) Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes in v2: - Modified patch subject to better match 2nd

[Linuxwacom-devel] [PATCH v2] Require PROP_FLAG_BOOLEAN params to be 'off' or 'on

2011-03-11 Thread Jason Gerecke
This patch set breaks apart the referenced patch into its component changes as requested by Peter. -- Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today

[Linuxwacom-devel] [PATCH v2 2/5] Detect boolean conversion failure in convert_value_from_user

2011-03-11 Thread Jason Gerecke
Properties with PROP_FLAG_BOOLEAN set can only take on a restricted set of values. We detect if the string matches any of the allowed values and convert if possible. If not possible, the caller is notified. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c |9

[Linuxwacom-devel] [PATCH v2 5/5] Add tests for convert_value_from_user

2011-03-11 Thread Jason Gerecke
Some basic tests to ensure booleans and non-booleans act like we want them to. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/tools/xsetwacom.c b/tools

[Linuxwacom-devel] [PATCH v2 4/5] Expand recognized boolean input for convert_value_from_user

2011-03-11 Thread Jason Gerecke
We remove the case sensitivity requirement for off/on and also allow the use of true and false Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index ee353fa

[Linuxwacom-devel] [PATCH] Fix button assignment bug introduced in 22bc3028

2011-03-11 Thread Jason Gerecke
of a6b9416148e5423c5a0c2632d88dbee5589615 was actually on the right track... Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 3435389..1d7265d 100644 --- a/tools

Re: [Linuxwacom-devel] [PATCH] Fix button assignment bug introduced in 22bc3028

2011-03-14 Thread Jason Gerecke
On Sun, Mar 13, 2011 at 11:00 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Mar 11, 2011 at 04:02:56PM -0800, Jason Gerecke wrote: I just noticed I was unable to map button presses to keys and after some investigation (yay git bisect!) found the following commit caused the bug

[Linuxwacom-devel] [PATCH v3 1/5] Change signature of convert_value_from_user

2011-03-14 Thread Jason Gerecke
Have it return true/false to indicate conversion success/failure. Note that in its current state the function cannot tell if there was a conversion failure... Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v2: * Use val instead of allocating memory tools/xsetwacom.c | 36

[Linuxwacom-devel] [PATCH v3 5/5] Add tests for convert_value_from_user

2011-03-14 Thread Jason Gerecke
Some basic tests to ensure booleans and non-booleans act like we want them to. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v2: * Use val instead of allocating memory tools/xsetwacom.c | 38 ++ 1 files changed, 38 insertions(+), 0

[Linuxwacom-devel] [PATCH 2/2] Clear the correct amount of memory

2011-03-18 Thread Jason Gerecke
Though this doesn't result in any bad behavior at the moment, it could cause some serious headaches in the future. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmXCommand.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/wcmXCommand.c b/src

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-22 Thread Jason Gerecke
*grumble, grumble* There has got to be a GMail extension that makes Reply to all more prominent than Reply for lists... On Mon, Mar 21, 2011 at 9:11 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Mar 18, 2011 at 06:01:16PM -0700, Jason Gerecke wrote: Crash first appears

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-23 Thread Jason Gerecke
As I'm working on the X11 wheel mapping, I'm finding a few weird quirks in the code. I pretty much understand 'how' things work, but I'm not sure why some things are the way they are... 1. Why does WACOM_PROP_BUTTON_ACTIONS have room for only 16 buttons, yet priv-btn_actions (storing the same

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-24 Thread Jason Gerecke
On Wed, Mar 23, 2011 at 6:30 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 23, 2011 at 12:58:21PM -0700, Jason Gerecke wrote: As I'm working on the X11 wheel mapping, I'm finding a few weird quirks in the code. I pretty much understand 'how' things work, but I'm not sure why

Re: [Linuxwacom-devel] Area Option Relative

2011-03-24 Thread Jason Gerecke
On Thu, Mar 24, 2011 at 12:29 PM, Cedric Sodhi man...@gmx.net wrote: Hello, I find it rather inconvenient that the Area Option (rather recent GIT) appears to depend on the output device and is relative to the screen area. Meaning that the same Area Options have different effects when I use two

[Linuxwacom-devel] [PATCH 1/4] Return from function on parse error

2011-03-24 Thread Jason Gerecke
and maps Button 1 to key +a. Instead of making partial changes, xsetwacom should instead bail at the first sign of a problem. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tools/xsetwacom.c b/tools

[Linuxwacom-devel] [PATCH 4/4] Make set/unset code easier to understand

2011-03-24 Thread Jason Gerecke
Between the parsing code seperating the two halves of set/unset and the code being confusing in general, I've rewritten this to hopefully make its operation a little clearer for the next person. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 108

[Linuxwacom-devel] [PATCH 3/4] Don't use unset_prop

2011-03-24 Thread Jason Gerecke
We don't need to bother changing the device property if we're unsetting since we're just going to be deleting it anyway. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/tools/xsetwacom.c b/tools

[Linuxwacom-devel] [PATCH] Change hardcoded string to already-defined constant

2011-03-28 Thread Jason Gerecke
WACOM_PROP_BUTTON_ACTIONS is already defined in wacom-properties.h Lets use it instead of all those magic constants. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/xsetwacom.c b/tools

Re: [Linuxwacom-devel] [PATCH] Change hardcoded string to already-defined constant

2011-03-29 Thread Jason Gerecke
On Tue, Mar 29, 2011 at 1:08 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Mar 28, 2011 at 10:06:56AM -0700, Jason Gerecke wrote: WACOM_PROP_BUTTON_ACTIONS is already defined in wacom-properties.h Lets use it instead of all those magic constants. Signed-off-by: Jason Gerecke

[Linuxwacom-devel] [PATCH 3/9] Add WACOM_PROP_WHEELBUTTONS to cursor devices

2011-03-29 Thread Jason Gerecke
This enables the Wacom Wheel Buttons property for cursor devices, allowing xsetwacom to set (rel|abs)wheel(up|down) actions. I'm not sure if there are non-puck cursor devices which should *not* have this enabled, but until somebody says otherwise... :) Signed-off-by: Jason Gerecke killert

[Linuxwacom-devel] [PATCH 0/9] Patchset overview

2011-03-29 Thread Jason Gerecke
on wheels/strips - Gets things ready for removing raw buttons from the driver itself Jason Gerecke (9): Fix buttons must be set twice bug from d650b139 Fix strip/wheel mapping Add WACOM_PROP_WHEELBUTTONS to cursor devices Make it clearer when actions are sent Allow parse_actions

[Linuxwacom-devel] [PATCH 2/9] Fix strip/wheel mapping

2011-03-29 Thread Jason Gerecke
is returned. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index 736a53c..39ae983 100644 --- a/src/wcmCommon.c +++ b/src/wcmCommon.c @@ -333,7 +333,7 @@ static

[Linuxwacom-devel] [PATCH 6/9] Remove map_button_simple

2011-03-29 Thread Jason Gerecke
did. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 30 +- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 7eb95d7..f6626d3 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c

[Linuxwacom-devel] [PATCH 4/9] Make it clearer when actions are sent

2011-03-29 Thread Jason Gerecke
When I first saw this, I thought somebody forgot to put an else clause here; I completely missed that tiny return statement. This makes the reality a little clearer. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c | 13 +++-- 1 files changed, 7 insertions(+), 6

[Linuxwacom-devel] [PATCH 7/9] Remove 'special_map_wheels' and 'special_map_buttons'

2011-03-29 Thread Jason Gerecke
Since neither function actually do anything that couldn't just be done in 'map_wheels' and 'map_button' respectively, we simply squash them together. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 44 ++-- 1 files changed, 14

[Linuxwacom-devel] [PATCH 9/9] Revamp button/wheel/strip getters

2011-03-29 Thread Jason Gerecke
back to the method originally used for non-actions: punt and ask XGetDeviceButtonMapping for something. When raw buttons are removed from the driver, it should be possible to replace 'get_map' with 'get_actions' (since everything will be an action at that point). Signed-off-by: Jason Gerecke

Re: [Linuxwacom-devel] Moving towards 0.11

2011-03-29 Thread Jason Gerecke
On Tue, Mar 29, 2011 at 3:55 PM, Peter Hutterer peter.hutte...@who-t.net wrote: It's been a few weeks since 0.10.11, 114 patches already and I think it's high time for another release. As we discussed after the 0.10.11 release we should change the release tactics. So here is what I'd like to

Re: [Linuxwacom-devel] [PATCH 9/9] Revamp button/wheel/strip getters

2011-03-30 Thread Jason Gerecke
On Tue, Mar 29, 2011 at 9:21 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 29, 2011 at 04:18:38PM -0700, Jason Gerecke wrote: @@ -1782,41 +1797,118 @@ static int get_special_button_map(Display *dpy, XDevice *dev,       TRACE(%s\n, buff); -     XFree(btnact_data

Re: [Linuxwacom-devel] [PATCH 1/9] Fix buttons must be set twice bug from d650b139

2011-03-30 Thread Jason Gerecke
On Tue, Mar 29, 2011 at 9:03 PM, Peter Hutterer peter.hutte...@who-t.net wrote: applied, but from a cursory glance I'm not sure why. In fact, I would have guessed the other way round. anyway, I've added a comment to avoid this in the future (at least until we find the reason why and fixed it).

Re: [Linuxwacom-devel] [PATCH 9/9] Revamp button/wheel/strip getters

2011-03-30 Thread Jason Gerecke
On Tue, Mar 29, 2011 at 11:37 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 29, 2011 at 11:21:58PM -0700, Jason Gerecke wrote: On Tue, Mar 29, 2011 at 9:21 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Mar 29, 2011 at 04:18:38PM -0700, Jason Gerecke wrote

[Linuxwacom-devel] [PATCH 8v2/9] Merge 'map_wheels' and 'map_button' into a unified 'map_actions'

2011-03-30 Thread Jason Gerecke
worthy of breaking into its own function. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v1: * Use strcmp instead of == tools/xsetwacom.c | 98 - 1 files changed, 52 insertions(+), 46 deletions(-) diff --git a/tools

[Linuxwacom-devel] [PATCH 9v2/9] Revamp button/wheel/strip getters

2011-03-30 Thread Jason Gerecke
back to the method originally used for non-actions: punt and ask XGetDeviceButtonMapping for something. When raw buttons are removed from the driver, it should be possible to replace 'get_map' with 'get_actions' (since everything will be an action at that point). Signed-off-by: Jason Gerecke

[Linuxwacom-devel] [PATCH 7/7] Fix get_map to return proper wheel/strip button number

2011-03-30 Thread Jason Gerecke
, once the raw button path is removed from the driver, the entire 'get_map' function can go the way of the dodo. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 36 1 files changed, 24 insertions(+), 12 deletions(-) diff --git

[Linuxwacom-devel] [PATCH 0/7] Patchset summary

2011-03-30 Thread Jason Gerecke
Patches 1-4 improve argument validation and make xsetwacom noiser when it fails. Patches 5-7 finish up the remaining raw button removal from xsetwacom. Jason Gerecke (7): Fail with warnings where possible More explicit input check for set_rotate Change from prop_extra to arg_count More

[Linuxwacom-devel] [PATCH 1/7] Fail with warnings where possible

2011-03-30 Thread Jason Gerecke
that we have the correct number of arguments. I've tried to make checks as pedantic as possible, e.g. throwing errors about number of arguments even if the function ignores arguments. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 31 +++ 1

[Linuxwacom-devel] [PATCH 4/7] More strict argument-count checking

2011-03-30 Thread Jason Gerecke
-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 60 +++- 1 files changed, 36 insertions(+), 24 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index ae35996..d99a671 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c

[Linuxwacom-devel] [PATCH 5/7] Decrease minimum number of args to 'set' [allow wheels/strips reset]

2011-03-30 Thread Jason Gerecke
possible to run e.g. `xsetwacom --set $ID StripLeftDown` to reset the action to its default. Doing the same with buttons has been supported, but wheels and strips were out of luck because they would require too few arguments to 'set'. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools

[Linuxwacom-devel] [PATCH 6/7] Have wheel and strip properties be actions instead of buttons

2011-03-30 Thread Jason Gerecke
by following the mold already in place for buttons. With no more need for conversion, we can also nuke the conversion-related bits from xsetwacom. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmXCommand.c | 28 tools/xsetwacom.c | 74

Re: [Linuxwacom-devel] [PATCH 5/7] Decrease minimum number of args to 'set' [allow wheels/strips reset]

2011-03-31 Thread Jason Gerecke
On Wed, Mar 30, 2011 at 9:04 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 30, 2011 at 01:54:45PM -0700, Jason Gerecke wrote: Since the worker functions now check that they have the appropriate number of arguments, its possible to decrease the number of arguments required

Re: [Linuxwacom-devel] [PATCH 1/7] Fail with warnings where possible

2011-03-31 Thread Jason Gerecke
On Wed, Mar 30, 2011 at 8:57 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 30, 2011 at 01:54:41PM -0700, Jason Gerecke wrote: For many commands, improper arguments cause a silent failure. The user is often given no indication if their command succeeded or failed. I've tried

Re: [Linuxwacom-devel] [PATCH 7/7] Fix get_map to return proper wheel/strip button number

2011-03-31 Thread Jason Gerecke
On Wed, Mar 30, 2011 at 9:20 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 30, 2011 at 01:54:47PM -0700, Jason Gerecke wrote: Adding to the only-kinda-hackish use of XGetDeviceButtonMapping, in get_map, this total hackjob of a patch fixes the problem with us having no way

Re: [Linuxwacom-devel] [PATCH 5/7] Decrease minimum number of args to 'set' [allow wheels/strips reset]

2011-04-01 Thread Jason Gerecke
On Thu, Mar 31, 2011 at 9:21 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 30, 2011 at 11:51:22PM -0700, Jason Gerecke wrote: On Wed, Mar 30, 2011 at 9:04 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 30, 2011 at 01:54:45PM -0700, Jason Gerecke wrote: Since

Re: [Linuxwacom-devel] [PATCH 7/7] Fix get_map to return proper wheel/strip button number

2011-04-01 Thread Jason Gerecke
On Thu, Mar 31, 2011 at 9:28 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Mar 31, 2011 at 12:07:32AM -0700, Jason Gerecke wrote: On Wed, Mar 30, 2011 at 9:20 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 30, 2011 at 01:54:47PM -0700, Jason Gerecke wrote

Re: [Linuxwacom-devel] [PATCH 5/7] Decrease minimum number of args to 'set' [allow wheels/strips reset]

2011-04-04 Thread Jason Gerecke
On Sun, Apr 3, 2011 at 8:26 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Apr 01, 2011 at 11:17:15AM -0700, Jason Gerecke wrote: On Thu, Mar 31, 2011 at 9:21 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 30, 2011 at 11:51:22PM -0700, Jason Gerecke wrote: On Wed

Re: [Linuxwacom-devel] [linuxwacom-announce] [ANNOUNCE] xf86-input-wacom 0.10.99.1

2011-04-04 Thread Jason Gerecke
On Sun, Apr 3, 2011 at 10:42 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Apr 04, 2011 at 07:32:44AM +0200, Andrzej Giniewicz wrote: are you scrolling through gestures? afaict the scrolling code is hardcoded to use 4/5 6/7 instead of the button mapping. yes, that was of course

[Linuxwacom-devel] [PATCH 2/2] Fix cursor freeze after performing gesture - RFC

2011-04-05 Thread Jason Gerecke
doesn't appear to fix the bug... Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c | 61 -- 1 files changed, 23 insertions(+), 38 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index 0d3e8d8..ff70d64 100644

[Linuxwacom-devel] [PATCH 1/3] Have man page reflect per-tablet nature of 'Rotate' option

2011-04-05 Thread Jason Gerecke
Change documentation to indicate that rotation affects all tools associated with the same tablet. Signed-off-by: Jason Gerecke killert...@gmail.com --- man/xsetwacom.man |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/man/xsetwacom.man b/man/xsetwacom.man index

[Linuxwacom-devel] [PATCH 2/3] Swap range of 'RawSample' and 'Suppress' in man page

2011-04-05 Thread Jason Gerecke
Looks like the range of these two options was confused a while back. Switch them so that the right option has the right range. Signed-off-by: Jason Gerecke killert...@gmail.com --- man/xsetwacom.man |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/man/xsetwacom.man b

[Linuxwacom-devel] [PATCH 3v2/3] Expand manpage documentation for Button parameter

2011-04-06 Thread Jason Gerecke
Include list of parameters that are supported, as well as an example of mixing keywords in one action. Signed-off-by: Jason Gerecke killert...@gmail.com --- Changes from v1: * Remove superfluous mention of zoom man/xsetwacom.man | 21 ++--- 1 files changed, 14 insertions

[Linuxwacom-devel] Cintiq: TabletPCButton = on?

2011-04-11 Thread Jason Gerecke
Right now the man page indicates that TabletPCButton is 'on' for TabletPCs and 'off' for everything else. It appears that this option is also 'on' for my Cintiq 21UX. Is this just less-than-clear documentation, or a driver bug? I was leaning to the first (as they're both transparent tablets), but

Re: [Linuxwacom-devel] Cintiq: TabletPCButton = on?

2011-04-11 Thread Jason Gerecke
? Favux On Mon, Apr 11, 2011 at 1:33 PM, Jason Gerecke killert...@gmail.com wrote: Right now the man page indicates that TabletPCButton is 'on' for TabletPCs and 'off' for everything else. It appears that this option is also 'on' for my Cintiq 21UX. Is this just less-than-clear documentation

Re: [Linuxwacom-devel] [RFC PATCH] Add mask checking macros. (was Cintiq: TabletPCButton = on?)

2011-04-12 Thread Jason Gerecke
On Mon, Apr 11, 2011 at 6:15 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- I could remove WCM_LCD from the definition of WCM_TPC but I think the more correct fix would actually be changing TabletHasFeature(common, feature):

[Linuxwacom-devel] [PATCH 2/4] man: Fix hyphenation error

2011-04-12 Thread Jason Gerecke
What else needs to be said? Signed-off-by: Jason Gerecke killert...@gmail.com --- man/xsetwacom.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/xsetwacom.man b/man/xsetwacom.man index 910f873..5e6c3f0 100644 --- a/man/xsetwacom.man +++ b/man/xsetwacom.man

[Linuxwacom-devel] [PATCH 4/4] man: Use __drivername__ instead of wacom

2011-04-12 Thread Jason Gerecke
Because hardcoding things is uncool Signed-off-by: Jason Gerecke killert...@gmail.com --- man/wacom.man |2 +- man/xsetwacom.man |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/man/wacom.man b/man/wacom.man index 8911294..a26dad1 100644 --- a/man/wacom.man +++ b

[Linuxwacom-devel] [PATCH 1/4] man: Update usage information

2011-04-12 Thread Jason Gerecke
The usage provided by '--help' is more accurate than that provided in the man page, and some arguments to '--set' do not require a value. Signed-off-by: Jason Gerecke killert...@gmail.com --- man/xsetwacom.man |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/man

Re: [Linuxwacom-devel] [linuxwacom-announce] [ANNOUNCE] xf86-input-wacom 0.10.99.2

2011-04-14 Thread Jason Gerecke
On Thu, Apr 14, 2011 at 5:20 AM, Andrzej Giniewicz ggi...@gmail.com wrote: Some more tests done. First of all, I made tests for 2.6.38.2 and it seems to work just as well as on 2.6.37.5 which I had before. Anyway, when doing more tests I noticed few new odd things in gestures, things that as

Re: [Linuxwacom-devel] [PATCH 2/4] Have ToolSerials patch re-use existing infrastructure

2011-04-18 Thread Jason Gerecke
On Mon, Apr 18, 2011 at 11:26 AM, Jason Gerecke killert...@gmail.com wrote: This tweaks the prior ToolSerials patch to use the existing infrastructure where appropriate. For instance, using the 'WacomTool' struct instead of the custom 'WacomToolSerial' struct. This should actually

Re: [Linuxwacom-devel] input-wacom 0.11.0 - empty tar.bz2 on sf.net

2011-04-26 Thread Jason Gerecke
I made the same mistake yesterday and figured somebody else fixed it. A new copy has just been uploaded to SF -- hopefully this one works better :) Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. On Tue, Apr 26, 2011 at 5:33 AM,

Re: [Linuxwacom-devel] [Linuxwacom-discuss] Fwd: Bamboo PT CTH-661 - Cursor jumps using finger touch function

2011-05-02 Thread Jason Gerecke
Ping has been pushing me to poke around in the kernel more, and this seems like it'd be a good opportunity. Unfortunately my plate is pretty full with another project for a few weeks... I might be able to sneak in some time at random points, but I'm still a kernel newbie so it'd take me a while

Re: [Linuxwacom-devel] Auto-spawning new devices for wacom tools

2011-05-08 Thread Jason Gerecke
I concur with Chris on this one, especially regarding the third idea. I can see a use for a daemon which sets up all the pens without needing to modify the xorg.conf (which may not be user-editable in production environments) or wait on bringing each tool into proximity before the user can load

Re: [Linuxwacom-devel] Auto-spawning new devices for wacom tools

2011-05-09 Thread Jason Gerecke
On Sun, May 8, 2011 at 10:01 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sun, May 08, 2011 at 08:26:59PM +, Jason Gerecke wrote: I concur with Chris on this one, especially regarding the third idea. I can see a use for a daemon which sets up all the pens without needing to modify

Re: [Linuxwacom-devel] Auto-spawning new devices for wacom tools

2011-05-09 Thread Jason Gerecke
On Mon, May 9, 2011 at 5:03 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, May 09, 2011 at 03:56:53PM -0700, Jason Gerecke wrote: On Sun, May 8, 2011 at 10:01 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sun, May 08, 2011 at 08:26:59PM +, Jason Gerecke wrote: I

Re: [Linuxwacom-devel] Anyone working on touchpad?

2011-05-18 Thread Jason Gerecke
Cedric, From what I understand, Ping wrote the code which preferentially sends pen events from the kernel, but she's unavailable for the next few weeks. In addition, I know Peter and I are both busy with other things at the moment, which further limits the attention this bug gets. Please bear

[Linuxwacom-devel] Solaris Patches?

2011-06-17 Thread Jason Gerecke
I'm wondering what people's thoughts are on integrating the OpenSolaris patches available at http://hub.opensolaris.org/bin/view/Community+Group+device_drivers/wacomtablet into our code. Obviously they can't be integrated as-is, but I'm more interested in finding out if its worth tacking onto the

Re: [Linuxwacom-devel] [PATCH 0/4] xsetwacom: NVIDIA TwinView support for MapToOutput

2011-06-20 Thread Jason Gerecke
On Sun, Jun 19, 2011 at 9:01 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Subject says it all. I haven't actually tested this on account of not having a server that has the transformation matrix _and_ uses the nvidia binary driver but the matrix looks correct. Testing feedback would be

Re: [Linuxwacom-devel] [PATCH 3/4] xsetwacom: move matrix calculation into a separate function

2011-06-20 Thread Jason Gerecke
On Sun, Jun 19, 2011 at 9:01 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  tools/xsetwacom.c |   62 +++-  1 files changed, 37 insertions(+), 25 deletions(-) diff --git

Re: [Linuxwacom-devel] [PATCH 4/4] xsetwacom: Support MapToOutput for TwinView.

2011-06-20 Thread Jason Gerecke
On Sun, Jun 19, 2011 at 9:01 PM, Peter Hutterer peter.hutte...@who-t.net wrote: The NVIDIA binary driver doesn't support RandR 1.2. Test for the NV-CONTROL extension and assume the binary driver is running when this extension is detected. Then use Xinerama to query the screen offset and set the

Re: [Linuxwacom-devel] [PATCH 1/4] xsetwacom: add missing linebreak in error message.

2011-06-23 Thread Jason Gerecke
/linuxwacom-devel Reviewed-by: Jason Gerecke killert...@gmail.com Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. -- Simplify data backup and recovery for your virtual

Re: [Linuxwacom-devel] [PATCH 2/4] xsetwacom: split output setting into set_output_xrandr

2011-06-23 Thread Jason Gerecke
@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel Tested-by: Jason Gerecke killert...@gmail.com Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha

Re: [Linuxwacom-devel] [PATCH v2 3/4] xsetwacom: move matrix calculation into a separate function

2011-06-23 Thread Jason Gerecke
to find output '%s'.                        Output may not be connected.\n, output_name); -- 1.7.5.4 Tested-by: Jason Gerecke killert...@gmail.com Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha

Re: [Linuxwacom-devel] [PATCH v3 4/4] xsetwacom: Support MapToOutput for TwinView.

2011-06-28 Thread Jason Gerecke
, maj, min) || (maj * 1000 + min) 1002) +               set_output_xinerama(dpy, dev, param, argc, argv); +       else +               set_output_xrandr(dpy, dev, param, argc, argv);  } -- 1.7.5.4 Tested-by: Jason Gerecke killert...@gmail.com Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it

[Linuxwacom-devel] [PATCH] Allow zero-argument use of MapToOutput to reset map to entire desktop

2011-08-01 Thread Jason Gerecke
If zero commandline arguments are provided to 'set_output', we now interpret that as the user's desire to remap their tablet to the entire desktop. This is accomplished by loading the identity matrix. --- man/xsetwacom.man |5 +++-- tools/xsetwacom.c | 12 ++-- 2 files changed, 13

[Linuxwacom-devel] Hotplugging resets other tablets' properties

2011-08-05 Thread Jason Gerecke
I was running into problems getting the Top/Bottom X/Y attributes to work in an xorg.conf.d file when I stumbled across the following thread: http://old.nabble.com/Wacom-drivers-ignore-BottomX-td31169628.html I was trying to figure out what was going wrong (since I saw no obvious problems with

Re: [Linuxwacom-devel] Hotplugging resets other tablets' properties

2011-08-08 Thread Jason Gerecke
On Sun, Aug 7, 2011 at 11:58 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Sat, Aug 06, 2011 at 10:35:56AM -0500, Chris Bagwell wrote: On Fri, Aug 5, 2011 at 6:48 PM, Jason Gerecke killert...@gmail.com wrote: I was running into problems getting the Top/Bottom X/Y attributes to work

Re: [Linuxwacom-devel] GNOME support for multiple tablets (was Re: Hotplugging resets other tablets' properties)

2011-08-09 Thread Jason Gerecke
On Mon, Aug 8, 2011 at 5:37 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Changing subject to reflect new topic On Mon, Aug 08, 2011 at 09:33:11AM -0700, Jason Gerecke wrote: Good call. I thought it might be g-s-d at first, but didn't find any keys in gconf... I completely forgot

[Linuxwacom-devel] [PATCH 2/3] Add 'pressurehold' button command to xsetwacom

2011-08-09 Thread Jason Gerecke
This adds the framework for xsetwacom to use AC_PRESSUREHOLD as a button command. With no implementation yet in the driver, it does nothing. --- src/wcmXCommand.c |1 + tools/xsetwacom.c | 11 +++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/wcmXCommand.c

[Linuxwacom-devel] [PATCH 1/3] Add AC_PRESSUREHOLD button action constant

2011-08-09 Thread Jason Gerecke
Replaces the deprecated AC_DBLCLICK constant with a new constant which denotes when a button action is supposed to cause the driver to hold the current pressure value. --- include/Xwacom.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/Xwacom.h

[Linuxwacom-devel] [PATCH 3/3] Add driver support for AC_PRESSUREHOLD button command

2011-08-09 Thread Jason Gerecke
Supports AC_PRESSUREHOLD by adding a 'holdPressure' variable to the '_WacomDeviceRec' struct. When non-negative, the value of this variable will be used in place of pressure being reported by the hardware. --- src/wcmCommon.c | 11 +++ src/xf86Wacom.c |1 +

[Linuxwacom-devel] [PATCH 2/4] Move 'set_output' intelligence into helper functions

2011-08-09 Thread Jason Gerecke
Instead of having 'set_output' be responsible for choosing an appropriate helper function, we let the helper functions be autonomous. If they cannot find an appropriate output (or encounter an error), they simply return False to let the caller know that it failed. --- tools/xsetwacom.c | 46

[Linuxwacom-devel] [PATCH 4/4] Suppress most output from 'set_output' helper functions

2011-08-09 Thread Jason Gerecke
Things get confusing when one helper function reports that it couldn't find an output, but the next doesn't report success. This change moves most of the output from the helper functions into TRACE() calls that can be investigated if need be, and adds a fallthrough failure message to 'set_output'.

[Linuxwacom-devel] DisplayToggle Help

2011-08-09 Thread Jason Gerecke
I've been recently trying to resurrect the DisplayToggle button command without much success. Most of the data I need access to (e.g. the contents of the coordinate transformation matrix) are only accessible with a Display object. I quickly learned that calling XOpenDisplay from within the driver

Re: [Linuxwacom-devel] DisplayToggle Help

2011-08-10 Thread Jason Gerecke
On Wed, Aug 10, 2011 at 3:44 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Aug 09, 2011 at 06:05:00PM -0700, Jason Gerecke wrote: I've been recently trying to resurrect the DisplayToggle button command without much success. Most of the data I need access to (e.g. the contents

Re: [Linuxwacom-devel] [PATCH 1/3] Add AC_PRESSUREHOLD button action constant

2011-08-11 Thread Jason Gerecke
On Wed, Aug 10, 2011 at 6:18 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Aug 09, 2011 at 05:31:39PM -0700, Jason Gerecke wrote: Replaces the deprecated AC_DBLCLICK constant with a new constant which denotes when a button action is supposed to cause the driver to hold the current

Re: [Linuxwacom-devel] [PATCH 2/4] Move 'set_output' intelligence into helper functions

2011-08-11 Thread Jason Gerecke
On Wed, Aug 10, 2011 at 6:43 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Aug 09, 2011 at 05:50:11PM -0700, Jason Gerecke wrote: Instead of having 'set_output' be responsible for choosing an appropriate helper function, we let the helper functions be autonomous. If they cannot

Re: [Linuxwacom-devel] [PATCH 4/4] Suppress most output from 'set_output' helper functions

2011-08-11 Thread Jason Gerecke
On Wed, Aug 10, 2011 at 6:51 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Aug 09, 2011 at 05:50:13PM -0700, Jason Gerecke wrote: Things get confusing when one helper function reports that it couldn't find an output, but the next doesn't report success. This change moves most

Re: [Linuxwacom-devel] [PATCH 2/4] Move 'set_output' intelligence into helper functions

2011-08-11 Thread Jason Gerecke
On Thu, Aug 11, 2011 at 4:09 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Aug 11, 2011 at 03:49:45PM -0700, Jason Gerecke wrote: On Wed, Aug 10, 2011 at 6:43 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Aug 09, 2011 at 05:50:11PM -0700, Jason Gerecke wrote

[Linuxwacom-devel] [PATCH 1/3] Introduce AC_CUSTOM; deprecate AC_MODETOGGLE and AC_DISPLAYTOGGLE

2011-08-12 Thread Jason Gerecke
The AC_CUSTOM event type is introduced to make better use of the limited space available in each Action Code. The value within the AC_CODE mask defines what action to take when AC_TYPE == AC_CUSTOM. Actions which do not require an argument (like modetoggle and displaytoggle) should use the

[Linuxwacom-devel] [PATCH 2/3] Add pressure hold to driver and xsetwacom

2011-08-12 Thread Jason Gerecke
This patch allows setting a button to a pressure hold switch. While the button is held, the pressure reported by the driver will remain at the level it was just before the button was pressed. When released, normal operation continues. Pressure hold is implemented by adding a 'holdPressure'

[Linuxwacom-devel] [PATCH 0/3] Pressure hold re-submission

2011-08-12 Thread Jason Gerecke
Looks like I forgot to edit the total number of patches before mailing. I held back a third patch just before sending, so there are only two to review, despite what the subject indicates! Wasn't sure if I should label these as v2 or not since the numerical relationship of the patch number of the

  1   2   3   4   5   6   7   8   9   10   >