Re: [Linuxwacom-devel] [PATCH 5/6] Search for more potential key and cert locations

though this may be inside > a directory that only root can read from). Does this mean we should prompt users to compile input-wacom under root? It’s quite a lot of work. Thank you for your effort, Jason! Acked-by: Ping Cheng for the whole set. Cheers, Ping > > Signed-off-by: Jason Gereck

[Linuxwacom-devel] [PATCH] 2.6.32 RHEL: Add out of tree support for RHEL 6.10

Make those devices not supported by RHEL 6.10 into wacom-ot.ko so both drivers can live happily together ;). Signed-off-by: Ping Cheng --- 2.6.32/Makefile.in | 17 - 2.6.32/wacom_sys.c | 7 ++- 2.6.32/wacom_wac.c | 18 ++ configure.ac | 12

Re: [Linuxwacom-devel] [PATCH input-wacom] Add support for kernel module signing and enforcement

Looks like a good workaround! Acked-by: Ping Cheng I assume you had someone tested the patch for you. Can you get a test-by from them? Thank you for your effor. Ping On Fri, Nov 30, 2018 at 10:38 AM Jason Gerecke wrote: > It is becoming more common for systems to only allow signed ker

Re: [Linuxwacom-devel] [PATCH 1/4] Correct two comments

On Tue, Oct 23, 2018 at 7:48 PM Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Patchset looks good. The whole set is: Reviewed-by: Ping Cheng Thank you Peter! Ping > > --- > src/wcmUSB.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff -

[Linuxwacom-devel] [PATCH] Support DTU-1141B on older kernels

Signed-off-by: Ping Cheng --- src/wcmValidateDevice.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c index 95c8a2c..cf4edf9 100644 --- a/src/wcmValidateDevice.c +++ b/src/wcmValidateDevice.c @@ -332,6 +332,7 @@ int wcmDeviceTypeKeys

[Linuxwacom-devel] [PATCH] Support DTU-1141B in the 3.7, 2.6.38, and 2.6.30 branches

Signed-off-by: Ping Cheng --- 2.6.32/wacom_wac.c | 31 ++- 2.6.32/wacom_wac.h | 1 + 2.6.38/wacom_wac.c | 31 ++- 2.6.38/wacom_wac.h | 1 + 3.7/wacom_wac.c| 31 ++- 3.7/wacom_wac.h| 1 + 6 files

Re: [Linuxwacom-devel] [PATCH 3/3] Overhaul calculation of default scroll, zoom, and spread distances

aking some of our loyal users happy :). With libinput coming to the foreground, hope we don't need to worry about gestures in the driver anymore! The whole set is: Ref: https://github.com/linuxwacom/input-wacom/issues/33 > Signed-off-by: Jason Gerecke > Reviewed-by: Ping Cheng Ch

Re: [Linuxwacom-devel] [PATCH input-wacom] backport: restore touch functionality to SW_MUTE_DEVICE devices

On Mon, Apr 23, 2018 at 4:37 PM Peter Hutterer wrote: > On Mon, Apr 23, 2018 at 12:44:51PM -0700, Aaron Armstrong Skomra wrote: > > Setting the bit for SW_MUTE_DEVICE on kernels which do not have > > SW_MUTE_DEVICE declared in input.h (prior to 3.13), causes these > >

Re: [Linuxwacom-devel] [PATCH input-wacom 2/2] 2.6.32: Fix abs get/set accessors for 2.6.36/2.6.37

; If it does, we make use of it; of not, we access the members directly. > Yeah, we get to be clever the third time :D. > Fixes: 58d8320541 ("2.6.30: define wacom_input_abs_get_val") > Fixes: ab2ea683fb ("2.6.32: Backport resolution support to 2.6.32") > Signed-off-by: Jas

Re: [Linuxwacom-devel] [PATCH input-wacom 1/6] 2.6.30: Check WACOM_QUIRK_BBTOUCH_LOWRES before modifying Bamboo coords

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > The whole set looks find to me. The set is Reviewed-by: Ping Cheng <ping.ch...@wacom.com> Cheers, Ping > --- > 2.6.30/wacom_wac.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --gi

Re: [Linuxwacom-devel] [PATCH input-wacom 00/10] 2.6.30: Synchronize wacom_features structures

structures > 2.6.30: Backport resolution data (but not implementation) > 2.6.30: Backport touch_max data > 2.6.30: Backport missing TABLETPC ISDv4 devices > 2.6.30: Backport TABLETPCE ISDv4 devices > 2.6.30: Backport MTSCREEN ISDv4 devices > Reviewed-by: Ping Cheng <pin

Re: [Linuxwacom-devel] [PATCH input-wacom] Fix -EINVAL error preventing probe of One by Wacom on pre-3.17 kernels

support for One by Wacom > (CTL-472 / CTL-672)") > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > No one complained. I guess "One by Wacom" users don't run old kernels ;). Anyway, Reviewed-by: Ping Cheng <ping.ch...@wacom.com> Cheers, Ping --- >

[Linuxwacom-devel] [PATCH xf86-input-wacom] Support DTK-2451 and DTH-2452 on older kernels

Signed-off-by: Ping Cheng <ping.ch...@wacom.com> --- src/wcmUSB.c| 3 +++ src/wcmValidateDevice.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 1e4dc51..ca63e6d 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -234,6 +234,9 @@ static

Re: [Linuxwacom-devel] [PATCH] Support DTK-2451 and DTH-2452 on older kernels

On Wed, Jan 31, 2018 at 5:32 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Wed, Jan 31, 2018 at 03:04:34PM -0800, Ping Cheng wrote: > > From: Ping Cheng <ping.ch...@wacom.com> > > > > Signed-off-by: Ping Cheng <ping.ch...@wacom.com> > > Re

[Linuxwacom-devel] [PATCH] Support DTK-2451 and DTH-2452 on older kernels

From: Ping Cheng <ping.ch...@wacom.com> Signed-off-by: Ping Cheng <ping.ch...@wacom.com> --- src/wcmUSB.c| 3 +++ src/wcmValidateDevice.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 2f96a8a..42f108e 100644 --- a/src/wcmUSB

[Linuxwacom-devel] [PATCH] Add support for DTK-2451 and DTH-2452

Signed-off-by: Ping Cheng <ping.ch...@wacom.com> --- 2.6.30/wacom_sys.c | 8 ++-- 2.6.30/wacom_wac.c | 45 +++-- 2.6.30/wacom_wac.h | 3 +++ 2.6.38/wacom_sys.c | 3 +++ 2.6.38/wacom_wac.c | 45 +++--

Re: [Linuxwacom-devel] [PATCH input-wacom 2/2] Implement support for multitouch value conflict resolution on 2.6.35+

you. > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > Reviewed-by: Ping Cheng <ping.ch...@wacom.com> for the set. Cheers, Ping --- > 2.6.30/wacom_wac.c | 26 ++ > 1 file changed, 14 insertions(+), 12 deletions(-) > > diff --git a/

Re: [Linuxwacom-devel] [v2ish xf86-input-wacom 2/2] add Github to release.sh script

On Mon, Jan 15, 2018 at 11:12 AM, Aaron Armstrong Skomra <sko...@gmail.com> wrote: > Require at least 1 of Github/Sourceforge. > > Signed-off-by: Aaron Armstrong Skomra <sko...@gmail.com> > Reviewed-by: Ping Cheng <ping.ch...@wacom.com> for the set. Let's get on

Re: [Linuxwacom-devel] [PATCH] Allocate 4 buttons for stylus devices (Pro Pen 3D)

for the comments in code below. Except that, the patch is Reviewed-by: Ping Cheng <ping.ch...@wacom.com> Ping --- > src/wcmUSB.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/wcmUSB.c b/src/wcmUSB.c > index 9190fbe..6349d69 100644 > ---

Re: [Linuxwacom-devel] [PATCH 3/3] Reset filter when buttons are pressed

Thank you for your cleanup work, Jason. The first two patches look fine. This one definitely needs some testing to make sure it achieves what you planned for. Assuming your testing of this patch was successfully, the whole set is; Reviewed-by: Ping Cheng <ping.ch...@wacom.com> With one qu

Re: [Linuxwacom-devel] [PATCH] Intuos Pro 2nd Generation doesn't support the puck.

On Wed, Dec 6, 2017 at 9:00 AM, Aaron Armstrong Skomra <sko...@gmail.com> wrote: > > > On Wed, Dec 6, 2017 at 7:38 AM, Jason Gerecke <killert...@gmail.com> > wrote: > >> On Tue, Dec 5, 2017 at 2:15 PM, Ping Cheng <pingli...@gmail.com> wrote: >> &

Re: [Linuxwacom-devel] [PATCH] Intuos Pro 2nd Generation doesn't support the puck.

On Wednesday, December 6, 2017, Jason Gerecke <killert...@gmail.com> wrote: > On Tue, Dec 5, 2017 at 2:15 PM, Ping Cheng <pingli...@gmail.com> wrote: > > Yeah, puck’s feature is pretty much replaced by MT’s... > > > > On Tuesday, December 5, 2017, Aaron A

Re: [Linuxwacom-devel] [PATCH] Intuos Pro 2nd Generation doesn't support the puck.

Yeah, puck’s feature is pretty much replaced by MT’s... On Tuesday, December 5, 2017, Aaron Armstrong Skomra <sko...@gmail.com> wrote: > Signed-off-by: Aaron Armstrong Skomra <aaron.sko...@wacom.com> Reviewed-by: Ping Cheng <ping.ch...@wacom.com> Ping > --- &g

Re: [Linuxwacom-devel] [PATCH 1/3] xsetwacom: Use explicit NULL for final element of 'parameters' array

one after this set, look good to me. One nitpicking is: I don’t think you wanted to emphasize your idea by double “allow” in the above line. Reviewed-by: Ping Cheng <ping.ch...@wacom.com> Cheers, Ping > list `{}`, which can > result in missing-field-initializers warnings from the comp

Re: [Linuxwacom-devel] [PATCH input-wacom 1/2] Process 24HDT and 27QHDT in wacom_multitouch_generic

at is available > in every kernel tree (wacom_24hdt_irq itself was never backported to > 2.6.30/2.6.36). > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com <javascript:;>> Acked-by: Ping Cheng <ping.ch...@wacom.com> Ping --- > 2.6.30/wacom_wac.c | 5 +- >

Re: [Linuxwacom-devel] [PATCH input-wacom] Correct tilt range for MobileStudio/Intuos/Cintiq Pro devices

, > 2.6.30") > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com <javascript:;>> Acked-by: Ping Cheng <ping.ch...@wacom.com> Ping > --- > 2.6.30/wacom_wac.c | 4 > 2.6.36/wacom_wac.c | 4 > 2.6.38/wacom_wac.c | 4 > 3.7/wacom

Re: [Linuxwacom-devel] [PATCH input-wacom 1/4] Synchronize trivial changes into to 3.17

these issues, this commit pulls in as many trivial changes > from 4.5 (which we assume is nearly-identical to upstream) as possible. > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Acked-by: Ping Cheng <ping.cheng@wacom,com>, if you were waiting for one ;). Cheers, Ping

Re: [Linuxwacom-devel] [PATCH input-wacom] Fix tool type reporting by wacom_mspro_pen_irq on pre-3.17 kernels

erecke <jason.gere...@wacom.com <javascript:;>> Reviewed-by: Ping Cheng <ping.ch...@wacom.com> Cheers, Ping > --- > 2.6.30/wacom_wac.c | 2 +- > 2.6.36/wacom_wac.c | 2 +- > 2.6.38/wacom_wac.c | 2 +- > 3.7/wacom_wac.c| 2 +- > 4 files changed, 4 inserti

Re: [Linuxwacom-devel] [PATCH libwacom] Mark 2nd-gen non-professional "Intuos" devices (CTH-X90) as "Bamboo" class

On Mon, Oct 2, 2017 at 3:20 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Oct 02, 2017 at 02:33:05PM -0700, Ping Cheng wrote: >> On Fri, Sep 29, 2017 at 7:25 AM, Jason Gerecke <killert...@gmail.com> wrote: >> > These devices are much more similar to t

Re: [Linuxwacom-devel] [PATCH libwacom] Mark 2nd-gen non-professional "Intuos" devices (CTH-X90) as "Bamboo" class

On Fri, Sep 29, 2017 at 7:25 AM, Jason Gerecke wrote: > These devices are much more similar to the Bamboo line of devices than to > the original professional "Intuos" devices (GD-) that are nearly 20 > years old at this point. The 1st-gen non-professional "Intuos"

Re: [Linuxwacom-devel] [PATCH input-wacom] Allow __wacom_is_usb_parent to handle unconfigured USB devices

On Wed, Sep 27, 2017 at 4:19 PM, Aaron Armstrong Skomra <sko...@gmail.com> wrote: > > > On Fri, Aug 11, 2017 at 4:46 PM, Ping Cheng <pingli...@gmail.com> wrote: >> >> On Friday, August 11, 2017, Jason Gerecke <killert...@gmail.com> wrote: >>> >

Re: [Linuxwacom-devel] [PATCH] xsetwacom: Recognize 'AltGr' key as synonym for 'ISO_Level3_Shift'

name that should typically be used. > > https://sourceforge.net/p/linuxwacom/bugs/344/ > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com <javascript:;>> xsetwacom forces us to get familiar with international keys and ISO keysyms ;). Reviewed-by: Ping Cheng <ping.ch..

Re: [Linuxwacom-devel] [PATCH 1/2] Add support for 2nd-generation Intuos Pro

-control-center to > not allow configuration of the ring. > > https://bugzilla.gnome.org/show_bug.cgi?id=785358 > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com <javascript:;>> Reviewed-by: Ping Cheng <ping.ch...@wacom.com> for the set of two patches.

Re: [Linuxwacom-devel] [PATCH] Remove the device's fd from the select() set when we get ENODEV

rged. But it is not. The patch is: > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> Tested-by: crocket <crockabisc...@gmail.com> Reviewed-by: Ping Cheng <ping.ch...@wacom.com> Please merge it, Peter. Cheers, Ping > --- > src/xf86Wacom.c | 12 +--- > src

Re: [Linuxwacom-devel] [PATCH] Support recent display devices on older kernels

On Mon, May 15, 2017 at 9:59 AM, Aaron Armstrong Skomra wrote: > On Sun, May 14, 2017 at 5:17 PM, Peter Hutterer > wrote: >> On Fri, May 12, 2017 at 01:37:53PM -0700, Aaron Armstrong Skomra wrote: >>> Older kernels like 2.6.30 will end up with touches

Re: [Linuxwacom-devel] [PATCH linuxwacom] Add support for Oracle Solaris 10

s a few developers' effort to get this far. Let's keep the code for those who still need it. Acked-by: Ping Cheng <ping.ch...@wacom.com> Thank you Jason for maintaining the code. Ping > --- > README.solaris.md| 179 > THIRDPARTYLICENSEREADME.txt |

Re: [Linuxwacom-devel] [PATCH input-wacom 1/2] backport: report width and height for Intuos Pro 2 on 3.7 and 2.6.38

On Thu, Apr 13, 2017 at 12:22 PM, Aaron Armstrong Skomra <sko...@gmail.com> wrote: > Also remove extra spaces. > > Signed-off-by: Aaron Armstrong Skomra <aaron.sko...@wacom.com> Reviewed-by: Ping Cheng <ping.ch...@wacom.com> for the set. Thank you, Aaron, for the clea

Re: [Linuxwacom-devel] [PATCH linuxwacom 1/5] Mark DTU-2231 as a display tablet in wacomcpl

On Tue, Apr 11, 2017 at 1:20 PM, Jason Gerecke <killert...@gmail.com> wrote: > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Ping Cheng <ping.ch...@wacom.com> for the while set. Thanks, Ping > --- > src/wacomxi/wacomcpl-exec | 3 +++ >

[Linuxwacom-devel] [PATCH v2] Make sibling device name matching slightly more lenient

t; suffixes. For the MobileStudio Pro and Cintiq Pro, this should allow the "basename" that is considered for sibling device matches to be identical between both the pen and touch interfaces. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Signed-off-by: Ping Cheng <pin

Re: [Linuxwacom-devel] [PATCH] Make sibling device name matching slightly more lenient

On Wednesday, February 8, 2017, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Feb 06, 2017 at 05:36:21PM -0800, Ping Cheng wrote: > > The wcmIsSiblingDevice function uses several tricks to try and determine > > if two devices should be considered siblings.

[Linuxwacom-devel] [PATCH] Make sibling device name matching slightly more lenient

ffixes. For the MobileStudio Pro and Cintiq Pro, this should allow the "basename" that is considered for sibling device matches to be identical between both the pen and touch interfaces. Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Signed-off-by: Ping Cheng <ping.ch...@wacom.co

Re: [Linuxwacom-devel] [PATCH input-wacom A 1/2] Add missing pen arbitration function calls

; Thank you Jason for cleaning up my mess. For A, B, and D sets, Reviewed-by: Ping Cheng <ping.ch...@wacom.com>. Cheers, Ping > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > --- > 3.17/wacom_wac.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deleti

Re: [Linuxwacom-devel] [PATCH libwacom] data: set the 22HD(T) to allow for touch strip modes

On Sun, Oct 30, 2016 at 2:58 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Sat, Oct 29, 2016 at 01:48:49AM +0200, Bastien Nocera wrote: >> On Fri, 2016-10-28 at 16:23 -0700, Ping Cheng wrote: >> > On Thu, Oct 27, 2016 at 2:53 AM, Bastien Nocera <ha

Re: [Linuxwacom-devel] [PATCH libwacom] data: set the 22HD(T) to allow for touch strip modes

On Thu, Oct 27, 2016 at 2:53 AM, Bastien Nocera wrote: > On Thu, 2016-10-27 at 13:39 +1000, Peter Hutterer wrote: >> There is no physical LED to show the current mode, but the tablet was >> clearly >> intended to be used that way [1] and we already reserve two buttons >> as

Re: [Linuxwacom-devel] [PATCH 1/2] Increase full-scale pressure range from 0..2047 to 0..65535

On Thursday, October 27, 2016, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Wed, Oct 26, 2016 at 11:56:57PM -0700, Ping Cheng wrote: > > On Wednesday, October 26, 2016, Peter Hutterer <peter.hutte...@who-t.net > <javascript:;>> > > wrote: > >

Re: [Linuxwacom-devel] [PATCH libwacom] data: set the 22HD(T) to allow for touch strip modes

correctly and let the userspace stack > worry > about displaying mode switches (it's already responsible for changing LEDs > anyway). If user space agrees with your suggestion, I am all for it! Reviewed-by: Ping Cheng <pi...@wacom.com> Thank you for the patch. Ping > > [1]

Re: [Linuxwacom-devel] [PATCH 1/2] Increase full-scale pressure range from 0..2047 to 0..65535

ge for some time, meaning that we > cannot simply change the range without causing a change in the perceived > threshold for users. To ensure compatibility, the value is interpreted > as a fraction of 2048 and then scaled to the actual normalization range. > > Signed-off-by: Jason G

Re: [Linuxwacom-devel] [PATCH 01/25] backport: HID: wacom: actually report the battery level for wireless connected

Thank you Aaron for the heavy backward lifting! It is a big bonus for those users who don't/can't upgrade their systems... The patchset looks fine to me. Acked-by: Ping Cheng <pi...@wacom.com> Ping On Thu, Oct 20, 2016 at 11:42 AM, Aaron Armstrong Skomra <sko...@gmail.com> w

Re: [Linuxwacom-devel] [PATCH libwacom] data: the 22HD(T) have virtual modes - note it as a comment

er could implement > any number of modes, not just what libwacom suggests. > > Add the modes as a comment so we have an explanation. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net <javascript:;>> Reviewed-by: Ping Cheng <pi...@wacom.com> Thanks, Ping

Re: [Linuxwacom-devel] [PATCH 3/3] Make DEVICE_CLOSE a noop

and connecting of Wacom device didn't show issues related to either X server or Wacom driver. The new X server is quite robust. And I am more confident with the performance of xf86-input-wacom than before. Thank you for your effort here and at freedesktop! The whole series is: Tested-by: Ping C

Re: [Linuxwacom-devel] [PATCH libwacom] Handle error case of missing parent

erver trying to pick all of > them up) the parent can sometimes be null. It at least serves as a safeguard. So, Acked-by: Ping Cheng <pi...@wacom.com>. Cheers, Ping > libwacom/libwacom.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libwacom/libwacom.c b/libwac

[Linuxwacom-devel] [PATCH] xsetwacom: refer KeySyms defined by keysymdef.h in man page

they are looking for. Signed-off-by: Ping Cheng <pi...@wacom.com> --- man/xsetwacom.man | 15 +++ tools/xsetwacom.c | 3 +++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/man/xsetwacom.man b/man/xsetwacom.man index 1930d67..234e9ba 100644 --- a/man/xsetwacom.man +++

Re: [Linuxwacom-devel] [PATCH] xsetwacom: refer KeySyms defined by keysymdef.h in man page

On Wed, Aug 3, 2016 at 10:52 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Wed, Aug 03, 2016 at 10:13:48PM -0700, Ping Cheng wrote: >> xsetwacom accepts keys in X11 KeySyms format. To make the interface >> user friendly, we mapped a set of modifiers to aliases that

Re: [Linuxwacom-devel] [PATCH] xsetwacom: refer KeySyms defined by keysymdef.h in man page

On Wed, Aug 3, 2016 at 10:52 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Wed, Aug 03, 2016 at 10:13:48PM -0700, Ping Cheng wrote: >> xsetwacom accepts keys in X11 KeySyms format. To make the interface >> user friendly, we mapped a set of modifiers to aliases that

[Linuxwacom-devel] [PATCH] xsetwacom: refer KeySyms defined by keysymdef.h in man page

they are looking for. Return key is added as a bonus (by-product ;). Signed-off-by: Ping Cheng <pi...@wacom.com> Tested-by: Kelly Price <strredw...@gmail.com> --- man/xsetwacom.man | 13 +++-- tools/xsetwacom.c | 4 2 files changed, 11 insertions(+), 6 deletions(-) diff

Re: [Linuxwacom-devel] [PATCH input-wacom 1/4] backport: Input: wacom_w8001 - drop use of ABS_MT_TOOL_TYPE

ory (5f7e544)] > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > [aaron.sko...@wacom.com: backported from input-wacom repository (215a2f5)] > Signed-off-by: Aaron Skomra <aaron.sko...@wacom.com> The backporting looks good to me. The whole set is: Reviewed-by: Ping Cheng <pi..

Re: [Linuxwacom-devel] [PATCH libwacom] data: enable modes on the ExpressKey Remote

ose info sooner or later ;). > Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> Acked-by: Ping Cheng <pi...@wacom.com> Cheers, Ping > --- > data/ek-remote.tablet | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/data/ek-remote.tab

Re: [Linuxwacom-devel] [PATCH libwacom v2 2/3] layouts: fix the anchors of some svg button labels

those start, middle, and end details when I copy/pasted the labels. The other two patches are sensible to me too. So, the whole series is Reviewed-by: Ping Cheng <pi...@wacom.com> Ping > Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com > <javascript:;>> >

Re: [Linuxwacom-devel] [PATCH input-wacom] Prevent NULL derefence when bNumEndpoints is 0

b_interface *intf, const struct usb_device_id *i if (!id->driver_info) return -EINVAL; + /* Verify that a device really has an endpoint */ + if (intf->cur_altsetting->desc.bNumEndpoints < 1) + return -EINVAL; + wacom = kzalloc(sizeof(struct wa

Re: [Linuxwacom-devel] [PATCH libwacom] tools: add a quirk for the HUION Consumer Control device in the udev rules

On Wed, Apr 13, 2016 at 8:28 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Wed, Apr 13, 2016 at 05:43:02PM -0700, Ping Cheng wrote: >> On Thu, Mar 31, 2016 at 5:44 PM, Peter Hutterer >> <peter.hutte...@who-t.net> wrote: >> > These devices have th

Re: [Linuxwacom-devel] [PATCH] isdv4: Use last-known event position in touch up events

position on touch up). Sounds sensible to me. > > Fixes: https://sourceforge.net/p/linuxwacom/bugs/312/ > > Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> Reviewed-by: Ping Cheng <pingli...@gmail.com> Ping > --- > src/wcmISDV4.c | 8 > 1 file changed, 4

Re: [Linuxwacom-devel] [PATCH libwacom] tools: add a quirk for the HUION Consumer Control device in the udev rules

On Thu, Mar 31, 2016 at 5:44 PM, Peter Hutterer wrote: > These devices have the same VID/PID as the tablet devices but are effectively > keyboards. Labelling them as tablets causes a libinput crash (fixed in > libinput with 1.2.1-5-g5d904b6). > >

[Linuxwacom-devel] [PATCH] Add .data files for DTK-1651

svg file was created by our in-house SVG expert, Jason Gerecke. Signed-off-by: Ping Cheng <pi...@wacom.com> --- data/dtk-1651.tablet | 34 +++ data/layouts/dtk-1651.svg | 144 ++ 2 files changed, 178 insertions(+) create mode 10064

Re: [Linuxwacom-devel] [PATCH wdaemon 1/2] Cleanup initial values

On Tue, Jan 19, 2016 at 7:11 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Jan 19, 2016 at 06:35:24PM -0800, Ping Cheng wrote: > > On Tue, Jan 19, 2016 at 6:17 PM, Peter Hutterer < > peter.hutte...@who-t.net> > > wrote: > > > > > O

Re: [Linuxwacom-devel] [PATCH wdaemon 1/2] Cleanup initial values

On Tue, Jan 19, 2016 at 5:03 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Jan 19, 2016 at 04:29:09PM -0800, Ping Cheng wrote: > > Group inital values by device types. > > > > Signed-off-by: Ping Cheng <pi...@wacom.com> > > --- > &

Re: [Linuxwacom-devel] [PATCH wdaemon 1/2] Cleanup initial values

On Tue, Jan 19, 2016 at 6:17 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Jan 19, 2016 at 05:47:50PM -0800, Ping Cheng wrote: > > On Tue, Jan 19, 2016 at 5:03 PM, Peter Hutterer < > peter.hutte...@who-t.net> > > wrote: > > > > > O

[Linuxwacom-devel] [PATCH wdaemon 1/2] Cleanup initial values

Group inital values by device types. Signed-off-by: Ping Cheng <pi...@wacom.com> --- v2: rely on device type instead of kernel version, as suggested by Peter. --- wacom.c | 67 + 1 file changed, 13 insertions(+), 54 del

[Linuxwacom-devel] [PATCH wdaemon 2/2] Add Intuos Pro support

Signed-off-by: Ping Cheng <pi...@wacom.com> --- udev/60-wacom.rules | 3 +++ udev/wdaemon_is_uinput.sh | 3 +++ wacom.c | 12 3 files changed, 18 insertions(+) diff --git a/udev/60-wacom.rules b/udev/60-wacom.rules index 7f536e3..0e62b35 100644 ---

[Linuxwacom-devel] [PATCH wdaemon 3/4] Add udev rules for Intuos5 series

It was missed in 228af55 Signed-off-by: Ping Cheng <pi...@wacom.com> --- udev/60-wacom.rules | 5 + udev/wdaemon_is_uinput.sh | 5 + 2 files changed, 10 insertions(+) diff --git a/udev/60-wacom.rules b/udev/60-wacom.rules index b883364..7f536e3 100644 --- a/udev/60-wacom

[Linuxwacom-devel] [PATCH wdaemon 4/4] Add Intuos Pro support

Signed-off-by: Ping Cheng <pi...@wacom.com> --- udev/60-wacom.rules | 3 +++ udev/wdaemon_is_uinput.sh | 3 +++ wacom.c | 9 + 3 files changed, 15 insertions(+) diff --git a/udev/60-wacom.rules b/udev/60-wacom.rules index 7f536e3..0e62b35 100644 --- a/u

[Linuxwacom-devel] [PATCH wdaemon 1/4] Set Cintiq and Intuos events in a new routine

Those events are set for all devices in current code. Signed-off-by: Ping Cheng <pi...@wacom.com> --- wacom.c | 141 ++-- 1 file changed, 57 insertions(+), 84 deletions(-) diff --git a/wacom.c b/wacom.c index 4ec3290..cd89aab

Re: [Linuxwacom-devel] [PATCH input-wacom 1/3] Allow user to specify kernel directory or version independently

<jason.gere...@wacom.com> This patch makes compilation across versions a lot easier! The whole set is: Tested-by: Ping Cheng <pi...@wacom.com> Ping > --- > configure.ac | 138 > --- > 1 file changed, 75 insertio

Re: [Linuxwacom-devel] [PATCH input-wacom] Enable additional compile warnings

ed-off-by: Jason Gerecke <jason.gere...@wacom.com <javascript:;>> It's a very good idea to make sure we take care of important warnings before submitting patches upstream. Thank you Jason. Acked-by: Ping Cheng <pi...@wacom.com> Ping --- > 2.6.30/Makefile.in | 2 +- > 2

[Linuxwacom-devel] [PATCH libwacom 1/2] Add .data files for Intuos series

All svg files are created based on intuos-m-p.svg. People with Inkscape experience can fine-tune the layouts if necessay. Signed-off-by: Ping Cheng <pi...@wacom.com> --- data/intuos-m-pt.tablet | 2 +- data/intuos-s-p.tablet | 2 +- data/intuos-s-pt.tablet | 2 +- data/l

[Linuxwacom-devel] [PATCH libwacom 2/2] Add .data files for Intuos 2 series

A new stylus id, 0x8e2, is added to libwacom.stylus since stylus for this series reports data in old Intuos format, which support tool serial number and tool ID. Signed-off-by: Ping Cheng <pi...@wacom.com> --- data/intuos-m-p2.tablet | 41 data/intuos

Re: [Linuxwacom-devel] [PATCH input-wacom] Fix powersupply issue for Wacom ExpressKey Remote

Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > Reviewed-by: Ping Cheng <pi...@wacom.com> Thank you Jason for the quick fix. Ping --- > 3.17/wacom_wac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/3.17/wacom_wac.c b/3.17/wacom_wa

[Linuxwacom-devel] [PATCH] data: the model name of Cintiq 21UX is DTZ-2100

Just to correct the device model name. Signed-off-by: Ping Cheng pi...@wacom.com --- data/cintiq-21ux.tablet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/cintiq-21ux.tablet b/data/cintiq-21ux.tablet index 69e8d4a..b905c1b 100644 --- a/data/cintiq-21ux.tablet +++ b

[Linuxwacom-devel] [PATCH 2/2] data: cintiq 22hdt supports touch

Signed-off-by: Ping Cheng pi...@wacom.com --- data/cintiq-22hdt.tablet | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/cintiq-22hdt.tablet b/data/cintiq-22hdt.tablet index c79f274..cc801ac 100644 --- a/data/cintiq-22hdt.tablet +++ b/data/cintiq-22hdt.tablet @@ -44,7 +44,7

[Linuxwacom-devel] [PATCH 1/2] data: add cintiq 13hdt tablet

Signed-off-by: Ping Cheng pi...@wacom.com --- data/cintiq-13hdt.tablet | 43 +++ 1 file changed, 43 insertions(+) create mode 100644 data/cintiq-13hdt.tablet diff --git a/data/cintiq-13hdt.tablet b/data/cintiq-13hdt.tablet new file mode 100644 index

Re: [Linuxwacom-devel] [PATCH] Allow PAD only interfaces without EV_ABS and/or EV_X/Y to report events

Hutterer peter.hutte...@who-t.net Reviewed-by: Ping Cheng pi...@wacom.com Sorry for the delay... Ping -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed

[Linuxwacom-devel] [PATCH libwacom] Add data files for Cintiq 27QHD and 27QHD touch

Signed-off-by: Ping Cheng pi...@wacom.com --- data/cintiq-27hd.tablet | 21 + data/cintiq-27hdt.tablet | 22 ++ 2 files changed, 43 insertions(+) create mode 100644 data/cintiq-27hd.tablet create mode 100644 data/cintiq-27hdt.tablet diff --git a/data

Re: [Linuxwacom-devel] [PATCH libwacom] data: add Distance to the axes reported by the mice/lens cursors

On Sun, Mar 1, 2015 at 10:55 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Not sure about the Intuos 1, 2, and 3 devices here, but I just assumed they'll do distance too. Yes, all pucks report distance. Reviewed-by: Ping Cheng

Re: [Linuxwacom-devel] [PATCH libwacom 2/2] tools: unset ID_INPUT_JOYSTICK for wacom tablets

you. Reviewed-by: Ping Cheng pi...@wacom.com for the series. Ping } static void print_uinput_entry_for_match (WacomDevice *device, const WacomMatch *match, -- 2.1.0 -- Dive into the World of Parallel

[Linuxwacom-devel] [PATCH v2] Update tool IDs for newer Cintiqs and Intuos 4/5/pro

New tools have been added when we added new tablets. Kernel driver has been updated with new tool IDs. But, we didn't update corresponding data/*.tablet and libwacom.stylus Signed-off-by: Ping Cheng pi...@wacom.com --- v2: updated Intuos4 series. Fixed make check and dbverfiy issues as pointed

[Linuxwacom-devel] [PATCH 1/2] Add data file for DTU 1031X

layout is unnecessary since there is no extra feature on the tablet. Signed-off-by: Ping Cheng pi...@wacom.com --- data/dtu-1031x.tablet | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 data/dtu-1031x.tablet diff --git a/data/dtu-1031x.tablet b/data/dtu

Re: [Linuxwacom-devel] [PATCH libwacom] add svg files for more Intuos tablets

-by: Ping Cheng pi...@wacom.com Thank you Aaron, Ping On Tue, Dec 9, 2014 at 1:53 PM, Ping Cheng pingli...@gmail.com wrote: On Tue, Dec 9, 2014 at 12:17 PM, Aaron Skomra sko...@gmail.com wrote: Signed-off-by: Aaron Skomra sko...@gmail.com --- Please note the buttons on these tablets do

Re: [Linuxwacom-devel] [PATCH libwacom] add svg files for more Intuos tablets

On Tue, Dec 9, 2014 at 12:17 PM, Aaron Skomra sko...@gmail.com wrote: Signed-off-by: Aaron Skomra sko...@gmail.com --- Please note the buttons on these tablets do not associate correctly when using the button mapping interface in GNOME, see my previous commit. data/intuos-m-pt.tablet

Re: [Linuxwacom-devel] [PATCH libwacom] Remove 'System' from IntegratedIn values for dt displays

On Fri, Nov 21, 2014 at 11:53 AM, Aaron Armstrong Skomra sko...@gmail.com wrote: Corrects the fact that most of the dt displays are identified as being integrated in a system. Signed-off-by: Aaron Skomra aaron.sko...@wacom.com Reviewed-by: Ping Cheng pi...@wacom.com Thank you Aaron

Re: [Linuxwacom-devel] [PATCH] Allow PAD only interface without setting up EV_ABS and/or EV_X/Y

On Thursday, November 20, 2014, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Nov 18, 2014 at 04:42:22PM -0800, Ping Cheng wrote: Wacom kernel driver has been merged to HID subsystem. As a bonus, we also allow PAD to report its data on its own interface. To declare the exact event

[Linuxwacom-devel] [PATCH] Allow PAD only interface without setting up EV_ABS and/or EV_X/Y

makes future PAD-only, or even expresskey-only, tablets work properly. Signed-off-by: Ping Cheng pi...@wacom.com --- src/wcmUSB.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 638ffb8..bac3c66 100644 --- a/src/wcmUSB.c +++ b/src

[Linuxwacom-devel] [PATCH] Add data file for Intuos Pen Medium

Signed-off-by: Ping Cheng pi...@wacom.com --- data/intuos-m-p.tablet | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 data/intuos-m-p.tablet diff --git a/data/intuos-m-p.tablet b/data/intuos-m-p.tablet new file mode 100644 index 000..7d41204

Re: [Linuxwacom-devel] [PATCH 1/5] Input - wacom: create a separate input device for pads

, ABS_MISC is necessary and is a reasonable way to group PAD events. So, I do not think it is for backward compatibility. It is there to stay. With that said, the whole patchset is Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Reviewed-by: Ping Cheng pi...@wacom.com Thank you

Re: [Linuxwacom-devel] [PATCH v2] Don't assume tablet (x, y) always starts from (0, 0)

On Tue, Jun 17, 2014 at 4:03 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Jun 10, 2014 at 12:49:55PM -0700, Ping Cheng wrote: Newer Cintiqs have an outbound of 200 tablet count outside of screen area. This causes absinfo.minimum to be 200 for some tablets instead of always 0

[Linuxwacom-devel] [PATCH v2] Don't assume tablet (x, y) always starts from (0, 0)

Newer Cintiqs have an outbound of 200 tablet count outside of screen area. This causes absinfo.minimum to be 200 for some tablets instead of always 0 for all tablets. Update struct _WacomDeviceRec and _WacomCommonRec to process this change. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed

[Linuxwacom-devel] [PATCH] Don't assume tablet (x, y) always starts from (0, 0)

Newer Cintiqs have an outbound of 200 tablet count outside of screen area. This causes absinfo.minimum to be 200 for some tablets instead of always 0 for all tablets. Update struct _WacomDeviceRec and _WacomCommonRec to process this change. Signed-off-by: Ping Cheng pi...@wacom.com --- src

Re: [Linuxwacom-devel] [PATCH] Fix enter-prox detection

the old records */ + /* when entering prox, replace the zeroed-out oldState with a copy of +* the current state to prevent jumps. reset the prox and button state +* to zero to properly detect changes. It is sensible to me. For all three patches, Reviewed-by: Ping Cheng pi

Re: [Linuxwacom-devel] [PATCH 1/4] Do not store a second copy of old touchstrip values in oldTilt[XY]

for the pad device for obvious reasons ;)). At this point in time, there is absolutely no reason to store a second copy of the strip values in oldTilt[XY]. Signed-off-by: Jason Gerecke killert...@gmail.com Nice cleanup, especially the third one! Reviewed-by: Ping Cheng pi...@wacom.com for the whole

Re: [Linuxwacom-devel] Kernel panic (null ptr) with 3.14.1 + CTH-480

On Thu, Apr 17, 2014 at 9:22 AM, Przemo Firszt prz...@firszt.eu wrote: Quoting Ping Cheng pingli...@gmail.com: Please follow the steps here: http://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=Input-Wacom to up date your kernel driver to see what happens. http

Re: [Linuxwacom-devel] Kernel panic (null ptr) with 3.14.1 + CTH-480

, reboot depmod -a modprobe wacom boom! On 15 April 2014 18:41, Ping Cheng pingli...@gmail.comjavascript:_e(%7B%7D,'cvml','pingli...@gmail.com'); wrote: On Tue, Apr 15, 2014 at 3:30 PM, Elv1313 . elv1...@gmail.comjavascript:_e(%7B%7D,'cvml','elv1...@gmail.com'); wrote: Hello, I

Re: [Linuxwacom-devel] Kernel panic (null ptr) with 3.14.1 + CTH-480

On Tue, Apr 15, 2014 at 3:30 PM, Elv1313 . elv1...@gmail.com wrote: Hello, I recently bought a Wacom CTH-480 to use it with Linux. I had no luck so far, but I read on this list that 3.14 should support it. However, all I get is a KP when modprobing the wacom driver. Did you build the driver

  1   2   3   4   5   6   7   8   >