Hi Peter,
Thanks for your review.
Peter Hutterer said the following on 11/01/2012 07:10 AM:
please sign off your patches.
Done.
ACK to the patch, but a few comments:
- should we call this svgdata or something like that instead of the generic
Images? in the makefile you call it layouts
From 85c9a02a524428b696619df37376b5b26a19fb81 Mon Sep 17 00:00:00 2001
From: Olivier Fourdan ofour...@redhat.com
Date: Thu, 25 Oct 2012 13:16:55 +0200
Subject: [PATCH 1/4] data: add image data for cintiq 12wx and Intuos5-m
as SVG files.
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
From da71825141c1a516f9f8b3253c57f4805afddbe8 Mon Sep 17 00:00:00 2001
From: Olivier Fourdan ofour...@redhat.com
Date: Thu, 25 Oct 2012 14:43:28 +0200
Subject: [PATCH 2/4] lib: add SVG layouts to device properties
Signed-off-by: Olivier Fourdan ofour...@redhat.com
---
From d711ef807a41636fd7682c810c5f2c03ab1a93dc Mon Sep 17 00:00:00 2001
From: Olivier Fourdan ofour...@redhat.com
Date: Mon, 29 Oct 2012 18:25:24 +0100
Subject: [PATCH 4/4] data: add missing button direction
test: check presence of direction for all known buttons
Make it mandatory to provide
Note: This updated patch also adds support for groups (g/g) in SVG.
From faed67e73057c6998fde65871075e9bfbcaa43af Mon Sep 17 00:00:00 2001
From: Olivier Fourdan ofour...@redhat.com
Date: Mon, 29 Oct 2012 18:08:27 +0100
Subject: [PATCH 3/4] tools: add tablet image viewer
test: add image
On Tue, Nov 06, 2012 at 03:06:59PM +0100, Olivier Fourdan wrote:
Note: This updated patch also adds support for groups (g/g) in SVG.
From faed67e73057c6998fde65871075e9bfbcaa43af Mon Sep 17 00:00:00 2001
From: Olivier Fourdan ofour...@redhat.com
Date: Mon, 29 Oct 2012 18:08:27 +0100