Re: [Linuxwacom-devel] [PATCH 0/2] add IntegratedIn feature for ISD

2012-10-11 Thread Olivier Fourdan
Updated patchset which also includes the use of kernel flags INPUT_PROP_POINTER/INPUT_PROP_DIRECT if available (ie applies on top of [PATCH] lib: use kernel flags if available and [PATCH 0/2] libwacom status LED helper functions - take 2 This also changes the enum to use -1 for

Re: [Linuxwacom-devel] [PATCH 0/2] add IntegratedIn feature for ISD

2012-10-09 Thread Bastien Nocera
On Tue, 2012-10-09 at 16:23 +0200, Olivier Fourdan wrote: Bastien Nocera said the following on 10/08/2012 06:24 PM: [...] Looks to me like builtin is tablet is integrated with the display and ISD is tablet is integrated with the computer. I'm sure we could deprecate the _is_builtin()

Re: [Linuxwacom-devel] [PATCH 0/2] add IntegratedIn feature for ISD

2012-10-09 Thread Olivier Fourdan
Bastien Nocera said the following on 10/09/2012 05:18 PM: WACOM_DEVICE_INTEGRATED_UNSET = -1 Then. The compiler will make it an int instead of an unsigned int. Humm, nope, not what I want. -1 will have all bits set to 1 if I a not mistaken, so that means all the bits mask will return true,

Re: [Linuxwacom-devel] [PATCH 0/2] add IntegratedIn feature for ISD

2012-10-09 Thread Bastien Nocera
On Tue, 2012-10-09 at 17:23 +0200, Olivier Fourdan wrote: Bastien Nocera said the following on 10/09/2012 05:18 PM: WACOM_DEVICE_INTEGRATED_UNSET = -1 Then. The compiler will make it an int instead of an unsigned int. Humm, nope, not what I want. -1 will have all bits set to 1 if I a

Re: [Linuxwacom-devel] [PATCH 0/2] add IntegratedIn feature for ISD

2012-10-09 Thread Olivier Fourdan
Bastien Nocera said the following on 10/09/2012 05:37 PM: On Tue, 2012-10-09 at 17:23 +0200, Olivier Fourdan wrote: Bastien Nocera said the following on 10/09/2012 05:18 PM: WACOM_DEVICE_INTEGRATED_UNSET = -1 Then. The compiler will make it an int instead of an unsigned int. Humm, nope, not