[Lldb-commits] [PATCH] lldb handle breakpoints on ARM64

2014-08-19 Thread Paul Osmialowski
The opcode was taken from gdb sources. break set -n main Breakpoint 1: where = example`$x, address = 0x00400c60 Note that for me, gdb worked only with statically linked binaries on emulated AArch64 machine, therefore from now on I'm testing lldb with statically linked binaries too.

Re: [Lldb-commits] [PATCH] lldb handle breakpoints on ARM64

2014-08-19 Thread Paul Osmialowski
On gdb, the same breakpoint in the same binary is situated 8 bytes further... (gdb) break main Breakpoint 1 at 0x400c68 http://reviews.llvm.org/D4969 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r215976 - Buffer not null terminated CID 1094354

2014-08-19 Thread Sylvestre Ledru
Author: sylvestre Date: Tue Aug 19 07:13:14 2014 New Revision: 215976 URL: http://llvm.org/viewvc/llvm-project?rev=215976view=rev Log: Buffer not null terminated CID 1094354 Modified: lldb/trunk/source/API/SBModule.cpp Modified: lldb/trunk/source/API/SBModule.cpp URL:

Re: [Lldb-commits] [PATCH] Add process launch --enable-aslr option, tweak handling of flag

2014-08-19 Thread Ed Maste
On 18 August 2014 17:43, jing...@apple.com wrote: The logic behind the name is that it's not as though the debugger is able to turn aslr on on a system that doesn't have it - so -aslr on/true/yes doesn't make sense - but rather the debugger is running on a system with ASLR, in which case

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-19 Thread Todd Fiala
Looking at this now. http://reviews.llvm.org/D4803 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb handle breakpoints on ARM64

2014-08-19 Thread Todd Fiala
Look at this now (in isolation from http://reviews.llvm.org/D4803). http://reviews.llvm.org/D4969 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb - Register Context Linux ARM64

2014-08-19 Thread Todd Fiala
Same with this - did this go in while I was on vacation? Looking to close out some reviews that are still listed as open. http://reviews.llvm.org/D4580 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Adjust process launch --disable-aslr to take true/false value.

2014-08-19 Thread Todd Fiala
Thanks. I'll get that in and be done with it (wipes hands clean...) ;-) On Tue, Aug 19, 2014 at 10:27 AM, jing...@apple.com wrote: That looks right to me. Jim On Aug 18, 2014, at 9:07 PM, Todd Fiala tfi...@google.com wrote: Hey Jim, Does this patch adequately address your

[Lldb-commits] [lldb] r215993 - Fix .clang-format file to adhere to LLDB 140 column limit.

2014-08-19 Thread Zachary Turner
Author: zturner Date: Tue Aug 19 12:18:38 2014 New Revision: 215993 URL: http://llvm.org/viewvc/llvm-project?rev=215993view=rev Log: Fix .clang-format file to adhere to LLDB 140 column limit. Modified: lldb/trunk/.clang-format Modified: lldb/trunk/.clang-format URL:

[Lldb-commits] [lldb] r215992 - Move some Host logic into HostInfo class.

2014-08-19 Thread Zachary Turner
Author: zturner Date: Tue Aug 19 12:18:29 2014 New Revision: 215992 URL: http://llvm.org/viewvc/llvm-project?rev=215992view=rev Log: Move some Host logic into HostInfo class. This patch creates a HostInfo class, a static class used to answer basic queries about the host platform. As part of

Re: [Lldb-commits] [PATCH] Creates a HostInfo class from code that was previously in Host.

2014-08-19 Thread Zachary Turner
Closed by commit rL215992 (authored by @zturner). REPOSITORY rL LLVM http://reviews.llvm.org/D4963 Files: lldb/trunk/include/lldb/Core/ArchSpec.h lldb/trunk/include/lldb/Host/Host.h lldb/trunk/include/lldb/Host/HostInfo.h lldb/trunk/include/lldb/Host/HostInfoBase.h

[Lldb-commits] [lldb] r215996 - Adjust process launch --disable-aslr to take true/false value.

2014-08-19 Thread Todd Fiala
Author: tfiala Date: Tue Aug 19 12:40:43 2014 New Revision: 215996 URL: http://llvm.org/viewvc/llvm-project?rev=215996view=rev Log: Adjust process launch --disable-aslr to take true/false value. This change modifies the 'process launch' --disable-aslr option to take a boolean argument. If the

Re: [Lldb-commits] [PATCH] Adjust process launch --disable-aslr to take true/false value.

2014-08-19 Thread Todd Fiala
Submitted: tfiala-macpro2:lldb tfiala$ svn commit Sendinginclude/lldb/Target/Process.h Sendingsource/Commands/CommandObjectProcess.cpp Sendingsource/Target/Process.cpp Transmitting file data ... Committed revision 215996. On Tue, Aug 19, 2014 at 10:28 AM, Todd Fiala

[Lldb-commits] [lldb] r216000 - Add includes needed for FreeBSD.

2014-08-19 Thread Zachary Turner
Author: zturner Date: Tue Aug 19 13:38:53 2014 New Revision: 216000 URL: http://llvm.org/viewvc/llvm-project?rev=216000view=rev Log: Add includes needed for FreeBSD. Modified: lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cpp Modified: lldb/trunk/source/Host/freebsd/HostInfoFreeBSD.cpp

[Lldb-commits] [lldb] r216004 - Refactor the hardcoded formatters facility to use sequences of lambdas - still no feature change as none are present now, but this feels cleaner. Also, hardcoded format

2014-08-19 Thread Enrico Granata
Author: enrico Date: Tue Aug 19 13:47:58 2014 New Revision: 216004 URL: http://llvm.org/viewvc/llvm-project?rev=216004view=rev Log: Refactor the hardcoded formatters facility to use sequences of lambdas - still no feature change as none are present now, but this feels cleaner. Also, hardcoded

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-19 Thread Todd Fiala
Ok - that sounds good. Would you like to pull those out and put it in this patch, since they seem to be atomically related? On Tue, Aug 19, 2014 at 12:58 PM, Paul Osmialowski paw...@king.net.pl wrote: All those PT_* ifdefs were related to ARM64, so I suppose they can be safely removed.

Re: [Lldb-commits] [PATCH] lldb gdb inspired use of ptrace on arm64

2014-08-19 Thread Todd Fiala
Ok - that sounds good. Would you like to pull those out and put it in this patch, since they seem to be atomically related? http://reviews.llvm.org/D4803 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] lldb - Register Context Linux ARM64

2014-08-19 Thread Paul Osmialowski
D4488 was completely covered by later patch already on LLVM's master. http://reviews.llvm.org/D4580 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb - ELF: ARM64 relocation jump slot type

2014-08-19 Thread Paul Osmialowski
Similar patch was accepted later which adds missing R_AARCH64_JUMP_SLOT constant, so it builds fine now. http://reviews.llvm.org/D4579 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb - ELF: ARM64 relocation jump slot type

2014-08-19 Thread Todd Fiala
Okay - thanks Paul. Closing out. Listing as accepted with understanding this already went in (albeit slightly differently). http://reviews.llvm.org/D4579 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] lldb - Register Context Linux ARM64

2014-08-19 Thread Todd Fiala
Ok - marking as accepted and closing out (with understanding this functionality already went in via another patch). http://reviews.llvm.org/D4580 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] lldb handle breakpoints on ARM64

2014-08-19 Thread Paul Osmialowski
I really don't like to put brackets around objects/variables/constants - sizeof requires them only for type names. I'm doing this only to fit into existing code. http://reviews.llvm.org/D4969 Files: source/Plugins/Platform/Linux/PlatformLinux.cpp

[Lldb-commits] [lldb] r216021 - Fix FreeBSD build after r215992

2014-08-19 Thread Ed Maste
Author: emaste Date: Tue Aug 19 16:00:37 2014 New Revision: 216021 URL: http://llvm.org/viewvc/llvm-project?rev=216021view=rev Log: Fix FreeBSD build after r215992 Modified: lldb/trunk/include/lldb/Host/freebsd/HostInfoFreeBSD.h Modified:

[Lldb-commits] [lldb] r216026 - This is a fairly bulky patch, but a lot of it involves rearranging existing code

2014-08-19 Thread Enrico Granata
Author: enrico Date: Tue Aug 19 16:46:37 2014 New Revision: 216026 URL: http://llvm.org/viewvc/llvm-project?rev=216026view=rev Log: This is a fairly bulky patch, but a lot of it involves rearranging existing code What it does: - it introduces a concept of EncodingToType to the

[Lldb-commits] [lldb] r216028 - Attempt to keep the Linux build happy in face of my changes. Non-Apple folks, can you confirm that this is good enough to keep things building for you?

2014-08-19 Thread Enrico Granata
Author: enrico Date: Tue Aug 19 16:48:27 2014 New Revision: 216028 URL: http://llvm.org/viewvc/llvm-project?rev=216028view=rev Log: Attempt to keep the Linux build happy in face of my changes. Non-Apple folks, can you confirm that this is good enough to keep things building for you? Modified:

Re: [Lldb-commits] [lldb] r216028 - Attempt to keep the Linux build happy in face of my changes. Non-Apple folks, can you confirm that this is good enough to keep things building for you?

2014-08-19 Thread Todd Fiala
I'll verify on Linux. On Tue, Aug 19, 2014 at 2:48 PM, Enrico Granata egran...@apple.com wrote: Author: enrico Date: Tue Aug 19 16:48:27 2014 New Revision: 216028 URL: http://llvm.org/viewvc/llvm-project?rev=216028view=rev Log: Attempt to keep the Linux build happy in face of my changes.

Re: [Lldb-commits] [lldb] r216028 - Attempt to keep the Linux build happy in face of my changes. Non-Apple folks, can you confirm that this is good enough to keep things building for you?

2014-08-19 Thread Todd Fiala
Hey Enrico, A rebuild worked fine (which did a new cmake step). I'm in the middle of a clean build, but the cmake step passed. Usually that's the part that will bark if there's an issue. I think you're fine as far as cmake builds are concerned. -Todd On Tue, Aug 19, 2014 at 3:06 PM, Todd

Re: [Lldb-commits] [lldb] r216028 - Attempt to keep the Linux build happy in face of my changes. Non-Apple folks, can you confirm that this is good enough to keep things building for you?

2014-08-19 Thread Enrico Granata
Awesome! If any other build system in use has issues, hopefully the patch is self-explanatory, but please let me know and I will try and help! On Aug 19, 2014, at 3:13 PM, Todd Fiala tfi...@google.com wrote: Hey Enrico, A rebuild worked fine (which did a new cmake step). I'm in the

[Lldb-commits] [lldb] r216032 - Add an accessor to ValueObject that determines if the object represents a base class, and also returns the depth of base-class-ness. For instance if one has class C : p

2014-08-19 Thread Enrico Granata
Author: enrico Date: Tue Aug 19 17:29:08 2014 New Revision: 216032 URL: http://llvm.org/viewvc/llvm-project?rev=216032view=rev Log: Add an accessor to ValueObject that determines if the object represents a base class, and also returns the depth of base-class-ness. For instance if one has class

Re: [Lldb-commits] [PATCH] Profile Assembly Until Ret Instruction

2014-08-19 Thread Greg Clayton
The EH frame doesn't track the PIC bump stuff and that can/will hose up stepping. On Aug 19, 2014, at 4:22 PM, Jason Molenda jmole...@apple.com wrote: Hi Tong, my message was a little rambling. Let's be specific. We are changing lldb to trust eh_frame instructions on the