Hi Greg/Jason,
This change, r218001, reverses a change I made: r214480.
I made the change (send triple as plain text), motivated by a discussion
with Jason Molenda, which started here:
http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20140721/011978.html
What's happening here?
Author: gclayton
Date: Mon Sep 22 17:06:41 2014
New Revision: 218279
URL: http://llvm.org/viewvc/llvm-project?rev=218279view=rev
Log:
Played around with TK UI a bit this weekend.
If you command script import this file, then you will have two new commands:
(lldb) tk-variables
(lldb) tk-process
1) added the
process_sp-GetExtendedThreadList().AddThread (new_thread_sp);
line when the ThreadSP is created, and also added this into the test case
2) refactored the duplicate code into a CreateHistoryThreadFromValueObject
function that is called twice.
http://reviews.llvm.org/D5452
Files:
Addressing review comments.
http://reviews.llvm.org/D4527
Files:
include/sanitizer/asan_interface.h
lib/asan/asan_debugging.cc
lib/asan/asan_globals.cc
lib/asan/asan_interface_internal.h
lib/asan/asan_report.cc
lib/asan/asan_report.h
test/asan/TestCases/debug_locate.cc
Uploading patch with more context.
http://reviews.llvm.org/D4527
Files:
include/sanitizer/asan_interface.h
lib/asan/asan_debugging.cc
lib/asan/asan_globals.cc
lib/asan/asan_interface_internal.h
lib/asan/asan_report.cc
lib/asan/asan_report.h
test/asan/TestCases/debug_locate.cc
Author: jmolenda
Date: Mon Sep 22 21:43:35 2014
New Revision: 218291
URL: http://llvm.org/viewvc/llvm-project?rev=218291view=rev
Log:
ConnectionFileDescriptor::Connect()'s handling of the fd:// method
was broken in r214984 by the addition of an unconditional error
return at the start of the code
Looks good, a couple changes to match the lldb coding style better; please
commit.
Comment at: source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp:119
@@ +118,3 @@
+
+if (count = 0) return;
+
Please split into two lines,
```
if (count = 0)
return;
```
