Author: tfiala
Date: Fri Sep 26 07:58:25 2014
New Revision: 218518
URL: http://llvm.org/viewvc/llvm-project?rev=218518view=rev
Log:
gtest: modified Xcode integration so gtest assert/expect failure now shows
error content in the error marker at the line of failure.
This change modifies the
Greg is out on vacation for a week. This looks fairly straightforward. There
used to be architectures with weird byte sizes like 9 or 12 bits - gdb had some
support for this. Choosing to express the number of bits per byte as a
multiple of 8 makes it impossible to support this situation.
Greg is out on vacation for a week. This looks fairly straightforward. There
used to be architectures with weird byte sizes like 9 or 12 bits - gdb had some
support for this. Choosing to express the number of bits per byte as a
multiple of 8 makes it impossible to support this situation.
Comment at: source/Host/common/Host.cpp:978-980
@@ -957,2 +977,5 @@
}
+#else
+error.SetErrorString(Host::LaunchProcessPosixSpawn() not supported on
Android);
+#endif
If launching a process via posix_spawn() isn't supported on Android, then how
*do*
I also want to echo all the comments that I really don't like the #ifdefs
everywhere. I've been working for the past 2 months specifically to get rid of
#ifdefs, so this is like a punch in the stomach :(
http://reviews.llvm.org/D5495
___
Author: tfiala
Date: Fri Sep 26 14:08:00 2014
New Revision: 218537
URL: http://llvm.org/viewvc/llvm-project?rev=218537view=rev
Log:
gtest: tweaked test runner to fix an extra comma, added more tdd-based thread
coordinator behavior.
Starting to flesh out the thread state coordinator class that
Reverted in r218501 due to test failure on the sanitizer-x86_64-linux buildbot.
Committed again in r218538 with a fix, intptr_t - uintptr_t, and an extra
free(heap_ptr) to fix the LeakSanitizer report. Both changes are in the test
file only (debug_locate.cc).
http://reviews.llvm.org/D4527
I'm not seeing the changes to HostInfoPosix and HostThreadPosix that I
suggested. Are those still coming in a followup?
On Fri, Sep 26, 2014 at 11:59 AM, Tong Shen endlessr...@google.com wrote:
http://reviews.llvm.org/D5495
Files:
include/lldb/Core/IOHandler.h
! In D5495#27, @zturner wrote:
I'm not seeing the changes to HostInfoPosix and HostThreadPosix that I
suggested. Are those still coming in a followup?
With Android, it's *mostly* Linux (at the kernel level) except we have a whole
slew of different runtime libraries that differ. So, for much
Actually, Todd suggested me to add Android specific files for
HostInfo, HostThread, etc.
What's the best way to avoid duplicating HostInfoLinux functions into
HostInfoAndroid?
On Fri, Sep 26, 2014 at 1:09 PM, Zachary Turner ztur...@google.com wrote:
const char *
Have a look Jim :-) I'd love to do that but right now everything appears
to be static AFAICT.
On Fri, Sep 26, 2014 at 1:18 PM, jing...@apple.com wrote:
Sorry, I must be missing something. Why can't HostInfoAndroid just derive
from HostInfoLinux, and only modify the methods it actually
Sorry, I must be missing something. Why can't HostInfoAndroid just derive from
HostInfoLinux, and only modify the methods it actually changes?
Jim
On Sep 26, 2014, at 1:16 PM, Tong Shen endlessr...@google.com wrote:
Actually, Todd suggested me to add Android specific files for
HostInfo,
It wasn't made a class instance hierarchy for the same reason that Host
wasn't a class instance to begin with. HostInfo only contains method that
are inherently static. You could make it an instance, but it would be
awkward, because you would have to create one for the sole purpose of
calling a
I think that for the purposes that I wrote HostInfo to handle, very simple
methods that answer simple queries about the host os, the virtual methods
would not be needed. For example, what's the username of the currently
logged in user? What's the page size? Get the value of an environment
I think some of the changes you wanted to see Tong make (which I think are
fine to change) are what Tong's looking at now, which need to deviate some
POSIX code in very minor ways.
Tong - can you call out the code for us?
Thanks,
Todd
On Fri, Sep 26, 2014 at 1:34 PM, Zachary Turner
If there is concern over calling a GetHostInfoInstance() or some kind of
singleton caller, we can always wrap that in static calls that do it for
us. But I'd much prefer here to have an instance with a vtable.
On Fri, Sep 26, 2014 at 1:36 PM, Todd Fiala tfi...@google.com wrote:
I think some of
! In D5495#29, @endlessroad wrote:
Add Host{Info, Thread}Android. They cannot directly inherit Host{Info,
Thread}Posix, because that would need linking the base classes, which will
cause linker error (some POSIX functions do not exist on Android)
It didn't occur to me that there would be
Reupload DIff version 4.
Hi Jim, Greg,
All your original comments have been addressed.
http://reviews.llvm.org/D5495
Files:
include/lldb/Core/IOHandler.h
include/lldb/Host/linux/Config.h
source/Core/IOHandler.cpp
source/Host/common/Host.cpp
source/Host/common/Socket.cpp
Author: tfiala
Date: Fri Sep 26 20:11:17 2014
New Revision: 218558
URL: http://llvm.org/viewvc/llvm-project?rev=218558view=rev
Log:
thread state coordinator: added test for notify after two pending thread stops.
Glad I did - caught a bug where the auto variable was not a reference
to a set and
Author: tfiala
Date: Fri Sep 26 20:58:13 2014
New Revision: 218559
URL: http://llvm.org/viewvc/llvm-project?rev=218559view=rev
Log:
thread state coordinator: added thread death support and more tests.
Tested two pending stops before notification, where one of the pending stop
requirements was
20 matches
Mail list logo
