Re: [Lldb-commits] [lldb] r226544 - Fix creation of StringRef in FileSpec::ResolveUsername()

Should add -- when stopped here, (lldb) p pathname (const char *) $6 = 0x7fb75946b890 ~jmolenda/lldb/simplebt.py (lldb) p normalized (llvm::SmallString64) $5 = { llvm::SmallVectorchar, 64 = { llvm::SmallVectorImplchar = { llvm::SmallVectorTemplateBasechar, true = {

[Lldb-commits] [lldb] r226543 - Don't mention a --core-file argument to target create. It is

Author: jmolenda Date: Mon Jan 19 21:06:17 2015 New Revision: 226543 URL: http://llvm.org/viewvc/llvm-project?rev=226543view=rev Log: Don't mention a --core-file argument to target create. It is --core. rdar://problem/19518164 Modified: lldb/trunk/source/Commands/CommandObjectTarget.cpp

[Lldb-commits] [lldb] r226530 - Added an Xcode target so we build the lldb-mi executable as part of the desktop and desktop no xpc targets.

Author: gclayton Date: Mon Jan 19 18:04:26 2015 New Revision: 226530 URL: http://llvm.org/viewvc/llvm-project?rev=226530view=rev Log: Added an Xcode target so we build the lldb-mi executable as part of the desktop and desktop no xpc targets. Include paths were switched to be user include paths,

Re: [Lldb-commits] [lldb] r226544 - Fix creation of StringRef in FileSpec::ResolveUsername()

It's a bit of an awkward interface. It doesn't necessarily store a null terminator by default. If you call SmallString::c_str(), it will append a null terminator (if necessary), but the base class, SmallVector doesn't have a c_str() method, only a data() method, which doesn't append the null

Re: [Lldb-commits] [PATCH] Fix output of do-gtest.py

Great to see you around Tamas! Todd isn't on the project anymore, you and I own this file. =) I'll take a look shortly. http://reviews.llvm.org/D7054 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits

Re: [Lldb-commits] [PATCH] Add -exec-arguments command

Looks ok to me. 2 comments though. 1. Why are changes in SBTarget when you are not using them. 2. I think the test cases for arguments are currently skipped (@unittest2.skip(requires 'quotes' and 'CLI support' patches)). Currently, we can test for argc. So I think at least that portion should

Re: [Lldb-commits] [PATCH] fixed up some logging messages (options and wait_pid were swapped)

lgtm REPOSITORY rL LLVM http://reviews.llvm.org/D7058 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix for lldb-platform linking error on OSX/CMake

Look good. REPOSITORY rL LLVM http://reviews.llvm.org/D6921 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Add -exec-arguments command

So the way you set arguments when you launch a process through the SB API's (besides some old unstructured API's that we'll eventually deprecate) is through the SBLaunchInfo. You're adding another way to get and set the arguments that's independent of that. I'd rather we didn't create another

Re: [Lldb-commits] [PATCH] Added Connection::GetURI()

This is still using snprintf(). Can we switch over to using StringStream? REPOSITORY rL LLVM http://reviews.llvm.org/D7026 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] UpdateSDKDirectoryInfosInNeeded(); called twice, is that right?

Please fix our typo from UpdateSDKDirectoryInfosInNeeded to UpdateSDKDirectoryInfosIsNeeded and commit. REPOSITORY rL LLVM http://reviews.llvm.org/D7059 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___

Re: [Lldb-commits] [PATCH] Fix for lldb-platform linking error on OSX/CMake

REPOSITORY rL LLVM http://reviews.llvm.org/D6921 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] UpdateSDKDirectoryInfosInNeeded(); called twice, is that right?

Presumably that should be IfNeeded as well? REPOSITORY rL LLVM http://reviews.llvm.org/D7059 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Add -exec-arguments command

In http://reviews.llvm.org/D6965#110558, @jingham wrote: So the way you set arguments when you launch a process through the SB API's (besides some old unstructured API's that we'll eventually deprecate) is through the SBLaunchInfo. You're adding another way to get and set the arguments

Re: [Lldb-commits] [PATCH] Add -exec-arguments command

If we want to have a way to directly set the arguments in a Target, I would prefer to have the SBTarget vend the SBLaunchInfo that it will use when it launches (if you don't give it another SBLaunchInfo) and then set the arguments there. Right now it is pretty incoherent, you can set arguments