Re: [Lldb-commits] [PATCH] Initial Assembly profiler for mips64

This patch implements MIPS64 assembly profiler using EmulateInstruction class. REPOSITORY rL LLVM http://reviews.llvm.org/D7696 Files: cmake/LLDBDependencies.cmake lib/Makefile source/Plugins/Instruction/CMakeLists.txt source/Plugins/Instruction/MIPS64/CMakeLists.txt

Re: [Lldb-commits] [PATCH] Don't require AVX registers if the target CPU doesn't have them

Comment at: test/tools/lldb-server/TestLldbGdbServer.py:465 @@ +464,3 @@ +def targetHasAVX(self): +# Need to do something different for non-Linux/Android targets +if lldb.remote_platform: Would be nice to see a switch on sys.platform or

Re: [Lldb-commits] [PATCH] Initialize ProcessGDBRemoteLog for LLGS to fix remote platform logging

REPOSITORY rL LLVM Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:142 @@ +141,3 @@ +void +GDBRemoteCommunication::Initialize() +{ tberghammer wrote: ovyalov wrote: Maybe introduce ProcessGDBRemoteLog::Initialize() instead of this

Re: [Lldb-commits] [PATCH] Initialize ProcessGDBRemoteLog for LLGS by GDBRemoteCommunication::Initialize

Move Log initialization to Log class Initialize functions and use std::call_once to guard against multiple calls. REPOSITORY rL LLVM http://reviews.llvm.org/D8186 Files: source/Plugins/Process/Linux/NativeProcessLinux.cpp source/Plugins/Process/Linux/NativeProcessLinux.h

Re: [Lldb-commits] [PATCH] Fix a comment for ValueObject::GetValueDidChange after r231526

That's fine. Jim http://reviews.llvm.org/D8206 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix a comment for ValueObject::GetValueDidChange after r231526

That's fine. Jim On Mar 10, 2015, at 10:15 AM, Ilia K ki.s...@gmail.com wrote: some changes http://reviews.llvm.org/D8206 Files: include/lldb/API/SBValue.h include/lldb/Core/ValueObject.h Index: include/lldb/API/SBValue.h

[Lldb-commits] [lldb] r231808 - Add Debugger::InitializeForLLGS to allow ref counted LLGS initialization.

Author: flackr Date: Tue Mar 10 13:07:47 2015 New Revision: 231808 URL: http://llvm.org/viewvc/llvm-project?rev=231808view=rev Log: Add Debugger::InitializeForLLGS to allow ref counted LLGS initialization. After http://reviews.llvm.org/D8133 landed as r231550 process launch on remote platform

Re: [Lldb-commits] [PATCH] Fix deadlock in Listener/Broadcaster::Clear

What happens if somebody tries to add a listener to a broadcaster while it is calling clear? Jim On Mar 10, 2015, at 10:30 AM, Pavel Labath lab...@google.com wrote: Hi clayborg, When calling Listener::Clear() and Broadcaster::Clear() simultaneously from two threads a deadlock would

Re: [Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

I didn't see these options in doc: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-File-Commands.html. Is it well-known options? I use the the following code instead of this: -interpreter-exec console platform select remote-ios --sysroot \/Users/IliaK/Library/Developer/Xcode/iOS

Re: [Lldb-commits] [PATCH] Add Debugger::InitializeForLLGS to allow ref counted LLGS initialization.

REPOSITORY rL LLVM http://reviews.llvm.org/D8183 Files: lldb/trunk/include/lldb/Core/Debugger.h lldb/trunk/source/Core/Debugger.cpp lldb/trunk/source/lldb.cpp lldb/trunk/tools/lldb-server/lldb-server.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: [Lldb-commits] [PATCH] Allow the specification of a mode property on the LLDB Builder

If I get the idea right, you need to reconcile the parameter mode with the property mode, giving the priority to the property. The patch as is wouldn't do what you want. http://reviews.llvm.org/D8062 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

[Lldb-commits] [PATCH] Add lldb-mi/lldb-server test folders to PATH before in dotest.py

Hi vharron, This patch allows not specify search path in each lldb-mi test. It makes tests easier. This fix was requested by vharron. All test pass on OS X. http://reviews.llvm.org/D8207 Files: test/dotest.py test/tools/lldb-mi/breakpoint/TestMiBreak.py

[Lldb-commits] [lldb] r231804 - Fix a comment for ValueObject::GetValueDidChange after r231526

Author: ki.stfu Date: Tue Mar 10 12:24:32 2015 New Revision: 231804 URL: http://llvm.org/viewvc/llvm-project?rev=231804view=rev Log: Fix a comment for ValueObject::GetValueDidChange after r231526 Summary: Fix a comment for ValueObject::GetValueDidChange after r231526. This fix was requested by

Re: [Lldb-commits] [PATCH] Fix deadlock in Listener/Broadcaster::Clear

What happens if somebody tries to add a listener to a broadcaster while it is calling clear? Jim http://reviews.llvm.org/D8211 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

Looks good except the launch code. See my inlined comment. BTW: to make inline comments in the code, you click and drag in the line numbers column and let go and then you can comment on specific bits of code. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:96-110 @@ -98,1 +95,17 @@

Re: [Lldb-commits] [PATCH] Refactor GdbRemote test cases to support remote platforms

You shouldn't ever have to call SBPlatform::Install() manually unless you just want to run a process remotely without debugging it. Is this what you are trying to do? Install something so that lldb-server can be used? If so ignore what I am saying below. If you are trying to just debug

Re: [Lldb-commits] [PATCH] Update the LLDB website with more information

That looks good. http://reviews.llvm.org/D8222 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

See my remarks below. Comment at: tools/lldb-mi/MICmdCmdFile.cpp:88 @@ -78,1 +87,3 @@ +m_setCmdArgs.Add(*(new CMICmdArgValOptionShort(m_constStrArgNamedRemotePath, false, true, +

Re: [Lldb-commits] [PATCH] [MIPS] - Register Context for MIPS64

Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D8166 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Update the LLDB website with more information

I wasn't aware that the Xcode build did that. I'll update in a bit. I think it's useful to say something about the directory structure though because it lets people know how to update their code. Also will fix the suggestions about line length On Tue, Mar 10, 2015 at 12:20 PM Jim Ingham

Re: [Lldb-commits] [PATCH] Add =shlibs-added/=shlibs-removed notifications (MI)

Overall looks good, just a few things to fix. See inlined comments. Comment at: include/lldb/API/SBModule.h:332-333 @@ +331,4 @@ +//-- +lldb::SBFileSpec +GetSymbolVendorMainFileSpec() const; +

[Lldb-commits] [PATCH] XFAIL TestAbbreviations on Linux

Hi clayborg, tberghammer, flackr, It was failing on gcc 4.8, only passing accidentally on clang 3.5 This patch improves the checking to make sure if fails in all cases and then XFAILS http://reviews.llvm.org/D8192 Files: test/functionalities/abbreviation/TestAbbreviations.py Index:

Re: [Lldb-commits] [PATCH] XFAIL TestAbbreviations on Linux

lgtm http://reviews.llvm.org/D8192 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add =shlibs-added/=shlibs-removed notifications (MI)

Rename SBModule::GetSymbolVendorMainFileSpec to GetSymbolFileSpec http://reviews.llvm.org/D8201 Files: include/lldb/API/SBEvent.h include/lldb/API/SBModule.h include/lldb/API/SBTarget.h include/lldb/Target/Target.h source/API/SBModule.cpp source/API/SBTarget.cpp

Re: [Lldb-commits] [PATCH] Add =shlibs-added/=shlibs-removed notifications (MI)

REPOSITORY rL LLVM http://reviews.llvm.org/D8201 Files: lldb/trunk/include/lldb/API/SBEvent.h lldb/trunk/include/lldb/API/SBModule.h lldb/trunk/include/lldb/API/SBTarget.h lldb/trunk/include/lldb/Target/Target.h lldb/trunk/source/API/SBModule.cpp lldb/trunk/source/API/SBTarget.cpp

[Lldb-commits] [lldb] r231858 - Add =shlibs-added/=shlibs-removed notifications (MI)

Author: ki.stfu Date: Tue Mar 10 16:59:55 2015 New Revision: 231858 URL: http://llvm.org/viewvc/llvm-project?rev=231858view=rev Log: Add =shlibs-added/=shlibs-removed notifications (MI) Summary: This patch adds =shlibs-added/=shlibs-removed notifications in lldb-mi. In more detail: # Add

Re: [Lldb-commits] [PATCH] Create a CODE_OWNERS.txt file for LLDB

Added Enrico to swig http://reviews.llvm.org/D8228 Files: CODE_OWNERS.txt Index: CODE_OWNERS.txt === --- /dev/null +++ CODE_OWNERS.txt @@ -0,0 +1,46 @@ +This file is a list of the people responsible for ensuring that patches for

Re: [Lldb-commits] [PATCH] Add =shlibs-added/=shlibs-removed notifications (MI)

I have a question. Comment at: source/API/SBTarget.cpp:136 @@ +135,3 @@ +{ +return Target::TargetEventData::GetEventDataFromEvent(event.get()) != NULL; +} clayborg wrote: Make static functions in Target.h/cpp so we don't expose the TargetEventData class

Re: [Lldb-commits] [PATCH] Create a CODE_OWNERS.txt file for LLDB

Yes please. Ilia K will be fine. On Wed, Mar 11, 2015 at 12:43 AM, Zachary Turner ztur...@google.com wrote: Should I list your name as Ilia K, or would you prefer a full last name? On Tue, Mar 10, 2015 at 2:43 PM Ilia K ki.s...@gmail.com wrote: In http://reviews.llvm.org/D8228#138260,

Re: [Lldb-commits] [PATCH] Create a CODE_OWNERS.txt file for LLDB

Looks good. http://reviews.llvm.org/D8228 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r231885 - If the user specifies a kernel binary that isn't correct for the current

Author: jmolenda Date: Tue Mar 10 18:34:52 2015 New Revision: 231885 URL: http://llvm.org/viewvc/llvm-project?rev=231885view=rev Log: If the user specifies a kernel binary that isn't correct for the current kernel debug session, instead of issuing a warning (which on one ever sees), drop the

Re: [Lldb-commits] [PATCH] Refactor GdbRemote test cases to support remote platforms

Comment at: test/tools/lldb-server/gdbremote_testcase.py:363 @@ +362,3 @@ +remote_file_spec = lldb.SBFileSpec(remote_path, False) +err = lldb.remote_platform.Install(lldb.SBFileSpec(inferior_exe_path, True), remote_file_spec) +if

Re: [Lldb-commits] [PATCH] Don't require AVX registers if the target CPU doesn't have them

Comment at: test/tools/lldb-server/TestLldbGdbServer.py:472-474 @@ +471,5 @@ + +f = open(cpuinfo_path, 'r') +cpuinfo = f.read() +f.close() +return avx in cpuinfo Please remove the local copy of cpuinfo for remote platforms

[Lldb-commits] [PATCH] Pass a process full executable path within name response field.

Hi clayborg, vharron, Pass a full executable path within name response field for q*ProcessInfo commands so lldb host can get a full executable path for a process. Client side already expects this field to be a full path - process_info.GetExecutableFile().SetFile (value.c_str(), false); -

Re: [Lldb-commits] [PATCH] Add filepath to qModuleInfo packet

http://stackoverflow.com/questions/5103443/how-to-check-what-shared-library-is-loaded-at-run-time Potentially, we may add optional pid request field to qModuleInfo and then try either to call remotely dlopen(NULL, RTLD_NOW) in a zygote process (it might be tricky since this requires dl library