the cUnescapedChar to unsigned char also fixes the crash.
Regards,
Abid
-Original Message-
From: Pavel Labath [mailto:lab...@google.com]
Sent: 28 April 2015 16:06
To: Abid, Hafiz
Cc: Ilia K; lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [lldb] r235991 - Replace sprintf
. But that
is a separate fix.
Regards,
Abid
From: Ilia K [mailto:ki.s...@gmail.com]
Sent: 28 April 2015 15:26
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [lldb] r235991 - Replace sprintf with snprintf to
avoid a crash.
Hello Abid,
I thought it never can happen because
Thanks for your report. I have fixed it in 229681.
-Original Message-
From: lldb-commits-boun...@cs.uiuc.edu [mailto:lldb-commits-
boun...@cs.uiuc.edu] On Behalf Of Ilia K
Sent: 18 February 2015 14:35
To: abidh@gmail.com
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits]
for MSVC so I am leaving it in for now.
If someone sees a problem with it then I can rework it.
Thanks,
Abid
-Original Message-
From: lldb-commits-boun...@cs.uiuc.edu [mailto:lldb-commits-
boun...@cs.uiuc.edu] On Behalf Of Abid, Hafiz
Sent: 03 February 2015 11:20
To: lldb-commits
There was no further comment on your 2nd patch so I have committed it. It
seemed small and safe enough.
Thanks,
Abid
From: lldb-commits-boun...@cs.uiuc.edu
[mailto:lldb-commits-boun...@cs.uiuc.edu] On Behalf Of Abid, Hafiz
Sent: 12 January 2015 17:33
To: Ilia K
Cc: lldb-commits@cs.uiuc.edu
It seems that your 2nd patch is needed. I will look at it tomorrow.
Thanks,
Abid
From: Ilia K [mailto:ki.s...@gmail.com]
Sent: 12 January 2015 13:27
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [PATCH] test: ignore IOError in
Base.deletePexpectChild and clean
.
Thanks,
Abid
From: Ilia K [ki.s...@gmail.com]
Sent: Monday, December 22, 2014 11:54 AM
To: Abid, Hafiz; lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [PATCH] test: ignore IOError in
Base.deletePexpectChild and clean TestMySyntax test
Hello,
My previous
to the other part of testing code which as you noted also use
sendline('quit').
Regards,
Abid
From: Ilia K [ki.s...@gmail.com]
Sent: Tuesday, December 30, 2014 4:11 PM
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [PATCH] test: ignore IOError
: Ilia K [ki.s...@gmail.com]
Sent: Tuesday, December 30, 2014 4:29 PM
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: RE: [Lldb-commits] [PATCH] test: ignore IOError in
Base.deletePexpectChild and clean TestMySyntax test
As I understood both of them are legal (in theory) but in practice I
I committed the cleanup in 224990. Please have a look and let me know if you
see a problem.
Regards,
Abid
From: Ilia K [ki.s...@gmail.com]
Sent: Tuesday, December 30, 2014 4:50 PM
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [PATCH
Sorry for the delay. I will review your patches this week.
Thanks,
Abid
Sent from my iPhone
On 22 Dec 2014, at 11:54, Ilia K ki.s...@gmail.commailto:ki.s...@gmail.com
wrote:
Hello,
My previous messages left without answer. I'm posting them again (see below)
with patch files.
The initial
suggestions. If there are not more comments, then I
will commit it for you.
Thanks,
Abid
From: Ilia K [mailto:ki.s...@gmail.com]
Sent: 13 December 2014 23:29
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [lldb] r223222 - Fix a hang on OSX while executing
-exec-run.
Hello Abid
[mailto:ki.s...@gmail.com]
Sent: 10 December 2014 09:29
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [lldb] r223222 - Fix a hang on OSX while executing
-exec-run.
Hello Abid,
Thanks again for the fix :)
As far as I know this needed only on OSX and it isn't required on other
Looks good to me. Please commit or let me know if you don’t have commit access.
Thanks for fixing this.
Regards,
Abid
From: Ilia K [mailto:ki.s...@gmail.com]
Sent: 05 December 2014 16:29
To: lldb-commits@cs.uiuc.edu; Abid, Hafiz
Subject: [Lldb-commits] [PATCH] lldb-mi: fix -stack-list-locals
You mean that just the change in ‘InputAvailable’ was needed? Rest of the
changes were required with ‘select’.
Regards,
Abid
From: Ilia K [mailto:ki.s...@gmail.com]
Sent: 03 December 2014 10:59
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [lldb] r223222 - Fix a hang
Thanks for catching this. I have removed the extra changes in r223227.
Thanks,
Abid
From: Ilia K [mailto:ki.s...@gmail.com]
Sent: 03 December 2014 12:40
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: RE: [Lldb-commits] [lldb] r223222 - Fix a hang on OSX while executing
-exec-run.
Yes
I will test your patch further on Linux and Windows. If it does not break
anything
and we don't hear any other objection then I will commit it.
Thanks,
Abid
-Original Message-
From: d...@burble.org [mailto:d...@burble.org]
Sent: 02 December 2014 09:58
To: Abid, Hafiz
Cc: co
that this whole file should be compiled conditionally as it is not
used on windows instead of putting many #ifdefs.
Thanks,
Abid
-Original Message-
From: d...@burble.org [mailto:d...@burble.org]
Sent: 02 December 2014 09:58
To: Abid, Hafiz
Cc: co...@codeplay.com; dee...@codeplay.com; lldb
I see only one fileno call inside lldb-mi and that is specific to Windows code.
Probably some fileno call inside lldb proper is causing this issue. In which
case, there is nothing much lldb-mi can do but to try to avoid this scenario.
As I told earlier, ‘select’ based solution increases time to
-exit then an extra check
for it where we check for quit will work too.
Regards,
Abid
-Original Message-
From: d...@burble.org [mailto:d...@burble.org]
Sent: 26 November 2014 00:13
To: Abid, Hafiz; co...@codeplay.com; dee...@codeplay.com; lldb-
comm...@cs.uiuc.edu
Subject: Re: [Lldb
Sorry I missed svn add on that. It has been committed now.
Thanks,
Abid
-Original Message-
From: d...@burble.org [mailto:d...@burble.org]
Sent: 26 November 2014 22:08
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [PATCH] new lldb-mi token test and cleanup
Thanks all for your comments. I have added a comment describing that order is
important and committed the patch.
Regards,
Abid
-Original Message-
From: d...@burble.org [mailto:d...@burble.org]
Sent: 26 November 2014 05:38
To: Zachary Turner
Cc: Jason Molenda; Abid, Hafiz; Kate
[mailto:d...@burble.org]
Sent: 26 November 2014 05:15
To: Zachary Turner
Cc: Abid, Hafiz; co...@codeplay.com; dee...@codeplay.com; lldb-
comm...@cs.uiuc.edu
Subject: Re: [Lldb-commits] [PATCH] fix lldb-mi hang on OSX
The existing code used _MSC_VER. I would rather a change like
confirmation before I commit this
patch.
-child.expect_exact(prompt)
+child.expect_exact(prompt) #FIXME: no prompt after error
Regards,
Abid
-Original Message-
From: d...@burble.org [mailto:d...@burble.org]
Sent: 25 November 2014 22:23
To: Abid, Hafiz
Turner
Cc: lldb-commits@cs.uiuc.edu; d...@burble.org; Abid, Hafiz
Subject: Re: [Lldb-commits] [PATCH] add tests for lldb-mi
Yes, please enable tests if they _should_ work on other platforms.
On Nov 24, 2014 11:27 PM, Zachary Turner
ztur...@google.commailto:ztur...@google.com wrote:
On Mon Nov 24
Hi Kate,
I observed that this change is causing crash on Linux whenever a confirmation
is shown to the user (e.g. breakpoint delete or quit). I think the following
code is responsible. It is casting this pointer in initializer list to a base
class which is still not initialized.
Hi Dawn,
I had a quick look at the tests and I think those will be useful addition. I
have
the following questions though.
1. I am wondering why have you restricted tests to darwin only? I have tried
them
on Linux and they seem to work. Although 'interrupt' test gave a timeout error.
I will
Hi Dawn,
Some quick comments on the patch.
+// Make sure we have a valid MI command
This comment looks a bit misleading to me.
+CMIUtilString vMITextLine(vTextLine);
+if (vTextLine.at(0) != '-')
It seem that you are deciding the if a command is not an MI by checking for '-'
in the
Hi Zachary,
Some 'goto' jumps over local variable with initialization in
ConnectionGenericFileWindows.cpp.
I think this makes the code ill-formed as per C++ standard 6.7.3. I have
attached a simple
fix for it. Please let me know if you see a problem with it. Otherwise I will
apply it later
Please send the patch on this mailing list with some description of what and
how you are fixing a problem.
Someone will commit it for you if it looks ok. After you have done some patches
then you can request commit access.
Regards,
Abid
-Original Message-
From:
Deepak,
int items = bytesGot / reg_info-byte_size;
Is this line assuming that all registers will be of same size?
Regards,
Abid
-Original Message-
From: lldb-commits-boun...@cs.uiuc.edu [mailto:lldb-commits-
boun...@cs.uiuc.edu] On Behalf Of Deepak Panickal
Sent: 25 July 2014 16:56
Hi Matthew,
You also need to add lldbPluginPlatformKalimba to source/CMakefileList.txt.
Otherwise cmake build will fail. After doing that your patch build OK for me on
Linux
with cmake. I have not tried autotools build though.
I will commit your patch later if there are no other comments.
Sorry I meant source/CMakeLists.txt.
-Original Message-
From: lldb-commits-boun...@cs.uiuc.edu [mailto:lldb-commits-
boun...@cs.uiuc.edu] On Behalf Of Abid, Hafiz
Sent: 16 July 2014 13:34
To: Matthew Gardiner; lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [PATCH] Submission
.
Having said that, I am OK to go with your change if you still think that would
be the better check.
Thanks,
Abid
From: Saleem Abdulrasool [mailto:compn...@compnerd.org]
Sent: 15 March 2014 02:54
To: Abid, Hafiz
Cc: lldb-commits@cs.uiuc.edu
Subject: Re: [Lldb-commits] [lldb] r203781 - Hide some
34 matches
Mail list logo
