Re: [Lldb-commits] [PATCH] Add maximum_operations_per_instruction to DWARFDebugLine.

2014-09-29 Thread Jason Molenda
Looks good; one small suggestion, otherwise please commit. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:427 @@ -426,1 +426,3 @@ prologue-min_inst_length = debug_line_data.GetU8(offset_ptr); +if (prologue-version = 4) +

Re: [Lldb-commits] [PATCH] Add maximum_operations_per_instruction to DWARFDebugLine.

2014-09-29 Thread Tong Shen
Address Jason's comment http://reviews.llvm.org/D5533 Files: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp source/Plugins/SymbolFile/DWARF/DWARFDebugLine.h Index: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp === ---

Re: [Lldb-commits] [PATCH] Add maximum_operations_per_instruction to DWARFDebugLine.

2014-09-29 Thread Todd Fiala
Thanks, Jason! Just running a few tests over here. If it comes up clean, I'll get it in. http://reviews.llvm.org/D5533 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add maximum_operations_per_instruction to DWARFDebugLine.

2014-09-29 Thread Todd Fiala
``` $ svn commit Sendingsource/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp Sendingsource/Plugins/SymbolFile/DWARF/DWARFDebugLine.h Transmitting file data .. Committed revision 218641. ``` http://reviews.llvm.org/D5533 ___ lldb-commits

Re: [Lldb-commits] [PATCH] Add maximum_operations_per_instruction to DWARFDebugLine.

2014-09-29 Thread Todd Fiala
Passed tests on Ubuntu Linux and MacOSX. http://reviews.llvm.org/D5533 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits