Re: [Lldb-commits] [PATCH] Add synchronization to TestWatchLocation.

2015-02-26 Thread Oleksiy Vyalov
Please see my comments. Comment at: test/functionalities/watchpoint/hello_watchlocation/main.cpp:20 @@ -19,3 +19,3 @@ pthread_t g_thread_3 = NULL; - +pthread_barrier_t barrier; char *g_char_ptr = NULL; Please follow the existing naming convention here -

Re: [Lldb-commits] [PATCH] Add synchronization to TestWatchLocation.

2015-02-26 Thread Chaoren Lin
REPOSITORY rL LLVM http://reviews.llvm.org/D7916 Files: lldb/trunk/test/functionalities/watchpoint/hello_watchlocation/main.cpp Index: lldb/trunk/test/functionalities/watchpoint/hello_watchlocation/main.cpp === ---