chaoren updated this revision to Diff 29811.
chaoren added a comment.
- Address review comments.
http://reviews.llvm.org/D10887
Files:
cmake/platforms/Android.cmake
source/Host/common/Socket.cpp
Index: source/Host/common/Socket.cpp
ovyalov accepted this revision.
ovyalov added a reviewer: ovyalov.
ovyalov added a comment.
LGTM
http://reviews.llvm.org/D10887
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
chaoren added a subscriber: chaoren.
chaoren added a comment.
I am statically linking against API-21. There are some bugs in the old
toolchains that can be avoided by doing this. Aside from this issue, the
resulting binary seem to run fine on API 10 devices (and passes most of the
test suite).
chaoren added a comment.
- b.android.com/178448
- pthread_sigmask doesn't work at all in the older toolchains
The only possible problems I can see right now are missing syscalls, and we
can easily get a diff of those between API 21 and API 9.
labath requested changes to this revision.
labath
chaoren added a comment.
For reference, the gdbserver binary currently in the toolchain is
statically linked.
Using a shim results in about a 5M increase in the lldb-server binary
because of the need to export all symbols dynamically. And still has those
two bugs (which would be in the system
For reference, the gdbserver binary currently in the toolchain is
statically linked.
Using a shim results in about a 5M increase in the lldb-server binary
because of the need to export all symbols dynamically. And still has those
two bugs (which would be in the system libs, if linked
labath added a comment.
In http://reviews.llvm.org/D10887#198526, @chaoren wrote:
Using a shim results in about a 5M increase in the lldb-server binary
because of the need to export all symbols dynamically. And still has those
two bugs (which would be in the system libs, if linked
chaoren added a comment.
We can't patch bugs on the system libc of shipped devices, while with
static linking, we can avoid all but the latest bugs in the toolchain
(which I think the toolchain guys would be more receptive to fixing).
labath added a comment.
In
chaoren added a comment.
That's what the shim does. You need to export the main symbol to call it
with dlopen.
http://reviews.llvm.org/D10887
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
