Re: [Lldb-commits] [PATCH] D11102: Set the compiler's language options using the language of the current frame's CU, and fix ObjC evaluation.

2015-07-28 Thread Dawn Perchik
dawn planned changes to this revision. dawn added a comment. I'll update this patch to what I believe Greg wants in http://reviews.llvm.org/D11482, and merge in http://reviews.llvm.org/D11173 which is also needed in that case. Comment at:

Re: [Lldb-commits] [PATCH] D11102: Set the compiler's language options using the language of the current frame's CU, and fix ObjC evaluation.

2015-07-20 Thread Dawn Perchik
dawn added a comment. Added more reviewers in the hopes that someone will review this patch. Please? Repository: rL LLVM http://reviews.llvm.org/D11102 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] D11102: Set the compiler's language options using the language of the current frame's CU, and fix ObjC evaluation.

2015-07-20 Thread Dawn Perchik
dawn added a comment. See comments added in patch. Comment at: source/Commands/CommandObjectExpression.cpp:311 @@ +310,3 @@ +} +} + Ignore this part of the patch - the language will instead be controlled by an option as discussed in

Re: [Lldb-commits] [PATCH] D11102: Set the compiler's language options using the language of the current frame's CU, and fix ObjC evaluation.

2015-07-15 Thread Dawn Perchik
dawn added a comment. Please review? Thanks. Repository: rL LLVM http://reviews.llvm.org/D11102 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D11102: Set the compiler's language options using the language of the current frame's CU, and fix ObjC evaluation.

2015-07-10 Thread Dawn Perchik
dawn created this revision. dawn added reviewers: clayborg, spyffe, zturner. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. The main purpose of this patch is to be able to get the frame's context (instead of just the target's) when evaluating, so

Re: [Lldb-commits] [PATCH] D11102: Set the compiler's language options using the language of the current frame's CU, and fix ObjC evaluation.

2015-07-10 Thread Greg Clayton
clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will defer to Sean Callanan. Repository: rL LLVM http://reviews.llvm.org/D11102 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu