REPOSITORY
rL LLVM
http://reviews.llvm.org/D8561
Files:
lldb/trunk/include/lldb/Expression/ClangASTSource.h
lldb/trunk/source/Expression/ClangASTSource.cpp
lldb/trunk/source/Symbol/ClangASTImporter.cpp
lldb/trunk/test/types/TestRecursiveTypes.py
lldb/trunk/test/types/recursive_type_1.
Will submit this to trunk. Spoke with Sean about porting to release_36 as well
after letting it sit for a couple of weeks on trunk, he's fine with it. Will do
that too.
http://reviews.llvm.org/D8561
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
Looks good! Thanks for the patch.
http://reviews.llvm.org/D8561
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commi
I am ok as long as Sean Callanan is ok with this.
http://reviews.llvm.org/D8561
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/list
Use a scoped class to do removals.
http://reviews.llvm.org/D8561
Files:
include/lldb/Expression/ClangASTSource.h
source/Expression/ClangASTSource.cpp
source/Symbol/ClangASTImporter.cpp
test/types/TestRecursiveTypes.py
test/types/recursive_type_1.cpp
test/types/recursive_type_2.cpp
This looks good, just make the RAII change so that everybody editing the code
doesn't have to remember this.
Comment at: source/Expression/ClangASTSource.cpp:483
@@ -465,1 +482,3 @@
+{
+m_active_lexical_decls.erase(context_decl);
return ELR_Failure;
Add unit tests and address review comments.
http://reviews.llvm.org/D8561
Files:
include/lldb/Expression/ClangASTSource.h
source/Expression/ClangASTSource.cpp
source/Symbol/ClangASTImporter.cpp
test/types/TestRecursiveTypes.py
test/types/recursive_type_1.cpp
test/types/recursive_type
Comment at: source/Symbol/ClangASTImporter.cpp:289-296
@@ -288,2 +288,10 @@
{
-return CompleteTagDecl(tag_type->getDecl());
+auto tag_decl = tag_type->getDecl();
+if (tag_decl->getDefinition() || tag_decl->isBeingDefined())
+{
+retur
Stéphane,
please add me as a reviewer for this patch. I have an account, spyffe.
Sean
> On Mar 23, 2015, at 12:48 PM, Stephane Sezer wrote:
>
> I'd like to add some unit tests for this patch but I don't know how to create
> one that has two separate source files (which is required to repro t
Stéphane,
please add me as a reviewer for this patch. I have an account, spyffe.
Sean
http://reviews.llvm.org/D8561
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.ed
See inline comments.
You can easily make a test case with two files, there are many that do it.
Comment at: source/Symbol/ClangASTImporter.cpp:289-296
@@ -288,2 +288,10 @@
{
-return CompleteTagDecl(tag_type->getDecl());
+auto tag_decl = tag_type->getDecl();
I'd like to add some unit tests for this patch but I don't know how to create
one that has two separate source files (which is required to repro this bug).
Does the unit test framework support that?
http://reviews.llvm.org/D8561
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailp
Hi clayborg,
If a struct type S has a member T that has a member that is a function that
returns a typedef of S* the respective field would be duplicated, which caused
an assert down the line in RecordLayoutBuilder. This patch adds a check that
removes the possibility of trying to resolve the same
13 matches
Mail list logo
