Why are we putting logic for a specific language runtime in generic code?
This doesn't seem right to me.
On Mon, Mar 23, 2015 at 11:38 AM Greg Clayton clayb...@gmail.com wrote:
lgtm
http://reviews.llvm.org/D8558
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
I agree with Zachary. That wasn't what the FIXME was about, and moving more
runtime specific code into target is not what is desired. This should go into
the Runtime, and get called by the dynamic loader. I don't think this change
is a change in the right direction.
Jim
On Mar 23, 2015,
Hi clayborg,
Saw this while reading some code in DynamicLoader classes. Looks like this has
been a FIXME since 2011 at least.
http://reviews.llvm.org/D8558
Files:
source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
source/Target/Target.cpp
Index:
lgtm
http://reviews.llvm.org/D8558
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8558
Files:
lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
lldb/trunk/source/Target/Target.cpp
Index: lldb/trunk/source/Target/Target.cpp
===
---
