Done:
Sendinginclude/lldb/Utility/SharedCluster.h
Transmitting file data .
Committed revision 209010.
Thanks for doing this and to Todd for remembering to poke me about this!
Jim
On May 16, 2014, at 12:48 PM, Scott Knight wrote:
> I do not have commit access so if someone who does cou
I do not have commit access so if someone who does could commit that would
be great.
Thanks,
Scott Knight
On May 16, 2014 3:26 PM, wrote:
> I got the same result. This patch is much more likely to cause crashes
> than failures if it was wrong, and I didn't see that either. And the patch
> look
I got the same result. This patch is much more likely to cause crashes than
failures if it was wrong, and I didn't see that either. And the patch looks
reasonable. I say check it in.
Jim
On May 16, 2014, at 12:23 PM, Scott Knight wrote:
> I did go ahead and run dotest.py this morning both
I did go ahead and run dotest.py this morning both before and after applying
the patch and it seems to have the same 10 failures before and after like you
mentioned. Another set of eyes checking the test results would be great though.
http://reviews.llvm.org/D3616
This did not ever get reviewed. I wasn't sure about the process after
submitting the patch to phabricator. I have not run tests yet because I wasn't
clear on that process either. The lldb website mentions using make to run tests
but that's under the building on linux/freebsd section. Since I'm o
Based on conversations with Greg and Jim on lldb-dev, when lldb looks a a root
object with many sub objects the ClusterManager can get slower and slower. This
change switches the internal object list from a vector to the SmallPtrSet data
type which speeds things up.
http://reviews.llvm.org/D361
