[Lldb-commits] [lldb] r231535 - Make sure to re-read the file data you can get from OptionValueFileSpec::GetFileContents(...) when the file has changed.

Author: gclayton Date: Fri Mar 6 17:46:54 2015 New Revision: 231535 URL: http://llvm.org/viewvc/llvm-project?rev=231535view=rev Log: Make sure to re-read the file data you can get from OptionValueFileSpec::GetFileContents(...) when the file has changed. This means you can set an expression

[Lldb-commits] [lldb] r231550 - Move Python Init from InitializeForLLGS to Initialize

Author: vharron Date: Fri Mar 6 21:37:15 2015 New Revision: 231550 URL: http://llvm.org/viewvc/llvm-project?rev=231550view=rev Log: Move Python Init from InitializeForLLGS to Initialize Linux configure+make builds have ~175 tests failing that aren't failing in cmake builds. The tests have

Re: [Lldb-commits] [PATCH] Delete ScriptInterpreterObject

So does this need to be applied after patches 1 and 2 from before? http://reviews.llvm.org/D8128 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Fix ValueObject::GetValueDidChange; Improve test for it

I have noticed 2 new failures: == FAIL: test_with_dsym_and_run_command (TestTypeCompletion.TypeCompletionTestCase) Check that types only get completed when necessary.

Re: [Lldb-commits] [PATCH] Report stopped by trace if none of the watchpoint was hit

Thanks for noticing this bug and for all of the suggestions. I created a new fix what address the actual root cause of the problem with reporting the right stop reason from lldb-server. For ARMv8 the watchpoint handling is not implemented yet, but it should be possible to implement the

[Lldb-commits] [PATCH] Fix ValueObject::GetValueDidChange; Improve test for it

Hi clayborg, zturner, granata.enrico, ValueObject::GetValueDidChange is a getter for ValueObject.m_value_did_change, which is set in ValueObject::UpdateValueIfNeeded. When this method is called, it checks previous checksum using the ValueObject::IsChecksumEmpty method. If checksum is empty then

[Lldb-commits] [PATCH] Report the actual user register count from NativeRegisterContextLinux_x86_64

Hi chaoren, Report the actual user register count from NativeRegisterContextLinux_x86_64 This change have effect when the AVX registers aren't available with reporting the count of user registers without them. http://reviews.llvm.org/D8111 Files:

[Lldb-commits] [lldb] r231490 - Fix Radar10642615DataFormatterTestCase after r231449

Author: ki.stfu Date: Fri Mar 6 10:53:37 2015 New Revision: 231490 URL: http://llvm.org/viewvc/llvm-project?rev=231490view=rev Log: Fix Radar10642615DataFormatterTestCase after r231449 Summary: I'm not sure that this failure should be fixed by modifying this test. It seems strange for me that

Re: [Lldb-commits] [PATCH] Fix Radar10642615DataFormatterTestCase after r231449

REPOSITORY rL LLVM http://reviews.llvm.org/D8102 Files: lldb/trunk/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py Index: lldb/trunk/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py

Re: [Lldb-commits] [PATCH] Fix -var-create and -var-update (MI)

REPOSITORY rL LLVM http://reviews.llvm.org/D8110 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] Fix -var-update; Add MiVarTestCase.test_lldbmi_var_update test (MI)

Hi abidh, clayborg, emaste, * Clean up and fix -var-update command * Add MiVarTestCase.test_lldbmi_var_update test All tests pass on OS X. http://reviews.llvm.org/D8110 Files: test/tools/lldb-mi/variable/TestMiVar.py test/tools/lldb-mi/variable/main.cpp tools/lldb-mi/MICmdCmdVar.cpp

[Lldb-commits] [lldb] r231489 - Fix MiSignalTestCase.test_lldbmi_stopped_when_stopatentry_remote test after r231479

Author: ki.stfu Date: Fri Mar 6 10:43:38 2015 New Revision: 231489 URL: http://llvm.org/viewvc/llvm-project?rev=231489view=rev Log: Fix MiSignalTestCase.test_lldbmi_stopped_when_stopatentry_remote test after r231479 Modified: lldb/trunk/test/tools/lldb-mi/signal/TestMiSignal.py Modified:

[Lldb-commits] [PATCH] Fix Radar10642615DataFormatterTestCase after r231449

Hi granata.enrico, zturner, I'm not sure that this failure should be fixed by modifying this test. It seems strange for me that the only one type vUInt8 is printed with '0x' prefix. This patch fixes the following error: ``` ==

Re: [Lldb-commits] [PATCH] Fix -var-create and -var-update (MI)

Looks good REPOSITORY rL LLVM http://reviews.llvm.org/D8110 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [PATCH] Reduce the number of components initialized for LLGS further.

Hi tberghammer, clayborg, In http://reviews.llvm.org/D7880 the initialization for LLGS was separated out so that LLGS could initialize only the components it needs to. This further reduces the set of components initialized for LLGS. REPOSITORY rL LLVM http://reviews.llvm.org/D8112 Files:

Re: [Lldb-commits] [PATCH] Reduce the number of components initialized for LLGS further.

REPOSITORY rL LLVM http://reviews.llvm.org/D8112 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix ValueObject::GetValueDidChange; Improve test for it

I believe this will cause serious performance issues. GetValueDidChange() is not trying to figure out if any children have changed, but if the current SBValue or ValueObject has changed. A structure with 100 items doesn't have a value itself, and there is no way we should be checking all

Re: [Lldb-commits] [PATCH] Report stopped by trace if none of the watchpoint was hit

The approach looks right. I'll let somebody who works on the NativeThread side weigh in on whether the implementation is correct. http://reviews.llvm.org/D8081 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___

Re: [Lldb-commits] [Diffusion] rL231449: Provide synthetic children for some vector types

This revision should fix it: Sendingsource/DataFormatters/FormatManager.cpp Sendingsource/DataFormatters/VectorType.cpp Sendingsource/Symbol/ClangASTType.cpp Sending test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py Sending

Re: [Lldb-commits] [PATCH] Fix ValueObject::GetValueDidChange; Improve test for it

I believe the test is flawed. GetValueDidChange() will only work if you have gotten the value and then later ask if it changed. See my inline comments above. We can document that we GetValueDidChange() is only valid if GetValue() was previously called on a SBValue. So fix the test and remove

Re: [Lldb-commits] [PATCH] Fix ValueObject::GetValueDidChange; Improve test for it

Ok. Thanks for answer. I think we really should add this comment to avoid such questions in the future. I'll fix this test and remove the rest of the changes. http://reviews.llvm.org/D8103 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: [Lldb-commits] [PATCH] Fix -var-create and -var-update (MI)

REPOSITORY rL LLVM http://reviews.llvm.org/D8110 Files: lldb/trunk/test/tools/lldb-mi/variable/TestMiVar.py lldb/trunk/test/tools/lldb-mi/variable/main.cpp lldb/trunk/tools/lldb-mi/MICmdCmdVar.cpp lldb/trunk/tools/lldb-mi/MICmdCmdVar.h

Re: [Lldb-commits] [PATCH] Fix -var-create and -var-update (MI)

Force a value to update after -var-create http://reviews.llvm.org/D8110 Files: test/tools/lldb-mi/variable/TestMiVar.py test/tools/lldb-mi/variable/main.cpp tools/lldb-mi/MICmdCmdVar.cpp tools/lldb-mi/MICmdCmdVar.h tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.cpp