Re: [Lldb-commits] [lldb] r216398 - Change back all paths returns for lldb::PathType enumerations from HostInfo::GetLLDBPath() to return the directories in the FileSpec.m_directory field to match prev

I would just change it to GetLastPathComponent() and and leave GetDirectory() alone or change it to GetContainingDirectory(). Greg's suggestion maps very cleanly onto DWARF debug information, since with that we a compilation unit directory, e.g. /home/mg11/src/projects/browser and then the

[Lldb-commits] [lldb] r216553 - Add Linux support for get thread area on ARM64 using ProcessMonitor debugging.

Author: tfiala Date: Wed Aug 27 11:05:26 2014 New Revision: 216553 URL: http://llvm.org/viewvc/llvm-project?rev=216553view=rev Log: Add Linux support for get thread area on ARM64 using ProcessMonitor debugging. See http://reviews.llvm.org/D5073. Change by Paul Osmialowski. Modified:

Re: [Lldb-commits] [PATCH] lldb get thread area on ARM64

LGTM. Tested: Ubuntu 14.04 x86_64, clang-3.5-built lldb. http://reviews.llvm.org/D5073 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb AArch64 should be listed as yet another 64-bit architecture in HostInfoBase

Testing now. Already reviewed by Greg Clayton. http://reviews.llvm.org/D5070 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb Missing break statement added

As Greg already called out, LGTM. Just giving it a test run on MacOSX, then will check in. http://reviews.llvm.org/D5069 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r216556 - lldb AArch64 should be listed as yet another 64-bit architecture in HostInfoBase.

Author: tfiala Date: Wed Aug 27 11:21:41 2014 New Revision: 216556 URL: http://llvm.org/viewvc/llvm-project?rev=216556view=rev Log: lldb AArch64 should be listed as yet another 64-bit architecture in HostInfoBase. See http://reviews.llvm.org/D5070. Change by Paul Osmialowski. Modified:

Re: [Lldb-commits] [PATCH] lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added

Testing now, change looks good. http://reviews.llvm.org/D5078 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added

Tested: Ubuntu 14.04 x86_64, clang-3.5-built lldb. http://reviews.llvm.org/D5078 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r216559 - lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added.

Author: tfiala Date: Wed Aug 27 11:32:02 2014 New Revision: 216559 URL: http://llvm.org/viewvc/llvm-project?rev=216559view=rev Log: lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added. See http://reviews.llvm.org/D5078. Change by Paul Osmialowski. Modified:

Re: [Lldb-commits] [PATCH] lldb Missing ARM64 breakpoint opcode for ProcessPOSIX added

svn commit Sendingsource/Plugins/Process/POSIX/ProcessPOSIX.cpp Transmitting file data . Committed revision 216559. http://reviews.llvm.org/D5078 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r216564 - NativeThreadLinux: remove translation of some Linux signals to gdb signals.

Author: tfiala Date: Wed Aug 27 12:11:56 2014 New Revision: 216564 URL: http://llvm.org/viewvc/llvm-project?rev=216564view=rev Log: NativeThreadLinux: remove translation of some Linux signals to gdb signals. I copied this originally based on what debugserver was doing. This appears to be

[Lldb-commits] [lldb] r216606 - Update LLDB to use LLVM's DynamicLibrary.

Author: zturner Date: Wed Aug 27 15:15:09 2014 New Revision: 216606 URL: http://llvm.org/viewvc/llvm-project?rev=216606view=rev Log: Update LLDB to use LLVM's DynamicLibrary. LLDB had implemented its own DynamicLibrary class for plugin support. LLVM has an equivalent mechanism, so this patch

[Lldb-commits] [lldb] r216612 - Fix linker error due to missing static variable instantiation.

Author: zturner Date: Wed Aug 27 15:44:26 2014 New Revision: 216612 URL: http://llvm.org/viewvc/llvm-project?rev=216612view=rev Log: Fix linker error due to missing static variable instantiation. Modified: lldb/trunk/source/Host/posix/HostProcessPosix.cpp Modified:

[Lldb-commits] [PATCH] lldb more on register context arm64

More on registering context on arm64. Depends on D4580 which although accepted, does not seem to be commited yet (I guess due to Host vs HostInfo problem). http://reviews.llvm.org/D5089 Files: source/Plugins/Process/POSIX/CMakeLists.txt source/Plugins/Process/POSIX/POSIXThread.cpp

Re: [Lldb-commits] [PATCH] lldb more on register context arm64

Hey Paul, For D4580, I looked at the notes on it. I mistook this comment: D4488 http://reviews.llvm.org/D4488 was completely covered by later patch already on LLVM's master. to indicate that D4580 was already in, so I was just trying to clear out this ticket. What is the complete set of

Re: [Lldb-commits] [PATCH] lldb - towards AArch64 being recognised as platform architecture

Hey Paul, Trying to catch up on the patches that didn't make it in yet. This looks like one of them. Can you shoot me an email with all the changes that are not in yet? Can you also add me as reviewers on them (user tfiala) and rebase them against lldb top of tree? Thanks! -Todd

[Lldb-commits] [lldb] r216630 - Add some logging around Process attaching and inferior exec handling.

Author: tfiala Date: Wed Aug 27 17:58:26 2014 New Revision: 216630 URL: http://llvm.org/viewvc/llvm-project?rev=216630view=rev Log: Add some logging around Process attaching and inferior exec handling. Modified: lldb/trunk/include/lldb/Target/Process.h

[Lldb-commits] [lldb] r216637 - Make it clear in the help that breakpoint command add will act on the last set

Author: jingham Date: Wed Aug 27 19:50:17 2014 New Revision: 216637 URL: http://llvm.org/viewvc/llvm-project?rev=216637view=rev Log: Make it clear in the help that breakpoint command add will act on the last set breakpoint if no breakpoint id is specified. rdar://problem/17885160 Modified: