[Lldb-commits] [lldb] r217667 - Fix OSX CMake build

2014-09-12 Thread Deepak Panickal
Author: panickal Date: Fri Sep 12 07:15:11 2014 New Revision: 217667 URL: http://llvm.org/viewvc/llvm-project?rev=217667view=rev Log: Fix OSX CMake build Modified: lldb/trunk/source/CMakeLists.txt Modified: lldb/trunk/source/CMakeLists.txt URL:

[Lldb-commits] [lldb] r217668 - Fix lldb-mi driver for running on OSX.

2014-09-12 Thread Deepak Panickal
Author: panickal Date: Fri Sep 12 07:17:21 2014 New Revision: 217668 URL: http://llvm.org/viewvc/llvm-project?rev=217668view=rev Log: Fix lldb-mi driver for running on OSX. Modified: lldb/trunk/tools/lldb-mi/MIUtilSystemOsx.cpp Modified: lldb/trunk/tools/lldb-mi/MIUtilSystemOsx.cpp URL:

Re: [Lldb-commits] [PATCH] lldb fix ARM64 register access

2014-09-12 Thread Todd Fiala
Thanks, Paul. Having a look at this now. http://reviews.llvm.org/D5232 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] lldb fix ARM64 register access

2014-09-12 Thread Todd Fiala
svn commit Sendingsource/Plugins/Process/Linux/ProcessMonitor.cpp Transmitting file data . Committed revision 217691. http://reviews.llvm.org/D5232 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Check for byte order correctness in GDBRemoteCommunicationClient::GetCurrentProcessInfo.

2014-09-12 Thread Todd Fiala
I'm going to go ahead and get this in since I didn't hear any feedback. (Working through your backlog of patches, Stephane...) On Fri, Sep 5, 2014 at 8:11 AM, Todd Fiala tfi...@google.com wrote: This looks reasonable; however, I’d like to hear the Apple guys since I’m not sure if there’s any

[Lldb-commits] [lldb] r217701 - Add logic to LLDB to figure out the types of member functions of C++ classes. Add plumbing for that all the way up to the SB layer

2014-09-12 Thread Enrico Granata
Author: enrico Date: Fri Sep 12 13:45:43 2014 New Revision: 217701 URL: http://llvm.org/viewvc/llvm-project?rev=217701view=rev Log: Add logic to LLDB to figure out the types of member functions of C++ classes. Add plumbing for that all the way up to the SB layer Added:

[Lldb-commits] [PATCH] Fix JITLoaderGDB for 64-bit host and 32-bit target

2014-09-12 Thread Tong Shen
Hi tfiala, jasonmolenda, There are target pointer members in struct jit_code_entry and jit_descriptor. Data layout of those structures should be decided by target, not host. This fixes JITLoaderGDB for 64-bit host and 32-bit target http://reviews.llvm.org/D5339 Files:

Re: [Lldb-commits] [PATCH] Check for byte order correctness in GDBRemoteCommunicationClient::GetCurrentProcessInfo.

2014-09-12 Thread Todd Fiala
I had a look at a few of the asserts in that function which end up being the only portion of the body of some if checks. I tried rolling the ifs into the assert, but made the assert relatively more complicated to read. I ended up punting on that in the name of maintainability. I'm hitting a

Re: [Lldb-commits] [PATCH] use std::atomic to protect variables being accessed by multiple threads

2014-09-12 Thread jingham
That looks okay. Thanks for looking at this. Seems to me that if you're only synchronization is locking access to some flag, then you're either doing something fairly weak (like the log example) or missing some real synchronization... So it's worth viewing the necessity of the change with

Re: [Lldb-commits] [PATCH] Check for byte order correctness in GDBRemoteCommunicationClient::GetCurrentProcessInfo.

2014-09-12 Thread Todd Fiala
My pleasure! On Fri, Sep 12, 2014 at 1:38 PM, Stephane Sezer s...@fb.com wrote: Thanks a lot, Todd :) On Sep 12, 2014, at 10:09 AM, Todd Fiala tfi...@google.com wrote: I'm going to go ahead and get this in since I didn't hear any feedback. (Working through your backlog of patches,

Re: [Lldb-commits] [PATCH] Fix JITLoaderGDB for 64-bit host and 32-bit target

2014-09-12 Thread Todd Fiala
Adding Keno... http://reviews.llvm.org/D5339 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r217714 - Make ProcessLaunchInfo copyable.

2014-09-12 Thread Zachary Turner
Author: zturner Date: Fri Sep 12 17:38:39 2014 New Revision: 217714 URL: http://llvm.org/viewvc/llvm-project?rev=217714view=rev Log: Make ProcessLaunchInfo copyable. Modified: lldb/trunk/include/lldb/Target/ProcessLaunchInfo.h lldb/trunk/source/Target/ProcessLaunchInfo.cpp Modified:

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-09-12 Thread Kuba Brecka
Updated patch. Consider introducing a struct for address description instead of passing quadruple (name, name_size, region_address, region_size) around. It would be much easier to modify it later. You can also add region_kind (global, stack etc.) string there. Introduced AddressDescription.

Re: [Lldb-commits] [lldb] r217714 - Make ProcessLaunchInfo copyable.

2014-09-12 Thread jingham
Hey Zachary, at some point I'll finish up the lldb coding conventions document, but till I get around to the full thing, one of the bullet items it will have is not to use this form of listing the initializations: +: ProcessInfo() +, m_working_dir() +, m_plugin_name() +,

[Lldb-commits] [lldb] r217717 - llgs: fix thread names broken by recent native thread changes.

2014-09-12 Thread Todd Fiala
Author: tfiala Date: Fri Sep 12 17:51:49 2014 New Revision: 217717 URL: http://llvm.org/viewvc/llvm-project?rev=217717view=rev Log: llgs: fix thread names broken by recent native thread changes. * Fixes the local stack variable return pointer usage in NativeThreadLinux::GetName(). * Changes

[Lldb-commits] [lldb] r217718 - std::function is a better choice than a raw function pointer here. You probably still want to be careful about cleaning up stuff you captured, but it's not like a funct

2014-09-12 Thread Enrico Granata
Author: enrico Date: Fri Sep 12 17:56:52 2014 New Revision: 217718 URL: http://llvm.org/viewvc/llvm-project?rev=217718view=rev Log: std::function is a better choice than a raw function pointer here. You probably still want to be careful about cleaning up stuff you captured, but it's not like a

[Lldb-commits] [lldb] r217719 - ResolveUsername should resolve ~ to the user's home directory as well as ~/. This

2014-09-12 Thread Jim Ingham
Author: jingham Date: Fri Sep 12 17:59:05 2014 New Revision: 217719 URL: http://llvm.org/viewvc/llvm-project?rev=217719view=rev Log: ResolveUsername should resolve ~ to the user's home directory as well as ~/. This gets command-line file completion from ~ working again. Modified:

[Lldb-commits] [lldb] r217721 - Fix incorrect initializer list style.

2014-09-12 Thread Zachary Turner
Author: zturner Date: Fri Sep 12 18:10:33 2014 New Revision: 217721 URL: http://llvm.org/viewvc/llvm-project?rev=217721view=rev Log: Fix incorrect initializer list style. Modified: lldb/trunk/source/Target/ProcessLaunchInfo.cpp Modified: lldb/trunk/source/Target/ProcessLaunchInfo.cpp URL:

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-09-12 Thread Alexey Samsonov
Getting closer. Comment at: lib/asan/asan_debugging.cc:35 @@ +34,3 @@ + descr-name[0] = 0; + internal_strncat(descr-name, vars[i].name_pos, + Min(descr-name_size, vars[i].name_len)); Why not internal_strncpy(descr-name,

Re: [Lldb-commits] [PATCH] Fix JITLoaderGDB for 64-bit host and 32-bit target

2014-09-12 Thread Keno Fischer
LGTM. http://reviews.llvm.org/D5339 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r217722 - Don't make paths with /Foo//bar, that confuses everybody down the line.

2014-09-12 Thread Jim Ingham
Author: jingham Date: Fri Sep 12 18:39:38 2014 New Revision: 217722 URL: http://llvm.org/viewvc/llvm-project?rev=217722view=rev Log: Don't make paths with /Foo//bar, that confuses everybody down the line. This gets the file completer for absolute paths working again. Modified:

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-09-12 Thread Alexey Samsonov
! In D4527#31, @kubabrecka wrote: Getting closer. Thanks for the patience :) Why not internal_strncpy(descr-name, vars[i].name_pos, Min(descr-name_size - 1, vars[i].name_len)) ? Because that would not write \0 after the string (we're copying just a part of the string pointed to by