[Lldb-commits] [lldb] r232618 - Clean up CommandObjectBreakpointNameList: remove duplicated 'protected' access modifier

Author: ki.stfu Date: Wed Mar 18 04:14:49 2015 New Revision: 232618 URL: http://llvm.org/viewvc/llvm-project?rev=232618view=rev Log: Clean up CommandObjectBreakpointNameList: remove duplicated 'protected' access modifier Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp

Re: [Lldb-commits] [Diffusion] rL232396: Remove redundant comments from lldb-mi source files.

USERS abidh (Author) ki.stfu (Auditor) http://reviews.llvm.org/rL232396 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [Diffusion] rL232396: Remove redundant comments from lldb-mi source files.

In Most of the file, it just said that Implementation of ABC classs, there I have removed it. In other places, it described many commands implemented in that file, I left it there. May be that can be removed too as new commands have been added and that list may not be quite accurate. Regards,

Re: [Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.

Comment at: test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py:51 @@ +50,3 @@ + +self.expect(thread step-over) +self.expect(thread list, STOPPED_DUE_TO_WATCHPOINT, This test relies on step-over being implemented using

[Lldb-commits] [lldb] r232625 - Parse .note.android.ident header from elf files

Author: tberghammer Date: Wed Mar 18 05:36:27 2015 New Revision: 232625 URL: http://llvm.org/viewvc/llvm-project?rev=232625view=rev Log: Parse .note.android.ident header from elf files In android a .note.android.ident section header is added to the elf files to provide information for the

Re: [Lldb-commits] [PATCH] Fix memory allocating inside signal handler (MI)

Please, take a look again. http://reviews.llvm.org/D8256 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix memory allocating inside signal handler (MI)

Remove unused IDS_PROCESS_SIGNAL_RECEIVED from CMICmnResources http://reviews.llvm.org/D8256 Files: tools/lldb-mi/MICmnResources.cpp tools/lldb-mi/MICmnResources.h tools/lldb-mi/MIDriverMain.cpp Index: tools/lldb-mi/MICmnResources.cpp

[Lldb-commits] [lldb] r232619 - Initial Assembly profiler for mips64

Author: bhushan.attarde Date: Wed Mar 18 04:21:29 2015 New Revision: 232619 URL: http://llvm.org/viewvc/llvm-project?rev=232619view=rev Log: Initial Assembly profiler for mips64 Summary: This is initial implementation of assembly profiler which only scans prologue/epilogue assembly instructions

Re: [Lldb-commits] [Diffusion] rL232396: Remove redundant comments from lldb-mi source files.

In Most of the file, it just said that Implementation of ABC classs, there I have removed it. In other places, it described many commands implemented in that file, I left it there. May be that can be removed too as new commands have been added and that list may not be quite accurate. Ok.

Re: [Lldb-commits] [PATCH] Make lldb-mi handle only MI commands

In http://reviews.llvm.org/D8381#142042, @ki.stfu wrote: All tests pass on OS X. As I understood you will remove Driver.cpp later, right? Yes. I will remove it later. Thanks for review. http://reviews.llvm.org/D8381 EMAIL PREFERENCES

[Lldb-commits] [lldb] r232621 - Make lldb-mi handle only MI commands

Author: abidh Date: Wed Mar 18 05:07:46 2015 New Revision: 232621 URL: http://llvm.org/viewvc/llvm-project?rev=232621view=rev Log: Make lldb-mi handle only MI commands Summary: Previously lldb-mi can also act as a driver like normal lldb. It needed a lot of redundant code in the lldb-mi for

[Lldb-commits] [PATCH] Fix -break-insert for system functions (MI)

Hi abidh, clayborg, # Fix -break-insert for system functions # Fix MiExecTestCase to use -break-insert instead of CLI b # Improve MiBreakTestCase: now it uses printf() instead of in-house function All tests pass on OS X. http://reviews.llvm.org/D8412 Files:

[Lldb-commits] [lldb] r232633 - Fix comment in tools/lldb-mi/MIDriver.cpp

Author: ki.stfu Date: Wed Mar 18 08:08:52 2015 New Revision: 232633 URL: http://llvm.org/viewvc/llvm-project?rev=232633view=rev Log: Fix comment in tools/lldb-mi/MIDriver.cpp Modified: lldb/trunk/tools/lldb-mi/MIDriver.cpp Modified: lldb/trunk/tools/lldb-mi/MIDriver.cpp URL:

Re: [Lldb-commits] [PATCH] Convert open options for POSIX open on target platform.

REPOSITORY rL LLVM http://reviews.llvm.org/D8395 Files: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp Index:

[Lldb-commits] [lldb] r232634 - Convert open options for POSIX open on target platform.

Author: flackr Date: Wed Mar 18 08:55:48 2015 New Revision: 232634 URL: http://llvm.org/viewvc/llvm-project?rev=232634view=rev Log: Convert open options for POSIX open on target platform. This moves the conversion of the open options to the target platform. On mac fcntl.h has different values

Re: [Lldb-commits] [PATCH] Initial Assembly profiler for mips64

FYI, this seems to have broken the xcode build for me: Undefined symbols for architecture x86_64: EmulateInstructionMIPS64::Initialize(), referenced from: lldb_private::Initialize() in liblldb-core.a(lldb.o) EmulateInstructionMIPS64::Terminate(), referenced from:

Re: [Lldb-commits] [PATCH] Remove hack about the size of long doubles from DataExtractor

Fine as long as clang no longer asserts and float values display correctly on x86_64 systems. http://reviews.llvm.org/D8417 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list

[Lldb-commits] [lldb] r232640 - Skip intermittently failing test on FreeBSD

Author: emaste Date: Wed Mar 18 10:23:53 2015 New Revision: 232640 URL: http://llvm.org/viewvc/llvm-project?rev=232640view=rev Log: Skip intermittently failing test on FreeBSD It is already skipped on the other platforms anyhow. llvm.org/pr19246 Modified:

Re: [Lldb-commits] [PATCH] Fix -break-insert for system functions (MI)

lgtm http://reviews.llvm.org/D8412 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.

Comment at: test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py:37-38 @@ +36,4 @@ +self.runCmd(target create + exe, CURRENT_EXECUTABLE_SET) +self.runCmd(breakpoint set --name main, BREAKPOINT_CREATED) + +self.runCmd(process

[Lldb-commits] [PATCH] Fix xcodeproj build after http://reviews.llvm.org/rL232619

Hi clayborg, Adds EmulateInstructionMIPS64 to the xcodeproj build so that it's found when linking. REPOSITORY rL LLVM http://reviews.llvm.org/D8420 Files: lldb.xcodeproj/project.pbxproj Index: lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r232653 - Move lldb-log.cpp to core/Logging.cpp

Author: zturner Date: Wed Mar 18 13:20:42 2015 New Revision: 232653 URL: http://llvm.org/viewvc/llvm-project?rev=232653view=rev Log: Move lldb-log.cpp to core/Logging.cpp So that we don't have to update every single #include in the entire codebase to #include this new header (which used to get

[Lldb-commits] [lldb] r232649 - Always add some fake threads with x86_64 registers no matter what the architecture since this is just for testing that we can add new threads with completely different

Author: gclayton Date: Wed Mar 18 12:03:13 2015 New Revision: 232649 URL: http://llvm.org/viewvc/llvm-project?rev=232649view=rev Log: Always add some fake threads with x86_64 registers no matter what the architecture since this is just for testing that we can add new threads with completely

Re: [Lldb-commits] [PATCH] Fix xcodeproj build after http://reviews.llvm.org/rL232619

Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D8420 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r232655 - Fix the Xcode build after the MIPS64 changes

Author: enrico Date: Wed Mar 18 13:42:41 2015 New Revision: 232655 URL: http://llvm.org/viewvc/llvm-project?rev=232655view=rev Log: Fix the Xcode build after the MIPS64 changes Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [PATCH] Fix memory allocating inside signal handler (MI)

Revert CMICmnResources; Remove logging from signal handlers http://reviews.llvm.org/D8256 Files: tools/lldb-mi/MIDriverMain.cpp Index: tools/lldb-mi/MIDriverMain.cpp === --- tools/lldb-mi/MIDriverMain.cpp +++

Re: [Lldb-commits] [PATCH] Fix xcodeproj build after http://reviews.llvm.org/rL232619

Thanks for the FYI, you beat me to landing the fix :-). In hindsight I see that simple patches which fix build breakages can be landed before review. REPOSITORY rL LLVM http://reviews.llvm.org/D8420 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: [Lldb-commits] [PATCH] Move LLDB initialization / shutdown to Application

Or APIPrivate or PrivateAPI? http://reviews.llvm.org/D8428 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] expose 64 bit addresses through MI

I am now using the PRIx64 macro in all locations. I checked and made sure that every type being used is either an MIUint64 or and lldb::addr_t, both of with are uint64s. I also noticed that IDS_CMD_ERR_LLDB_ERR_READ_MEM_BYTES was being initialized twice, and switched the second initialization

[Lldb-commits] [lldb] r232689 - Comment discouraging writing command based test cases.

Author: jingham Date: Wed Mar 18 18:16:58 2015 New Revision: 232689 URL: http://llvm.org/viewvc/llvm-project?rev=232689view=rev Log: Comment discouraging writing command based test cases. Modified: lldb/trunk/test/README-TestSuite Modified: lldb/trunk/test/README-TestSuite URL:

Re: [Lldb-commits] [PATCH] Move LLDB initialization / shutdown to Application

I actually had it called Initialization originally. I like Initialization slightly better than InternalAPI because it makes it clear that that the stuff is specific to initialization. InternalAPI makes me think I can go put a bunch of random stuff in it which might make more sense somewhere

Re: [Lldb-commits] [PATCH] Move LLDB initialization / shutdown to Application

Initialization would be fine. http://reviews.llvm.org/D8428 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r232687 - Enable TestCallStdStringFunction for GCC.

Author: sivachandra Date: Wed Mar 18 18:02:28 2015 New Revision: 232687 URL: http://llvm.org/viewvc/llvm-project?rev=232687view=rev Log: Enable TestCallStdStringFunction for GCC. Test Plan: dotest.py -C gcc -p TestCallStdStringFunction Reviewers: vharron Subscribers: lldb-commits Differential

Re: [Lldb-commits] [PATCH] Enable TestCallStdStringFunction for GCC.

REPOSITORY rL LLVM http://reviews.llvm.org/D8426 Files: lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py Index: lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py === ---

[Lldb-commits] [lldb] r232702 - Add NameMatches.h header to fix FreeBSD build after r232673

Author: emaste Date: Wed Mar 18 21:47:36 2015 New Revision: 232702 URL: http://llvm.org/viewvc/llvm-project?rev=232702view=rev Log: Add NameMatches.h header to fix FreeBSD build after r232673 Modified: lldb/trunk/source/Host/freebsd/Host.cpp Modified: lldb/trunk/source/Host/freebsd/Host.cpp

Re: [Lldb-commits] [PATCH] Fix handling of CommandInterpreter's events in lldb-mi

Friendly ping http://reviews.llvm.org/D8382 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Initial Assembly profiler for mips64

In http://reviews.llvm.org/D7696#142754, @flackr wrote: FYI, this seems to have broken the xcode build for me: Undefined symbols for architecture x86_64: EmulateInstructionMIPS64::Initialize(), referenced from: lldb_private::Initialize() in liblldb-core.a(lldb.o)

Re: [Lldb-commits] [lldb] r232653 - Move lldb-log.cpp to core/Logging.cpp

On 18 March 2015 at 14:20, Zachary Turner ztur...@google.com wrote: Author: zturner Date: Wed Mar 18 13:20:42 2015 New Revision: 232653 URL: http://llvm.org/viewvc/llvm-project?rev=232653view=rev Log: Move lldb-log.cpp to core/Logging.cpp Looks like we need a Makefile update too:

[Lldb-commits] [lldb] r232669 - Try to fix the Makefile build.

Author: zturner Date: Wed Mar 18 15:58:39 2015 New Revision: 232669 URL: http://llvm.org/viewvc/llvm-project?rev=232669view=rev Log: Try to fix the Makefile build. I deleted lldb-log.cpp, but the Makefile build lists this file explicitly, so it is removed in this patch. Modified:

[Lldb-commits] [lldb] r232673 - Move some functions from source/lldb.cpp to Utility.

Author: zturner Date: Wed Mar 18 16:31:45 2015 New Revision: 232673 URL: http://llvm.org/viewvc/llvm-project?rev=232673view=rev Log: Move some functions from source/lldb.cpp to Utility. Specifically, there were some functions for converting enums to strings and a function for matching a string