Re: [Lldb-commits] [PATCH] Change lldb_assert() to use llvm::sys::PrintBacktrace

2015-03-04 Thread Chandler Carruth
On Wed, Mar 4, 2015 at 6:06 PM Ed Maste ema...@freebsd.org wrote: On 4 March 2015 at 20:48, Enrico Granata egran...@apple.com wrote: In this case we could get away with the lesser interface (FILE*), that’s true. However, if - say - we ended up deciding that the output of lldbassert()

[Lldb-commits] [lldb] r230126 - Update for Clang API change in r230123 -- lookup_result was always

2015-02-20 Thread Chandler Carruth
Author: chandlerc Date: Fri Feb 20 22:31:13 2015 New Revision: 230126 URL: http://llvm.org/viewvc/llvm-project?rev=230126view=rev Log: Update for Clang API change in r230123 -- lookup_result was always const, there was never a need for lookup_const_result. Now that vestigal type is gone, so

[Lldb-commits] [lldb] r229084 - Fix four missing 'override' specifiers found with the Clang

2015-02-13 Thread Chandler Carruth
Author: chandlerc Date: Fri Feb 13 02:07:00 2015 New Revision: 229084 URL: http://llvm.org/viewvc/llvm-project?rev=229084view=rev Log: Fix four missing 'override' specifiers found with the Clang '-Winconsistent-missing-override' warning. I suggest folks use this to ensure that override is

[Lldb-commits] [lldb] r229096 - Disable a warning for the python modules as the python C API headers

2015-02-13 Thread Chandler Carruth
Author: chandlerc Date: Fri Feb 13 04:22:00 2015 New Revision: 229096 URL: http://llvm.org/viewvc/llvm-project?rev=229096view=rev Log: Disable a warning for the python modules as the python C API headers trigger this warning. With this, 'ninja' succeeds without warnings for me on Linux.

[Lldb-commits] [lldb] r229085 - Fix the last two warnings I see on Linx building 'lldb': mismatched

2015-02-13 Thread Chandler Carruth
Author: chandlerc Date: Fri Feb 13 02:16:15 2015 New Revision: 229085 URL: http://llvm.org/viewvc/llvm-project?rev=229085view=rev Log: Fix the last two warnings I see on Linx building 'lldb': mismatched signed and unsigned types in comparisons. For the text offset, use the addr_t type that is

[Lldb-commits] [lldb] r229083 - Remove an unused variable found with a Clang warning.

2015-02-13 Thread Chandler Carruth
Author: chandlerc Date: Fri Feb 13 02:04:18 2015 New Revision: 229083 URL: http://llvm.org/viewvc/llvm-project?rev=229083view=rev Log: Remove an unused variable found with a Clang warning. Modified: lldb/trunk/source/Host/linux/HostInfoLinux.cpp Modified:

[Lldb-commits] [lldb] r226427 - Update to reflect the API change to createMCSymbolizer in LLVM r226416.

2015-01-18 Thread Chandler Carruth
Author: chandlerc Date: Sun Jan 18 21:07:25 2015 New Revision: 226427 URL: http://llvm.org/viewvc/llvm-project?rev=226427view=rev Log: Update to reflect the API change to createMCSymbolizer in LLVM r226416. This should fix the LLDB build since that change. Modified:

[Lldb-commits] [lldb] r224929 - [cmake] Teach the standalone CMake build to find the Python interpreter

2014-12-29 Thread Chandler Carruth
Author: chandlerc Date: Mon Dec 29 06:32:27 2014 New Revision: 224929 URL: http://llvm.org/viewvc/llvm-project?rev=224929view=rev Log: [cmake] Teach the standalone CMake build to find the Python interpreter the same way the LLVM CMake build does, notably using the proper CMake module and

[Lldb-commits] [lldb] r224930 - [cmake/multilib] Teach LLDB to respect the multlib LLVM_LIBDIR_SUFFIX

2014-12-29 Thread Chandler Carruth
Author: chandlerc Date: Mon Dec 29 06:42:33 2014 New Revision: 224930 URL: http://llvm.org/viewvc/llvm-project?rev=224930view=rev Log: [cmake/multilib] Teach LLDB to respect the multlib LLVM_LIBDIR_SUFFIX variable (now provided both by the normal parent LLVM CMake files and by the

[Lldb-commits] [lldb] r218831 - [cmake] Include the new file in the CMake lists. Without this every

2014-10-01 Thread Chandler Carruth
Author: chandlerc Date: Wed Oct 1 16:33:28 2014 New Revision: 218831 URL: http://llvm.org/viewvc/llvm-project?rev=218831view=rev Log: [cmake] Include the new file in the CMake lists. Without this every CMake build of any part of LLVM with LLDB checked out fails immediately. =[ We appear to not

Re: [Lldb-commits] [lldb] r218831 - [cmake] Include the new file in the CMake lists. Without this every

2014-10-01 Thread Chandler Carruth
It would be awesome to get that bot pointed at the LLVM build master where other developers are expected to look... Or to wire up a new LLDB bot specifically for that purpose. On Wed Oct 01 2014 at 2:57:05 PM Ed Maste ema...@freebsd.org wrote: On 1 October 2014 17:33, Chandler Carruth chandl

Re: [Lldb-commits] [lldb] r215223 - Add new MI commands, features and fixes to the lldb-mi driver.

2014-08-11 Thread Chandler Carruth
On Sat, Aug 9, 2014 at 4:33 AM, Deepak Panickal dee...@codeplay.com wrote: Yeah, I understand. The lldb-mi driver is a sub project which only we have been committing to and working on primarily. It’s separate from the core files of LLDB. Which is why I committed a bigger patch. I agree

Re: [Lldb-commits] [PATCH] Make CMake choose the test exe target architecture according to the build.

2014-07-31 Thread Chandler Carruth
Minor comment tweak. Otherwise this looks good now. Thanks. I guess Greg wants you to wait for Todd's LGTM? :: shruug :: I know nothing about LLDB, just cmake. =] Comment at: test/CMakeLists.txt:18-19 @@ -17,14 +17,4 @@ -# Users can override LLDB_TEST_ARGS to modify the way

Re: [Lldb-commits] [PATCH] Make CMake choose the test exe target architecture according to the build.

2014-07-30 Thread Chandler Carruth
Comment at: CMakeLists.txt:22-26 @@ -21,1 +21,7 @@ +# Determine the native architecture. +string(TOLOWER ${LLVM_TARGET_ARCH} LLDB_TARGET_ARCH) +if( LLDB_TARGET_ARCH STREQUAL host ) + string(REGEX MATCH ^[^-]* LLDB_TARGET_ARCH ${LLVM_HOST_TRIPLE}) +endif () +

Re: [Lldb-commits] [PATCH] Add a .clang-format file to enhance formatting experience with clang-format

2014-07-22 Thread Chandler Carruth
(peanut gallery comment from LLVm and Clang communities and a happy clang-format user) One thing to keep in mind is that clang-format is just a tool. You can use it, but you can also not use it when it doesn't serve your purpose. I still will at times manually format code correctly precisely

Re: [Lldb-commits] [PATCH] Add a .clang-format file to enhance formatting experience with clang-format

2014-07-22 Thread Chandler Carruth
On Tue, Jul 22, 2014 at 2:52 PM, jing...@apple.com wrote: But touching a file doesn't mean you should also fix up its formatting with such a tool. As long as THAT is part of our coding conventions, I guess I can't object. From my experience in Clang and LLVM the only way folks go in and do

[Lldb-commits] [lldb] r211899 - [cmake] When Python is disabled for LLDB, don't try to install the

2014-06-27 Thread Chandler Carruth
Author: chandlerc Date: Fri Jun 27 10:04:42 2014 New Revision: 211899 URL: http://llvm.org/viewvc/llvm-project?rev=211899view=rev Log: [cmake] When Python is disabled for LLDB, don't try to install the python bindings. For example, this prevents errors on systems that disable python because the

Re: [Lldb-commits] [PATCH] Switch python install to use an install(DIRECTORY ...) cmake command rather than a cmake script

2014-06-16 Thread Chandler Carruth
Thanks, submitted in r211028. http://reviews.llvm.org/D4151 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Update LLDB for LLVM iterator change in r203364

2014-03-10 Thread Chandler Carruth
Comment at: source/Expression/IRForTarget.cpp:362 @@ -365,3 +361,3 @@ -for (auto u = fun-use_begin(), e = fun-use_end(); u != e; ++u) { +for (auto u = fun-user_begin(), e = fun-user_end(); u != e; ++u) { if (auto call =

Re: [Lldb-commits] [PATCH] Update LLDB for LLVM iterator change in r203364

2014-03-10 Thread Chandler Carruth
Sorry if it wasn't clear before, this LGTM. =] http://llvm-reviews.chandlerc.com/D3030 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits