jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda accepted this revision.
jasonmolenda added a reviewer: jasonmolenda.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Hm, won't we get some compiler warning about how there aren't default: cases
for these
Author: jmolenda
Date: Sat Aug 1 20:36:09 2015
New Revision: 243846
URL: http://llvm.org/viewvc/llvm-project?rev=243846view=rev
Log:
GDBRemoteCommunication::DecompressPacket assumed that the buffer it was
working with (the Communication m_bytes ivar) contained a single packet.
Instead, it may
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks good. I suspected this wouldn't link on older systems.
Repository:
rL LLVM
http://reviews.llvm.org/D11668
___
Author: jmolenda
Date: Thu Jul 30 23:21:25 2015
New Revision: 243732
URL: http://llvm.org/viewvc/llvm-project?rev=243732view=rev
Log:
Add another log to the Host channel for logging
the actions taken when trying to locate binaries.
Modified:
lldb/trunk/source/Commands/CommandObjectTarget.cpp
Author: jmolenda
Date: Fri Jul 31 00:47:00 2015
New Revision: 243736
URL: http://llvm.org/viewvc/llvm-project?rev=243736view=rev
Log:
Move the computation of whether a DWARF compile unit
is optimized into DWARFCompileUnit, where it should have
been. Next I'll need to call this from another
We were discussing the same thing last week - I think we all agree that
approach #1 is the way to go. My main concern here is that jstopinfo is
ascii-hex encoded. JSON is already pretty verbose (particularly with all the
numbers being base 10, sigh) but then we double the size of the string.
Author: jmolenda
Date: Tue Jul 28 20:42:16 2015
New Revision: 243511
URL: http://llvm.org/viewvc/llvm-project?rev=243511view=rev
Log:
When debugserver fails to attach to a process on a Darwin
system, make a couple of additional checks to see if the
attach was denied via the System Integrity
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
It's been a long time since I touched roff markup but this looks reasonable to
me.
http://reviews.llvm.org/D11561
___
lldb-commits
jasonmolenda closed this revision.
jasonmolenda added a comment.
Sendingsource/Host/common/Socket.cpp
Transmitting file data .
Committed revision 243175.
Repository:
rL LLVM
http://reviews.llvm.org/D11497
___
lldb-commits mailing list
Author: jmolenda
Date: Fri Jul 24 21:39:42 2015
New Revision: 243200
URL: http://llvm.org/viewvc/llvm-project?rev=243200view=rev
Log:
Add some initial logging for when lldb is searching for binaries,
dSYMs, or reading binaries out of memory to the 'Host' log channel.
There's more to be done here,
Author: jmolenda
Date: Wed Jul 22 18:42:54 2015
New Revision: 242968
URL: http://llvm.org/viewvc/llvm-project?rev=242968view=rev
Log:
Fix the variable used to reply to the qGDBServerVersion
packet so that debugserver will send a reply like
name:debugserver;version:340.99;
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Makes sense to me, please apply.
http://reviews.llvm.org/D11295
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
looks good to me.
http://reviews.llvm.org/D11258
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Author: jmolenda
Date: Wed Jul 15 22:42:40 2015
New Revision: 242380
URL: http://llvm.org/viewvc/llvm-project?rev=242380view=rev
Log:
Only include the stack memory for the caller stack
frame, don't go any further, in RNBRemote::SendStopReplyPacketForThread.
These are the memory pre-fetches in
Author: jmolenda
Date: Wed Jul 15 22:38:17 2015
New Revision: 242379
URL: http://llvm.org/viewvc/llvm-project?rev=242379view=rev
Log:
Build ValueObjectConstResultCast.cpp.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
jasonmolenda added inline comments.
Comment at: docs/lldb-gdb-remote.txt:1555-1575
@@ +1554,23 @@
+registers: {
+ 0:8000,
+ 1:,
+ 2:20fabf5fff7f,
+ 3:e8f8bf5fff7f,
+ 4:0100,
+
Author: jmolenda
Date: Tue Jul 14 14:19:07 2015
New Revision: 242184
URL: http://llvm.org/viewvc/llvm-project?rev=242184view=rev
Log:
Add comment explaning sanity check on packet size in the packet decompression
method.
Modified:
Author: jmolenda
Date: Tue Jul 14 19:16:09 2015
New Revision: 242256
URL: http://llvm.org/viewvc/llvm-project?rev=242256view=rev
Log:
Correct length of packet that GDBRemoteCommunicationClient::Detach
should send when detaching and leaving the remote process/system
halted. Previously only the
jasonmolenda added a subscriber: jasonmolenda.
Comment at: docs/lldb-gdb-remote.txt:1555-1575
@@ +1554,23 @@
+registers: {
+ 0:8000,
+ 1:,
+ 2:20fabf5fff7f,
+ 3:e8f8bf5fff7f,
+
Author: jmolenda
Date: Mon Jul 13 23:51:05 2015
New Revision: 242119
URL: http://llvm.org/viewvc/llvm-project?rev=242119view=rev
Log:
Fix off-by-one error in the packet decompression routine
that would not pass through empty (unsupported packet) replies
correctly.
Modified:
Author: jmolenda
Date: Fri Jul 10 18:15:22 2015
New Revision: 241964
URL: http://llvm.org/viewvc/llvm-project?rev=241964view=rev
Log:
Add a another packet to the gdb-remote protocol,
jGetLoadedDynamicLibrariesInfos. This packet is similar to
qXfer:libraries:read except that lldb supplies the
On Jul 6, 2015, at 5:31 PM, Siva Chandra sivachan...@google.com wrote:
On Mon, Jul 6, 2015 at 4:40 PM, Greg Clayton gclay...@apple.com wrote:
Modified: lldb/trunk/include/lldb/Utility/JSON.h
URL:
Author: jmolenda
Date: Mon Jul 6 22:38:42 2015
New Revision: 241540
URL: http://llvm.org/viewvc/llvm-project?rev=241540view=rev
Log:
For the ios target add a shell script phase at the end which
removes the LLDB.framework/Resources and LLDB.framework/Swift
directories. This isn't a deep bundle
Author: jmolenda
Date: Mon Jul 6 23:15:43 2015
New Revision: 241553
URL: http://llvm.org/viewvc/llvm-project?rev=241553view=rev
Log:
When debugserver is running on an iOS device, call
proc_set_wakemon_params() to raise the limit on the # of wakeups
per second that are acceptable before the
jasonmolenda accepted this revision.
This revision is now accepted and ready to land.
I'm fine with trying this approach. These heuristics for falling back to
alternate unwind methods are tricky to get right; often the best approach is to
live on them for a bit and pay close attention to the
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
This looks OK to me too.
http://reviews.llvm.org/D10866
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Great idea.
http://reviews.llvm.org/D10902
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Looks good to me.
http://reviews.llvm.org/D10806
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: jmolenda
Date: Thu Jun 25 17:37:57 2015
New Revision: 240713
URL: http://llvm.org/viewvc/llvm-project?rev=240713view=rev
Log:
Mark armv7em and armv7m as compatible architectures.
rdar://problem/21244671
Modified:
lldb/trunk/source/Core/ArchSpec.cpp
Modified:
Author: jmolenda
Date: Thu Jun 25 21:16:48 2015
New Revision: 240753
URL: http://llvm.org/viewvc/llvm-project?rev=240753view=rev
Log:
When the user specifies a corefile that is not readable,
give them a meaningful error message instead of
Unable to find process plug-in for core file
Greg's the best person to review this - as for the comment vrs. #if 0, I don't
have a preference; I think for larger blocks of code the #if 0 is less noisy
but it can also be easy to miss the fact that the code block is commented out
when you're readingit.
http://reviews.llvm.org/D10702
Author: jmolenda
Date: Wed Jun 24 22:03:47 2015
New Revision: 240621
URL: http://llvm.org/viewvc/llvm-project?rev=240621view=rev
Log:
xcode project file updates for the movement of the POSIX files into the FreeBSD
process subdir.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Tamas, I apologize for taking so long to get to this patch. I meant to do it
over the weekend but didn't have the time - I need to think hard about changes
in the unwinder before I feel comfortable with them and it took me a couple
hours of staring at the patch and thinking things over.
I
Greg's out of the office for tonight. Do you want to revert it or should I?
On Jun 22, 2015, at 7:10 PM, Chaoren Lin chaor...@google.com wrote:
Hi Greg,
This commit caused a severe breakage on the Linux buildbot. Would you mind if
I reverted it until you can find a fix?
On Mon, Jun
On Mac OS X there's these simulator processes used for debugging iOS apps on
the Mac. They are native i386/x86_64 code, they use the native Mac OS X ABI,
but they link against different libraries so it behaves like an iOS device.
These processes will have an architecture like i386-apple-ios.
Author: jmolenda
Date: Thu Jun 18 16:15:58 2015
New Revision: 240060
URL: http://llvm.org/viewvc/llvm-project?rev=240060view=rev
Log:
Correct the end-of-vector check in GetCompactUnwindInfoForFunction().
Problem noticed by Todd Fiala.
Modified:
lldb/trunk/source/Symbol/CompactUnwindInfo.cpp
Author: jmolenda
Date: Thu Jun 18 16:46:06 2015
New Revision: 240066
URL: http://llvm.org/viewvc/llvm-project?rev=240066view=rev
Log:
Add a new wart, I mean feature, on to gdb-remote protocol: compression.
For some communication channels, sending large packets can be very
slow. In those cases,
I don't have any objections to this test idea. Trying to encapsulate tricky
unwind scenarios in an arch-independent manner is very hard. IMO the only way
to do this is hand-written platform-specific assembly or platform-specific
corefiles that capture a problematic program state.
Excellent, then I'm all for it. :) I didn't think it would turn up anything
but it's great to hear that it is. Thanks for working on this.
http://reviews.llvm.org/D10454
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Author: jmolenda
Date: Thu Jun 4 01:03:03 2015
New Revision: 239013
URL: http://llvm.org/viewvc/llvm-project?rev=239013view=rev
Log:
Make the function that parses the json packets in debugserver
a little more resilient to freely formatted json. Greg's change
in r238279 made the json output from
Author: jmolenda
Date: Wed May 27 23:55:53 2015
New Revision: 238395
URL: http://llvm.org/viewvc/llvm-project?rev=238395view=rev
Log:
Add quick bit of doc about SBFrame::GetCFA().
Modified:
lldb/trunk/scripts/interface/SBFrame.i
Modified: lldb/trunk/scripts/interface/SBFrame.i
URL:
Hi Robert, this change introduced a bit of a regression in Mac native lldb.
It's not easy to spot on a Mac but in other environments it's a problem.
LocateDSYMInVincinityOfExecutable is a function in Host/common/Symbols.cpp. It
takes a ModuleSpec (the details about the executable binary --
://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/2406
Vince
On Thu, May 14, 2015 at 5:19 PM, Jason Molenda jmole...@apple.com wrote:
Author: jmolenda
Date: Thu May 14 19:19:28 2015
New Revision: 237411
URL: http://llvm.org/viewvc/llvm-project?rev=237411view=rev
Log
Author: jmolenda
Date: Thu May 14 19:19:28 2015
New Revision: 237411
URL: http://llvm.org/viewvc/llvm-project?rev=237411view=rev
Log:
The StopInfo base class has an m_description std::string.
Remove the m_description ivar from the StopInfoBreakpoint
and StopInfoWatchpoint subclasses of StopInfo.
Author: jmolenda
Date: Mon May 4 21:05:53 2015
New Revision: 236478
URL: http://llvm.org/viewvc/llvm-project?rev=236478view=rev
Log:
Fix an uninitialized memory use error when interpreting
compact unwind encodings for x86_64 / i386 omit-frame-pointer
code. It was possible for lldb to get the
Author: jmolenda
Date: Mon May 4 21:03:37 2015
New Revision: 236477
URL: http://llvm.org/viewvc/llvm-project?rev=236477view=rev
Log:
Add CommandObjectLanguage to the xcode project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
Author: jmolenda
Date: Fri May 1 18:39:48 2015
New Revision: 236363
URL: http://llvm.org/viewvc/llvm-project?rev=236363view=rev
Log:
Change process kill to call Process::Destroy (force_kill = true);
follow-up to the change in r235158. Right now if you attach to
a process and type kill, lldb
On Apr 29, 2015, at 7:23 PM, Zachary Turner ztur...@google.com wrote:
What do you think about Enrico's suggestion? If there's a way to make this
useful for everyone it's certainly better than me doing my own thing in
ProcessWindows, but when i look at my code decorated with log statements
Author: jmolenda
Date: Thu Apr 30 18:31:04 2015
New Revision: 236284
URL: http://llvm.org/viewvc/llvm-project?rev=236284view=rev
Log:
Use #include lldb/API/SBCommandReturnObject.h instead of
Modified:
lldb/trunk/tools/lldb-mi/MICmdCmdData.h
Modified:
Author: jmolenda
Date: Thu Apr 30 18:42:56 2015
New Revision: 236286
URL: http://llvm.org/viewvc/llvm-project?rev=236286view=rev
Log:
Guard against the case where the Write method is called with
an argument pointing into the middle of m_buffer and then
Write() calls GrowBuffer() to resize
Author: jmolenda
Date: Wed Apr 29 17:17:45 2015
New Revision: 236170
URL: http://llvm.org/viewvc/llvm-project?rev=236170view=rev
Log:
Don't force a vendor check in ProcessMachCore::CanDebug() -- if this
is a Mach-O file and it is a Mach-O core file, activate the
ProcessMachCore plugin.
Hi, a small followup to this patch. I noticed that our arm UnwindProfiles are
having problems recently and tracked it down to the change in
UnwindAssemblyInstEmulation. The patch adds code to
UnwindAssemblyInstEmulation which recognizes
EmulateInstruction::eContextRegisterLoad -- a register
Author: jmolenda
Date: Fri Apr 17 14:15:02 2015
New Revision: 235218
URL: http://llvm.org/viewvc/llvm-project?rev=235218view=rev
Log:
Whitespace-only tweaks to Colin's r235109 patch to match the lldb
coding style a little more closely.
Modified:
Author: jmolenda
Date: Fri Apr 17 00:01:58 2015
New Revision: 235158
URL: http://llvm.org/viewvc/llvm-project?rev=235158view=rev
Log:
Add a force_kill arg to Process::Destroy(). This is needed after
the changes in r233255/r233258. Normally if lldb attaches to
a running process, when we call
Author: jmolenda
Date: Tue Apr 14 16:34:51 2015
New Revision: 234945
URL: http://llvm.org/viewvc/llvm-project?rev=234945view=rev
Log:
Remove unneeded include.
Modified:
lldb/trunk/source/Core/Error.cpp
Modified: lldb/trunk/source/Core/Error.cpp
URL:
Author: jmolenda
Date: Wed Apr 1 23:35:32 2015
New Revision: 233886
URL: http://llvm.org/viewvc/llvm-project?rev=233886view=rev
Log:
Add a tiny bit of hardening to the eh_frame and compact unwind parsing.
When we're seeing offsets that exceed the size of our section, don't
try to use that
Looks good, thanks for adding this, please commit. In the comments in
lea_rsp_pattern_p() did you mean to write '8 bit' and '32 bit' displacement?
http://reviews.llvm.org/D8583
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Not worth changing the patch but fwiw you could have added eFlagRequiresFrame
to the CommandObjectParsed flags for this command to do the same thing. My
main reaction echoes Jim's - I don't know what it means to have a thread and no
frame 0. But given that two lldb devs have hit it, I guess
Good change as long as it accomplishes the same thing as your null check
against GetStackFrameAtIndex(0). eFlagRequiresFrame is slightly different,
checking that the ExecutionContext got a frame but I suppose the ECX got it
from the same place -- GetStackFrameAtIndex(0) so it should be fine.
On armv7 architecture systems, there are 4 hardware breakpoint registers
(DBGBVR) and 4 hardware watchpoint registers (DBGWVR). The breakpoint
registers track values in the pc register. You can also say stop when the PC
is not equal to this value which is how single instruction stepping is
Author: jmolenda
Date: Tue Mar 17 18:16:42 2015
New Revision: 232563
URL: http://llvm.org/viewvc/llvm-project?rev=232563view=rev
Log:
Build fix for building debugserver for ios.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp
Author: jmolenda
Date: Tue Mar 10 18:34:52 2015
New Revision: 231885
URL: http://llvm.org/viewvc/llvm-project?rev=231885view=rev
Log:
If the user specifies a kernel binary that isn't correct for the current
kernel debug session, instead of issuing a warning (which on one ever
sees), drop the
Author: jmolenda
Date: Wed Mar 4 20:42:06 2015
New Revision: 231342
URL: http://llvm.org/viewvc/llvm-project?rev=231342view=rev
Log:
Add support for the DWARFv3 (circa 2005) DW_OP_form_tls_address
operator in addition to the vendor-extension DW_OP_GNU_push_tls_address.
clang on PS4 and Darwin
Author: jmolenda
Date: Mon Feb 23 21:21:38 2015
New Revision: 230302
URL: http://llvm.org/viewvc/llvm-project?rev=230302view=rev
Log:
Move the copy phases for the xpcservices bundles from the LLDB
target to the desktop target. They aren't used for iOS builds.
Modified:
This patch looks good to me, please commit. I don't anticipate any change in
behavior on Mac systems.
http://reviews.llvm.org/D7792
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
When you're talking about compiler generated code, a hand written assembly
parser is easy. The complication comes when the compiler changes how it
expresses prologues -- or hand written assembly routines.
A simple example for x86_64, you can save a register to the stack with either
push
Author: jmolenda
Date: Sat Feb 21 00:13:51 2015
New Revision: 230130
URL: http://llvm.org/viewvc/llvm-project?rev=230130view=rev
Log:
If constructed llvm_build_dir doesn't exist, retry as an iphoneos path.
Modified:
lldb/trunk/scripts/package-clang-headers.py
Modified:
OK, I see what you're thinking of. I was looking at this from a dynamic point
of view with an actually running process. We need a live process for most of
the unwinder stuff to work correctly -- you don't have any information about
registers until you can get a RegisterContext from a Thread.
Updated patch to include the fixes Zachary suggested, added a simple test case
for this behavior to functionality/paths.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7477
Files:
source/Host/common/FileSpec.cpp
test/functionalities/paths/TestPaths.py
Index:
Author: jmolenda
Date: Fri Feb 13 17:24:21 2015
New Revision: 229186
URL: http://llvm.org/viewvc/llvm-project?rev=229186view=rev
Log:
Change the default disassembly format again. First attempt at
changing it was in r219544 - after living on that for a few
months, I wanted to take another crack
Preparing to commit.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7578
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Landed in r229186.
Sendinginclude/lldb/Core/Address.h
Sendinginclude/lldb/Core/Disassembler.h
Sendinginclude/lldb/Core/FormatEntity.h
Sendinginclude/lldb/Symbol/SymbolContext.h
Sendingsource/API/SBInstruction.cpp
Sending
Actually, on the bike ride home I realized that one of your concerns is
justified: There is no formatter for the comment field in the disassembly
output. A lot of different things can appear here -- this could be an address
to an instruction in the current function, in a different function,
I like your suggestion of showing the comment contents as the operand instead
of the raw address (or in addition to the raw address) -- but there are lots of
things that can end up in the comments (and llvm can add additional things like
hints about what an instruction does) so it might not
I didn't explain the disassembly-format in my proposal - it already works like
you're describing. The current lldb format is
${current-pc-arrow}${addr-file-or-load}{
${function.name-without-args}${function.concrete-only-addr-offset-no-padding}}:
A user can put this in their ~/.lldbinit file
Author: jmolenda
Date: Thu Feb 12 00:14:23 2015
New Revision: 228910
URL: http://llvm.org/viewvc/llvm-project?rev=228910view=rev
Log:
Search through all memory regions of the core file for
both a user process dyld and for a kernel binary -- we
will decide which to prefer after one or both have
In r219544 (2014-10-10) I changed the default disassembly format to more
closely resemble gdb's disassembly format. After living on this format for a
few months, there are obvious shortcomings with C++ and Objective-C programs
and I want to try a new approach.
Originally lldb's disassembly
Thanks for all the comments, no rush on this. I need to update the patch to
integrate your suggested changes and try to write a test case still.
http://reviews.llvm.org/D7477
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Author: jmolenda
Date: Sat Feb 7 00:03:49 2015
New Revision: 228486
URL: http://llvm.org/viewvc/llvm-project?rev=228486view=rev
Log:
When creating a disassembler for one of the arm variants that can
only execute thumb instructions, force the arch triple string to
be thumbv... instead of armv...
Those new warnings from UnwindAssembly-x86.cpp are my fault. I'll fix them
later today.
http://reviews.llvm.org/D6271
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
Author: jmolenda
Date: Thu Jan 29 00:20:05 2015
New Revision: 227419
URL: http://llvm.org/viewvc/llvm-project?rev=227419view=rev
Log:
When starting a kernel debug session (PlatformDarwinKernel), scan
for executable binaries on the local filesystem so the user doesn't
need to provide the path to
Author: jmolenda
Date: Mon Jan 26 04:07:39 2015
New Revision: 227083
URL: http://llvm.org/viewvc/llvm-project?rev=227083view=rev
Log:
Add link to github x86-psABI repo where the ABI doc is being
revised.
Modified:
lldb/trunk/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp
Modified:
Author: jmolenda
Date: Thu Jan 22 19:02:32 2015
New Revision: 226889
URL: http://llvm.org/viewvc/llvm-project?rev=226889view=rev
Log:
Two fixes for compact unwind decoding for frameless large-stack-size
i386/x86_64 functions. The stack size was being multiplied by the
pointer size incorrectly.
Author: jmolenda
Date: Wed Jan 21 18:39:36 2015
New Revision: 226752
URL: http://llvm.org/viewvc/llvm-project?rev=226752view=rev
Log:
Add Utility/UriParser.cpp to the lldb-core target so xcode builds
work again.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified:
Author: jmolenda
Date: Thu Jan 22 00:31:58 2015
New Revision: 226789
URL: http://llvm.org/viewvc/llvm-project?rev=226789view=rev
Log:
Update ExpressionSourceCode::GetText() to match the
name of the iOS simulator platform which was changed
in r181631.
rdar://problem/19200084
Modified:
Author: jmolenda
Date: Tue Jan 20 19:26:28 2015
New Revision: 226631
URL: http://llvm.org/viewvc/llvm-project?rev=226631view=rev
Log:
Adding compact unwind as a source of unwind information
introduced subtle bugs in two places in
RegisterContextLLDB::GetFullUnwindPlanForFrame where
it
0x7fff57d85ef8: 69 6d 70 6c 65 62 74 2e 70 79 1b implebt.py.
It looks like I'm getting a 0x1b instead of a \0 here.
On Jan 19, 2015, at 8:51 PM, Jason Molenda jmole...@apple.com wrote:
I'm open to the idea that I'm fixing the wrong problem. This came from
FielSpec::SetFile
Author: jmolenda
Date: Mon Jan 19 21:06:17 2015
New Revision: 226543
URL: http://llvm.org/viewvc/llvm-project?rev=226543view=rev
Log:
Don't mention a --core-file argument to target create. It is
--core.
rdar://problem/19518164
Modified:
lldb/trunk/source/Commands/CommandObjectTarget.cpp
Author: jmolenda
Date: Fri Jan 16 17:54:15 2015
New Revision: 226347
URL: http://llvm.org/viewvc/llvm-project?rev=226347view=rev
Log:
Add comments explaining the unwind setup in
ABIMacOSX_i386::CreateFunctionEntryUnwindPlan,
ABIMacOSX_i386::CreateDefaultUnwindPlan,
Author: jmolenda
Date: Thu Jan 15 18:27:25 2015
New Revision: 226231
URL: http://llvm.org/viewvc/llvm-project?rev=226231view=rev
Log:
Add comment regarding which i386 registers are non-volatile instead of
just pointing to the standard document regarding this.
Modified:
Author: jmolenda
Date: Thu Jan 15 20:31:35 2015
New Revision: 226244
URL: http://llvm.org/viewvc/llvm-project?rev=226244view=rev
Log:
Fixes to DNBArchImpl in debugserver to correctly get/set
the register state when debugging AArch32 programs (armv7
programs running on an armv8 processor). Most
Author: jmolenda
Date: Tue Jan 13 17:48:53 2015
New Revision: 225853
URL: http://llvm.org/viewvc/llvm-project?rev=225853view=rev
Log:
Save restore the array of which registers have already been
saved/restored across a mid-function epilogue. We ignore
repeated push/pops of a register so once we
I didn't look very closely at the line break logic in OutputFormattedHelpText
but everything else looks good to me.
Comment at: source/Interpreter/CommandInterpreter.cpp:1175
@@ +1174,3 @@
+if (help_prologue != NULL) {
+
Author: jmolenda
Date: Mon Jan 12 18:54:59 2015
New Revision: 225748
URL: http://llvm.org/viewvc/llvm-project?rev=225748view=rev
Log:
Don't run functionalities/tty under sudo / as root.
The terminal window will be opened under the ownership
of the real userid and it won't be able to open the
Author: jmolenda
Date: Tue Jan 13 00:04:04 2015
New Revision: 225770
URL: http://llvm.org/viewvc/llvm-project?rev=225770view=rev
Log:
Change the x86 assembly instruction unwind parser to
step through the complete function looking for any epilogue
instructions. If we find an epilogue sequence,
Author: jmolenda
Date: Tue Jan 13 00:07:07 2015
New Revision: 225771
URL: http://llvm.org/viewvc/llvm-project?rev=225771view=rev
Log:
Add an additional check to UnwindAssembly_x86::AugmentUnwindPlanFromCallSite
which will verify if the eh_frame instructions include details about
the prologue or
Author: jmolenda
Date: Tue Jan 13 01:39:03 2015
New Revision: 225773
URL: http://llvm.org/viewvc/llvm-project?rev=225773view=rev
Log:
Enhance the eh_frame unwind instruction augmenter so that
it will do the right thing on x86 routines with a mid-function
epilogue sequence (where the unwind rules
Author: jmolenda
Date: Sat Jan 10 04:39:27 2015
New Revision: 225585
URL: http://llvm.org/viewvc/llvm-project?rev=225585view=rev
Log:
Add RegisterNumber.cpp.
Modified:
lldb/trunk/source/Utility/CMakeLists.txt
Modified: lldb/trunk/source/Utility/CMakeLists.txt
URL:
Author: jmolenda
Date: Fri Jan 9 22:01:03 2015
New Revision: 225578
URL: http://llvm.org/viewvc/llvm-project?rev=225578view=rev
Log:
Hoist the RegisterNumber class out of RegisterContextLLDB and make
it more generally available.
Add checks to UnwindAssembly_x86::AugmentUnwindPlanFromCallSite()
Author: jmolenda
Date: Fri Jan 9 22:20:14 2015
New Revision: 225579
URL: http://llvm.org/viewvc/llvm-project?rev=225579view=rev
Log:
Forgot to include RegisterNumber.h in prev commit.
Added:
lldb/trunk/include/lldb/Utility/RegisterNumber.h
Added:
1 - 100 of 304 matches
Mail list logo
