Re: [Lldb-commits] [PATCH] D11672: [MIPS] Handle false positives for MIPS hardware watchpoints

2015-08-03 Thread Jim Ingham
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This looks fine. Please add a comment to the declaration of GetWatchpointHitAddress. The meaning is really only explained in StopInfo.cpp, and I don't think the name is clear

Re: [Lldb-commits] [PATCH] D11415: Add jstopinfo support to llgs

2015-07-30 Thread Jim Ingham
Jason Greg looked at this too, and I think they were playing with solutions along the lines of your #1. I think that's really the only safe way to do it. For instance, on OS X, when a thread is sitting in a syscall, and the program receives a signal, as part of interrupting the syscall the

[Lldb-commits] [lldb] r243507 - Lock the owners mutex in the BreakpointSite before updating the hit

2015-07-28 Thread Jim Ingham
Author: jingham Date: Tue Jul 28 19:40:36 2015 New Revision: 243507 URL: http://llvm.org/viewvc/llvm-project?rev=243507view=rev Log: Lock the owners mutex in the BreakpointSite before updating the hit counts. If you delete a breakpoint belonging to a site just as you are processing a hit on that

Re: [Lldb-commits] [PATCH] D11384: Improve check for ASAN callbacks

2015-07-27 Thread Jim Ingham
jingham added a subscriber: jingham. jingham added a comment. Did you try just turning include_inlines to false? If we are just looking up a name and not looking for inlines we shouldn't have to go grubbing in the debug information. http://reviews.llvm.org/D11384

Re: [Lldb-commits] [PATCH] D11357: Resolve DW_AT_comp_dir path if it contains a symlink

2015-07-27 Thread Jim Ingham
jingham added a comment. As a followup, can you make this non-exported static array of names that are pretty much only interesting on Linux into something queried from the platform? That way we could provide a way for the user to augment the list to add a new directory thats relevant, or even

Re: [Lldb-commits] [PATCH] D11357: Resolve DW_AT_comp_dir path if it contains a symlink

2015-07-27 Thread Jim Ingham
jingham added a comment. There should also be a test for this if you can manage to make one, even if it only runs on Linux, or this is likely to break. http://reviews.llvm.org/D11357 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] D11482: Add target setting to have the language follow the frame's CU.

2015-07-27 Thread Jim Ingham
On Jul 27, 2015, at 11:09 AM, Dawn Perchik dawn+l...@burble.org wrote: dawn requested a review of this revision. dawn added a comment. I need guidance due to conflicting directions from Greg and Sean. Sean wants to be able to evaluate ObjC++ by default always, hence this feature was

[Lldb-commits] [lldb] r243193 - Shorten the lldb timeout, we were seeing occasional failure because

2015-07-24 Thread Jim Ingham
Author: jingham Date: Fri Jul 24 19:52:38 2015 New Revision: 243193 URL: http://llvm.org/viewvc/llvm-project?rev=243193view=rev Log: Shorten the lldb timeout, we were seeing occasional failure because lldb didn't wake up before the target function got a chance to complete.

Re: [Lldb-commits] [PATCH] D11390: Optimize GetCompileUnitContainingDIE with a lookup table

2015-07-21 Thread Jim Ingham
jingham added a subscriber: jingham. jingham added a comment. I'll let Greg weigh in on the actual details, but if as I understand the patch, the m_die_to_index_map only stored CU dies, can you make the name of the ivar indicate that fact? http://reviews.llvm.org/D11390

Re: [Lldb-commits] [PATCH] D11357: Resolve DW_AT_comp_dir path if it contains a symlink

2015-07-20 Thread Jim Ingham
jingham added a subscriber: jingham. jingham added a comment. Why do you need to do this? Between the comp dir and the file name you should have an absolute path. If the debug information is not resolved to an absolute path, that's a compiler bug and should be fixed there. The debugger does

Re: [Lldb-commits] [PATCH] D11119: Parse breakpoint expressions using the language of the frame's CU.

2015-07-15 Thread Jim Ingham
That sounds fine, except you shouldn't call the option expr-language because we expr is the common abbreviation for the expression command, but the breakpoint specifications are not in general expressions. In fact, the only breakpoint specifier that is an expression: --address would NOT take

Re: [Lldb-commits] [PATCH] D11119: Parse breakpoint expressions using the language of the frame's CU.

2015-07-15 Thread Jim Ingham
jingham added a subscriber: jingham. jingham added a comment. That sounds fine, except you shouldn't call the option expr-language because we expr is the common abbreviation for the expression command, but the breakpoint specifications are not in general expressions. In fact, the only

[Lldb-commits] [lldb] r242262 - Fix another little nit with detach and keep stopped, you have to check

2015-07-14 Thread Jim Ingham
Author: jingham Date: Tue Jul 14 19:59:25 2015 New Revision: 242262 URL: http://llvm.org/viewvc/llvm-project?rev=242262view=rev Log: Fix another little nit with detach and keep stopped, you have to check both for packet success and that the response is OK. Modified:

Re: [Lldb-commits] [PATCH] D11094: Refactor Unix signals.

2015-07-10 Thread Jim Ingham
Note, there is a document that describes the rules for coding the SB API's: http://lldb.llvm.org/SB-api-coding-rules.html if there's something there that isn't clear, feel free to clarify the text there... Jim On Jul 10, 2015, at 9:45 AM, Greg Clayton clayb...@gmail.com wrote: A quick

Re: [Lldb-commits] [PATCH] D11094: Refactor Unix signals.

2015-07-10 Thread Jim Ingham
jingham added a subscriber: jingham. jingham added a comment. Note, there is a document that describes the rules for coding the SB API's: http://lldb.llvm.org/SB-api-coding-rules.html if there's something there that isn't clear, feel free to clarify the text there... Jim

Re: [Lldb-commits] [PATCH] D9404: Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-07-09 Thread Jim Ingham
jingham added a subscriber: jingham. jingham added a comment. For my part that looks great. Jim Repository: rL LLVM http://reviews.llvm.org/D9404 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] D9404: Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-07-09 Thread Jim Ingham
For my part that looks great. Jim On Jul 9, 2015, at 10:03 AM, Ewan Crawford e...@codeplay.com wrote: EwanCrawford updated this revision to Diff 29343. EwanCrawford added a comment. To address that final point of not doing any code execution at all for certain targets. I used the

[Lldb-commits] [lldb] r241632 - Add a version of SBTarget::EvaluateExpression that doesn't require

2015-07-07 Thread Jim Ingham
Author: jingham Date: Tue Jul 7 17:12:17 2015 New Revision: 241632 URL: http://llvm.org/viewvc/llvm-project?rev=241632view=rev Log: Add a version of SBTarget::EvaluateExpression that doesn't require an options (and makes an appropriate defaulted option for you.) rdar://problem/20639202

[Lldb-commits] [lldb] r241650 - Don't select a thread that stopped for a signal that was

2015-07-07 Thread Jim Ingham
Author: jingham Date: Tue Jul 7 19:06:30 2015 New Revision: 241650 URL: http://llvm.org/viewvc/llvm-project?rev=241650view=rev Log: Don't select a thread that stopped for a signal that was not set to stop - there must be some other thread that stopped for a more interesting reason.

[Lldb-commits] [lldb] r241652 - Make command files specified to the driver actually print their

2015-07-07 Thread Jim Ingham
Author: jingham Date: Tue Jul 7 19:59:59 2015 New Revision: 241652 URL: http://llvm.org/viewvc/llvm-project?rev=241652view=rev Log: Make command files specified to the driver actually print their results if the -Q option is not provided. Also took out the quietly option from AddInitialCommand,

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-07-01 Thread Jim Ingham
I didn't look at the IRInterpreter part of this closely at first, but now looking over this a bit I am concerned about passing the ExecutionContext to CanInterpret, what information is that really providing? Do we expect some threads could interpret but not others? This just makes it

[Lldb-commits] [lldb] r241181 - Add a missing space.

2015-07-01 Thread Jim Ingham
Author: jingham Date: Wed Jul 1 14:27:08 2015 New Revision: 241181 URL: http://llvm.org/viewvc/llvm-project?rev=241181view=rev Log: Add a missing space. Modified: lldb/trunk/examples/python/scripted_step.py Modified: lldb/trunk/examples/python/scripted_step.py URL:

Re: [Lldb-commits] [PATCH] Add new bugreport command to lldb

2015-07-01 Thread Jim Ingham
So much of the useful bug reporting information in lldb is gathered by turning on logs BEFORE the bad thing occurs, then making it happen, then gathering the logs that were produced as a part of that process. For instance, once a bad unwind has occurred that info is cached, and you can't watch

[Lldb-commits] [lldb] r241216 - Another slightly less goofy example of scripted steps.

2015-07-01 Thread Jim Ingham
Author: jingham Date: Wed Jul 1 19:24:17 2015 New Revision: 241216 URL: http://llvm.org/viewvc/llvm-project?rev=241216view=rev Log: Another slightly less goofy example of scripted steps. Modified: lldb/trunk/examples/python/scripted_step.py Modified:

Re: [Lldb-commits] [PATCH] Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

2015-06-24 Thread Jim Ingham
That seems fine. Jim On Jun 24, 2015, at 2:05 PM, Oleksiy Vyalov ovya...@google.com wrote: Hi jingham, labath, Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined. http://reviews.llvm.org/D10711 Files: include/lldb/API/SBFrame.h scripts/interface/SBFrame.i

Re: [Lldb-commits] [PATCH] Add const versions of SBFrame::GetFunctionName and SBFrame::IsInlined.

2015-06-24 Thread Jim Ingham
That seems fine. Jim http://reviews.llvm.org/D10711 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r240435 - Mark SBFrame::GetFunctionName and SBFrame::IsInlined as const.

2015-06-24 Thread Jim Ingham
at 9:54 AM, Jim Ingham jing...@apple.com wrote: Pavel is right. Our agreement was we wouldn't take anything AWAY from the SB API's. If you want to add a const version, you have to add one, not change an existing API. Jim On Jun 24, 2015, at 12:43 AM, Pavel Labath lab...@google.com

Re: [Lldb-commits] [lldb] r240435 - Mark SBFrame::GetFunctionName and SBFrame::IsInlined as const.

2015-06-24 Thread Jim Ingham
Pavel is right. Our agreement was we wouldn't take anything AWAY from the SB API's. If you want to add a const version, you have to add one, not change an existing API. Jim On Jun 24, 2015, at 12:43 AM, Pavel Labath lab...@google.com wrote: Hi, how will this affect the stability of

[Lldb-commits] [lldb] r240461 - Fix the handling of the run lock in cases where you needed to run

2015-06-23 Thread Jim Ingham
Author: jingham Date: Tue Jun 23 16:02:45 2015 New Revision: 240461 URL: http://llvm.org/viewvc/llvm-project?rev=240461view=rev Log: Fix the handling of the run lock in cases where you needed to run a hand-called function from the private state thread. The problem was that on the way out of the

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-22 Thread Jim Ingham
Great. I am assuming these files are lldb_private, the instructions are slightly different for SB API files. Open the lldb.xcworkspace in the top-level lldb directory. Select the Project Navigator from the Navigators on the LHS of the Xcode window, and figure out where in the project

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-19 Thread Jim Ingham
Do you have a MacOS X system? If so I can explain how to add files in Xcode. If you don't, when you get around to checking this in just ping us and tell us what files you added, and one of us will add them to the project file. Jim On Jun 19, 2015, at 9:50 AM, Ewan Crawford e...@codeplay.com

Re: [Lldb-commits] [PATCH] Avoid querying thread stop info if the thread hasn't been running

2015-06-18 Thread Jim Ingham
I thought about this for much the same reason just a little while ago. Turns out OS X, it is possible for us to stop a process, and fetch all the exceptions, but have some thread exception that wasn't quite ready to be delivered to that thread. The next time you let the task run, that

Re: [Lldb-commits] [PATCH] Avoid querying thread stop info if the thread hasn't been running

2015-06-18 Thread Jim Ingham
I thought about this for much the same reason just a little while ago. Turns out OS X, it is possible for us to stop a process, and fetch all the exceptions, but have some thread exception that wasn't quite ready to be delivered to that thread. The next time you let the task run, that

Re: [Lldb-commits] [PATCH] Avoid querying thread stop info if the thread hasn't been running

2015-06-18 Thread Jim Ingham
On Jun 18, 2015, at 3:11 PM, Jim Ingham jing...@apple.com wrote: I thought about this for much the same reason just a little while ago. Turns out OS X, it is possible for us to stop a process, and fetch all the exceptions, but have some thread exception that wasn't quite ready

[Lldb-commits] [lldb] r239854 - Fix a typo in the help.

2015-06-16 Thread Jim Ingham
Author: jingham Date: Tue Jun 16 16:39:56 2015 New Revision: 239854 URL: http://llvm.org/viewvc/llvm-project?rev=239854view=rev Log: Fix a typo in the help. Modified: lldb/trunk/source/Target/Target.cpp Modified: lldb/trunk/source/Target/Target.cpp URL:

[Lldb-commits] [lldb] r238862 - Fix up some comments to be more explicit. Remove some long-commented out code.

2015-06-02 Thread Jim Ingham
Author: jingham Date: Tue Jun 2 15:26:13 2015 New Revision: 238862 URL: http://llvm.org/viewvc/llvm-project?rev=238862view=rev Log: Fix up some comments to be more explicit. Remove some long-commented out code. Modified: lldb/trunk/include/lldb/Target/Thread.h

[Lldb-commits] [lldb] r237824 - Since the asan report function doesn't gather bp or sp,

2015-05-20 Thread Jim Ingham
Author: jingham Date: Wed May 20 14:15:43 2015 New Revision: 237824 URL: http://llvm.org/viewvc/llvm-project?rev=237824view=rev Log: Since the asan report function doesn't gather bp or sp, don't put those values in the Structured Data we make up from the report. rdar://problem/21038887

[Lldb-commits] [lldb] r237866 - Fix the logic in DynamicLoaderMacOSXDYLD::Clear that would only remove the old dyld notification

2015-05-20 Thread Jim Ingham
Author: jingham Date: Wed May 20 19:27:01 2015 New Revision: 237866 URL: http://llvm.org/viewvc/llvm-project?rev=237866view=rev Log: Fix the logic in DynamicLoaderMacOSXDYLD::Clear that would only remove the old dyld notification breakpoint only if the process it was for is still alive.

[Lldb-commits] [lldb] r237279 - Add a comment clarifying what func_name_type_mask is.

2015-05-13 Thread Jim Ingham
Author: jingham Date: Wed May 13 14:01:15 2015 New Revision: 237279 URL: http://llvm.org/viewvc/llvm-project?rev=237279view=rev Log: Add a comment clarifying what func_name_type_mask is. Modified: lldb/trunk/include/lldb/Target/Target.h Modified: lldb/trunk/include/lldb/Target/Target.h URL:

[Lldb-commits] [lldb] r236762 - Add a missing check for m_real_stop_reason.

2015-05-07 Thread Jim Ingham
Author: jingham Date: Thu May 7 13:51:04 2015 New Revision: 236762 URL: http://llvm.org/viewvc/llvm-project?rev=236762view=rev Log: Add a missing check for m_real_stop_reason. rdar://problem/20738527 Modified: lldb/trunk/source/Target/ThreadPlanCallFunction.cpp Modified:

[Lldb-commits] [lldb] r236429 - Fix a typo in the warning.

2015-05-04 Thread Jim Ingham
Author: jingham Date: Mon May 4 12:33:33 2015 New Revision: 236429 URL: http://llvm.org/viewvc/llvm-project?rev=236429view=rev Log: Fix a typo in the warning. rdar://problem/20799707 Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [lldb] r236287 - Don't return nullptr when you mean to return an empty llvm::StringRef...

2015-04-30 Thread Jim Ingham
Author: jingham Date: Thu Apr 30 18:45:07 2015 New Revision: 236287 URL: http://llvm.org/viewvc/llvm-project?rev=236287view=rev Log: Don't return nullptr when you mean to return an empty llvm::StringRef... rdar://problem/20747164 Modified: lldb/trunk/source/Interpreter/PythonDataObjects.cpp

[Lldb-commits] [lldb] r235527 - Formatting fix.

2015-04-22 Thread Jim Ingham
Author: jingham Date: Wed Apr 22 12:48:24 2015 New Revision: 235527 URL: http://llvm.org/viewvc/llvm-project?rev=235527view=rev Log: Formatting fix. Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL:

[Lldb-commits] [lldb] r235538 - This is some groundwork for filtering the language Exception

2015-04-22 Thread Jim Ingham
Author: jingham Date: Wed Apr 22 14:42:18 2015 New Revision: 235538 URL: http://llvm.org/viewvc/llvm-project?rev=235538view=rev Log: This is some groundwork for filtering the language Exception breakpoints, for instance on the class of the thrown object. This change doesn't actually make that

[Lldb-commits] [lldb] r235564 - Missed one piece when committing r235538.

2015-04-22 Thread Jim Ingham
Author: jingham Date: Wed Apr 22 19:28:25 2015 New Revision: 235564 URL: http://llvm.org/viewvc/llvm-project?rev=235564view=rev Log: Missed one piece when committing r235538. Modified: lldb/trunk/source/Target/StopInfo.cpp Modified: lldb/trunk/source/Target/StopInfo.cpp URL:

[Lldb-commits] [lldb] r235122 - The last argument to CreateExceptionBreakpoint is internal not Hardware.

2015-04-16 Thread Jim Ingham
Author: jingham Date: Thu Apr 16 12:32:27 2015 New Revision: 235122 URL: http://llvm.org/viewvc/llvm-project?rev=235122view=rev Log: The last argument to CreateExceptionBreakpoint is internal not Hardware. Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp Modified:

[Lldb-commits] [lldb] r235153 - Fix help language, the languages printer was assuming the

2015-04-16 Thread Jim Ingham
Author: jingham Date: Thu Apr 16 19:44:36 2015 New Revision: 235153 URL: http://llvm.org/viewvc/llvm-project?rev=235153view=rev Log: Fix help language, the languages printer was assuming the eLanguageType numbers would be sequential, but vendor types are not and the printer went crazy.

Re: [Lldb-commits] [PATCH] Generate an event when a pending breakpoint binds

2015-04-08 Thread Jim Ingham
You will see this resolved event when you make a new breakpoint after the process is running as well as when a pre-existing breakpoint gets a location on load. So you should be able to write an MI test that sets a breakpoint and then makes sure you emit the breakpoint-modified event that

Re: [Lldb-commits] [PATCH] Generate an event when a pending breakpoint binds

2015-04-08 Thread Jim Ingham
This looks fine. Your description of the patch doesn't use terminology in quite the same way as lldb does. This isn't an MI event, it is just a regular lldb event. There really aren't MI events. That's not terribly important, except if you were to think that these are only used by MI...

Re: [Lldb-commits] [PATCH] Fix selecting the Platform in TargetList::CreateTargetInternal()

2015-03-31 Thread Jim Ingham
IIRC, the point of the previous patch was to make new targets use the currently selected platform, so that you can do: (lldb) platform select whatever (lldb) file some_file and some_file would use the platform you had specified. That seems a useful behavior. Can you fix this in a way that

Re: [Lldb-commits] [PATCH] Fix race condition in Target::Launch

2015-03-26 Thread Jim Ingham
Todd originally put that in, but only in the async case. It is just some dopey little delay in the hope of avoiding a race. The synchronous case is going to the trouble of waiting for a real stop to happen and get reported, that's going to take longer than this little delay. Of course, it

Re: [Lldb-commits] [PATCH] Fix expression evaluation with logs (step + verbose) enabled.

2015-03-26 Thread Jim Ingham
I don't understand how calling ReportRegisterState when the takedown had already been done could cause the error you report - though without more details about what you are doing it's hard to say for sure. After all, within ShouldStop the m_thread in the ThreadPlan must still be valid, and all

Re: [Lldb-commits] [PATCH] Fix expression evaluation with logs (step + verbose) enabled.

2015-03-26 Thread Jim Ingham
The step log should show you if any code got run between the stop to evaluate ShouldStop and when you go to get the register context here. I would be surprised if this is happening, however. If any thread plans need to run code to do some task, they just push another ThreadPlanCallFunction,

Re: [Lldb-commits] [PATCH] Add a --all command option to target delete

2015-03-25 Thread Jim Ingham
I think it is worth mentioning in the help that if you do clean then you will need to reparse all shared modules the next time you debug. This can be a significant hiccup when you next debug... Can't think of a succinct way to say this off the top of my head, though... I try to use boolean

Re: [Lldb-commits] [PATCH] Use eFlagRequiresFrame instead of manually checking in CommandObjectThread.cpp.

2015-03-24 Thread Jim Ingham
The only thing that bothers me a bit about this patch is that somebody might think we need to go clean up all the places where a thread doesn't have a frame 0, and worse, actually try to do something reasonable in that case. That would be wasted effort. To that end, an assert here might in

Re: [Lldb-commits] [PATCH] Add a missing null pointer check in CommandObjectThread.cpp.

2015-03-23 Thread Jim Ingham
How do you get a thread that has NO frame 0? That seems weird, we always have a register context to make frame 0... Anyway, if you're going to do this, add it to the thread == NULL checks earlier on in the function so we can get out of the command with an appropriate error message. If we

Re: [Lldb-commits] [PATCH] Add a missing null pointer check in CommandObjectThread.cpp.

2015-03-23 Thread Jim Ingham
Yes, I think there are a lot of places around in lldb where we assume that if you have a valid thread you have a valid frame 0. You're not going to get very far if you don't get that right. Jim REPOSITORY rL LLVM http://reviews.llvm.org/D8554 EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] Report breakpoint/watchpoint hits during single stepping.

2015-03-18 Thread Jim Ingham
Comment at: test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py:37-38 @@ +36,4 @@ +self.runCmd(target create + exe, CURRENT_EXECUTABLE_SET) +self.runCmd(breakpoint set --name main, BREAKPOINT_CREATED) + +self.runCmd(process

[Lldb-commits] [lldb] r232689 - Comment discouraging writing command based test cases.

2015-03-18 Thread Jim Ingham
Author: jingham Date: Wed Mar 18 18:16:58 2015 New Revision: 232689 URL: http://llvm.org/viewvc/llvm-project?rev=232689view=rev Log: Comment discouraging writing command based test cases. Modified: lldb/trunk/test/README-TestSuite Modified: lldb/trunk/test/README-TestSuite URL:

Re: [Lldb-commits] [PATCH] Add =shlibs-added/=shlibs-removed notifications (MI)

2015-03-11 Thread Jim Ingham
If you are on a system using ASLR you also might want to know where the main executable loaded, so it seems useful to send it for the main executable. shlibs-added is a little funny, for instance on OS X gdb used to read all the directly linked libraries when the main executable was loaded, so

Re: [Lldb-commits] [PATCH] Fix a comment for ValueObject::GetValueDidChange after r231526

2015-03-10 Thread Jim Ingham
That's fine. Jim http://reviews.llvm.org/D8206 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix deadlock in Listener/Broadcaster::Clear

2015-03-10 Thread Jim Ingham
What happens if somebody tries to add a listener to a broadcaster while it is calling clear? Jim http://reviews.llvm.org/D8211 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] Update the LLDB website with more information

2015-03-10 Thread Jim Ingham
That looks good. http://reviews.llvm.org/D8222 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Report stopped by trace if none of the watchpoint was hit

2015-03-06 Thread Jim Ingham
The approach looks right. I'll let somebody who works on the NativeThread side weigh in on whether the implementation is correct. http://reviews.llvm.org/D8081 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___

Re: [Lldb-commits] [PATCH] Expect stop reason watchpoint for the step over breakpoint thread plan

2015-03-05 Thread Jim Ingham
I didn't understand your reply. Adding a test case won't make this code work correctly. This change should not go in till you figure out how to identify the watchpoint stop reason which corresponds to the return from the single step and only return true in that case.

Re: [Lldb-commits] [PATCH] Expect stop reason watchpoint for the step over breakpoint thread plan

2015-03-05 Thread Jim Ingham
Do you get any data back from the watchpoint hit? For instance, if the trace is implemented by a pc != curr_pc type watch, then you should be able to get the watched address from the watchpoint hit event. In that case, you can check whether the watched address was the current PC, and only

[Lldb-commits] [lldb] r231287 - Fix a thinko in the case where we return a launch error with no error

2015-03-04 Thread Jim Ingham
Author: jingham Date: Wed Mar 4 15:28:55 2015 New Revision: 231287 URL: http://llvm.org/viewvc/llvm-project?rev=231287view=rev Log: Fix a thinko in the case where we return a launch error with no error string. Return unknown error rather than the empty launch error... rdar://problem/20026469

Re: [Lldb-commits] [PATCH] Prevent LLGS from crashing when exiting - make NativeProcessLinux to wait until ThreadStateCoordinator is fully stopped before entering ~NativeProcessLinux.

2015-02-18 Thread Jim Ingham
Be careful about this sort of thing, there are all sorts of gnarly corner cases, like a breakpoint command that does: (lldb) break command add Enter your debugger command(s). Type 'DONE' to end. settings set auto-confirm true process kill DONE The process kill gets executed while you

[Lldb-commits] [lldb] r228938 - Add an -A option to break set -p to search all files for matches. Also add the version of

2015-02-12 Thread Jim Ingham
Author: jingham Date: Thu Feb 12 11:37:46 2015 New Revision: 228938 URL: http://llvm.org/viewvc/llvm-project?rev=228938view=rev Log: Add an -A option to break set -p to search all files for matches. Also add the version of SBTarget::BreakpointCreateBySourceRegex that takes file spec lists to

Re: [Lldb-commits] [PATCH] Make TestHelloWorld.py to pass remotely on Linux.

2015-02-11 Thread Jim Ingham
It is part of the linker stage so each rebuild should produce an unique UUID. Note, the MacOS X linker actually makes the UUID by checksumming the binary - minus some obvious bits the linker knows to contain timestamps - so if you rebuild the same sources with the same compiler compiler

[Lldb-commits] [lldb] r227217 - The MCJIT doesn't seem to call getPointerForNamedFunction from the MemoryManager anymore, switching to getSymbolAddress, which

2015-01-27 Thread Jim Ingham
Author: jingham Date: Tue Jan 27 12:03:05 2015 New Revision: 227217 URL: http://llvm.org/viewvc/llvm-project?rev=227217view=rev Log: The MCJIT doesn't seem to call getPointerForNamedFunction from the MemoryManager anymore, switching to getSymbolAddress, which it does call, and implementing it so

[Lldb-commits] [lldb] r227285 - SBThread::GetDescription should use the Thread format instead of making up

2015-01-27 Thread Jim Ingham
Author: jingham Date: Tue Jan 27 19:18:01 2015 New Revision: 227285 URL: http://llvm.org/viewvc/llvm-project?rev=227285view=rev Log: SBThread::GetDescription should use the Thread format instead of making up some format of its own. Modified: lldb/trunk/source/API/SBThread.cpp Modified:

[Lldb-commits] [lldb] r226886 - Remove the / from the end of rpath paths. Having it there causes the

2015-01-22 Thread Jim Ingham
Author: jingham Date: Thu Jan 22 18:39:13 2015 New Revision: 226886 URL: http://llvm.org/viewvc/llvm-project?rev=226886view=rev Log: Remove the / from the end of rpath paths. Having it there causes the paths we get from dladdr to have // in it internally, and while that is formally correct it is

Re: [Lldb-commits] [PATCH] Add -exec-arguments command

2015-01-21 Thread Jim Ingham
My suggestion was to have the SBTarget vend the SBLaunchInfo it WOULD use if you were to call launch without providing an SBLaunchInfo of your own. Unfortunately, the underlying target doesn't actually use a ProcessLaunch info to store these settings, it stores the individual bits. That's

Re: [Lldb-commits] [PATCH] Add -exec-arguments command

2015-01-19 Thread Jim Ingham
So the way you set arguments when you launch a process through the SB API's (besides some old unstructured API's that we'll eventually deprecate) is through the SBLaunchInfo. You're adding another way to get and set the arguments that's independent of that. I'd rather we didn't create another

Re: [Lldb-commits] [PATCH] UpdateSDKDirectoryInfosInNeeded(); called twice, is that right?

2015-01-19 Thread Jim Ingham
Presumably that should be IfNeeded as well? REPOSITORY rL LLVM http://reviews.llvm.org/D7059 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Add -exec-arguments command

2015-01-19 Thread Jim Ingham
If we want to have a way to directly set the arguments in a Target, I would prefer to have the SBTarget vend the SBLaunchInfo that it will use when it launches (if you don't give it another SBLaunchInfo) and then set the arguments there. Right now it is pretty incoherent, you can set arguments

Re: [Lldb-commits] [PATCH] Don't remove backslashes from arguments unless the following char is recognized.

2015-01-16 Thread Jim Ingham
If I had a path component that began with a space (dunno if you can do that on Windows) what would I have to do to enter that? d:\\ foo\bar ? I guess that's not too horrible... Jim http://reviews.llvm.org/D7018 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

[Lldb-commits] [lldb] r226074 - Make sure that when a breakpoint is hit but its condition is not met,

2015-01-14 Thread Jim Ingham
Author: jingham Date: Wed Jan 14 19:41:04 2015 New Revision: 226074 URL: http://llvm.org/viewvc/llvm-project?rev=226074view=rev Log: Make sure that when a breakpoint is hit but its condition is not met, the hit count is not updated. Also, keep the hit count for the breakpoint in the breakpoint.

Re: [Lldb-commits] [PATCH] Add support for character option types

2015-01-12 Thread Jim Ingham
This seems fine to me. http://reviews.llvm.org/D6887 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r224392 - Add the ability to tag one or more breakpoints with a name. These

2014-12-20 Thread Jim Ingham
Author: jingham Date: Tue Dec 16 17:40:14 2014 New Revision: 224392 URL: http://llvm.org/viewvc/llvm-project?rev=224392view=rev Log: Add the ability to tag one or more breakpoints with a name. These names can then be used in place of breakpoint id's or breakpoint id ranges in all the commands

[Lldb-commits] [lldb] r224602 - Audit uses of ConstString::AsCString() to make sure they weren't assuming

2014-12-19 Thread Jim Ingham
Author: jingham Date: Fri Dec 19 13:20:44 2014 New Revision: 224602 URL: http://llvm.org/viewvc/llvm-project?rev=224602view=rev Log: Audit uses of ConstString::AsCString() to make sure they weren't assuming they would always get a non-NULL string back. rdar://problem/19298575 Modified:

[Lldb-commits] [lldb] r223731 - Simple test for file line dummy breakpoints.

2014-12-08 Thread Jim Ingham
Author: jingham Date: Mon Dec 8 19:28:22 2014 New Revision: 223731 URL: http://llvm.org/viewvc/llvm-project?rev=223731view=rev Log: Simple test for file line dummy breakpoints. Added: lldb/trunk/test/functionalities/breakpoint/dummy_target_breakpoints/

[Lldb-commits] [lldb] r223543 - First pass at a description of the lldb coding conventions.

2014-12-05 Thread Jim Ingham
Author: jingham Date: Fri Dec 5 17:18:01 2014 New Revision: 223543 URL: http://llvm.org/viewvc/llvm-project?rev=223543view=rev Log: First pass at a description of the lldb coding conventions. Added: lldb/trunk/www/lldb-coding-conventions.html Modified: lldb/trunk/www/sidebar.incl

[Lldb-commits] [lldb] r223550 - Add an initial description of the rules for constructing new SB API classes.

2014-12-05 Thread Jim Ingham
Author: jingham Date: Fri Dec 5 18:28:05 2014 New Revision: 223550 URL: http://llvm.org/viewvc/llvm-project?rev=223550view=rev Log: Add an initial description of the rules for constructing new SB API classes. Added: lldb/trunk/www/SB-api-coding-rules.html Modified:

[Lldb-commits] [lldb] r223559 - Fix a type (MAX_PATH instead of PATH_MAX) and remove an unused variable.

2014-12-05 Thread Jim Ingham
Author: jingham Date: Fri Dec 5 19:03:17 2014 New Revision: 223559 URL: http://llvm.org/viewvc/llvm-project?rev=223559view=rev Log: Fix a type (MAX_PATH instead of PATH_MAX) and remove an unused variable. Modified: lldb/trunk/source/Host/common/Host.cpp Modified:

[Lldb-commits] [lldb] r223565 - Add the ability to set breakpoints with conditions, commands, etc,

2014-12-05 Thread Jim Ingham
Author: jingham Date: Fri Dec 5 19:28:03 2014 New Revision: 223565 URL: http://llvm.org/viewvc/llvm-project?rev=223565view=rev Log: Add the ability to set breakpoints with conditions, commands, etc, in the dummy-target. The dummy target breakpoints prime all future targets. Breakpoints set

Re: [Lldb-commits] [PATCH] Fix some posixy assumptions that were used during RunShellCommand

2014-12-05 Thread Jim Ingham
I did it (r223568.) Jim REPOSITORY rL LLVM http://reviews.llvm.org/D6553 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r222599 - Make the sourcing of the local .lldbinit file quiet.

2014-11-21 Thread Jim Ingham
Author: jingham Date: Fri Nov 21 19:33:22 2014 New Revision: 222599 URL: http://llvm.org/viewvc/llvm-project?rev=222599view=rev Log: Make the sourcing of the local .lldbinit file quiet. rdar://problem/19065278 Modified: lldb/trunk/tools/driver/Driver.cpp lldb/trunk/tools/driver/Driver.h

[Lldb-commits] [lldb] r222600 - This is the first step of making lldb able to create target-specific things

2014-11-21 Thread Jim Ingham
Author: jingham Date: Fri Nov 21 19:42:44 2014 New Revision: 222600 URL: http://llvm.org/viewvc/llvm-project?rev=222600view=rev Log: This is the first step of making lldb able to create target-specific things (e.g. breakpoints, stop-hooks) before we have any targets - for instance in your

[Lldb-commits] [lldb] r222459 - nexti should not step over inlined functions.

2014-11-20 Thread Jim Ingham
Author: jingham Date: Thu Nov 20 16:04:45 2014 New Revision: 222459 URL: http://llvm.org/viewvc/llvm-project?rev=222459view=rev Log: nexti should not step over inlined functions. rdar://problem/16705325 Modified: lldb/trunk/source/Target/ThreadPlanStepInstruction.cpp Modified:

[Lldb-commits] [lldb] r222479 - Make the option parsing of -k -K match the help strings.

2014-11-20 Thread Jim Ingham
Author: jingham Date: Thu Nov 20 17:37:13 2014 New Revision: 222479 URL: http://llvm.org/viewvc/llvm-project?rev=222479view=rev Log: Make the option parsing of -k -K match the help strings. Modified: lldb/trunk/tools/driver/Driver.cpp Modified: lldb/trunk/tools/driver/Driver.cpp URL:

[Lldb-commits] [lldb] r222484 - Add a test for the driver's -k option.

2014-11-20 Thread Jim Ingham
Author: jingham Date: Thu Nov 20 18:14:57 2014 New Revision: 222484 URL: http://llvm.org/viewvc/llvm-project?rev=222484view=rev Log: Add a test for the driver's -k option. Modified: lldb/trunk/test/driver/batch_mode/TestBatchMode.py Modified:

[Lldb-commits] [lldb] r222243 - Patch from d...@burble.org to make the --silent-run do what it says, not the opposite of what it says.

2014-11-18 Thread Jim Ingham
Author: jingham Date: Tue Nov 18 13:12:13 2014 New Revision: 43 URL: http://llvm.org/viewvc/llvm-project?rev=43view=rev Log: Patch from d...@burble.org to make the --silent-run do what it says, not the opposite of what it says. Modified:

[Lldb-commits] [lldb] r222295 - Add -k and -K options to the driver, that allow you to register

2014-11-18 Thread Jim Ingham
Author: jingham Date: Tue Nov 18 19:28:13 2014 New Revision: 95 URL: http://llvm.org/viewvc/llvm-project?rev=95view=rev Log: Add -k and -K options to the driver, that allow you to register some commands that will get run if the target crashes. Also fix the bug where the local .lldbinit

[Lldb-commits] [lldb] r222059 - Fix examine-threads to build for arm64.

2014-11-14 Thread Jim Ingham
Author: jingham Date: Fri Nov 14 16:58:25 2014 New Revision: 222059 URL: http://llvm.org/viewvc/llvm-project?rev=222059view=rev Log: Fix examine-threads to build for arm64. Modified: lldb/trunk/tools/darwin-threads/examine-threads.c Modified:

[Lldb-commits] [lldb] r222075 - For some reason, sometimes the directory paths that clang emits have internal

2014-11-14 Thread Jim Ingham
Author: jingham Date: Fri Nov 14 19:54:26 2014 New Revision: 222075 URL: http://llvm.org/viewvc/llvm-project?rev=222075view=rev Log: For some reason, sometimes the directory paths that clang emits have internal relative paths, like: /whatever/llvm/lib/Sema/../../include/llvm/Sema/ That causes

Re: [Lldb-commits] [PATCH] LLGS Android target support

2014-11-07 Thread Jim Ingham
Most of this seems okay, but in a couple of places you either write stub versions of functions that are missing from the Android NDK. std::to_string is done in the linux/Host.cpp, which seems like an appropriate place to put missing functions, but timegm and posix_openpt you do in the place

Re: [Lldb-commits] [PATCH] LLGS Android target support

2014-11-07 Thread Jim Ingham
Most of this seems okay, but in a couple of places you either write stub versions of functions that are missing from the Android NDK. std::to_string is done in the linux/Host.cpp, which seems like an appropriate place to put missing functions, but timegm and posix_openpt you do in the place

Re: [Lldb-commits] [PATCH] Move NativeProcessProtocol and friends from Host/ to Target/

2014-11-04 Thread Jim Ingham
As I understood it originally, the NativeProcess stuff would end up replacing the guts of the ProcessLinux, etc, but in a way that would easily allow you to slot them into llgs as well. That’s why I thought of them as some kind ur-process plugin. Jim http://reviews.llvm.org/D6123

  1   2   3   >