:-) Yay!
-Todd
On Feb 2, 2015, at 12:59 PM, Greg Clayton clayb...@gmail.com wrote:
This is the big llgs patch we have been eagerly waiting to see. If the MacOSX
test suite is good, then I am ok with this.
http://reviews.llvm.org/D7238
EMAIL PREFERENCES
(Ok - flipped to my google account)
Yay! Glad to see this approaching submission :-)
On Feb 2, 2015, at 12:59 PM, Greg Clayton clayb...@gmail.com wrote:
This is the big llgs patch we have been eagerly waiting to see. If the MacOSX
test suite is good, then I am ok with this.
Author: tfiala
Date: Sun Oct 26 16:37:46 2014
New Revision: 220650
URL: http://llvm.org/viewvc/llvm-project?rev=220650view=rev
Log:
Fix HelloWorld attach test for Linux kernels with ptrace ancestor lockdown.
Similar to a recent test I fixed for gdb-remote attach scenarios, this
fix is for Linux
Author: tfiala
Date: Sun Oct 26 17:08:56 2014
New Revision: 220654
URL: http://llvm.org/viewvc/llvm-project?rev=220654view=rev
Log:
Fix TestAttachResume test so it doesn't hang on Linux with ptrace lockdown.
Similar to previous fix, this augments the test inferior to
immediately indicate it may
Author: tfiala
Date: Sun Oct 26 17:25:33 2014
New Revision: 220656
URL: http://llvm.org/viewvc/llvm-project?rev=220656view=rev
Log:
Fix up TestRegisters for Linux ptracer lock-down.
All of these test fixups are prep work for when llgs is
running with llgs for local process debugging, where these
Author: tfiala
Date: Sun Oct 26 19:31:05 2014
New Revision: 220660
URL: http://llvm.org/viewvc/llvm-project?rev=220660view=rev
Log:
Fix TestProcessAttach for Linux ptracer lock-down and llgs-local.
Modified:
lldb/trunk/test/functionalities/process_attach/main.c
Modified:
Author: tfiala
Date: Sun Oct 26 19:58:27 2014
New Revision: 220661
URL: http://llvm.org/viewvc/llvm-project?rev=220661view=rev
Log:
Fix the TestCreateAfterAttach test for llgs-local on ptracer lock-down.
Modified:
lldb/trunk/test/functionalities/thread/create_after_attach/main.c
Modified:
Author: tfiala
Date: Sun Oct 19 22:56:46 2014
New Revision: 220181
URL: http://llvm.org/viewvc/llvm-project?rev=220181view=rev
Log:
Fix 4 failing llgs-related tests on a stock Ubuntu 14.04 x86_64 system./
This fix addresses a requirement on some Linux kernels that limits
a PTRACER to be an
FWIW:
These are the test failures I still see on a stock Linux x86_64 system at TOT:
```
FAIL: LLDB (suite) :: TestCallStopAndContinue.py (Linux vagrant
3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014 x86_64 x86_64)
FAIL: LLDB (suite) :: TestDataFormatterStdVector.py (Linux
This fixes the following test failures:
```
FAIL: LLDB (suite) :: TestGdbRemoteProcessInfo.py (Linux vagrant
3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014 x86_64 x86_64)
FAIL: LLDB (suite) :: TestGdbRemoteAttach.py (Linux vagrant 3.13.0-32-generic
#57-Ubuntu SMP Tue Jul 15
/listinfo/lldb-commits
--
Todd Fiala | Software Engineer | tfi...@google.com
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Some Linux kernels have a ptrace security feature that prevents a ptracer from
attaching to the inferior if the ptracer is not an ancestor in the process
hierarchy. In the gdb-remote attach tests, the llgs is not a parent of the
inferior, so kernels that protect against this are failing on the
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
--
Todd Fiala | Software Engineer | tfi...@google.com
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: tfiala
Date: Sat Oct 11 15:11:18 2014
New Revision: 219576
URL: http://llvm.org/viewvc/llvm-project?rev=219576view=rev
Log:
Fix cmake build for PluginInstrumentationRuntimeAddressSanitizer.
Modified:
lldb/trunk/source/Plugins/CMakeLists.txt
Modified:
Closed by:
```
svn commit
Sendinginclude/lldb/Target/FileAction.h
Sendingsource/Plugins/Platform/Linux/PlatformLinux.cpp
Sendingsource/Plugins/Platform/Linux/PlatformLinux.h
Sendingsource/Plugins/Platform/MacOSX/PlatformDarwin.cpp
Sending
I reversed this out with this change:
```
svn commit
Sendinginclude/lldb/Expression/ClangExpressionParser.h
Sendinginclude/lldb/Target/Target.h
Sendingsource/Expression/ClangExpressionParser.cpp
Sendingsource/Expression/ClangFunction.cpp
Sending
add Rectangle --summary-string Category1 -w Category1
and the value for the -w option ends up being ategory1 with the leading C
chopped away
On Oct 6, 2014, at 4:23 PM, Todd Fiala tfi...@google.com wrote:
svn commit
Sendinginclude/lldb/Expression/ClangExpressionParser.h
Sending
FYI Tong's internship is up, so his @google.com email address will show up as
unreachable.
It looks like this change has introduced this bug:
http://llvm.org/bugs/show_bug.cgi?id=21190
http://reviews.llvm.org/D5472
___
lldb-commits mailing list
Hi clayborg,
This change does the following:
* Enable lldb-gdbserver (llgs) usage for local-process Linux debugging.
To turn on local llgs debugging support, which is disabled by default, enable
this setting:
```
(lldb) settings set platform.plugin.linux.use-llgs-for-local true
```
* Adds a
Note: this change enables llgs to work for local Linux debugging. There are
some caveats - we have some known issues and test build failures with local
llgs that we're working out in the github.com/tfiala/lldb dev-llgs-local-launch
branch. However, as llgs is not on by default and we haven't
Testing this over here now.
http://reviews.llvm.org/D5632
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
:
It's ugly to have to add quotes and then remove them, but until we write
our own option parser I can't think of a better way to do it...
Jim
http://reviews.llvm.org/D5472
--
Todd Fiala | Software Engineer | tfi...@google.com
___
lldb-commits
Author: tfiala
Date: Thu Oct 2 09:07:46 2014
New Revision: 218871
URL: http://llvm.org/viewvc/llvm-project?rev=218871view=rev
Log:
gtest runner: now always does a clean step after running.
* Checks for any 'clean' arg, setting clean-only mode.
* If clean-only mode, skip the make.
* Adds the
Author: tfiala
Date: Thu Oct 2 09:44:33 2014
New Revision: 218873
URL: http://llvm.org/viewvc/llvm-project?rev=218873view=rev
Log:
Fix up stale comments from last change.
Modified:
lldb/trunk/gtest/unittest/Plugins/Process/Linux/ThreadStateCoordinatorTest.cpp
Modified:
I tested this with the lldb docs for 'type summary' here:
http://lldb.llvm.org/varformats.html, using the floating point type summary
example:
```
type summary add --summary-string Sign: ${var[31]%B} Exponent: ${var[30-23]%x}
Mantissa: ${var[0-22]%u} float
```
That seemed to work in the
Adding Jason as a proxy for Greg.
http://reviews.llvm.org/D5568
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
--
Todd Fiala | Software Engineer | tfi...@google.com
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http
Author: tfiala
Date: Thu Oct 2 11:59:30 2014
New Revision: 218890
URL: http://llvm.org/viewvc/llvm-project?rev=218890view=rev
Log:
Fix codesigning of MacOSX debugserver when built with cmake.
This patch fixes the codesigning of debugserver on OSX when built with
cmake. Without this you get
Author: tfiala
Date: Thu Oct 2 14:03:06 2014
New Revision: 218897
URL: http://llvm.org/viewvc/llvm-project?rev=218897view=rev
Log:
thread state coordinator: added simpler deferred stop notification method.
Now that ThreadStateCoordinator errors out on threads in unexpected states,
it has enough
Author: tfiala
Date: Thu Oct 2 14:48:30 2014
New Revision: 218901
URL: http://llvm.org/viewvc/llvm-project?rev=218901view=rev
Log:
Fix stale comments in new tests.
Dang.
Modified:
lldb/trunk/gtest/unittest/Plugins/Process/Linux/ThreadStateCoordinatorTest.cpp
Modified:
Author: tfiala
Date: Wed Oct 1 16:40:45 2014
New Revision: 218833
URL: http://llvm.org/viewvc/llvm-project?rev=218833view=rev
Log:
thread state coordinator: added error callbacks, cleaned up tests.
ThreadStateCoordinator changes:
* Most commands that run in the queue now take an error handler
Author: tfiala
Date: Tue Sep 30 10:58:56 2014
New Revision: 218679
URL: http://llvm.org/viewvc/llvm-project?rev=218679view=rev
Log:
Fix cmake build for new thread plan files.
Modified:
lldb/trunk/source/API/CMakeLists.txt
lldb/trunk/source/Target/CMakeLists.txt
Modified:
Hey Tong,
Some feedback:
* The jit-ness of this is more or less an implementation detail. Naming it
something related to expression evaluation seems like a better fit. Maybe
something like evaluation-compiler-args.
* See question on custom handling that one arg in CommandObjectSettings.cpp.
: http://reviews.llvm.org/D5417
FreeBSD build has been broken for a week with this change. Zach, can
you please have a look at applying the same changes there?
--
Todd Fiala | Software Engineer | tfi...@google.com
___
lldb-commits mailing list
coded the Linux path when FreeBSD
needs the FreeBSD one.
I'll get that addressed.
On Tue, Sep 30, 2014 at 11:18 AM, Todd Fiala tfi...@google.com wrote:
Todd is looking into them.
Yep - looking at the FreeBSD build at TOT. I've got a couple interviews
to conduct so might not get this wrapped
Author: tfiala
Date: Mon Sep 29 16:45:21 2014
New Revision: 218629
URL: http://llvm.org/viewvc/llvm-project?rev=218629view=rev
Log:
thread state coordinator: add exec reset support, remove empty virtual
destructors.
Also added a test for the reset handling. The reset/state clearing happens
as
Thanks, Jason!
Just running a few tests over here. If it comes up clean, I'll get it in.
http://reviews.llvm.org/D5533
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
```
$ svn commit
Sendingsource/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp
Sendingsource/Plugins/SymbolFile/DWARF/DWARFDebugLine.h
Transmitting file data ..
Committed revision 218641.
```
http://reviews.llvm.org/D5533
___
lldb-commits
Passed tests on Ubuntu Linux and MacOSX.
http://reviews.llvm.org/D5533
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Hey Tong,
What are all the flags you assume are set when building this on the Android
side? In addition to building it with stock normal flags on Linux, I want to
use the same flag set.
Looks like the define flag set includes at least:
LLDB_DISABLE_LIBEDIT
LLDB_DISABLE_PYTHON
(and of course
Author: tfiala
Date: Sat Sep 27 11:54:22 2014
New Revision: 218568
URL: http://llvm.org/viewvc/llvm-project?rev=218568view=rev
Log:
Enable llgs to build against experimental Android AOSP
lldb/llvm/clang/compiler-rt repos.
See http://reviews.llvm.org/D5495 for more details.
These are changes
Author: tfiala
Date: Fri Sep 26 07:58:25 2014
New Revision: 218518
URL: http://llvm.org/viewvc/llvm-project?rev=218518view=rev
Log:
gtest: modified Xcode integration so gtest assert/expect failure now shows
error content in the error marker at the line of failure.
This change modifies the
Author: tfiala
Date: Fri Sep 26 14:08:00 2014
New Revision: 218537
URL: http://llvm.org/viewvc/llvm-project?rev=218537view=rev
Log:
gtest: tweaked test runner to fix an extra comma, added more tdd-based thread
coordinator behavior.
Starting to flesh out the thread state coordinator class that
! In D5495#27, @zturner wrote:
I'm not seeing the changes to HostInfoPosix and HostThreadPosix that I
suggested. Are those still coming in a followup?
With Android, it's *mostly* Linux (at the kernel level) except we have a whole
slew of different runtime libraries that differ. So, for much
/Thread.cpp
tools/lldb-gdbserver/lldb-gdbserver.cpp
--
Best Regards, Tong Shen
--
Best Regards, Tong Shen
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
, but it would be
awkward, because you would have to create one for the sole purpose of
calling a method that is actually static.
On Fri, Sep 26, 2014 at 1:17 PM, Todd Fiala tfi...@google.com wrote:
Hey Zachary,
I just started looking at the HostInfo* classes. I'm a little confused -
we are going
of an environment
variable. If something is more complicated than that, it probably belongs
somewhere else. Do you have an example in mind that you think is a natural
fit for HostInfo, but would require calling virtual methods?
On Fri, Sep 26, 2014 at 1:32 PM, Todd Fiala tfi...@google.com wrote
If there is concern over calling a GetHostInfoInstance() or some kind of
singleton caller, we can always wrap that in static calls that do it for
us. But I'd much prefer here to have an instance with a vtable.
On Fri, Sep 26, 2014 at 1:36 PM, Todd Fiala tfi...@google.com wrote:
I think some
Author: tfiala
Date: Fri Sep 26 20:11:17 2014
New Revision: 218558
URL: http://llvm.org/viewvc/llvm-project?rev=218558view=rev
Log:
thread state coordinator: added test for notify after two pending thread stops.
Glad I did - caught a bug where the auto variable was not a reference
to a set and
Author: tfiala
Date: Fri Sep 26 20:58:13 2014
New Revision: 218559
URL: http://llvm.org/viewvc/llvm-project?rev=218559view=rev
Log:
thread state coordinator: added thread death support and more tests.
Tested two pending stops before notification, where one of the pending stop
requirements was
/Plugins/Process/Linux/ThreadStateCoordinatorTest.cpp
?
-Todd
On Thu, Sep 25, 2014 at 7:34 AM, Todd Fiala tfi...@google.com wrote:
Maybe it would be better to make a parallel gtest directory, so the
unittest2 framework crawler doesn't accidentally find its way into any of
these tests.
I'm
BTW I'll have that fixed up and checked in soon, I'm just fixing a couple
issues with build directory changes and getting it hooked into Xcode.
On Thu, Sep 25, 2014 at 10:43 AM, Todd Fiala tfi...@google.com wrote:
Yeah, took me a minute to sort that out since the Python package
to gtest already, so I think we're likely okay
there. But something to watch out for, thanks for bringing that up!
On Thu, Sep 25, 2014 at 9:59 AM, jing...@apple.com wrote:
On Sep 25, 2014, at 9:51 AM, Todd Fiala tfi...@google.com wrote:
Right - that was the reason I wanted the unittest level
test/c++/make/Makefile.rules
Deleting test/c++/native_process/thread_state_coordinator/Makefile
Deleting
test/c++/native_process/thread_state_coordinator/ThreadStateCoordinatorTest.cpp
Transmitting file data ...
Committed revision 218460.
On Thu, Sep 25, 2014 at 10:44 AM, Todd Fiala
Haha okay, jinx :-)
http://reviews.llvm.org/D5495
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: tfiala
Date: Thu Sep 25 17:12:33 2014
New Revision: 218470
URL: http://llvm.org/viewvc/llvm-project?rev=218470view=rev
Log:
gtest: remove recursive make, add python driver + Xcode error hook-up.
This change does the following:
* Removes the gtest/Makefile recursive-make-based calling
.
Also one of the uses of __ANDROID__ is to not include some python goo, but
there's already a build without python define for that purpose.
Jim
http://reviews.llvm.org/D5495
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
Sorry Tong, should have looked more closely at the Python part --- I thought we
were already excluding Python and some of these fell out after that.
RE: this patch or follow up, we don't want a quick check-in that needs a
rework, let's get it right the first time. (I see you're already working
Having a look at this now.
http://reviews.llvm.org/D5475
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: tfiala
Date: Wed Sep 24 10:55:47 2014
New Revision: 218383
URL: http://llvm.org/viewvc/llvm-project?rev=218383view=rev
Log:
Adjust to LLVM JIT API change
Those wrapper functions seems not used by lldb... Removed
Reference for
replacing JITMemoryManager with SectionMemoryManager
Author: tfiala
Date: Wed Sep 24 14:59:13 2014
New Revision: 218405
URL: http://llvm.org/viewvc/llvm-project?rev=218405view=rev
Log:
Change inline-breakpoint-strategy setting to default to
eInlineBreakpointsAlways strategy.
See thread started here for motivation:
Author: tfiala
Date: Wed Sep 24 17:57:33 2014
New Revision: 218422
URL: http://llvm.org/viewvc/llvm-project?rev=218422view=rev
Log:
The beginnings of a gtest-based test framework.
Makes use of LLVM gtest support. This does *not* run as part of
the lldb test suite.
I'm using it to start testing
svn commit
Sendingsource/Plugins/Platform/MacOSX/PlatformDarwin.cpp
Sendingsource/Plugins/Platform/MacOSX/PlatformDarwin.h
Sendingsource/Plugins/Platform/POSIX/PlatformPOSIX.cpp
Sendingsource/Plugins/Platform/POSIX/PlatformPOSIX.h
Transmitting file data
Basic tk-frames and tk-variables
tk-process and tk-variables, rather...
On Tue, Sep 23, 2014 at 11:01 AM, Todd Fiala tfi...@google.com wrote:
Basic tk-frames and tk-variables functionality seems to be working fine on
Linux FWIW in a couple simple cases I tried.
-Todd
On Mon, Sep 22, 2014
Author: tfiala
Date: Fri Sep 19 13:27:45 2014
New Revision: 218133
URL: http://llvm.org/viewvc/llvm-project?rev=218133view=rev
Log:
Fix typo in Linux ASLR logging.
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp
Yep good here too.
On Fri, Sep 19, 2014 at 2:55 PM, Ed Maste ema...@freebsd.org wrote:
This looks good to me.
http://reviews.llvm.org/D5374
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
bug surfaced by recent native thread changes
-Todd
On Fri, Sep 12, 2014 at 3:51 PM, Todd Fiala todd.fi...@gmail.com wrote:
Author: tfiala
Date: Fri Sep 12 17:51:49 2014
New Revision: 217717
URL: http://llvm.org/viewvc/llvm-project?rev=217717view=rev
Log:
llgs: fix thread names broken
Author: tfiala
Date: Mon Sep 15 10:17:13 2014
New Revision: 217772
URL: http://llvm.org/viewvc/llvm-project?rev=217772view=rev
Log:
Fix build break in Xcode build of lldb-tool.
Modified:
lldb/trunk/tools/driver/Driver.cpp
Modified: lldb/trunk/tools/driver/Driver.cpp
URL:
Author: tfiala
Date: Mon Sep 15 10:31:11 2014
New Revision: 217773
URL: http://llvm.org/viewvc/llvm-project?rev=217773view=rev
Log:
Check for byte order correctness in
GDBRemoteCommunicationClient::GetCurrentProcessInfo.
This is useful for checking inconsistencies between what the remote debug
Committed here:
svn commit
Sending
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
Transmitting file data .
Committed revision 217773.
On Fri, Sep 12, 2014 at 1:39 PM, Todd Fiala tfi...@google.com wrote:
My pleasure!
On Fri, Sep 12, 2014 at 1:38 PM, Stephane
:50 PM, Todd Fiala tfi...@google.com wrote:
I'm not averse to the change. But I stumbled across a few places in the
code where, once we see cputype/cpuinfo, we start assuming we are in Apple
code. And to keep everyone sane, if you can migrate to using triples on
non-Apple hardware, I think
Author: tfiala
Date: Mon Sep 15 11:01:29 2014
New Revision: 217779
URL: http://llvm.org/viewvc/llvm-project?rev=217779view=rev
Log:
Properly decode architecture type in
GDBRemoteCommunicationClient::GetCurrentProcessInfo.
Instead of forcing the remote arch type to MachO all the time, we
inspect
wrote:
This prevents messing up the shell's prompt.
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
Author: tfiala
Date: Mon Sep 15 11:27:44 2014
New Revision: 217782
URL: http://llvm.org/viewvc/llvm-project?rev=217782view=rev
Log:
Handle ARM ELF symbols properly: skip $t* and $a* symbols in ObjectFileELF.
ELF objects contain marker symbols to differentiate between ARM and
THUMB functions.
bit, one without). Also, differentiating
between THUMB and ARM symbols allows the debugger to place the right
type of breakpoint.
0001-Skip-t-and-a-symbols-in-ObjectFileELF.patch0002-Store-the-thumbness-of-a-function-in-symbol-flags.patch
--
Todd Fiala | Software Engineer | tfi
, at 8:46 AM, Todd Fiala tfi...@google.com wrote:
I'm going to check this out now.
Regarding cputype/cpusubtype, I think the challenge we'll run on
non-Apple platforms is that I think those constants are all controlled by
Apple (i.e. authoritative source). What happens when a gdb-remote stub
is because I’m used to exit the
debugger with ^D instead, which results in the shell prompt being printed
right after the debugger prompt (lldb).
I think I could rework this patch to print the newline only on ^D instead
of printing it all the time when we exit.
On Sep 15, 2014, at 9:21 AM, Todd Fiala
://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
All good - I just wanted to double check since I jumped the gun on Jason
last time I took it the wrong way :-)
On Mon, Sep 15, 2014 at 11:06 AM, Jim Ingham jing...@apple.com wrote:
Sorry if I wasn’t clear, this looks fine. Check it in.
Jim
On Sep 15, 2014, at 7:55 AM, Todd Fiala tfi
Submitted here:
```
svn commit
Sendinginclude/lldb/Core/Communication.h
Sendinginclude/lldb/Core/ConnectionFileDescriptor.h
Sendinginclude/lldb/Target/Process.h
Sendingsource/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
Sending
Author: tfiala
Date: Mon Sep 15 15:07:33 2014
New Revision: 217818
URL: http://llvm.org/viewvc/llvm-project?rev=217818view=rev
Log:
use std::atomic to protect variables being accessed by multiple threads
There are several places where multiple threads are accessing the same
variables
Looks good - change went in here:
svn commit
Sendingsource/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
Sendingsource/Plugins/ObjectFile/ELF/ObjectFileELF.h
Transmitting file data ..
Committed revision 217841.
On Mon, Sep 15, 2014 at 3:30 PM, Todd Fiala tfi...@google.com wrote
Thanks, Paul. Having a look at this now.
http://reviews.llvm.org/D5232
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
svn commit
Sendingsource/Plugins/Process/Linux/ProcessMonitor.cpp
Transmitting file data .
Committed revision 217691.
http://reviews.llvm.org/D5232
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
I'm going to go ahead and get this in since I didn't hear any feedback.
(Working through your backlog of patches, Stephane...)
On Fri, Sep 5, 2014 at 8:11 AM, Todd Fiala tfi...@google.com wrote:
This looks reasonable; however, I’d like to hear the Apple guys since I’m
not sure if there’s any
a build error on MacOSX at the moment that is stalling me
looking at this further. I'll get back on this (and other patches) once it
is resolved.
-Todd
On Fri, Sep 12, 2014 at 10:09 AM, Todd Fiala tfi...@google.com wrote:
I'm going to go ahead and get this in since I didn't hear any feedback
My pleasure!
On Fri, Sep 12, 2014 at 1:38 PM, Stephane Sezer s...@fb.com wrote:
Thanks a lot, Todd :)
On Sep 12, 2014, at 10:09 AM, Todd Fiala tfi...@google.com wrote:
I'm going to go ahead and get this in since I didn't hear any feedback.
(Working through your backlog of patches
Adding Keno...
http://reviews.llvm.org/D5339
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: tfiala
Date: Fri Sep 12 17:51:49 2014
New Revision: 217717
URL: http://llvm.org/viewvc/llvm-project?rev=217717view=rev
Log:
llgs: fix thread names broken by recent native thread changes.
* Fixes the local stack variable return pointer usage in
NativeThreadLinux::GetName().
* Changes
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo
Author: tfiala
Date: Thu Sep 11 12:29:12 2014
New Revision: 217607
URL: http://llvm.org/viewvc/llvm-project?rev=217607view=rev
Log:
DWARF64 Fixes
1. DW_FORM_strp and DW_FORM_sec_offset are 64bits for DWARF64 / 32bits for
DWARF32
They are different from DW_FORM_addr, whose size is specified in
svn commit
Sendingsource/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
Sendingsource/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
Sendingsource/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
Sendingsource/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
:-)
On Thu, Sep 11, 2014 at 10:39 AM, Tong Shen endlessr...@google.com wrote:
Thanks Todd!
http://reviews.llvm.org/D5307
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits
Author: tfiala
Date: Thu Sep 11 18:29:14 2014
New Revision: 217647
URL: http://llvm.org/viewvc/llvm-project?rev=217647view=rev
Log:
llgs: fix Ctrl-C inferior interrupt handling to do the right thing.
* Sends a SIGSTOP to the process.
* Fixes busted SIGSTOP handling. Now builds a list of
mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
--
Todd Fiala | Software Engineer | tfi...@google.com | 650-943-3180
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman
everywhere in
theory.
On Sep 10, 2014, at 10:36 AM, Todd Fiala tfi...@google.com wrote:
Hey Stephane!
On this patch, one of the things I'm seeing is that it appears you are
(maybe?) sending cputype and cpusubtype in cases where the target is not a
MachO-based system. In general, the cputype
LGTM.
http://reviews.llvm.org/D5221
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Hey Paul,
The change looks fine.
Minor formatting nit. Could you adjust your bracing style to match the rest of
the code, though? You can either filter it through the clang formatter (there
was a thread on how to do that within the last 2 - 3 weeks on lldb-dev or
lldb-commits) or adjust the
1 - 100 of 375 matches
Mail list logo
