I reversed this out with this change:
```
svn commit
Sendinginclude/lldb/Expression/ClangExpressionParser.h
Sendinginclude/lldb/Target/Target.h
Sendingsource/Expression/ClangExpressionParser.cpp
Sendingsource/Expression/ClangFunction.cpp
Sending
Drats.
Enrico, did your recent commit fix that?
On Tue, Oct 7, 2014 at 3:59 PM, Enrico Granata egran...@apple.com wrote:
Heads up. This patch seems to be the cause of
http://llvm.org/bugs/show_bug.cgi?id=21190
Essentially, the command parser gets confused with commands like:
type summary
FYI Tong's internship is up, so his @google.com email address will show up as
unreachable.
It looks like this change has introduced this bug:
http://llvm.org/bugs/show_bug.cgi?id=21190
http://reviews.llvm.org/D5472
___
lldb-commits mailing list
Heads up. This patch seems to be the cause of
http://llvm.org/bugs/show_bug.cgi?id=21190
http://llvm.org/bugs/show_bug.cgi?id=21190
Essentially, the command parser gets confused with commands like:
type summary add Rectangle --summary-string Category1 -w Category1
and the value for the -w
It's ugly to have to add quotes and then remove them, but until we write our
own option parser I can't think of a better way to do it...
Jim
http://reviews.llvm.org/D5472
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
It's ugly to have to add quotes and then remove them, but until we write our
own option parser I can't think of a better way to do it...
Jim
On Oct 2, 2014, at 8:33 AM, Todd Fiala tfi...@google.com wrote:
I tested this with the lldb docs for 'type summary' here:
It's ugly to have to add quotes and then remove them, but until we write
our own option parser I can't think of a better way to do it...
Ok - I'll take that as a okay for now, let's revisit later response.
I'll get this in.
On Mon, Oct 6, 2014 at 3:08 PM, Jim Ingham jing...@apple.com wrote:
I tested this with the lldb docs for 'type summary' here:
http://lldb.llvm.org/varformats.html, using the floating point type summary
example:
```
type summary add --summary-string Sign: ${var[31]%B} Exponent: ${var[30-23]%x}
Mantissa: ${var[0-22]%u} float
```
That seemed to work in the
Hey Tong,
Some feedback:
* The jit-ness of this is more or less an implementation detail. Naming it
something related to expression evaluation seems like a better fit. Maybe
something like evaluation-compiler-args.
* See question on custom handling that one arg in CommandObjectSettings.cpp.
Address Jim's comments
- Rename jit-args to expr-parser-compiler-args.
- Add a common functionality for Args: if one argument is surrounded by quote
char, don't consider it as an command option.
http://reviews.llvm.org/D5472
Files:
include/lldb/Expression/ClangExpressionParser.h
10 matches
Mail list logo
