Re: [Lldb-commits] [PATCH] D13094: LLDB-MI: Fix assignment operator in CMIUtilString

evgeny777 added a comment. Also in MI empty value and NULL value almost always mean "no output". Checking for NULL everywhere is just not convenient http://reviews.llvm.org/D13094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13094: LLDB-MI: Fix assignment operator in CMIUtilString

evgeny777 added inline comments. Comment at: tools/lldb-mi/MIUtilString.cpp:41 @@ -40,3 +40,3 @@ CMIUtilString::CMIUtilString(const char *vpData) -: std::string(vpData) +: std::string(vpData != nullptr ? vpData : "") { ki.stfu wrote: > Not sure about

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

labath added a comment. I don't want to stand in the way of progress (and I do think that getting rid of the timeout dependency is progress), but this implementation regresses in a couple of features compared to using timeout: - timeout tries (with moderate success) to cleanup children spawned

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

evgeny777 updated this revision to Diff 35607. evgeny777 added a comment. Revised according to suggestions from granta.enrico and ki.stfu http://reviews.llvm.org/D13058 Files: include/lldb/API/SBTypeSummary.h source/API/SBTypeSummary.cpp

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

tfiala added a subscriber: tfiala. tfiala added a comment. Are you all still seeing this now? I am heading to sleep but can have a look early in the morning... Users: dawn (Auditor) http://reviews.llvm.org/rL248338 ___ lldb-commits mailing list

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

Are you all still seeing this now? I am heading to sleep but can have a look early in the morning... On Wed, Sep 23, 2015 at 10:09 PM, Bruce Mitchener via lldb-commits < lldb-commits@lists.llvm.org> wrote: > brucem added a subscriber: brucem. > brucem added a comment. > > I ran into this myself

[Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

tfiala created this revision. tfiala added reviewers: zturner, clayborg, labath. tfiala added a subscriber: lldb-commits. For all the parallel test runners, provide a pure-Python mechanism for timing out dotest inferior processes that run for too long. Stock OS X and Windows do not have a

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

tfiala added inline comments. Comment at: test/curses_results.py:223 @@ -223,1 +222,3 @@ +# Greg - not sure why this is here. It locks up on exit. +# self.main_window.key_event_loop()

Re: [Lldb-commits] [PATCH] D13094: LLDB-MI: Fix assignment operator in CMIUtilString

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Your fix in assign operator looks good. Others go out of scope of this CL, so please revert them. Comment at: tools/lldb-mi/MIUtilString.cpp:41 @@ -40,3 +40,3 @@

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

brucem added a comment. Yes. With a change that I'm going to submit for review: batavia:build-llvm bruce$ bin/lldb bin/clang (lldb) target create "bin/clang" Current executable set to 'bin/clang' (x86_64). (lldb) b main Breakpoint 1: where = clang`main, address = 0x00012890

[Lldb-commits] [lldb] r248466 - Improve error reporting for failing to find argdumper.

Author: brucem Date: Thu Sep 24 02:08:29 2015 New Revision: 248466 URL: http://llvm.org/viewvc/llvm-project?rev=248466=rev Log: Improve error reporting for failing to find argdumper. Reviewers: tfiala, granata.enrico, clayborg Subscribers: lldb-commits Differential Revision:

Re: [Lldb-commits] [PATCH] D13125: Improve error reporting for failing to find argdumper.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248466: Improve error reporting for failing to find argdumper. (authored by brucem). Changed prior to commit: http://reviews.llvm.org/D13125?vs=35590=35591#toc Repository: rL LLVM

Re: [Lldb-commits] [lldb] r248401 - DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

On Thu, Sep 24, 2015 at 6:47 AM, Siva Chandra wrote: > > > On Thu, Sep 24, 2015 at 6:40 AM, Ed Maste wrote: > >> The test case fails on FreeBSD right now because there's no error on >> "limit" and "nolimit": >> >> (lldb) expr f >> (Foo) $0 = (s =

Re: [Lldb-commits] [PATCH] D13094: LLDB-MI: Fix assignment operator in CMIUtilString

brucem added a comment. It doesn't seem right to have a strong construction and copy just to determine the length or if it is empty or not as in your examples. That would be appropriate for a helper function. http://reviews.llvm.org/D13094 ___

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

evgeny777 updated this revision to Diff 35618. evgeny777 added a comment. Revised, removed dependencies from http://reviews.llvm.org/D13094 http://reviews.llvm.org/D13058 Files: include/lldb/API/SBTypeSummary.h source/API/SBTypeSummary.cpp

Re: [Lldb-commits] [PATCH] D13094: LLDB-MI: Fix assignment operator in CMIUtilString

brucem added a subscriber: brucem. brucem added a comment. http://reviews.llvm.org/D13094 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r248401 - DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

On Thu, Sep 24, 2015 at 6:40 AM, Ed Maste wrote: > The test case fails on FreeBSD right now because there's no error on > "limit" and "nolimit": > > (lldb) expr f > (Foo) $0 = (s = "qwerty") > (lldb) expr s > (MyString) $1 = (std::__1::string = "qwerty") > Does

Re: [Lldb-commits] [lldb] r248401 - DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

I don't have access to a FreeBSD or a mac at the moment. Can you, or someone else, check how -fstandalone-debug and -fno-standalone-debug behave? On Thu, Sep 24, 2015 at 6:57 AM, Siva Chandra wrote: > On Thu, Sep 24, 2015 at 6:47 AM, Siva Chandra

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

tfiala added a comment. In http://reviews.llvm.org/D13124#252564, @labath wrote: > I don't want to stand in the way of progress (and I do think that getting rid > of the timeout dependency is progress), but this implementation regresses in > a couple of features compared to using timeout: > >

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

tfiala added a comment. I filed this: https://llvm.org/bugs/show_bug.cgi?id=24926 And I'm starting to look at it now. Users: dawn (Auditor) http://reviews.llvm.org/rL248338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

labath added a comment. I haven't followed the recent changes too closely, but at some point the hierarchy was: dosep.py dosep.py fork timeout dotest.py (lldb client) lldb-server inferior other executables which were sometimes spawned by the

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

labath added a comment. In http://reviews.llvm.org/D13124#252791, @tfiala wrote: > In http://reviews.llvm.org/D13124#252564, @labath wrote: > > > I don't want to stand in the way of progress (and I do think that getting > > rid of the timeout dependency is progress), but this implementation >

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

tfiala added a comment. In http://reviews.llvm.org/D13124#252784, @zturner wrote: > If I understand correctly, the process hierarchy used to look like this: > > python - dotest.py > |__ python - multiprocessing fork > > |__ python - lldbtest > |__ inferior executable > > > And now

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

tfiala added a comment. > Thanks for working on this once again :) Sure thing! http://reviews.llvm.org/D13124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

tfiala added a comment. > What is happening is that it is looking for argdumper and not finding it. > This happens because it is looking in the lib directory within the build > directory, but argdumper is in the bin directory (where it should be). I'm not sure I would say that is accurate.

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

dawn added a comment. Is there a workaround for this? Ok to revert this commit until it is fixed? It's blocker for me. Thanks. Users: dawn (Auditor) http://reviews.llvm.org/rL248338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

clayborg added a comment. Each shared library is an object that can be shared between multiple targets. We do not want to injecting types from another shared library into the static notion of what a type is within a shared library. Why? What if one target in lldb loads liba.so which has a

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

tfiala added a comment. > Which reminds me of another thing: Since you're working heavily on the tet > suite, one thing I've always wanted is what I just mentioned: Something > like an lldbxplat module which is essentially a helper module that exposes > a single interface for doing things

[Lldb-commits] LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

I'm ok with leaving some straggling processes on Windows for now, because it's obviously better than what we have currently, which is nothing. I can implement some sort of helper module at some point that exposes a new createProcess function that supports this for Windows and Unix with a single

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

tfiala added a comment. I do intend to get back to this after resolving the cmake build issue on OS X. Hopefully by tonight. http://reviews.llvm.org/D13124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r248401 - DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

On Thu, Sep 24, 2015 at 2:15 PM, Ed Maste wrote: > On 24 September 2015 at 10:04, Siva Chandra > wrote: > > I don't have access to a FreeBSD or a mac at the moment. Can you, or > someone > > else, check how -fstandalone-debug and -fno-standalone-debug

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

tfiala added a comment. The cmake OS X fix went in here: Sendingsource/Host/macosx/HostInfoMacOSX.mm Transmitting file data . Committed revision 248545. Let me know if you still have trouble after that. Users: dawn (Auditor) http://reviews.llvm.org/rL248338

[Lldb-commits] [lldb] r248541 - [TestCppIncompleteTypes] Remove the dependence on std::string.

Author: sivachandra Date: Thu Sep 24 16:29:54 2015 New Revision: 248541 URL: http://llvm.org/viewvc/llvm-project?rev=248541=rev Log: [TestCppIncompleteTypes] Remove the dependence on std::string. Reviewers: dblaikie, clayborg Subscribers: lldb-commits Differential Revision:

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

tfiala added a comment. > Hi Todd, yes, I read the bug report and updated my comment while you were > writing yours :) Great! Once I validate that the standard OS X build isn't busted (in progress), I'll get it checked in. Users: dawn (Auditor) http://reviews.llvm.org/rL248338

[Lldb-commits] [PATCH] D13149: Create GoLanguageRuntime

ribrdb created this revision. ribrdb added a reviewer: clayborg. ribrdb added a subscriber: lldb-commits. ribrdb set the repository for this revision to rL LLVM. GoLanguageRuntime supports finding the runtime type for Go interfaces. Repository: rL LLVM http://reviews.llvm.org/D13149 Files:

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

tfiala added a comment. Hi Dawn, See https://llvm.org/bugs/show_bug.cgi?id=24926 for a workaround. I'm developing a fix for it. Still testing but what is there in that patch (in the bug) works for your build scenario as long as you add '--executable /path/to/your/just/build/lldb' when

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

Also,when you say the next iteration, is this something that is going to happen at an unknown time in the future whenever you happen to touch it again, or are you working on another iteration now? On Thu, Sep 24, 2015 at 4:25 PM Zachary Turner wrote: > To be clear, I would

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

zturner added a comment. To be clear, I would like this Makefile to turn into the following: LEVEL = ../../../make CXX_SOURCES = main.cpp length.cpp DEBUG_INFO_FULL = True DEBUG_INFO_LIMITED = True And that's it. You shouldn't need anything else. Whatever needs to happen in Makefile.rules

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

To be clear, I would like this Makefile to turn into the following: LEVEL = ../../../make CXX_SOURCES = main.cpp length.cpp DEBUG_INFO_FULL = True DEBUG_INFO_LIMITED = True And that's it. You shouldn't need anything else. Whatever needs to happen in Makefile.rules to make this work should be

Re: [Lldb-commits] [lldb] r248401 - DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

On 24 September 2015 at 10:04, Siva Chandra wrote: > I don't have access to a FreeBSD or a mac at the moment. Can you, or someone > else, check how -fstandalone-debug and -fno-standalone-debug behave? Both OS X and FreeBSD default to full debug info, but the enable /

[Lldb-commits] [lldb] r248545 - Fix tests on cmake-based OS X after rL248338

Author: tfiala Date: Thu Sep 24 16:59:48 2015 New Revision: 248545 URL: http://llvm.org/viewvc/llvm-project?rev=248545=rev Log: Fix tests on cmake-based OS X after rL248338 See: https://llvm.org/bugs/show_bug.cgi?id=24926 for details. On OS X, when LLDB.framework is not part of the lldb.dylib

[Lldb-commits] [PATCH] D13147: [TestCppIncompleteTypes] Handle different archs when building a.o.

sivachandra created this revision. sivachandra added a reviewer: chying. sivachandra added a subscriber: lldb-commits. http://reviews.llvm.org/D13147 Files: test/lang/cpp/incomplete-types/Makefile Index: test/lang/cpp/incomplete-types/Makefile

[Lldb-commits] [PATCH] D13154: [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address

bhushan created this revision. bhushan added a reviewer: clayborg. bhushan added subscribers: lldb-commits, nitesh.jain, mohit.bhakkad, sagar, jaydeep. bhushan set the repository for this revision to rL LLVM. In MIPS, an application elf can contain mixed code (mips + micromips) i.e some

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

KLapshin added a comment. @clayborg, @labath, After more deep investigation I think setting listener for hijacking also looks like workaround. Setting additional listener just change code flow path and buggy path not executed, thus no crash. At top level - crash appeared in

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

zturner added a comment. I know, I've seen them in a few places myself. But I think we should move away from that, because it's a large source of portability problems http://reviews.llvm.org/D13066 ___ lldb-commits mailing list

Re: [Lldb-commits] [lldb] r248401 - DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

On Thu, Sep 24, 2015 at 4:57 PM, Ed Maste wrote: > On 24 September 2015 at 17:35, Siva Chandra > wrote: > > > > As blaikie pointed out on the review, it could be because libc++ (which > is > > the default on FreeBSD and Darwin?) does not have an

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

dawn accepted this commit. dawn added a comment. Fixed by Todd in r248545. Todd rocks!!! :) Users: dawn (Auditor) http://reviews.llvm.org/rL248338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13124: test runner: switch to pure-Python timeout mechanism

tfiala added a comment. > That's a good idea. I'm (somewhat slowly) attempting to work in some clean up > each time I touch it. I'll hit that at some point. I'll start winding down on > changes to the test infrastructure soon-ish. If I don't hit that by the time > I stop heavy changes,

Re: [Lldb-commits] [Diffusion] rL248338: Move the "run" alias from process launch --shell to process launch --shell…

tfiala added a comment. > Fixed by Todd in r248545. Oh good! > Todd rocks!!! :) You are far too kind :-) Users: dawn (Auditor) http://reviews.llvm.org/rL248338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r248555 - Fix evaluation of unicode character arrays (char16_t[] and char32_t[])

Author: dperchik Date: Thu Sep 24 21:16:52 2015 New Revision: 248555 URL: http://llvm.org/viewvc/llvm-project?rev=248555=rev Log: Fix evaluation of unicode character arrays (char16_t[] and char32_t[]) Suppose we have the UTF-16 string: char16_t[] s = u"hello"; Before this patch, evaluating