[Lldb-commits] [lldb] r284799 - Guard GetEscapedHostname against a nullptr hostname.

Author: jmolenda Date: Thu Oct 20 21:32:08 2016 New Revision: 284799 URL: http://llvm.org/viewvc/llvm-project?rev=284799=rev Log: Guard GetEscapedHostname against a nullptr hostname. This can happen if you debug an iOS corefile on a mac, where PlatformPOSIX::GetHostname ends up not providing a

[Lldb-commits] [lldb] r284795 - Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands.

Author: jingham Date: Thu Oct 20 19:06:38 2016 New Revision: 284795 URL: http://llvm.org/viewvc/llvm-project?rev=284795=rev Log: Fix a race condition between "ephemeral watchpoint disable/enable" and continue in commands. Also, watchpoint commands, like breakpoint commands, need to run in async

[Lldb-commits] Buildbot numbers for the week of 10/2/2016 - 10/8/2016

Hello everyone, Below are some buildbot numbers for the week of 10/2/2016 - 10/8/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

[Lldb-commits] Buildbot numbers for the week of 10/9/2016 - 10/15/2016

Hello everyone, Below are some buildbot numbers for the last week of 10/9/2016 - 10/15/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

[Lldb-commits] [lldb] r284792 - Add an API to remove an action from the Process PreResumeActions.

Author: jingham Date: Thu Oct 20 17:50:00 2016 New Revision: 284792 URL: http://llvm.org/viewvc/llvm-project?rev=284792=rev Log: Add an API to remove an action from the Process PreResumeActions. Modified: lldb/trunk/include/lldb/Target/Process.h lldb/trunk/source/Target/Process.cpp

[Lldb-commits] [lldb] r284791 - Remove an unnecessary and incorrect check for num locations of a breakpoint

Author: jingham Date: Thu Oct 20 17:49:06 2016 New Revision: 284791 URL: http://llvm.org/viewvc/llvm-project?rev=284791=rev Log: Remove an unnecessary and incorrect check for num locations of a breakpoint by grubbing the break list output. If you pass a number of locations into the run_break_*

[Lldb-commits] [lldb] r284788 - frame.script became script.frame a while ago; fix up the docs

Author: enrico Date: Thu Oct 20 17:10:07 2016 New Revision: 284788 URL: http://llvm.org/viewvc/llvm-project?rev=284788=rev Log: frame.script became script.frame a while ago; fix up the docs Modified: lldb/trunk/www/formats.html Modified: lldb/trunk/www/formats.html URL:

[Lldb-commits] [lldb] r284787 - This debugging message has been left in the code for years, until one day it randomly hit on some corrupted memory

Author: enrico Date: Thu Oct 20 17:05:21 2016 New Revision: 284787 URL: http://llvm.org/viewvc/llvm-project?rev=284787=rev Log: This debugging message has been left in the code for years, until one day it randomly hit on some corrupted memory It is misleading to users in its current form, and

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

krytarowski added a comment. I think it's possible to specify `-DLLVM_CONFIG:PATH` option, if that does the job. Repository: rL LLVM https://reviews.llvm.org/D25830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

labath added subscribers: krytarowski, Eugene.Zelenko. labath added a comment. +cc: lldb standalone users I'll defer to @beanz on this. Repository: rL LLVM https://reviews.llvm.org/D25830 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D25832: Minidump plugin: Adding x86_32 register context converter

dvlahovski created this revision. dvlahovski added reviewers: labath, zturner. dvlahovski added subscribers: lldb-commits, amccarth. Herald added subscribers: modocache, mgorny, beanz. This, like the x86_64 case, reads the register values from the minidump file, and emits a binary buffer that is

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

mgorny added a comment. I agree. Don't introduce redundant variables when the same result can be achieved using existing means. (note that `find_program` makes `LLVM_CONFIG` a cache variable implicity, so you don't need to have any explicit support for altering it) Repository: rL LLVM

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

emaste added a comment. On a quick look this seems OK. I'll try to test/review in detail. Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:925 + + // eRegisterKindDWARF -> RegsiterValue + std::unordered_map m_register_values;

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

emaste added a comment. In https://reviews.llvm.org/D25756#574258, @labath wrote: > No, I'm saying someone *should*. :P > > Ed looked into that at some point but, I don't think get got too far with it. > Adding @emaste, who should probably review this. Yes, it needs to be done. Maybe now that

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

beanz requested changes to this revision. beanz added a comment. This revision now requires changes to proceed. `LLDB_PATH_TO_LLVM_BUILD` is a swift-ism that doesn't match LLVM's CMake conventions. In LLVM we don't pass in the path to build directories, instead we pass in `LLVM_CONFIG` to

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

tfiala added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:20 + find_program(LLVM_CONFIG "llvm-config" +HINTS ${FIND_PATHS}) if(LLVM_CONFIG) One question here would be what happens if FIND_PATHS stays "". Does find_program deal with

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

tfiala added a comment. (It would be good to wait for feedback from the others, though). Repository: rL LLVM https://reviews.llvm.org/D25830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D25830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context

This revision was automatically updated to reflect the committed changes. Closed by commit rL284741: Minidump plugin: redesign the x86_64 register context (authored by dvlahovski). Changed prior to commit: https://reviews.llvm.org/D25677?vs=75154=75309#toc Repository: rL LLVM

[Lldb-commits] [lldb] r284741 - Minidump plugin: redesign the x86_64 register context

Author: dvlahovski Date: Thu Oct 20 11:01:36 2016 New Revision: 284741 URL: http://llvm.org/viewvc/llvm-project?rev=284741=rev Log: Minidump plugin: redesign the x86_64 register context Summary: I misunderstood the format of the register context layout. I thought it was a dynamically changing

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

tberghammer updated this revision to Diff 75300. tberghammer marked 5 inline comments as done. https://reviews.llvm.org/D25726 Files: packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/smart_ptr/TestDataFormatterStdSmartPtr.py

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

tberghammer added inline comments. Comment at: source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp:138 +return 3; + return UINT32_MAX; +} labath wrote: > I know you just copied it, but this seems wrong (size_t can be 64-bit). Will > this work if

[Lldb-commits] [lldb] r284725 - Re-generate the python and cpp reference documentation

Modified: lldb/trunk/www/python_reference/toc-lldb.formatters.cpp.gnu_libstdcpp-module.html URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/www/python_reference/toc-lldb.formatters.cpp.gnu_libstdcpp-module.html?rev=284725=284724=284725=diff

[Lldb-commits] [PATCH] D25783: [Host] handle short reads and writes

labath added a comment. In https://reviews.llvm.org/D25783#574873, @zturner wrote: > In https://reviews.llvm.org/D25783#574860, @labath wrote: > > > > This can happen with any number of bytes and at any time. `write`, > > > `read`, and all other related functions will return a non-negative

Re: [Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

The reason you could not see this is that the issue is specific to arm (or any target that reports watchpoint hits *before* executing the instruction tripping the watch). In this case, we have special logic in the client which removes the watchpoint, does a single step, and reinstates the

Re: [Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

On 19 October 2016 at 18:39, Jim Ingham wrote: > >> On Oct 19, 2016, at 10:38 AM, Jim Ingham via lldb-commits >> wrote: >> >> >>> On Oct 19, 2016, at 6:35 AM, Pavel Labath via lldb-commits >>> wrote: >>> >>> >>>

[Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL284706: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate… (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D25057?vs=75103=75272#toc Repository: rL

[Lldb-commits] [lldb] r284706 - Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

Author: omjavaid Date: Thu Oct 20 04:07:26 2016 New Revision: 284706 URL: http://llvm.org/viewvc/llvm-project?rev=284706=rev Log: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints This patch fixes ARM/AArch64 watchpoint bug which was taking inferior out of