kubabrecka created this revision.
kubabrecka added reviewers: clayborg, jasonmolenda, jingham.
kubabrecka added subscribers: lldb-commits, zaks.anna.
kubabrecka set the repository for this revision to rL LLVM.
kubabrecka added a project: Sanitizers.
https://reviews.llvm.org/D27012 will add more
labath updated this revision to Diff 78895.
labath added a comment.
A new version, which uses a helper class which enables all the implicit
conversions that one would normally expect from the duration classes.
Things left TBD:
- name
- where to put it
- whether inheriting from Optional is fine
labath added a comment.
I suppose we could create a new class (I am not sure what a good name for that
would be... `OptionalDuration`, which inherits from `llvm:Optional`, but
provides the additional conversion operator to make things work seamlessly.
Something like:
template
class
zturner added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:56
-response,
-
std::chrono::duration_cast(kInterruptTimeout)
-.count(),
I think we should all be willing to agree that `using
clayborg added a comment.
Is there anything we need to do on this review?
https://reviews.llvm.org/D24610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I am not sure this is the right fix. This fix would mean that any IOHandler
would always be interactive even if the user didn't want it to be. A better fix
would be to make a
zturner added a comment.
In https://reviews.llvm.org/D26971#602738, @clayborg wrote:
> It would be nice if we can find a way to be able to use any time units we
> want when specifying the timeout. I would rather not have everyone have to
> convert their times to microseconds. Maybe we just add
Author: zturner
Date: Tue Nov 22 11:10:15 2016
New Revision: 287647
URL: http://llvm.org/viewvc/llvm-project?rev=287647=rev
Log:
Re-add "demonstrate new Args API"
This fixes the build breakage due to the use of C++14.
Modified:
lldb/trunk/include/lldb/Interpreter/Args.h
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We will need to take a look at the existing assert calls within LLDB and within
LLVM to make sure we won't cause things to crash at a later time with no
context as to what
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
It would be nice if we can find a way to be able to use any time units we want
when specifying the timeout. I would rather not have everyone have to convert
their times to
10 matches
Mail list logo
