Re: [Lldb-commits] [lldb] r289711 - Adopt PrettyStackTrace in LLDB

On Wed, Dec 14, 2016 at 1:41 PM Sean Callanan via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Modified: lldb/trunk/source/API/SBFrame.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBFrame.cpp?rev=289711&r1=289710&r2=289711&view=diff > > =

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

zturner added inline comments. Comment at: lldb/source/Interpreter/Options.cpp:728 +for (auto &def : range) { + std::string full_name("--"); + full_name.append(def.long_option); clayborg wrote: > Do we still need std::string here for ful

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

zturner added a comment. In response to all the questions about "Will a StringRef constructor be called on XXX", the answer is usually yes, but the constructor will be inlined and invoke `__builtin_strlen` (which is constexpr on GCC and Clang) when used on a string literal. In other words, the

[Lldb-commits] [lldb] r289746 - Fix incorrectly named variables.

Author: jingham Date: Wed Dec 14 18:30:30 2016 New Revision: 289746 URL: http://llvm.org/viewvc/llvm-project?rev=289746&view=rev Log: Fix incorrectly named variables. Modified: lldb/trunk/source/API/SBFrame.cpp lldb/trunk/source/API/SBTarget.cpp lldb/trunk/source/Interpreter/CommandIn

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

clayborg added a comment. There seems to be a bunch of places that we are passing a string literal to functions that take a StringRef. Can we pass L("--") instead of "--" to functions that take a string ref and have it be more efficient so a StringRef isn't implicitly constructed for us each ti

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

zturner created this revision. zturner added reviewers: clayborg, labath. zturner added a subscriber: lldb-commits. The major blocker to this until now has been that we can't have global constructors, no matter how trivial. Recently LLVM obtained the `StringLiteral` class which addresses this.

[Lldb-commits] [lldb] r289711 - Adopt PrettyStackTrace in LLDB

Author: spyffe Date: Wed Dec 14 15:31:31 2016 New Revision: 289711 URL: http://llvm.org/viewvc/llvm-project?rev=289711&view=rev Log: Adopt PrettyStackTrace in LLDB LLDB needs some minor changes to adopt PrettyStackTrace after https://reviews.llvm.org/D27683. We remove our own SetCrashDescription

[Lldb-commits] [lldb] r289695 - Test num locations >= 1 not == 1.

Author: jingham Date: Wed Dec 14 13:35:56 2016 New Revision: 289695 URL: http://llvm.org/viewvc/llvm-project?rev=289695&view=rev Log: Test num locations >= 1 not == 1. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py

[Lldb-commits] [PATCH] D27759: Fix build for mingw.

labath added a comment. Yeah, I meant using it everywhere as a generic "am I on windows, regardless of the compiler" check. (Assuming Zach is fine with that) https://reviews.llvm.org/D27759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D27759: Fix build for mingw.

abidh added a comment. > BTW, I am curious, are you planning on building python with mingw as well? If > you are, I'd be interested in knowing how that works out. I would like to do it but have not done it yet. I will keep you posted. Comment at: cmake/modules/LLDBConfig.cmak

[Lldb-commits] [PATCH] D27759: Fix build for mingw.

zturner added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:246 +if (MSVC) +add_definitions( /D _UNICODE /D UNICODE ) +elseif (MINGW) labath wrote: > Could you check if it's enough to pass `-DFOO` regardless of the platform. > This is the only

[Lldb-commits] [PATCH] D27759: Fix build for mingw.

labath added a comment. I'll leave Zachary to approve, but it seems reasonable. BTW, I am curious, are you planning on building python with mingw as well? If you are, I'd be interested in knowing how that works out. Comment at: cmake/modules/LLDBConfig.cmake:246 +if (MSVC) +

[Lldb-commits] [PATCH] D27759: Fix build for mingw.

abidh created this revision. abidh added reviewers: labath, zturner. abidh added a subscriber: lldb-commits. Herald added subscribers: mgorny, ki.stfu. I was building lldb using cross mingw-w64 toolchain on Linux and observed some issues. This is first patch in the series to fix that build. It mo

[Lldb-commits] [lldb] r289647 - Replace APFloatBase static fltSemantics data members with getter functions

Author: sberg Date: Wed Dec 14 05:57:17 2016 New Revision: 289647 URL: http://llvm.org/viewvc/llvm-project?rev=289647&view=rev Log: Replace APFloatBase static fltSemantics data members with getter functions At least the plugin used by the LibreOffice build (

[Lldb-commits] [PATCH] D27707: Remove code needed for supporting old VS versions.

abidh accepted this revision. abidh added a reviewer: abidh. abidh added a comment. This revision is now accepted and ready to land. Accepted on email. https://reviews.llvm.org/D27707 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://

[Lldb-commits] [lldb] r289644 - Remove code needed for supporting old VS versions.

Author: abidh Date: Wed Dec 14 05:13:03 2016 New Revision: 289644 URL: http://llvm.org/viewvc/llvm-project?rev=289644&view=rev Log: Remove code needed for supporting old VS versions. Summary: This code was probably needed to support VS2013 and is not needed now. I have built it with VS and mingw