[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2017-01-03 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. Instead of creating header SBDwarf.h, is it possible that python can reuse llvm Dwarf.h ? Thanks https://reviews.llvm.org/D27088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2017-01-03 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 83012. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D27088 Files: include/lldb/API/SBDwarf.h packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py

[Lldb-commits] [lldb] r290934 - [CMake] Fix install rules for tools included in the framework

2017-01-03 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Tue Jan 3 21:36:35 2017 New Revision: 290934 URL: http://llvm.org/viewvc/llvm-project?rev=290934=rev Log: [CMake] Fix install rules for tools included in the framework The logic for install rules was wrong for tools included in the framework if the framework build is

[Lldb-commits] [lldb] r290917 - Remove SymbolFilePDBTests.cpp from the list of tests to include in the

2017-01-03 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jan 3 18:01:25 2017 New Revision: 290917 URL: http://llvm.org/viewvc/llvm-project?rev=290917=rev Log: Remove SymbolFilePDBTests.cpp from the list of tests to include in the lldb-gtest binary that xcode builds for -scheme lldb-gtest; these tests won't run on macosx

Re: [Lldb-commits] [lldb] r290819 - [unittests] Split DWARF tests out of PDB, fix standalone build

2017-01-03 Thread Tim Hammerquist via lldb-commits
It may also be the addition of a source file not being added to the Xcode project. This is currently handled by manual changes to the xcodeproj. -Tim On Tue, Jan 3, 2017 at 9:41 AM, Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > I bet it's the Xcode build not

Re: [Lldb-commits] [lldb] r290819 - [unittests] Split DWARF tests out of PDB, fix standalone build

2017-01-03 Thread Pavel Labath via lldb-commits
I bet it's the Xcode build not replicating the if (LLVM_ENABLE_DIA_SDK) add_subdirectory(PDB) endif() and trying to run the PDB test even though it shouldn't. (I don't really have a good idea on how to fix this.) pl On 3 January 2017 at 17:36, Zachary Turner via lldb-commits

Re: [Lldb-commits] [lldb] r290819 - [unittests] Split DWARF tests out of PDB, fix standalone build

2017-01-03 Thread Zachary Turner via lldb-commits
Hi Michal, It looks like this patch may have broken this bot. http://lab.llvm.org:8080/green/job/lldb_build_test/23767/consoleFull#-1083450927b825e790-484f-4586-af29-73c4754ff671 What do you think? On Mon, Jan 2, 2017 at 10:31 AM Michal Gorny via lldb-commits < lldb-commits@lists.llvm.org>

[Lldb-commits] [PATCH] D28233: Improve the performance of jModulesInfo in lldb-server

2017-01-03 Thread Tamas Berghammer via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL290895: Improve the performance of jModulesInfo in lldb-server (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D28233?vs=82884=82897#toc Repository: rL LLVM

[Lldb-commits] [lldb] r290895 - Improve the performance of jModulesInfo in lldb-server

2017-01-03 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Jan 3 10:29:43 2017 New Revision: 290895 URL: http://llvm.org/viewvc/llvm-project?rev=290895=rev Log: Improve the performance of jModulesInfo in lldb-server Previously it parsed /proc//maps for every module separately resulting in a very slow response time. This CL

[Lldb-commits] [PATCH] D28233: Improve the performance of jModulesInfo in lldb-server

2017-01-03 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer marked an inline comment as done. tberghammer added a comment. On some extremely large cases I seen the response time to fell from ~120s to ~8s (default packet timeout is 2s). https://reviews.llvm.org/D28233 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D28233: Improve the performance of jModulesInfo in lldb-server

2017-01-03 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great, thanks. Do you have any measurements on the real impact this makes on jModulesInfo packet? Comment at:

[Lldb-commits] [PATCH] D27394: Fix expression evaluation inside lambda functions for gcc

2017-01-03 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer abandoned this revision. tberghammer added a comment. Based on the feedback will try to fix the Clang AS importer instead (don't have any ETA for it) https://reviews.llvm.org/D27394 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D28233: Improve the performance of jModulesInfo in lldb-server

2017-01-03 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: labath. tberghammer added a subscriber: lldb-commits. Improve the performance of jModulesInfo in lldb-server Previously it parsed /proc//maps for every module separately resulting in a very slow response time. This CL add some

[Lldb-commits] [lldb] r290890 - Fix-up TestLinuxCore for r290874

2017-01-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jan 3 07:18:12 2017 New Revision: 290890 URL: http://llvm.org/viewvc/llvm-project?rev=290890=rev Log: Fix-up TestLinuxCore for r290874 r290874 enabled the s390x test, which caused the rest of the tests to start misbehaving. This is because this test switches the

[Lldb-commits] [lldb] r290874 - Simplify reading of Linux notes to correctly handle endianess.

2017-01-03 Thread Howard Hellyer via lldb-commits
Author: hhellyer Date: Tue Jan 3 05:03:14 2017 New Revision: 290874 URL: http://llvm.org/viewvc/llvm-project?rev=290874=rev Log: Simplify reading of Linux notes to correctly handle endianess. Summary: This patch changes and simplifies the way notes are read from Linux Elf cores. The current

[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2017-01-03 Thread Hafiz Abid Qadeer via Phabricator via lldb-commits
abidh accepted this revision. abidh added a comment. Looks good. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/main.cpp:22 { -int a = 10; +int a = 10; + This declaration looks redundant. Comment at: