[Lldb-commits] [lldb] r332922 - Work around some odd instruction single-step behavior on macOS.

2018-05-21 Thread Jim Ingham via lldb-commits
Author: jingham Date: Mon May 21 17:06:55 2018 New Revision: 332922 URL: http://llvm.org/viewvc/llvm-project?rev=332922=rev Log: Work around some odd instruction single-step behavior on macOS. We've seen some cases on macOS where you go to instruction single step (over a breakpoint), and single

[Lldb-commits] [lldb] r332914 - Fix the Xcode project for the refactoring of the

2018-05-21 Thread Jim Ingham via lldb-commits
Author: jingham Date: Mon May 21 15:41:28 2018 New Revision: 332914 URL: http://llvm.org/viewvc/llvm-project?rev=332914=rev Log: Fix the Xcode project for the refactoring of the DWARF reader. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-21 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd updated this revision to Diff 147874. compnerd added a comment. fix regex https://reviews.llvm.org/D46726 Files: CMakeLists.txt cmake/modules/FindLibEdit.cmake scripts/Python/modules/readline/CMakeLists.txt Index: scripts/Python/modules/readline/CMakeLists.txt

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

2018-05-21 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd added inline comments. Comment at: cmake/modules/FindLibEdit.cmake:53-54 +set(libedit_VERSION_STRING "${libedit_major_version}.${libedit_minor_version}") +unset(libedit_major_version) +unset(libedit_minor_version) + endif() labath wrote: >

[Lldb-commits] [PATCH] D47147: DWARFIndex: Reduce duplication in the GetFunctions methods

2018-05-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Before I look too closely, we can probably add a DWARFDIE accessor function like: bool DWARFDIE::IsClassMethod() const; Then this would allow each DWARFIndex to just check and we might be able to get rid of the 3 lists in GetFunctionsByBaseOrMethodName? Seems like

[Lldb-commits] [lldb] r332877 - Enable Python API for OpenBSD.

2018-05-21 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon May 21 12:47:45 2018 New Revision: 332877 URL: http://llvm.org/viewvc/llvm-project?rev=332877=rev Log: Enable Python API for OpenBSD. Patch by David Carlier Modified: lldb/trunk/scripts/utilsOsType.py Modified: lldb/trunk/scripts/utilsOsType.py URL:

[Lldb-commits] [PATCH] D47110: [LLDB, lldb-mi] Add option --synchronous.

2018-05-21 Thread Alexander Polyakov via Phabricator via lldb-commits
polyakov.alex updated this revision to Diff 147806. polyakov.alex added a comment. Moved the option parsing code down by the others. Repository: rL LLVM https://reviews.llvm.org/D47110 Files: tools/lldb-mi/MICmnResources.cpp tools/lldb-mi/MICmnResources.h tools/lldb-mi/MIDriver.cpp

[Lldb-commits] [PATCH] D47147: DWARFIndex: Reduce duplication in the GetFunctions methods

2018-05-21 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, clayborg. Herald added a subscriber: aprantl. This extracts the common bits out of the two implementations back into the SymbolFileDWARF class. The goal was to make the function as similar as possible to the other DWARFIndex

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

2018-05-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 147787. JDevlieghere added a comment. Herald added a subscriber: mgorny. Make this work for Windows https://reviews.llvm.org/D47062 Files: packages/Python/lldbsuite/test/dosep.py packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [PATCH] D47133: Enable ProcessMachCore plugin on non-apple platforms

2018-05-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D47021: Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes

2018-05-21 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL332842: Fix PathMappingList for relative and empty paths after recent FileSpec… (authored by gclayton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r332842 - Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes

2018-05-21 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Mon May 21 07:14:36 2018 New Revision: 332842 URL: http://llvm.org/viewvc/llvm-project?rev=332842=rev Log: Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes PathMappingList was broken for relative and empty paths after

[Lldb-commits] [lldb] r332841 - Reland "[DWARF] Extract indexing code into a separate class hierarchy"

2018-05-21 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon May 21 07:12:52 2018 New Revision: 332841 URL: http://llvm.org/viewvc/llvm-project?rev=332841=rev Log: Reland "[DWARF] Extract indexing code into a separate class hierarchy" After this commit, the xcode project will need to be updated to include the new files added here.

[Lldb-commits] [PATCH] D47110: [LLDB, lldb-mi] Add option --synchronous.

2018-05-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. Looks fine, just move the option parsing code down by the others instead of having it before the checking for file args. Comment at: tools/lldb-mi/MIDriver.cpp:441-444 + if (strArg.compare("--synchronous") == 0)

[Lldb-commits] [PATCH] D47133: Enable ProcessMachCore plugin on non-apple platforms

2018-05-21 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, jasonmolenda. Herald added a subscriber: mgorny. The plugin already builds fine on other platforms (linux, at least). All that was necessary was to revitalize the hack in PlatformDarwinKernel (not a very pretty hack, but it gets

[Lldb-commits] [lldb] r332833 - Improve coverage of the apple-tables test

2018-05-21 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon May 21 03:09:22 2018 New Revision: 332833 URL: http://llvm.org/viewvc/llvm-project?rev=332833=rev Log: Improve coverage of the apple-tables test After closer examination, it turns out we mis-classify one of the methods only if two of the structs have the same name. Since

[Lldb-commits] [PATCH] D47064: Add some apple-tables lookup tests

2018-05-21 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL332831: Add some apple-tables lookup tests (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47064 Files:

[Lldb-commits] [lldb] r332831 - Add some apple-tables lookup tests

2018-05-21 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon May 21 02:27:16 2018 New Revision: 332831 URL: http://llvm.org/viewvc/llvm-project?rev=332831=rev Log: Add some apple-tables lookup tests Summary: Now that we are able to parse MachO files everywhere, we can write some cross-platform tests for handling of apple

[Lldb-commits] [PATCH] D47021: Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes

2018-05-21 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good. I don't know if anyone else has an opinion on how should we treat "" for mapping purposes, but treating it as "." seems fine to me. Comment at:

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

2018-05-21 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Looks fine to me, just make the path computation windows-compatible. Comment at: packages/Python/lldbsuite/test/dotest.py:386 +if is_exe(lldbtest_config.lldbExec): +lldbtest_config.dotestWrapper = "{}-dotest".format( +