teemperor created this revision.
teemperor added a reviewer: vsk.
Instead of iterating over our vector of functions, we might as well use a map
here to
directly get the function we need.
Thanks to Vedant for pointing this out.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50225
Files:
stella.stamenova added a comment.
There are a number of minidump tests that started failing for us on both Linux
and Windows and I suspect it's due to this change. Did the unit tests pass for
you with the changes on either Linux or Windows?
Failing Tests (6):
lldb-Unit ::
Author: dlj
Date: Thu Aug 2 14:45:05 2018
New Revision: 338772
URL: http://llvm.org/viewvc/llvm-project?rev=338772=rev
Log:
[lldb] Remove unused variable.
The use of this variable was removed in r338734. It now causes unused variable
warnings.
Modified:
Author: stella.stamenova
Date: Thu Aug 2 14:26:19 2018
New Revision: 338769
URL: http://llvm.org/viewvc/llvm-project?rev=338769=rev
Log:
[lldbsuite, windows] Mark tests as XFAIL on Windows or skip them
Summary:
1) Several tests that are flakey on windows fail the run even if they are
marked as
sgraenitz added a comment.
> (However if you are interested in something like this, then it might be
> interesting to look at whether this MethodName stuff couldn't be properly
> pluginified. Something like where a Language class registers a callback for a
> specific mangling type, and then
Author: zturner
Date: Thu Aug 2 10:44:41 2018
New Revision: 338746
URL: http://llvm.org/viewvc/llvm-project?rev=338746=rev
Log:
Fix CMake build.
Some new files were committed to the repository but not added
to the CMakeLists.txt, so this patch fixes the build.
Modified:
Please remember to test with the cmake build when you add or remove files,
as that is the build that all of the buildbots use. I almost reverted this
since it broke every LLDB buildbot, but I noticed that it's just forgetting
to remove the files from the CMakeLists.txt so I'll fix it.
On Thu,
zturner added a comment.
Please remember to test with the cmake build when you add or remove files,
as that is the build that all of the buildbots use. I almost reverted this
since it broke every LLDB buildbot, but I noticed that it's just forgetting
to remove the files from the CMakeLists.txt
sgraenitz abandoned this revision.
sgraenitz added a comment.
Yep
https://reviews.llvm.org/D50192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338734: Add support for ARM and ARM64 breakpad generated
minidump files (authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: gclayton
Date: Thu Aug 2 09:46:15 2018
New Revision: 338734
URL: http://llvm.org/viewvc/llvm-project?rev=338734=rev
Log:
Add support for ARM and ARM64 breakpad generated minidump files
In this patch I add support for ARM and ARM64 break pad files. There are two
flavors of ARM: Apple
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338733: Add byte counting mechanism to LLDBs Stream
class. (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: teemperor
Date: Thu Aug 2 09:38:34 2018
New Revision: 338733
URL: http://llvm.org/viewvc/llvm-project?rev=338733=rev
Log:
Add byte counting mechanism to LLDB's Stream class.
Summary:
This patch allows LLDB's Stream class to count the bytes it has written to so
far.
There are two major
teemperor updated this revision to Diff 158777.
teemperor added a comment.
- Fixing some of the merge conflicts.
- Fixed doxygen comment.
Thanks for the reviews!
https://reviews.llvm.org/D50159
Files:
include/lldb/Core/StreamAsynchronousIO.h
include/lldb/Core/StreamBuffer.h
davide added a comment.
My understanding is that @t.p.northover just committed the same patch.
https://reviews.llvm.org/D50192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
teemperor added a reviewer: t.p.northover.
teemperor added a comment.
This was changed by https://reviews.llvm.org/rLLDB338712 so I think Tim
probably knows better what's going on here.
https://reviews.llvm.org/D50192
___
lldb-commits mailing list
sgraenitz created this revision.
sgraenitz added a reviewer: teemperor.
Fix linker error:
Undefined symbols for architecture x86_64:
"lldb_private::ClangHighlighter::ClangHighlighter()", referenced from:
lldb_private::ObjCLanguage::ObjCLanguage() in
liblldb-core.a(ObjCLanguage.o)
Author: tnorthover
Date: Thu Aug 2 05:50:23 2018
New Revision: 338712
URL: http://llvm.org/viewvc/llvm-project?rev=338712=rev
Log:
Move ClangHighlighter.cpp to hopefully better place in Xcode project.
But with a write-only format, who can really say?
Modified:
labath added a comment.
In https://reviews.llvm.org/D50071#1184960, @sgraenitz wrote:
> > If I understand things correctly, we could avoid circular deps and untyped
> > pointers (or llvm::Any, which is essentially the same thing), by moving
> > CPlusPlusLanguage::MethodName to a separate file.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338695: Unit test for Symtab::InitNameIndexes (authored by
stefan.graenitz, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49909
Files:
labath added a comment.
Wouldn't it be even better to actually expose the llvm class via some accessor
or something? This way we could slowly migrate existing code by changing it to
write to `stream.accessor()` instead of `stream` ? (I am not saying to do that
now, but it opens up
JDevlieghere added inline comments.
Comment at: include/lldb/Utility/Stream.h:542
int m_indent_level; ///< Indention level.
+ std::size_t m_bytes_written = 0; /// The bytes this stream has written so
far.
I believe you need the `<` for Doxygen to
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I think there's a small difference in semantics between this and the `tell`
function on llvm streams. This tells the number of bytes written, while the
other one an absolute position within
23 matches
Mail list logo
