zturner added a comment.
Bleh, I think I found a problem with this approach. Since we assume everything
is a namespace, it can lead to ambiguities. I think we need to actually
consult the debug info while parsing components of the mangled name. For
example, suppose you have this code:
zturner updated this revision to Diff 172511.
zturner added a comment.
I just added a new test which dumps the clang AST and makes sure no bogus
records get introduced. Since this is already LGTM'ed I'm assuming this is
good to go, but since it now depends on https://reviews.llvm.org/D54072, I
zturner updated this revision to Diff 172510.
zturner added a comment.
clang dumps to stderr. Only use color if stderr supports this (e.g. if it's
not redirected to a file).
https://reviews.llvm.org/D54072
Files:
lldb/include/lldb/Symbol/SymbolFile.h
davide added a comment.
In https://reviews.llvm.org/D54056#1286620, @jankratochvil wrote:
> It broke the testsuite for me:
>
> $ time
> PYTHONPATH=$PWD/lib64/python2.7/site-packages:$PWD/lib64/python2.7/site-packages/lldb
> ../llvm-git/tools/lldb/test/dotest.py --executable $PWD/bin/lldb -C
jankratochvil added a comment.
It broke the testsuite for me:
$ time
PYTHONPATH=$PWD/lib64/python2.7/site-packages:$PWD/lib64/python2.7/site-packages/lldb
../llvm-git/tools/lldb/test/dotest.py --executable $PWD/bin/lldb -C
$PWD/bin/clang -t
aleksandr.urakov reopened this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.
@davide You are right, this patch was the cause of the failure, sorry for that.
It seems that I've found a generic issue with this patch. Thanks again for
pointing to
aleksandr.urakov added a comment.
Thank you!
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
labath added reviewers: sgraenitz, erik.pilkington, JDevlieghere.
Now that llvm demangler supports more generic customization, we can
implement type substitution directly on top of this API. This will allow
us to remove the specialized hooks which were added to the
zturner created this revision.
zturner added reviewers: vsk, davide, labath, jingham, aleksandr.urakov,
clayborg.
Herald added subscribers: JDevlieghere, aprantl.
This can be useful when diagnosing AST related problems. For example, I had a
bug where I was accidentally creating a record type
zturner added a comment.
I actually found some issues with this, or at least some potential issues which
I'm not sure are actual issues. But I'm adding some new functionality to LLDB
to help me confirm whether these are real issues or not, and worst case
scenario it will open up some new
JDevlieghere added a comment.
In https://reviews.llvm.org/D54059#1286293, @teemperor wrote:
> Minor detail: The revision title only mentions Java, but this revision
> removes both Go and Java.
Actually, this review is only for removing the Java plugin. There’s a different
review for the Go
krytarowski added a comment.
This looks fine to me.
https://reviews.llvm.org/D52941
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Kamil, I think you're the best qualified person to look at the lldb-server
changes right now, so I'd like to hear your opinion on the other changes too.
Otherwise, I'll just commit this some time next week.
https://reviews.llvm.org/D52941
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks for your patience. This looks good to me now.
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath added a comment.
A very nice use of the structured demangler.
https://reviews.llvm.org/D54053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
lldb-server is used on architectures that don't have python (readily)
available, and it uses the same codebase as the rest of lldb. (Granted, it only
needs a small subset of that codebase, and this subset doesn't/shouldn't care
about python, but we aren't able to split
kastiglione added a comment.
There are other commands that print instructions in the same way that `command
regex` does, should they be updated in this change too?
https://reviews.llvm.org/D48752
___
lldb-commits mailing list
kastiglione updated this revision to Diff 172488.
kastiglione added a comment.
Added IOHandlerActivatedInteractively
https://reviews.llvm.org/D48752
Files:
include/lldb/Core/IOHandler.h
packages/Python/lldbsuite/test/functionalities/command_regex/TestCommandRegex.py
aleksandr.urakov added a comment.
I'm not sure, but have an assumption. Here is the first green build of the
green-dragon-24: http://green.lab.llvm.org/green/job/lldb-cmake/12090/ It
became green after three changes, one of them is your revert of my commit,
while another is Zachary's "Fix the
19 matches
Mail list logo
