[Lldb-commits] [lldb] f0a5af9 - Merge in symbols from Mach-O dyld trie to the symbol table

Author: Jason Molenda Date: 2020-03-27T22:53:15-07:00 New Revision: f0a5af906b41b654ef0c71dee5f81bf7496524b2 URL: https://github.com/llvm/llvm-project/commit/f0a5af906b41b654ef0c71dee5f81bf7496524b2 DIFF: https://github.com/llvm/llvm-project/commit/f0a5af906b41b654ef0c71dee5f81bf7496524b2.diff

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace created this revision. wallace added reviewers: clayborg, kusmour, labath, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace updated this revision to Diff 253283. wallace added a comment. cleanup When using source maps for a breakpoint, in order to

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253283. wallace added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76964: Fix an issue where the IgnoreName function was not allowing "Class" to be looked up inside a namespace or other class.

clayborg created this revision. clayborg added reviewers: jingham, aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Objective C may or may not be enabled when running expressions. There was code that was no allowing "Class" or "id" to be looked up in

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

JDevlieghere added a comment. In D76827#1947176 , @brooks wrote: > Doing a bit of naive digging suggests to me that putting this section inside > an > > if (NOT CMAKE_CFG_INTDIR STREQUAL ".") > > > might do the trick. I can reproduce this with the

[Lldb-commits] [lldb] 823dbb4 - [lldb/CMake] Only CMAKE_CFG_INTDIR if it's not '.'

Author: Jonas Devlieghere Date: 2020-03-27T17:49:00-07:00 New Revision: 823dbb4c748feaae6f20637efd0de159dd156c69 URL: https://github.com/llvm/llvm-project/commit/823dbb4c748feaae6f20637efd0de159dd156c69 DIFF:

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

emrekultursay added a comment. I added an end-to-end test to the entire use-source-cache feature in https://reviews.llvm.org/D76806 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76804/new/ https://reviews.llvm.org/D76804

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay added a comment. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253260. emrekultursay added a comment. Cleanup the Python test to make it a bit more readable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files:

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 253257. aprantl added a comment. Herald added a subscriber: mgorny. I've reworked this a little based on your feedback. First, I've renamed `SDK` to `XcodeSDK`. An Xcode SDK is a fairly specific concept and I'm not going to pretend that it makes sense to

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253254. emrekultursay added a comment. Added test that verifies end-to-end impact of "setting set use_source_cache false" on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

brooks added a comment. Doing a bit of naive digging suggests to me that putting this section inside an if (NOT CMAKE_CFG_INTDIR STREQUAL ".") might do the trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76827/new/

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

NathanielMcVicar added a comment. > Hey Brooks, do you have a public buildbot so I can try to fix it? What > generator are you using? We are also experiencing a similar install failure on Ubuntu. Unfortunately we don't have a lldb buildbot for this platform either. I should have spoken up

[Lldb-commits] [PATCH] D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8

JDevlieghere planned changes to this revision. JDevlieghere added a comment. Right, I didn't check whether out and err were strings or bytes. I'll see if I can find a better solution or alternatively wrap it in a try-except. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76955/new/

[Lldb-commits] [PATCH] D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8

friss added a comment. I think this won't work with Python3, were `out` and `err` will be already "decoded" str objects CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76955/new/ https://reviews.llvm.org/D76955 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

JDevlieghere added a comment. In D76827#1947070 , @brooks wrote: > This is broken in a FreeBSD install. > > CMake Error at tools/lldb/cmake_install.cmake:44 (file): > file INSTALL cannot find >

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

brooks added a subscriber: emaste. brooks added a comment. The generator is Ninja. @emaste may know of a buildbot. Note that this is an install failure so I'm not sure if buildbots will catch it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76945: [lldb/CMake] Make check-lldb-* work for the standalone build.

xiaobai added a comment. In D76945#1947034 , @JDevlieghere wrote: > In D76945#1946988 , @xiaobai wrote: > > > > we need to build our own and tell LLVM to use it > > > > To clarify, this means we'd be building our

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

brooks added a comment. This is broken in a FreeBSD install. CMake Error at tools/lldb/cmake_install.cmake:44 (file): file INSTALL cannot find

[Lldb-commits] [PATCH] D76945: [lldb/CMake] Make check-lldb-* work for the standalone build.

JDevlieghere added a comment. In D76945#1946988 , @xiaobai wrote: > > we need to build our own and tell LLVM to use it > > To clarify, this means we'd be building our own llvm-lit and using that just > for the LLDB test suite, correct? Yep, should I

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

aprantl updated this revision to Diff 253226. aprantl marked an inline comment as done. aprantl added a comment. Remove the obsolete setter in `lldb::Type`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75562/new/ https://reviews.llvm.org/D75562 Files:

[Lldb-commits] [PATCH] D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8

JDevlieghere updated this revision to Diff 253229. JDevlieghere added a comment. Use single quotes for consistency CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76955/new/ https://reviews.llvm.org/D76955 Files: lldb/test/API/lldbtest.py Index: lldb/test/API/lldbtest.py

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

This revision was automatically updated to reflect the committed changes. Closed by commit rG8016d61e3cf4: [LLDB] CPlusPlusNameParser does not handles templated operator properly (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

aprantl added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75562/new/ https://reviews.llvm.org/D75562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

aprantl updated this revision to Diff 253224. aprantl added a comment. Rebase and update based on https://reviews.llvm.org/D75488. It no longer takes a reference, but is a value type instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75562/new/ https://reviews.llvm.org/D75562

[Lldb-commits] [PATCH] D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, aprantl, davide. JDevlieghere added a reviewer: labath. JDevlieghere updated this revision to Diff 253229. JDevlieghere added a comment. Use single quotes for consistency Fixes a UnicodeDecodeError when stdout or stderr

[Lldb-commits] [PATCH] D76945: [lldb/CMake] Make check-lldb-* work for the standalone build.

xiaobai added a comment. > we need to build our own and tell LLVM to use it To clarify, this means we'd be building our own llvm-lit and using that just for the LLDB test suite, correct? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76945/new/ https://reviews.llvm.org/D76945

[Lldb-commits] [lldb] 8016d61 - [LLDB] CPlusPlusNameParser does not handles templated operator< properly

Author: shafik Date: 2020-03-27T14:46:39-07:00 New Revision: 8016d61e3cf4967dd28c8f6296cec685dadcaee6 URL: https://github.com/llvm/llvm-project/commit/8016d61e3cf4967dd28c8f6296cec685dadcaee6 DIFF: https://github.com/llvm/llvm-project/commit/8016d61e3cf4967dd28c8f6296cec685dadcaee6.diff LOG:

[Lldb-commits] [lldb] 974fbd9 - Unbreak LLDB tests after 96023917e6f

Author: Adrian Prantl Date: 2020-03-27T14:23:30-07:00 New Revision: 974fbd9b8145d351b7359e34e415581eda6e0b4d URL: https://github.com/llvm/llvm-project/commit/974fbd9b8145d351b7359e34e415581eda6e0b4d DIFF: https://github.com/llvm/llvm-project/commit/974fbd9b8145d351b7359e34e415581eda6e0b4d.diff

[Lldb-commits] [lldb] 457eb05 - [lldb/PlatformMacOSX] Re-implement GetDeveloperDirectory

Author: Jonas Devlieghere Date: 2020-03-27T12:36:56-07:00 New Revision: 457eb05db67d201f34920e762a90d0deb670becb URL: https://github.com/llvm/llvm-project/commit/457eb05db67d201f34920e762a90d0deb670becb DIFF:

[Lldb-commits] [PATCH] D76938: [lldb/PlatformMacOSX] Re-implement GetDeveloperDirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG457eb05db67d: [lldb/PlatformMacOSX] Re-implement GetDeveloperDirectory (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76945: [lldb/CMake] Make check-lldb-* work for the standalone build.

JDevlieghere updated this revision to Diff 253192. JDevlieghere added a comment. Add missing context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76945/new/ https://reviews.llvm.org/D76945 Files: lldb/test/CMakeLists.txt Index: lldb/test/CMakeLists.txt

[Lldb-commits] [PATCH] D76938: [lldb/PlatformMacOSX] Re-implement GetDeveloperDirectory

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yea, this looks good, I don't think any of those other search methods were valid any longer. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76945: [lldb/CMake] Make check-lldb-* work for the standalone build.

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, mgorny, aprantl, stella.stamenova. JDevlieghere updated this revision to Diff 253192. JDevlieghere added a comment. Add missing context. In order to run check-lldb-* we need the correct map_config directives in

[Lldb-commits] [PATCH] D76808: Fix handling of bit-fields when there is a base class when parsing DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rG00c8120acbac: [LLDB] Fix handling of bit-fields when there is a base class when parsing DWARF (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 00c8120 - [LLDB] Fix handling of bit-fields when there is a base class when parsing DWARF

Author: shafik Date: 2020-03-27T11:28:07-07:00 New Revision: 00c8120acbac3430c3594c5b6ca3527ef9c1afca URL: https://github.com/llvm/llvm-project/commit/00c8120acbac3430c3594c5b6ca3527ef9c1afca DIFF: https://github.com/llvm/llvm-project/commit/00c8120acbac3430c3594c5b6ca3527ef9c1afca.diff LOG:

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham marked 2 inline comments as done. jingham added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads:

[Lldb-commits] [PATCH] D76938: [lldb/PlatformMacOSX] Re-implement GetDeveloperDirectory

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda. `GetDeveloperDirectory` returns a `const char*` which is `NULL` when we cannot find the developer directory. This crashes in `PlatformDarwinKernel::CollectKextAndKernelDirectories` because we're

[Lldb-commits] [PATCH] D76808: Fix handling of bit-fields when there is a base class when parsing DWARF

shafik updated this revision to Diff 253147. shafik marked 2 inline comments as done. shafik added a comment. Minor fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76808/new/ https://reviews.llvm.org/D76808 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik updated this revision to Diff 253142. shafik marked 6 inline comments as done. shafik added a comment. Fixing up loose language in the comments and adding periods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76168/new/ https://reviews.llvm.org/D76168 Files:

[Lldb-commits] [PATCH] D76891: [lldb-vscode] fix breakpoint result ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rGa515fd01a4f2: [lldb-vscode] fix breakpoint result ordering (authored by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a515fd0 - [lldb-vscode] fix breakpoint result ordering

Author: Walter Erquinigo Date: 2020-03-27T08:42:58-07:00 New Revision: a515fd01a4f2355291ab424d093e9de4f8acd4dc URL: https://github.com/llvm/llvm-project/commit/a515fd01a4f2355291ab424d093e9de4f8acd4dc DIFF:

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

labath added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads: Property<"plugin-reports-all-threads", "Boolean">, +