[Lldb-commits] [lldb] aa4b37b - Convert the ThreadPlanCommands test to use a scripted plan

Author: Jim Ingham Date: 2020-04-10T18:15:03-07:00 New Revision: aa4b37b2acda8f0879ed5507e1a732c37e6ec5aa URL: https://github.com/llvm/llvm-project/commit/aa4b37b2acda8f0879ed5507e1a732c37e6ec5aa DIFF: https://github.com/llvm/llvm-project/commit/aa4b37b2acda8f0879ed5507e1a732c37e6ec5aa.diff

[Lldb-commits] [lldb] f7de4b5 - Thread Plans pushed by a scripted plan should be private plans.

Author: Jim Ingham Date: 2020-04-10T18:15:03-07:00 New Revision: f7de4b5d6bce8c33ac3e18a41abcf5268a29f461 URL: https://github.com/llvm/llvm-project/commit/f7de4b5d6bce8c33ac3e18a41abcf5268a29f461 DIFF: https://github.com/llvm/llvm-project/commit/f7de4b5d6bce8c33ac3e18a41abcf5268a29f461.diff

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 256715. wallace edited the summary of this revision. wallace removed a reviewer: JDevlieghere. wallace removed a subscriber: JDevlieghere. wallace added a comment. Herald added a subscriber: mgorny. Addressed comments. The diff description now reflects the

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 256716. wallace added a comment. remove blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files: lldb/packages/Python/lldbsuite/test/configuration.py

[Lldb-commits] [lldb] f78fcd6 - [lldb/Test] Rewrite ReproducerInstrumentationTest

Author: Jonas Devlieghere Date: 2020-04-10T16:50:44-07:00 New Revision: f78fcd6906a032bf5feb0e60c9e8991bf31e990e URL: https://github.com/llvm/llvm-project/commit/f78fcd6906a032bf5feb0e60c9e8991bf31e990e DIFF:

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

clayborg added a comment. In D77790#1974047 , @jarin wrote: > Regarding the callback idea, I have bad experience with callbacks because > they break if the code is not crafted for re-entrancy and they are much > harder to understand. That change feels

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Utility/XcodeSDK.cpp:72 + llvm::VersionTuple version = ParseSDKVersion(input); + return {sdk, version}; +} sylvestre.ledru wrote: > With older version of the

[Lldb-commits] [PATCH] D77662: [lldb/test] Make TestLoadUnload compatible with windows

compnerd added a comment. @labath - can this get merged so that I can rebase and get D77287 merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77662/new/ https://reviews.llvm.org/D77662

[Lldb-commits] [lldb] f5be71b - Attempt to fix a compile error reported with older compilers and libstdc++

Author: Adrian Prantl Date: 2020-04-10T10:34:44-07:00 New Revision: f5be71b44500b18d636b1f540422dda4012ac192 URL: https://github.com/llvm/llvm-project/commit/f5be71b44500b18d636b1f540422dda4012ac192 DIFF: https://github.com/llvm/llvm-project/commit/f5be71b44500b18d636b1f540422dda4012ac192.diff

[Lldb-commits] [lldb] 02d152b - [lldb] Make some asserts in TestFixIts more expressive

Author: Raphael Isemann Date: 2020-04-10T19:16:33+02:00 New Revision: 02d152bb1b63e1f5ebdf502a8b8c8c99103a5e75 URL: https://github.com/llvm/llvm-project/commit/02d152bb1b63e1f5ebdf502a8b8c8c99103a5e75 DIFF:

[Lldb-commits] [PATCH] D77878: [lldb] Fix a typo in a test name

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Removing the Test prefix from the file name and its usages. The standard is using only Test as a suffix. This was correctly pointed out in

[Lldb-commits] [lldb] a0c6ebd - [lldb] Refactor TestFixIts so that most of it can run on aarch64-linux

Author: Raphael Isemann Date: 2020-04-10T13:38:45+02:00 New Revision: a0c6ebd58fabd4d42fce2233ee4c28e7febfe62f URL: https://github.com/llvm/llvm-project/commit/a0c6ebd58fabd4d42fce2233ee4c28e7febfe62f DIFF:

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

jarin added a comment. Regarding the callback idea, I have bad experience with callbacks because they break if the code is not crafted for re-entrancy and they are much harder to understand. That change feels out of scope for just adding a test and fixing an unrelated bug. Adding the

[Lldb-commits] [PATCH] D77842: Fix setting Python3_ROOT_DIR on Windows

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, PYTHON_HOME is apparently the Windows way we allow people to specify the python root when finding the package. Please update the review description though with why this change was

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

sylvestre.ledru added inline comments. Comment at: lldb/source/Utility/XcodeSDK.cpp:72 + llvm::VersionTuple version = ParseSDKVersion(input); + return {sdk, version}; +} With older version of the libcstdc++ (some Ubuntu LTS), it fails with: ``` error: chosen

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau marked 2 inline comments as done. ctetreau added inline comments. Comment at: llvm/include/llvm/IR/DerivedTypes.h:436 + + static VectorType *get(Type *ElementType, const VectorType *Other) { +return VectorType::get(ElementType, Other->getElementCount());

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

sdesmalen added a comment. Thanks for this patch @ctetreau! Overall looks great to me, just two little nits. Comment at: llvm/include/llvm/IR/DerivedTypes.h:436 + + static VectorType *get(Type *ElementType, const VectorType *Other) { +return VectorType::get(ElementType,

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau updated this revision to Diff 256435. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77587/new/ https://reviews.llvm.org/D77587 Files: lldb/source/Expression/IRInterpreter.cpp

[Lldb-commits] [PATCH] D77587: [SVE] Add new VectorType subclasses

ctetreau marked an inline comment as done. ctetreau added inline comments. Comment at: llvm/lib/ExecutionEngine/ExecutionEngine.cpp:1011 llvm_unreachable("Unknown constant pointer type!"); - } - break; + } break; efriedma wrote: > ? clang-format-diff

[Lldb-commits] [lldb] a4da4e3 - [lldb/Reproducers] Fix typo introduced when disabling register failing tests

Author: Med Ismail Bennani Date: 2020-04-10T08:37:06+02:00 New Revision: a4da4e3292834b5f93f54440f825dd90876d6615 URL: https://github.com/llvm/llvm-project/commit/a4da4e3292834b5f93f54440f825dd90876d6615 DIFF: