[Lldb-commits] [lldb] 20db891 - Fix typo in error message

Author: Gabor Greif Date: 2020-05-14T07:23:59+02:00 New Revision: 20db891cef97df752ff8d2a249c155e5605ba06d URL: https://github.com/llvm/llvm-project/commit/20db891cef97df752ff8d2a249c155e5605ba06d DIFF: https://github.com/llvm/llvm-project/commit/20db891cef97df752ff8d2a249c155e5605ba06d.diff L

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

clayborg added a comment. There was a patch previous to this that enabled IPv6. We need IPv6 on some computers here at Facebook. Can you check this file's log and look at the IPv6 patch and make sure this doesn't just undo that patch prior to committing this? If it does undo that patch, maybe w

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

clayborg added a comment. nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

clayborg added a comment. In D79811#2035078 , @shafik wrote: > In D79811#2034842 , @clayborg wrote: > > > The error where two of the same classes conflicted usually only happened > > in complex cases that were har

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

compnerd added a comment. WeakODR requires that the symbol actually be discarded if not referenced. This will preserve the symbol even if unreferenced will it not? One approach might be to just create a `DenseMap` and check for any references and mark is as preserved otherwise just drop it.

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

shafik added a comment. In D79811#2034842 , @clayborg wrote: > The error where two of the same classes conflicted usually only happened in > complex cases that were hard to reduce down. > > If I understand this correctly, the compiler should be able to a

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

clayborg added a comment. The error where two of the same classes conflicted usually only happened in complex cases that were hard to reduce down. If I understand this correctly, the compiler should be able to auto synthesize these functions at will since the original class definition should h

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

clayborg added a comment. might be nice to have "disconnectCommands" at some point if we ever need them too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79726/new/ https://reviews.llvm.org/D79726 __

[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

jingham accepted this revision. jingham added a comment. If you have --force, then the address range is informational, in which case having the full command would be more confusing than anything. So this is fine, thanks for adding it. I thought briefly about whether we should also add a settin

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

shafik marked an inline comment as done. shafik added a comment. In D79811#2033399 , @labath wrote: > In general, I think this is a good direction to go in. We can run into the > same kinds of problems even with non-artificial functions -- either the > a

[Lldb-commits] [PATCH] D79825: [lldb/Reproducers] Add test-specific API to set the test CWD

JDevlieghere added a comment. In D79825#2033405 , @labath wrote: > It's definitely a hack, but it seems to be fairly well contained. > > As an aside, I've always wondered, how much we really need to switch the cwd. > Now that we build tests out-of-tree, I

[Lldb-commits] [PATCH] D79825: [lldb/Reproducers] Add test-specific API to set the test CWD

This revision was automatically updated to reflect the committed changes. Closed by commit rG6671a81bc71c: [lldb/Reproducers] Add test-specific API to set the test CWD (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [lldb] 6671a81 - [lldb/Reproducers] Add test-specific API to set the test CWD

Author: Jonas Devlieghere Date: 2020-05-13T09:00:07-07:00 New Revision: 6671a81bc71cc2635c5a10d6f688fea46ca4e5d6 URL: https://github.com/llvm/llvm-project/commit/6671a81bc71cc2635c5a10d6f688fea46ca4e5d6 DIFF: https://github.com/llvm/llvm-project/commit/6671a81bc71cc2635c5a10d6f688fea46ca4e5d6.d

[Lldb-commits] [lldb] 5f7a5e3 - [lldb][NFC] Early-exit in SetupDeclVendor

Author: Raphael Isemann Date: 2020-05-13T16:54:38+02:00 New Revision: 5f7a5e3bdba3663c8ec9704e28f75f6b2850f9f8 URL: https://github.com/llvm/llvm-project/commit/5f7a5e3bdba3663c8ec9704e28f75f6b2850f9f8 DIFF: https://github.com/llvm/llvm-project/commit/5f7a5e3bdba3663c8ec9704e28f75f6b2850f9f8.dif

[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

labath updated this revision to Diff 263697. labath marked an inline comment as done. labath added a comment. Remove commas, add --force. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79789/new/ https://reviews.llvm.org/D79789 Files: lldb/source

[Lldb-commits] [PATCH] D79789: [lldb] Don't dissasemble large functions by default

labath added a reviewer: jingham. labath marked 3 inline comments as done. labath added a comment. In D79789#2032008 , @jingham wrote: > Instead of just printing out the range, can we print out the disassemble > command you would run to actually disassemb

[Lldb-commits] [lldb] 2fe6672 - [lldb][NFC] Don't specify a default argument when creating a TextDiagnosticPrinter

Author: Raphael Isemann Date: 2020-05-13T15:55:51+02:00 New Revision: 2fe6672498d60074fd34e2770659d5526e53e093 URL: https://github.com/llvm/llvm-project/commit/2fe6672498d60074fd34e2770659d5526e53e093 DIFF: https://github.com/llvm/llvm-project/commit/2fe6672498d60074fd34e2770659d5526e53e093.dif

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

labath added a comment. Yep. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79559/new/ https://reviews.llvm.org/D79559 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 added a comment. Thanks! I suppose this won't be in the next patch release (10.0.1) but instead in the next major ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79559/new/ https://reviews.llvm.org/D79559 ___

[Lldb-commits] [lldb] e072b20 - [lldb] Merge PlatformXXX::ResolveExecutable

Author: Pavel Labath Date: 2020-05-13T13:28:19+02:00 New Revision: e072b20bdea5629d0bc7a7c2216bdc7762dcb564 URL: https://github.com/llvm/llvm-project/commit/e072b20bdea5629d0bc7a7c2216bdc7762dcb564 DIFF: https://github.com/llvm/llvm-project/commit/e072b20bdea5629d0bc7a7c2216bdc7762dcb564.diff

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D79726#2031817 , @aadsm wrote: > > I gotta say I don't understand the difference between "exit" and > > "terminate" commands, as both seem to happen

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

labath closed this revision. labath added a comment. Committed as e16111ce2f . I've also added checks for the dstring/wstring types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] e16111c - [lldb] Also recognize DWARF UTF base types using their size

Author: Mathias LANG Date: 2020-05-13T12:56:13+02:00 New Revision: e16111ce2fce7fd86c10d3f1dfe3e3b62b76d73b URL: https://github.com/llvm/llvm-project/commit/e16111ce2fce7fd86c10d3f1dfe3e3b62b76d73b DIFF: https://github.com/llvm/llvm-project/commit/e16111ce2fce7fd86c10d3f1dfe3e3b62b76d73b.diff

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 added a comment. Good to know, thanks! It's also my first time using `arc`, so I had to poke around a bit. In any case I didn't seem to include that whitespace fix even after squashing the commits together. If this is fine as is, then great. No I don't have commit access. Repository:

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. This looks good now. As an aside, it would be nice if adb actually started supporting ipv6 -- it's over 20 years old now... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D79811: WIP: Reenable creation of artificial methods in AddMethodToCXXRecordType(...)

labath added a comment. In general, I think this is a good direction to go in. We can run into the same kinds of problems even with non-artificial functions -- either the application can have real ODR violations, or we can introduce ODR violations during expression eval by playing fast-and-loos

[Lldb-commits] [PATCH] D79825: [lldb/Reproducers] Add test-specific API to set the test CWD

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. It's definitely a hack, but it seems to be fairly well contained. As an aside, I've always wondered, how much we really need to switch the cwd. Now that we build tests out-of-tree, I would exp

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

labath added a comment. Yeah, harbormaster is a bit temperamental these days. I wouldn't worry too much about it reporting problems clearly unrelated to your patch. Btw, do you have commit access, or need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid marked 2 inline comments as done. omjavaid added a comment. In D77043#2031339 , @labath wrote: > The invalidate_regs part looks as I would expect. I think it ought to be > implemented a bit differently, but that can wait until the bigger issue is