Re: [Lldb-commits] [clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

Hey Richard, It appears this broke the lldb bots: http://lab.llvm.org:8011/builders/lldb-x86_64-debian http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20549/ It's hitting an assertion in llvm-project/clang/include/clang/AST/DeclCXX.h:887: Assertion `(data().DefaultedCopyAssignmentIsDel

[Lldb-commits] [lldb] 7fc6d36 - [nfc] [lldb] clang-format #include files order

Author: Jan Kratochvil Date: 2020-06-05T08:28:06+02:00 New Revision: 7fc6d36d4848abec95101fe3d0532e238e9579e8 URL: https://github.com/llvm/llvm-project/commit/7fc6d36d4848abec95101fe3d0532e238e9579e8 DIFF: https://github.com/llvm/llvm-project/commit/7fc6d36d4848abec95101fe3d0532e238e9579e8.diff

[Lldb-commits] [PATCH] D81209: Move GetXcode*Directory into HostInfo (NFC)

aprantl created this revision. aprantl added reviewers: JDevlieghere, friss, jingham. aprantl added a child revision: D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB. These functions really don't belong into PlatformDarwin, since they actually query state of the Host and not of

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

aprantl created this revision. aprantl added reviewers: JDevlieghere, friss, jingham. aprantl added a parent revision: D81209: Move GetXcode*Directory into HostInfo (NFC). Teach GetXcodeSDK to look in the Xcode that contains LLDB instead of preferring the one chosen with xcode-select. Because we

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace marked 2 inline comments as done. wallace added a comment. Well, the problem that i've seen happens mostly with long running processes like services that just don't die. So this fixes those issues anyway because those processes are not dying when they should. I tried an older version of

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham added a comment. In D80112#2075097 , @jingham wrote: > Adding a ShouldStop to that if test doesn't seem right. You should still run > the stop actions even if the thread doesn't want to stop. > > If I understand the problem you are describing, it

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So the main question is why was lldb-vscode not exiting. Do we know why? Some thread wasn't exiting I would guess, but usually as long as the main thread exits, all other threads

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham added a comment. Adding a ShouldStop to that if test doesn't seem right. You should still run the stop actions even if the thread doesn't want to stop. If I understand the problem you are describing, it is that you suspended a thread as a user-level suspend, so it's stop reason got stu

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. Didn't notice that we use in Process::ProcessEventData::DoOnRemoval: this_thread_wants_to_stop = stop_info_sp->ShouldStop(event_ptr); and yes it is probably correct to fix the issue by this: if (stop_info_sp && stop_info_sp->IsValid() && thread_sp->ShouldStop(even

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. As far as I see the problem lies in Process::ProcessEventData::DoOnRemoval: StopInfoSP stop_info_sp = thread_sp->GetStopInfo(); if (stop_info_sp && stop_info_sp->IsValid()) { does_anybody_have_an_opinion = true; bool this_thread_wants_to_sto

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace created this revision. wallace added reviewers: clayborg, labath, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace added a reviewer: kusmour. Recently I've noticed that VSCode sometimes doesn't send the terminateDebuggee flag within the disconnectReque

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

jasonmolenda added a comment. Hi Jan, I noticed our sanitizer bot started getting failures in Failing Tests (3): lldb-api :: commands/expression/unwind_expression/TestUnwindExpression.py lldb-unit :: Utility/./UtilityTests/DataExtractorTest.GetSLEB128_bit63 lldb-shell :: SymbolFile/DWARF/D

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

JDevlieghere updated this revision to Diff 268600. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81058/new/ https://reviews.llvm.org/D81058 Files: lldb/include/lldb/Interpreter/CommandReturnObject.h lldb/include/lldb/Utility/Stream.h lldb/source/Interprete

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham added a comment. Sorry, now that I'm thinking about this more, I'm confused as to why you are seeing the symptoms you describe. Thread::ShouldStop starts with: if (GetResumeState() == eStateSuspended) { LLDB_LOGF(log, "Thread::%s for tid = 0x%4.4" PRIx64 " 0x%4.4" PR

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham added a comment. It bugs me a little bit that we are doing work masking the stop info when in fact the ShouldStop mechanism is the one that shouldn't be consulting threads that were suspended by the user during the last run. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum marked an inline comment as done. fallkrum added inline comments. Comment at: lldb/source/Target/Thread.cpp:382 +if (m_stop_info_sp->IsValid() || +(IsStillAtLastBreakpointHit() && + m_resume_state != eStateSuspended) || fa

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. @jingham tried test you added, got the following output: Ilyas-Mac-mini:Ninja ilya$ ./bin/lldb-dotest -p TestStateAfterExpression.py /Library/Frameworks/Python.framework/Versions/3.8/bin/python3.8 /Users/ilya/Documents/Projects/llvm-project/lldb/test/API/dotest.py --arc

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

This revision was automatically updated to reflect the committed changes. Closed by commit rG476f520a0bd2: [lldb] Fix SLEB128 decoding (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D81119?vs=268489&id=268535#toc Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

jankratochvil marked 5 inline comments as done. jankratochvil added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf-sleb128.s:6 +# RUN: llvm-mc -g -dwarf-version=5 -triple x86_64-unknown-linux-gnu %s -filetype=obj > %t.o +# RUN: ld.lld -m elf_x86_64 %t.o -o %

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

jankratochvil marked 12 inline comments as done. jankratochvil added a comment. In D81119#2073973 , @labath wrote: > PS: You can still just drop the test if you think that's too much hassle. :) It is sure nice to learn more the LLDB high standards, thank

[Lldb-commits] [lldb] a976a7f - Disable this test for Windows.

Author: Jim Ingham Date: 2020-06-04T10:51:01-07:00 New Revision: a976a7fcae44ed5ca9e4f13735a4f91378169282 URL: https://github.com/llvm/llvm-project/commit/a976a7fcae44ed5ca9e4f13735a4f91378169282 DIFF: https://github.com/llvm/llvm-project/commit/a976a7fcae44ed5ca9e4f13735a4f91378169282.diff LO

[Lldb-commits] [lldb] 476f520 - [lldb] Fix SLEB128 decoding

Author: Jan Kratochvil Date: 2020-06-04T19:41:24+02:00 New Revision: 476f520a0bd29d74f559ea1151ac8d0b428d9150 URL: https://github.com/llvm/llvm-project/commit/476f520a0bd29d74f559ea1151ac8d0b428d9150 DIFF: https://github.com/llvm/llvm-project/commit/476f520a0bd29d74f559ea1151ac8d0b428d9150.diff

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. The fix and the unittest look good. I have a bunch of comments on the .s file. As I note in the inline comments, I don't think that having a test like that for specifically handling sl

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

jarin updated this revision to Diff 268497. jarin added a comment. Exclude UUID strings ending with "-". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80755/new/ https://reviews.llvm.org/D80755 Files: lldb/include/lldb/Utility/UUID.h lldb/source/Interpreter/OptionValueUUID.cpp ll

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

jankratochvil updated this revision to Diff 268489. jankratochvil added a comment. Added unit test, simplified the `.s` test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81119/new/ https://reviews.llvm.org/D81119 Files: lldb/source/Utility/Dat

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

labath added a comment. The fix is good (thanks for tracking that down), but the test is way to complicated for what the fix does. A generic "can we show the DW_AT_const_value of a global variable" test might be useful -- I don't believe we have anything exactly like that right now -- but it o

[Lldb-commits] [PATCH] D80775: [lldb] tab completion for `command script delete'

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e8f304f5ea5: [lldb] tab completion for `command script delete' (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 2ebe30c - [lldb][NFC] Address some review feedback for D80775 ('command script delete' completion)

Author: Raphael Isemann Date: 2020-06-04T10:30:27+02:00 New Revision: 2ebe30c6e4ab1d65fc8605051eb528fc26ffc621 URL: https://github.com/llvm/llvm-project/commit/2ebe30c6e4ab1d65fc8605051eb528fc26ffc621 DIFF: https://github.com/llvm/llvm-project/commit/2ebe30c6e4ab1d65fc8605051eb528fc26ffc621.dif

[Lldb-commits] [lldb] 2e8f304 - [lldb] tab completion for `command script delete'

Author: Gongyu Deng Date: 2020-06-04T10:19:03+02:00 New Revision: 2e8f304f5ea5f7b2bd4f5689eae23d4399cd5120 URL: https://github.com/llvm/llvm-project/commit/2e8f304f5ea5f7b2bd4f5689eae23d4399cd5120 DIFF: https://github.com/llvm/llvm-project/commit/2e8f304f5ea5f7b2bd4f5689eae23d4399cd5120.diff L