[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham added a comment. I thought I was just repeating your original description of the problem in a scenario orchestrated by breakpoint actions. I must have missed something in your description if it's true that the scenario I described doesn't match your initial problem. But regardless,

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. In D80112#2081008 , @jingham wrote: > Humm... So you'll have to test the continue behavior instead, which after > all was your original issue. That shouldn't be too hard, however. Just make > a breakpoint action that calls

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham added a comment. Humm... So you'll have to test the continue behavior instead, which after all was your original issue. That shouldn't be too hard, however. Just make a breakpoint action that calls "thread suspend" on its thread and returns false for should_stop the first time it is

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. In D80112#2080516 , @jingham wrote: > I was suggesting something like having a Python breakpoint action that > increments a Python variable. Hit the breakpoint first on thread A. That > should increment it by one. Then

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

jankratochvil marked 4 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h:113 - size_t GetAttributes(DWARFAttributes , uint32_t depth = 0) const; + size_t GetAttributes(DWARFAttributes , int32_t depth

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

jankratochvil updated this revision to Diff 269328. jankratochvil retitled this revision from "[lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC" to "2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D81423: 1/2: [nfc] [lldb] Reduce GetAttributes's depth parameter usage

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. jankratochvil added a child revision: D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC. There is Labath's comment

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

JDevlieghere updated this revision to Diff 269303. JDevlieghere added a comment. Add unstaged file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81058/new/ https://reviews.llvm.org/D81058 Files: lldb/include/lldb/Interpreter/CommandReturnObject.h

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham added a comment. In D80112#2078574 , @fallkrum wrote: > In D80112#2075097 , @jingham wrote: > > > If I understand the problem you are describing, it is that you suspended a > > thread as a user-level

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

JDevlieghere updated this revision to Diff 269287. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81058/new/ https://reviews.llvm.org/D81058 Files:

[Lldb-commits] [PATCH] D81300: Enable -DLLDB_ENERGY when compiling against an internal SDK

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/CMakeLists.txt:132 +if($ENV{SDKROOT} MATCHES ".Internal.sdk$") + message(STATUS "LLDB debugserver energy support is enabled") I guess this should be guarded by `if(APPLE)`?

[Lldb-commits] [lldb] 731fee8 - [lldb] Fail evaluation of DWARF expressions with unknown opcodes

Author: Pavel Labath Date: 2020-06-08T15:52:28+02:00 New Revision: 731fee8b420c3877e3574dfd50dc29531f7153af URL: https://github.com/llvm/llvm-project/commit/731fee8b420c3877e3574dfd50dc29531f7153af DIFF: https://github.com/llvm/llvm-project/commit/731fee8b420c3877e3574dfd50dc29531f7153af.diff

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

This revision was automatically updated to reflect the committed changes. Closed by commit rG0081149f96bd: [lldb/DWARF] Fix PC value for artificial tail call frames for the GNU case (authored by labath). Changed prior to commit: https://reviews.llvm.org/D81010?vs=268102=269191#toc Repository:

[Lldb-commits] [lldb] 0081149 - [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

Author: Pavel Labath Date: 2020-06-08T14:44:36+02:00 New Revision: 0081149f96bd62f1d1d21040ead30bfded86e8e5 URL: https://github.com/llvm/llvm-project/commit/0081149f96bd62f1d1d21040ead30bfded86e8e5 DIFF: https://github.com/llvm/llvm-project/commit/0081149f96bd62f1d1d21040ead30bfded86e8e5.diff

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

labath added inline comments. Comment at: lldb/source/Utility/Stream.cpp:178 +bool Stream::HasColors() const { return m_color_enabled; } + It looks like the only use for this function and the member variable is to initialize the ColorEnabled field of the

[Lldb-commits] [lldb] 4c50cf9 - [lldb] Fix YAMLModuleTester for the rename in 67b4afc4

Author: Pavel Labath Date: 2020-06-08T13:34:03+02:00 New Revision: 4c50cf9197370a6a42601bf39c0cd8606b8ff6ec URL: https://github.com/llvm/llvm-project/commit/4c50cf9197370a6a42601bf39c0cd8606b8ff6ec DIFF: https://github.com/llvm/llvm-project/commit/4c50cf9197370a6a42601bf39c0cd8606b8ff6ec.diff

[Lldb-commits] [PATCH] D81334: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

labath added a comment. Thanks for tracking this down, and for creating a nice test case. I think the implementation would be cleaner with a new argument, as per the inline comment. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.h:113 - size_t

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

labath added a comment. In D81119#2074109 , @jankratochvil wrote: > In D81119#2073973 , @labath wrote: > > > PS: You can still just drop the test if you think that's too much hassle. :) > > > It is sure nice to

[Lldb-commits] [PATCH] D81363: Disable remove-add module test on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG6143874f734b: [lldb] Disable remove-add module test on Windows (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81363/new/

[Lldb-commits] [lldb] 6143874 - [lldb] Disable remove-add module test on Windows

Author: Jaroslav Sevcik Date: 2020-06-08T08:21:07Z New Revision: 6143874f734bf3b27eeeb82d7756e008cba3b043 URL: https://github.com/llvm/llvm-project/commit/6143874f734bf3b27eeeb82d7756e008cba3b043 DIFF: https://github.com/llvm/llvm-project/commit/6143874f734bf3b27eeeb82d7756e008cba3b043.diff