[Lldb-commits] [lldb] 43031a3 - [lldb] Fix OptionValueFileColonLine to compile with MSVC

Author: Jonas Devlieghere Date: 2020-07-20T21:25:33-07:00 New Revision: 43031a38ff7f8ebe8048b136b0529ab0ea625e15 URL: https://github.com/llvm/llvm-project/commit/43031a38ff7f8ebe8048b136b0529ab0ea625e15 DIFF:

[Lldb-commits] [PATCH] D84210: [lldb] Use a weak pointer to hold on to the underlying thread plan in SBThreadPlan

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ba7ce401e76: [lldb] Use weak_ptr to hold on to the underlying thread plan in SBThreadPlan (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

This revision was automatically updated to reflect the committed changes. Closed by commit rGa54c42df9a72: Fix how we handle bit-fields for Objective-C when creating an AST (authored by shafik). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

This revision was automatically updated to reflect the committed changes. jingham marked 2 inline comments as done. Closed by commit rGbc0a9a17a4a6: Add an option (-y) to break set and source list that uses the same file… (authored by jingham). Changed prior to commit:

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rGf07ddbc9c4b6: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D84070?vs=278893=279406#toc Repository: rG

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b16e45f66e2: Enable -Wsuggest-override in the LLVM build (authored by logan-5). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84126/new/

[Lldb-commits] [PATCH] D84210: [lldb] Use a weak pointer to hold on to the underlying thread plan in SBThreadPlan

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, labath, teemperor. JDevlieghere updated this revision to Diff 279379. JDevlieghere added a comment. jingham accepted this revision. This revision is now accepted and ready to land. `s/thread_plan/thread_plan_sp/g`

[Lldb-commits] [PATCH] D84210: [lldb] Use a weak pointer to hold on to the underlying thread plan in SBThreadPlan

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84210/new/ https://reviews.llvm.org/D84210 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D84210: [lldb] Use a weak pointer to hold on to the underlying thread plan in SBThreadPlan

jingham added a comment. Yes, the only way you can get your hands on an SBThreadPlan is in the process of queueing one, so the ThreadPlan stack will always be the one to manage the lifecycle of a plan. And if an SBThreadPlan represents a ThreadPlan that has been discarded, it should convert

[Lldb-commits] [PATCH] D84210: [lldb] Use a weak pointer to hold on to the underlying thread plan in SBThreadPlan

JDevlieghere updated this revision to Diff 279379. JDevlieghere added a comment. `s/thread_plan/thread_plan_sp/g` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84210/new/ https://reviews.llvm.org/D84210 Files: lldb/include/lldb/API/SBThreadPlan.h lldb/include/lldb/lldb-forward.h

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279351. aelitashen added a comment. Add a white space in Symbols loaded info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a space before the '(' of the debug info size. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:357 + std::ostringstream oss; + oss << "("; + oss <<

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

mstorsjo added a subscriber: hans. mstorsjo added a comment. @hans - I think this one could be a fairly safe backport to the release branch. (Apparently phab lags behind regarding updating the reviews when they are committed at the moment; this was committed as

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

bbli added a comment. > I presume you don't have commit access and need someone to commit this for > you? Yup, that would be great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/new/ https://reviews.llvm.org/D83425

[Lldb-commits] [PATCH] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

labath added a comment. In D83552#2162555 , @friss wrote: > The `lldbtest.py` part LGTM, but I'm failing to see how this interacts with > `TestWeakSymbols.py`? IIRC, `registerSharedLibraryWithTarget` is an API we > call explicitly in the tests, but I

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279303. aelitashen added a comment. Remove white space for test_module_event Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[Lldb-commits] [lldb] bc0a9a1 - Add an option (-y) to "break set" and "source list" that uses the same

Author: Jim Ingham Date: 2020-07-20T17:40:36-07:00 New Revision: bc0a9a17a4a658153f4b524da3274d33a98d1c5b URL: https://github.com/llvm/llvm-project/commit/bc0a9a17a4a658153f4b524da3274d33a98d1c5b DIFF: https://github.com/llvm/llvm-project/commit/bc0a9a17a4a658153f4b524da3274d33a98d1c5b.diff

[Lldb-commits] [Differential] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jingham marked 2 inline comments as done. Closed by commit rGbc0a9a17a4a6: Add an

[Lldb-commits] [lldb] b79dff0 - [lldb] Make sure we don't leak SBThreadPlan pointer (NFCI)

Author: Jonas Devlieghere Date: 2020-07-20T16:58:06-07:00 New Revision: b79dff02795074ca5a4937fc1c93cf0dc7b8d943 URL: https://github.com/llvm/llvm-project/commit/b79dff02795074ca5a4937fc1c93cf0dc7b8d943 DIFF:

[Lldb-commits] [lldb] 2ba7ce4 - [lldb] Use weak_ptr to hold on to the underlying thread plan in SBThreadPlan

Author: Jonas Devlieghere Date: 2020-07-20T16:55:17-07:00 New Revision: 2ba7ce401e760990abb938c57e48c9d77d1b50de URL: https://github.com/llvm/llvm-project/commit/2ba7ce401e760990abb938c57e48c9d77d1b50de DIFF:

[Lldb-commits] [Differential] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

This revision was automatically updated to reflect the committed changes. Closed by commit rGa54c42df9a72: Fix how we handle bit-fields for Objective-C when creating an AST (authored by shafik). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] a54c42d - Fix how we handle bit-fields for Objective-C when creating an AST

Author: shafik Date: 2020-07-20T16:12:29-07:00 New Revision: a54c42df9a7261eafc9291128be4ff5217302dd3 URL: https://github.com/llvm/llvm-project/commit/a54c42df9a7261eafc9291128be4ff5217302dd3 DIFF: https://github.com/llvm/llvm-project/commit/a54c42df9a7261eafc9291128be4ff5217302dd3.diff LOG:

[Lldb-commits] [lldb] b1a6d37 - [PlatformMacOSX] Remove unused variable. NFC.

Author: Davide Italiano Date: 2020-07-20T14:50:59-07:00 New Revision: b1a6d373d5e0adbaa1ed70a9cadcfa84420a449f URL: https://github.com/llvm/llvm-project/commit/b1a6d373d5e0adbaa1ed70a9cadcfa84420a449f DIFF:

[Lldb-commits] [lldb] cd05406 - [testsuite] Adapt lldb-server base test helper to run on arm64

Author: Davide Italiano Date: 2020-07-20T14:38:13-07:00 New Revision: cd05406b105334b01f0eae141e7e05d6fb4a2ecb URL: https://github.com/llvm/llvm-project/commit/cd05406b105334b01f0eae141e7e05d6fb4a2ecb DIFF:

[Lldb-commits] [lldb] 001c8e1 - [PlatformDarwin] Add support for Apple Silicon.

Author: Davide Italiano Date: 2020-07-20T14:11:19-07:00 New Revision: 001c8e1fd9f09d3de9ff6e64bdac4b8ca681dfb4 URL: https://github.com/llvm/llvm-project/commit/001c8e1fd9f09d3de9ff6e64bdac4b8ca681dfb4 DIFF:

[Lldb-commits] [Differential] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf07ddbc9c4b6: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol (authored by mstorsjo). Changed prior to commit:

[Lldb-commits] [lldb] f07ddbc - [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

Author: Martin Storsjö Date: 2020-07-20T22:42:28+03:00 New Revision: f07ddbc9c4b66e91aa7a106042512ee903b6b3ba URL: https://github.com/llvm/llvm-project/commit/f07ddbc9c4b66e91aa7a106042512ee903b6b3ba DIFF:

[Lldb-commits] [lldb] f8df2e1 - [lldb/Reproducers] Always record the current working directory

Author: Jonas Devlieghere Date: 2020-07-20T11:54:11-07:00 New Revision: f8df2e1a19913e997d8d6dbe573de977406e736e URL: https://github.com/llvm/llvm-project/commit/f8df2e1a19913e997d8d6dbe573de977406e736e DIFF:

[Lldb-commits] [lldb] 3f16114 - [lldb] Fix method name to match LLDB code style (NFC)

Author: Jonas Devlieghere Date: 2020-07-20T11:54:11-07:00 New Revision: 3f16114ddb7896a91311c40f7070eb7f828c20cf URL: https://github.com/llvm/llvm-project/commit/3f16114ddb7896a91311c40f7070eb7f828c20cf DIFF:

[Lldb-commits] [PATCH] D84015: [lldb] Remove orphaned modules in a loop

shafik added a comment. Thank you for this fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84015/new/ https://reviews.llvm.org/D84015 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. In addition to it, I tried the below code, but it did not go well. ("\x1b[nD" moves the cursor n steps to the left.) self.child.send("hel") self.child.expect_exact(faint_color + "p frame" + reset + "\x1b[" + str(len("p frame")) + "D") In the first place, the

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. What Pavel said :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83975/new/ https://reviews.llvm.org/D83975

[Lldb-commits] [PATCH] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

friss added a comment. The `lldbtest.py` part LGTM, but I'm failing to see how this interacts with `TestWeakSymbols.py`? IIRC, `registerSharedLibraryWithTarget` is an API we call explicitly in the tests, but I don't see it called here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 marked an inline comment as done. gedatsu217 added inline comments. Comment at: lldb/source/Core/IOHandler.cpp:204 + .GetAutoSuggestionForCommand(line)) +result = res.getValue(); +} labath wrote: > gedatsu217 wrote: > > labath

[Lldb-commits] [lldb] 7fadd70 - [lldb/Utility] Simplify Scalar::SetValueFromData

Author: Pavel Labath Date: 2020-07-20T15:56:56+02:00 New Revision: 7fadd7006932adfe65f445aad1e60fe8d7b81eec URL: https://github.com/llvm/llvm-project/commit/7fadd7006932adfe65f445aad1e60fe8d7b81eec DIFF: https://github.com/llvm/llvm-project/commit/7fadd7006932adfe65f445aad1e60fe8d7b81eec.diff

[Lldb-commits] [lldb] 9decf04 - [lldb/test] Simplify Makefile rules for .d files

Author: Pavel Labath Date: 2020-07-20T15:53:19+02:00 New Revision: 9decf0405fe1bd79325ca47dba15d8914608e242 URL: https://github.com/llvm/llvm-project/commit/9decf0405fe1bd79325ca47dba15d8914608e242 DIFF: https://github.com/llvm/llvm-project/commit/9decf0405fe1bd79325ca47dba15d8914608e242.diff

[Lldb-commits] [lldb] 9199457 - [LLDB/test] Simplify result formatter code

Author: Pavel Labath Date: 2020-07-20T14:56:49+02:00 New Revision: 9199457bfb5a77121a950df5417fadbf8174cdde URL: https://github.com/llvm/llvm-project/commit/9199457bfb5a77121a950df5417fadbf8174cdde DIFF: https://github.com/llvm/llvm-project/commit/9199457bfb5a77121a950df5417fadbf8174cdde.diff

[Lldb-commits] [lldb] d9920e0 - Revert "AArch64 SVE register infos and core file support"

Author: Muhammad Omair Javaid Date: 2020-07-20T17:37:17+05:00 New Revision: d9920e0199b48734ef305e69ecd5235fff72be25 URL: https://github.com/llvm/llvm-project/commit/d9920e0199b48734ef305e69ecd5235fff72be25 DIFF:

[Lldb-commits] [lldb] 7e017de - AArch64 SVE register infos and core file support

Author: Muhammad Omair Javaid Date: 2020-07-20T17:21:16+05:00 New Revision: 7e017de0ad62dfd3f373354fc47b0e39c0fef657 URL: https://github.com/llvm/llvm-project/commit/7e017de0ad62dfd3f373354fc47b0e39c0fef657 DIFF:

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e017de0ad62: AArch64 SVE register infos and core file support (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [Differential] D77047: AArch64 SVE register infos and core file support

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e017de0ad62: AArch64 SVE register infos and core file support (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D77047?vs=278617=279006#toc

[Lldb-commits] [PATCH] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

labath added a comment. Any thoughts on this? It should fix the failures from D83306 ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83552/new/ https://reviews.llvm.org/D83552

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

jhenderson added a comment. In principle, this approach looks fine, but please do as @labath suggests to reduce the amount of changes in one go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84008/new/ https://reviews.llvm.org/D84008

[Lldb-commits] [Differential] D83753: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rG4923dca9bd8f: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64 (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4923dca - Remove use of multiple reg index enums by RegisterContextPOSIX_arm64

Author: Muhammad Omair Javaid Date: 2020-07-20T14:54:51+05:00 New Revision: 4923dca9bd8fe8a635cbc3d4f8affc4d03bdb0ca URL: https://github.com/llvm/llvm-project/commit/4923dca9bd8fe8a635cbc3d4f8affc4d03bdb0ca DIFF:

[Lldb-commits] [PATCH] D83753: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rG4923dca9bd8f: Remove use of multiple reg index enums by RegisterContextPOSIX_arm64 (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ca9b589c453: Remove Linux sysroot dependencies of SVE PT macros (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7ca9b58 - Remove Linux sysroot dependencies of SVE PT macros

Author: Muhammad Omair Javaid Date: 2020-07-20T14:54:51+05:00 New Revision: 7ca9b589c45302feb28c0b3b0e80088c0901bb40 URL: https://github.com/llvm/llvm-project/commit/7ca9b589c45302feb28c0b3b0e80088c0901bb40 DIFF:

[Lldb-commits] [Differential] D83541: Remove Linux sysroot dependencies of SVE PT macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ca9b589c453: Remove Linux sysroot dependencies of SVE PT macros (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D83541?vs=277702=279000#toc

[Lldb-commits] [PATCH] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

labath marked an inline comment as done. labath added a comment. Looks fine to me, modulo the clang-format issues. Comment at: lldb/source/Interpreter/OptionValueFileColonLine.cpp:74 + + // First separate the file and the line specification: + llvm::StringRef

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

Higuoxing added a comment. In D84008#2161461 , @labath wrote: > In D84008#2161243 , @Higuoxing wrote: > > > In D84008#2160426 , @MaskRay wrote: > > > > > The number of

[Lldb-commits] [PATCH] D83425: [lldb] add printing of stdout compile errors to lldbsuite

labath accepted this revision. labath added a subscriber: aprantl. labath added a comment. This revision is now accepted and ready to land. In D83425#2161255 , @bbli wrote: > > Setting this no longer makes sense, as it will always be empty. Please > >

[Lldb-commits] [PATCH] D83541: Remove Linux sysroot dependencies of SVE PT macros

omjavaid updated this revision to Diff 279152. omjavaid added a comment. One minor last minute change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83541/new/ https://reviews.llvm.org/D83541 Files: lldb/source/Plugins/Process/Linux/LinuxPTraceDefines_arm64sve.h

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

labath added a comment. In D84008#2161243 , @Higuoxing wrote: > In D84008#2160426 , @MaskRay wrote: > > > The number of changed tests is large. Is it worth moving the > > `IO.mapOptional("Length", Unit.Length);`

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

omjavaid updated this revision to Diff 279151. omjavaid added a comment. This update makes minor adjustments before merge in light of final comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files:

[Lldb-commits] [Differential] D84015: [lldb] Remove orphaned modules in a loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG139e2a3f7b27: [lldb] Remove orphaned modules in a loop (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D84015: [lldb] Remove orphaned modules in a loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG139e2a3f7b27: [lldb] Remove orphaned modules in a loop (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 139e2a3 - [lldb] Remove orphaned modules in a loop

Author: Raphael Isemann Date: 2020-07-20T10:47:56+02:00 New Revision: 139e2a3f7b279ca886c71b676f983ea314c36568 URL: https://github.com/llvm/llvm-project/commit/139e2a3f7b279ca886c71b676f983ea314c36568 DIFF:

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

labath accepted this revision. labath added a comment. Thanks. If you think this is worth cherry-picking to 11.0 (it sounds like it is), please file the appropriate bug. Comment at: lldb/test/Shell/ObjectFile/PECOFF/symbol.yaml:104 StorageClass:IMAGE_SYM_CLASS_STATIC

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added a comment. In D81001#2158645 , @teemperor wrote: > Not sure if there is a good way to test that the text is directly behind the > cursor, but we can test that it's there. I guess that would be done by expecting the appropriate cursor

[Lldb-commits] [lldb] 43f8a7c - [lldb][NFC] Remove unused FormattersContainer::Get overload

Author: Raphael Isemann Date: 2020-07-20T09:59:43+02:00 New Revision: 43f8a7c83b748f1509fa7ebf7276353018755995 URL: https://github.com/llvm/llvm-project/commit/43f8a7c83b748f1509fa7ebf7276353018755995 DIFF: