Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks, Vitaly! Let's have them there for at least 24 hours, shall we? Could you move sanitizer-buildbot1, sanitizer-buildbot3, sanitizer-buildbot7 as well, please? AnnotatedCommand on the staging has been tested functionally and is good. My only concern at this point is how it would handle a

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, lawrence_danna. JDevlieghere requested review of this revision. Add support for importing scripts relative the current home directory. rdar://68310384 https://reviews.llvm.org/D89295 Files:

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Looks like staging AnnotatedCommand fixed step statuses, so we can see which one is green. Please let me know when to switch bots back from the staging. Thank you! On Mon, 12 Oct 2020 at 21:38, Vitaly Buka wrote: > Switched all but PPC, I don't have access to them. But they run the same >

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Switched all but PPC, I don't have access to them. But they run the same script as sanitizer-x86_64-linux. http://lab.llvm.org:8014/#/waterfall?tags=sanitizer On Mon, 12 Oct 2020 at 19:19, Galina Kistanova wrote: > We have a better version of AnnotatedCommand on the staging. It should be > a

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

We have a better version of AnnotatedCommand on the staging. It should be a functional equivalent of the old one. We need to stress test it well before moving to the production build bot. For that we need all sanitizer + other bots which use the AnnotatedCommand directly or indirectly moved

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 297736. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 Files: lldb/include/lldb/Target/Trace.h

[Lldb-commits] [lldb] ec2c2ad - Add accessors. (NFC)

Author: Adrian Prantl Date: 2020-10-12T17:45:49-07:00 New Revision: ec2c2ad2a2dddf24b052625b5ff434704ea43e24 URL: https://github.com/llvm/llvm-project/commit/ec2c2ad2a2dddf24b052625b5ff434704ea43e24 DIFF: https://github.com/llvm/llvm-project/commit/ec2c2ad2a2dddf24b052625b5ff434704ea43e24.diff

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. wallace requested review of this revision. This diff finally implements trace decoding! The current interface is $ trace load

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08924b54debc: [lldb] Remove unused code in GetVersion (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 08924b5 - [lldb] Remove unused code in GetVersion (NFC)

Author: Dave Lee Date: 2020-10-12T16:31:14-07:00 New Revision: 08924b54debcfd47bcf22a8213308cec7d22b975 URL: https://github.com/llvm/llvm-project/commit/08924b54debcfd47bcf22a8213308cec7d22b975 DIFF: https://github.com/llvm/llvm-project/commit/08924b54debcfd47bcf22a8213308cec7d22b975.diff

[Lldb-commits] [PATCH] D89273: [lldb] Handle alternative output in TestAbortExitCode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa52cc9b4be36: [lldb] Handle alternative output in TestAbortExitCode (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] a52cc9b - [lldb] Handle alternative output in TestAbortExitCode

Author: Dave Lee Date: 2020-10-12T16:27:06-07:00 New Revision: a52cc9b4be362b12ca261000b723374d4b772a45 URL: https://github.com/llvm/llvm-project/commit/a52cc9b4be362b12ca261000b723374d4b772a45 DIFF: https://github.com/llvm/llvm-project/commit/a52cc9b4be362b12ca261000b723374d4b772a45.diff

[Lldb-commits] [lldb] 360ab00 - [lldb] Add instrumentation runtime category

Author: Jonas Devlieghere Date: 2020-10-12T16:02:40-07:00 New Revision: 360ab009e2b95629388cef132ebe639c120ed35e URL: https://github.com/llvm/llvm-project/commit/360ab009e2b95629388cef132ebe639c120ed35e DIFF:

[Lldb-commits] [lldb] e465dda - [lldb] Alphabetically sort test categories (NFC)

Author: Jonas Devlieghere Date: 2020-10-12T16:02:40-07:00 New Revision: e465ddac880228b879b5a6549adbb9c8a7f335bf URL: https://github.com/llvm/llvm-project/commit/e465ddac880228b879b5a6549adbb9c8a7f335bf DIFF:

[Lldb-commits] [PATCH] D89273: [lldb] Handle alternative output in TestAbortExitCode

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. This test On macOS, this test can instead return `status = 0 (0x) Terminated due

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1362 + + NativeThreadLinux = *GetThreadByID(GetID()); + assert(thread.GetState() ==

[Lldb-commits] [lldb] 26d861c - [trace] Scaffold "thread trace dump instructions"

Author: Walter Erquinigo Date: 2020-10-12T12:08:18-07:00 New Revision: 26d861cbbd5f40182b3b7f0ac7ed0e58e0e8feaa URL: https://github.com/llvm/llvm-project/commit/26d861cbbd5f40182b3b7f0ac7ed0e58e0e8feaa DIFF:

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26d861cbbd5f: [trace] Scaffold thread trace dump instructions (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo

Re: [Lldb-commits] [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

I switched one of our workers to the main Buildbot and everything seems fine #fingers-crossed. I guess that that was a temporary glitch? We haven't updated our local Buildbot installations - still on 0.8.5. Should we update? -Andrzej On 09/10/2020 00:44, Galina Kistanova wrote: Hi Paula,

Re: [Lldb-commits] [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hey Andrzej, What are you seeing in your buildbot logs? Is it this error? `twisted.spread.flavors.NoSuchMethod: No such method: remote_getWorkerInfo` If so, you might want to try updating your buildbot worker. I updated llvmlibc's to 2.8.4 and that seemed to solve the connection problem:

Re: [Lldb-commits] [cfe-dev] Upcoming upgrade of LLVM buildbot

Our Flang-aarch64 buildbots just won't connect to the main Buildbot master anymore. I switched them to the staging buildbot master instead and it seems fine for now. Is there anything that we can/should tweak at our end? http://lab.llvm.org:8014/#/waterfall?tags=flang -Andrzej On 08/10/2020

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Wed, Oct 7, 2020 at 4:32 PM Galina Kistanova via lldb-commits < lldb-commits@lists.llvm.org> wrote: > They are online now - http://lab.llvm.org:8011/#/waterfall?tags=sanitizer > > AnnotatedCommand has severe design conflict with the new buildbot. > We have changed it to be safe and still do

[Lldb-commits] [lldb] f21fccc - [LLDB] Fix 37 tests on Windows

Author: Adrian McCarthy Date: 2020-10-12T11:10:00-07:00 New Revision: f21fcccef7197f911a27b960aa2a180e0c7724aa URL: https://github.com/llvm/llvm-project/commit/f21fcccef7197f911a27b960aa2a180e0c7724aa DIFF:

[Lldb-commits] [PATCH] D89256: [LLDB] Fix 37 tests on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGf21fcccef719: [LLDB] Fix 37 tests on Windows (authored by amccarth). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89256/new/

[Lldb-commits] [PATCH] D89256: [LLDB] Fix 37 tests on Windows

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89256/new/ https://reviews.llvm.org/D89256 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D89256: [LLDB] Fix 37 tests on Windows

amccarth created this revision. amccarth added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. amccarth requested review of this revision. A Windows-style LLDB_PYTHON_HOME path in a Cmake template didn't have the backslashes escaped, which led to a garbled paths derived from it.

[Lldb-commits] [PATCH] D89215: [lldb] Add a page to the documentation with (external) links on how to use LLDB

vsk added a comment. + 1, this looks good to me. I think there might be room to include a short (~1 sentence) summary next to each extension entry, so readers know what to expect before clicking on one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89215/new/

[Lldb-commits] [PATCH] D89248: [lldb] [test/Register] Add read/write tests for multithreaded process

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. mgorny requested review of this revision. Add a test to verify that 'register read' and 'register write' commands work correctly in a multithreaded program, in particular

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

labath added a comment. In D89124#2325008 , @jankratochvil wrote: > In file included from > /home/jkratoch/redhat/llvm-monorepo/lldb/source/Host/common/NativeProcessProtocol.cpp:9: >

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

jankratochvil added a comment. In file included from /home/jkratoch/redhat/llvm-monorepo/lldb/source/Host/common/NativeProcessProtocol.cpp:9: /home/jkratoch/redhat/llvm-monorepo/lldb/include/lldb/Host/common/NativeProcessProtocol.h:20:10: fatal error: 'lldb/Utility/UnimplementedError.h' file

[Lldb-commits] [lldb] 2d1ee7c - [lldb] Note difference in vFile:pread/pwrite format for lldb

Author: David Spickett Date: 2020-10-12T15:09:49+01:00 New Revision: 2d1ee7cae9b2299186fa25d8d1fbdb8af482046c URL: https://github.com/llvm/llvm-project/commit/2d1ee7cae9b2299186fa25d8d1fbdb8af482046c DIFF:

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d1ee7cae9b2: [lldb] Note difference in vFile:pread/pwrite format for lldb (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

labath added inline comments. Comment at: lldb/docs/lldb-platform-packets.txt:10 defined there (vFile:size:, vFile:mode:, vFile:symlink, vFile:chmod:). Most importantly, the flags that lldb passes to vFile:open: are incompatible with the flags that gdb specifies.

[Lldb-commits] [PATCH] D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743)

labath created this revision. labath added reviewers: shafik, teemperor. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. labath requested review of this revision. Displaying large packed bitfields did not work if one was accessing them through a pointer, and he used the "->"

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added inline comments. Comment at: lldb/docs/lldb-platform-packets.txt:10 defined there (vFile:size:, vFile:mode:, vFile:symlink, vFile:chmod:). Most importantly, the flags that lldb passes to vFile:open: are incompatible with the flags that gdb specifies.

[Lldb-commits] [PATCH] D89121: [lldb/Utility] Introduce UnimplementedError

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2f1fe361a9c: [lldb/Utility] Introduce UnimplementedError (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e2f1fe3 - [lldb/Utility] Introduce UnimplementedError

Author: Pavel Labath Date: 2020-10-12T13:46:17+02:00 New Revision: e2f1fe361a9c7616a1d6459b036d15f47da4a073 URL: https://github.com/llvm/llvm-project/commit/e2f1fe361a9c7616a1d6459b036d15f47da4a073 DIFF: https://github.com/llvm/llvm-project/commit/e2f1fe361a9c7616a1d6459b036d15f47da4a073.diff

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

labath added a subscriber: jasonmolenda. labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ah, interesting. We already know of one incompatibility in vFile packets -- it seems you have found a second one. Making note of this is a good idea.

[Lldb-commits] [lldb] 54434dc - [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit

Author: Jan Kratochvil Date: 2020-10-12T13:26:54+02:00 New Revision: 54434dc4dce9d59c4d6cebfd87e5f67e2966573b URL: https://github.com/llvm/llvm-project/commit/54434dc4dce9d59c4d6cebfd87e5f67e2966573b DIFF:

[Lldb-commits] [PATCH] D89165: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54434dc4dce9: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit (authored by jankratochvil). Repository: rG LLVM Github Monorepo

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks, I see them. On Wed, 7 Oct 2020 at 16:32, Galina Kistanova wrote: > They are online now - http://lab.llvm.org:8011/#/waterfall?tags=sanitizer > > AnnotatedCommand has severe design conflict with the new buildbot. > We have changed it to be safe and still do something useful, but it will

[Lldb-commits] [PATCH] D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL

krytarowski added a comment. In D89182#2324267 , @labath wrote: > FWIW, PTHREAD_KILL is strongly discouraged on linux. But if the situation is > different on freebsd, then fine. I think you mean PTRACE_KILL. PT_KILL is fine for BSDs and in case when it

[Lldb-commits] [PATCH] D89227: [lldb] Note different vFile:pread/pwrite format for lldb

DavidSpickett added a reviewer: labath. DavidSpickett added a comment. This is the compatibility issue I mentioned in the other review. I found it investigating why remotely debugging lldb would work with lldb but not gdb, turned out to be a >2gb file causing it but I saw the different formats

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added a comment. In D82863#2321647 , @labath wrote: > In D82863#2321370 , @omjavaid wrote: > >> In D82863#2320342 , @jasonmolenda >> wrote: >> >>> The original g/G

[Lldb-commits] [PATCH] D89227: [lldb] Note different vFile:pread/pwrite format for lldb

DavidSpickett created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. https://sourceware.org/gdb/current/onlinedocs/gdb/Host-I_002fO-Packets.html States that all

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1354 + auto region_it = llvm::find_if(m_mem_region_cache, [](const auto ) { +return pair.first.GetExecutable() == MemoryRegionInfo::eYes; + }); jankratochvil

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

labath updated this revision to Diff 297523. labath added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89124/new/ https://reviews.llvm.org/D89124 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

labath added a comment. I assume this fixes some of the tests we have already, but it would be good to mention that in the description. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:479 + case XSaveRegSet: +// TODO: can

[Lldb-commits] [PATCH] D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL

labath added a comment. Herald added a subscriber: JDevlieghere. FWIW, PTHREAD_KILL is strongly discouraged on linux. But if the situation is different on freebsd, then fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89182/new/

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:61 + const std::vector ) { + TraceSP trace_instance(new TraceIntelPT(pt_cpu, targets)); + for (const TargetSP _sp :

[Lldb-commits] [PATCH] D89165: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89165/new/ https://reviews.llvm.org/D89165