Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

How were you setting the breakpoint in the case where it was failing from the command line? The breakpoint you are examining in the test in your patches is a "source regular expression" breakpoint. That would be "break set -p". If you were also doing that in the command line and got a

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 marked 4 inline comments as done. augusto2112 added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:371 + StreamString name_with_slash_stream; + name_with_slash_stream.Format("/{0}", process_name); + auto

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 updated this revision to Diff 316782. augusto2112 added a comment. Addresses comments, includes tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94672/new/ https://reviews.llvm.org/D94672 Files:

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

Thanks for the pointers! So I tried writing an API-type test for this line table/breakpoint behavior (it doesn't seem like it's entirely/just the line table (for one thing, the DWARF change is purely in the subprogram DIE, not in the line table)) and I can't seem to figure it out. The attached

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:359-366 + if (!include_existing) { +// Create the excluded process list before polling begins. +Host::FindProcesses(match_info, exclusion_list); +

[Lldb-commits] [PATCH] D94629: [LLDB] MinidumpParser: Prefer executable module even at higher address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85dfcaadc5f0: [LLDB] MinidumpParser: Prefer executable module even at higher address (authored by JosephTremoulet). Repository: rG LLVM Github

[Lldb-commits] [lldb] 85dfcaa - [LLDB] MinidumpParser: Prefer executable module even at higher address

Author: Joseph Tremoulet Date: 2021-01-14T13:17:57-05:00 New Revision: 85dfcaadc5f0920dc8ecbece6c786701b8f45ab4 URL: https://github.com/llvm/llvm-project/commit/85dfcaadc5f0920dc8ecbece6c786701b8f45ab4 DIFF:

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:377 + // by the desired name. + auto should_exclude_process = [_list, _name, + _with_slash]( labath

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:372 + name_with_slash_stream.Format("/{0}", process_name); + auto name_with_slash = name_with_slash_stream.GetString(); + augusto2112 wrote:

[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

labath added a comment. In D94077#2489064 , @werat wrote: > Thanks for the explanation, this makes sense. I've checked the mailing list > archives and it seems there was already a discussion about the enumerators in > the `.debug_names` index back in

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:372 + name_with_slash_stream.Format("/{0}", process_name); + auto name_with_slash =

[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

augusto2112 created this revision. augusto2112 added reviewers: labath, clayborg, jingham, aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implements the required functions on gdb-remote so the '--include-existing'

[Lldb-commits] [lldb] a997a1d - [lldb/test] Ensure launched processes are ready to be attached

Author: Pavel Labath Date: 2021-01-14T12:07:04+01:00 New Revision: a997a1d7fbe229433fb458bb0035b32424ecf3bd URL: https://github.com/llvm/llvm-project/commit/a997a1d7fbe229433fb458bb0035b32424ecf3bd DIFF: https://github.com/llvm/llvm-project/commit/a997a1d7fbe229433fb458bb0035b32424ecf3bd.diff

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. Thanks for your patience. I think this is in a pretty good shape now. Just a couple of quick questions inline... Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:410 + if (success && do_reconfigure_arm64_sve &&

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

labath added a comment. Using remote numbers in the lists seems reasonable as well, but I am troubled by the "opportunistic" aspect of the implementation. This pattern uint32_t lldb_regnum = ConvertRegisterKindToRegisterNumber( eRegisterKindProcessPlugin, reg); if (lldb_regnum !=

[Lldb-commits] [lldb] 4b284b9 - [lldb] Fix TestPlatformProcessConnect.py

Author: Pavel Labath Date: 2021-01-14T09:49:19+01:00 New Revision: 4b284b9ca8098e284b8d965a633b71bd283043d6 URL: https://github.com/llvm/llvm-project/commit/4b284b9ca8098e284b8d965a633b71bd283043d6 DIFF: https://github.com/llvm/llvm-project/commit/4b284b9ca8098e284b8d965a633b71bd283043d6.diff

[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2bbf724feea9: Implement vAttachWait in lldb-server (authored by augusto2112, committed by labath). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 2bbf724 - Implement vAttachWait in lldb-server

Author: Augusto Noronha Date: 2021-01-14T09:25:15+01:00 New Revision: 2bbf724feea9824f9b9e4d20d34828023dbec2af URL: https://github.com/llvm/llvm-project/commit/2bbf724feea9824f9b9e4d20d34828023dbec2af DIFF: