[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

nitesh.jain added a comment. In D96766#2596701 , @labath wrote: > Hm I'm very tempted to delete the linux mips implementation -- it uses > several techniques which are getting in the way of this patch (and also some > others in the past), for a lot

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

jankratochvil added a comment. In D97721#2598798 , @kwk wrote: > @jankratochvil out of curiosity. Can you give a pointer to what the C program > looks like that produces the object code? int main() {} Fedora Rawhide: gcc -o main.s main.c -gdwarf-5

[Lldb-commits] [lldb] db8b159 - [lldb] Inline objc_opt->version >= 14 to avoid dealing with bool type

Author: Jonas Devlieghere Date: 2021-03-02T16:41:44-08:00 New Revision: db8b1598b7187ff378b7b82c266d1993b0a39191 URL: https://github.com/llvm/llvm-project/commit/db8b1598b7187ff378b7b82c266d1993b0a39191 DIFF:

[Lldb-commits] [lldb] c85d47f - [lldb] Add more logging to __lldb_apple_objc_v2_get_dynamic_class_info

Author: Jonas Devlieghere Date: 2021-03-02T16:24:59-08:00 New Revision: c85d47f7b821a5e9030dffa6613f6257c5f39446 URL: https://github.com/llvm/llvm-project/commit/c85d47f7b821a5e9030dffa6613f6257c5f39446 DIFF:

[Lldb-commits] [PATCH] D97778: [lldb] Extend Python convenience variable table with equivalent APIs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf46a441b1c5d: [lldb] Extend Python convenience variable table with equivalent APIs (authored by JDevlieghere). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5826aa48f03f: Migrate to llvm::unique_function instead of static member functions for… (authored by nealsid, committed by JDevlieghere).

[Lldb-commits] [lldb] f46a441 - [lldb] Extend Python convenience variable table with equivalent APIs

Author: Jonas Devlieghere Date: 2021-03-02T16:13:55-08:00 New Revision: f46a441b1c5dfb0a2580f656e1506fa138f21165 URL: https://github.com/llvm/llvm-project/commit/f46a441b1c5dfb0a2580f656e1506fa138f21165 DIFF:

[Lldb-commits] [lldb] 5826aa4 - Migrate to llvm::unique_function instead of static member functions for callbacks

Author: Neal (nealsid) Date: 2021-03-02T16:13:54-08:00 New Revision: 5826aa48f03fba215b135f3c21ee52662281134d URL: https://github.com/llvm/llvm-project/commit/5826aa48f03fba215b135f3c21ee52662281134d DIFF:

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Progress.h:100 + /// The title of the progress activity. + ConstString m_message; + /// How much work ([0...m_total]) that has been completed. teemperor wrote: > `std::string` Agreed, after I

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

kwk added a comment. @jankratochvil out of curiosity. Can you give a pointer to what the C program looks like that produces the object code? I know GCC might change and no longer produce this code so it's better to have the obj code instead. But still I'm not nearly close to understanding

[Lldb-commits] [lldb] 14ccba2 - Promote scalars to load addresses when dereferencing them.

Author: Adrian Prantl Date: 2021-03-02T14:30:39-08:00 New Revision: 14ccba26bd4d4f78cf5ec2ca8bb55c95913a3ec5 URL: https://github.com/llvm/llvm-project/commit/14ccba26bd4d4f78cf5ec2ca8bb55c95913a3ec5 DIFF: https://github.com/llvm/llvm-project/commit/14ccba26bd4d4f78cf5ec2ca8bb55c95913a3ec5.diff

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

jingham added a comment. While next to the binary seems like a better guess than the cwd, it does seem awkward that if the binary & dwo's aren't in the same place, you have to move files to get that heuristic to work, whereas you could just "cd" into wherever the dwo's got dumped to make the

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

labath added a comment. In D97786#2598100 , @cmtice wrote: > re "GDB does it this way" -- I am also writing/submitting a patch to get GDB > to change this behavior. Ah, I see. That changes the picture, I'd say. If gdb folks go along with that, then I

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

cmtice added a comment. It is true that the compiler will not know where the final executable will be placed, and if the executable gets moved then debugging with .dwo files will probably not work anyway, However as it is currently written, LLDB will fail to find the .dwo files, *even when

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

labath added a subscriber: thakis. labath added a comment. Also, cc @thakis, who floated the idea of using a special path token (`$ORIGIN`) to achieve the same thing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786

[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

mgorny marked an inline comment as done. mgorny added a comment. I'm sorry for not replying earlier. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_mips64.cpp:141 + uint64_t f31; + uint64_t fcsr; + uint64_t fir; jrtc27 wrote: > MIPS

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

labath added a comment. In general, a compiler also does not know where the final executable will be placed -- this can be only (maybe) be said for a sufficiently strict build system (like the one at google). I wouldn't say that searching relative to the cwd is really that much better, but at

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

cmtice updated this revision to Diff 327523. cmtice added a comment. Upload the correct patch this time. (sorry!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Index:

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

smeenai added a comment. Is this rebased on main? The LLD for Mach-O changes look like they belong to a different diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

cmtice created this revision. cmtice added a reviewer: jingham. Herald added subscribers: cishida, hiraditya. Herald added a reviewer: int3. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. cmtice requested review of this revision. Herald added a reviewer: jdoerfert. Herald

[Lldb-commits] [PATCH] D97769: [lldb] Apply gdb-remote timeout to platform connections as well

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97769/new/ https://reviews.llvm.org/D97769

[Lldb-commits] [PATCH] D97778: [lldb] Extend Python convenience variable table with equivalent APIs

JDevlieghere updated this revision to Diff 327501. JDevlieghere added a comment. Use single backtick so Sphinx automatically links the API docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97778/new/ https://reviews.llvm.org/D97778 Files: lldb/docs/use/python-reference.rst Index:

[Lldb-commits] [PATCH] D97778: [lldb] Extend Python convenience variable table with equivalent APIs

JDevlieghere updated this revision to Diff 327489. JDevlieghere added a comment. Use backticks (everywhere) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97778/new/ https://reviews.llvm.org/D97778 Files: lldb/docs/use/python-reference.rst Index: lldb/docs/use/python-reference.rst

[Lldb-commits] [PATCH] D97778: [lldb] Extend Python convenience variable table with equivalent APIs

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Cool! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97778/new/ https://reviews.llvm.org/D97778 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D97778: [lldb] Extend Python convenience variable table with equivalent APIs

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. JDevlieghere requested review of this revision. Add a column to the table of convenience variables with the equivalent API to get to the current debugger, target, process, etc. We often get asked to make convenience

[Lldb-commits] [PATCH] D97760: [lldb][NFC] Delete unused AddressResolverName

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97760/new/ https://reviews.llvm.org/D97760 ___

[Lldb-commits] [PATCH] D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)

werat updated this revision to Diff 327469. werat added a comment. Use `clang_host` instead of `clang` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97765/new/ https://reviews.llvm.org/D97765 Files:

[Lldb-commits] [lldb] 1b8fdaa - [nfc] [lldb] DWARFDebugInfoEntry::Extract(): reindent

Author: Jan Kratochvil Date: 2021-03-02T16:44:07+01:00 New Revision: 1b8fdaacf49442dccacfe6e942b894150b287143 URL: https://github.com/llvm/llvm-project/commit/1b8fdaacf49442dccacfe6e942b894150b287143 DIFF:

[Lldb-commits] [lldb] 61c2932 - [lldb] DWARFDebugInfoEntry::Extract(): Print an error for unsupported DW_FORM_*

Author: Jan Kratochvil Date: 2021-03-02T16:39:04+01:00 New Revision: 61c29321b3dffa3ae45483dd7678faedaef535a7 URL: https://github.com/llvm/llvm-project/commit/61c29321b3dffa3ae45483dd7678faedaef535a7 DIFF:

[Lldb-commits] [PATCH] D97769: [lldb] Apply gdb-remote timeout to platform connections as well

labath created this revision. labath added reviewers: JDevlieghere, clayborg. Herald added a subscriber: kristof.beyls. labath requested review of this revision. Herald added a project: LLDB. We have a plugin.process.gdb-remote.packet-timeout setting, which can be used to control how long the

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related test failures

mgorny added a comment. Herald added a subscriber: JDevlieghere. I've edited both bugs (https://bugs.llvm.org/show_bug.cgi?id=48421 and https://bugs.llvm.org/show_bug.cgi?id=48376) to cover the generic problem. I can't promise I'll have time to work on them in the next ~2 months but if you

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4096ae06f47a: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC) (authored by jankratochvil). Changed prior to commit:

[Lldb-commits] [lldb] 4096ae0 - [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

Author: Jan Kratochvil Date: 2021-03-02T15:17:23+01:00 New Revision: 4096ae06f47af9db2c2550a2c34979edfbd91b8d URL: https://github.com/llvm/llvm-project/commit/4096ae06f47af9db2c2550a2c34979edfbd91b8d DIFF:

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added a comment. This looks good apart from minor nits inline Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; ptrace request is a success if number of tags requested is not equal to

[Lldb-commits] [PATCH] D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s:17 + +// RUN: %clang -o %t

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:43 + +ptrdiff_t MemoryTagManagerAArch64MTE::AddressDiff(lldb::addr_t addr1, + lldb::addr_t addr2) const {

[Lldb-commits] [PATCH] D97696: [lldb] Enable cross CU decl file test only for x64 Linux

werat abandoned this revision. werat added a comment. The original commit was reverted, abandon in favor of https://reviews.llvm.org/D97765 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97696/new/ https://reviews.llvm.org/D97696

[Lldb-commits] [PATCH] D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)

werat created this revision. werat added reviewers: JDevlieghere, labath, jankratochvil. Herald added a reviewer: shafik. werat requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Apply changes from

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:43 + +ptrdiff_t MemoryTagManagerAArch64MTE::AddressDiff(lldb::addr_t addr1, + lldb::addr_t addr2) const {

[Lldb-commits] [PATCH] D97498: [LLDB] Support GDB remote g packet partial read

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG536783170f08: Support GDB remote g packet partial read (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 5367831 - Support GDB remote g packet partial read

Author: Muhammad Omair Javaid Date: 2021-03-02T17:21:48+05:00 New Revision: 536783170f0843838b2d521f8a0331f174f60e3c URL: https://github.com/llvm/llvm-project/commit/536783170f0843838b2d521f8a0331f174f60e3c DIFF:

[Lldb-commits] [PATCH] D97696: [lldb] Enable cross CU decl file test only for x64 Linux

teemperor added a comment. You can just directly land these bot fixes (or you revert the original aptch). Not sure if I'm the right person to review this as I rarely touch the shell tests, but Jonas or Pavel probably know for sure what's the proper way to restrict the test environment for this

[Lldb-commits] [PATCH] D97760: [lldb][NFC] Delete unused AddressResolverName

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added subscribers: JDevlieghere, mgorny. teemperor requested review of this revision. That's all just dead code that hasn't been changed in years. https://reviews.llvm.org/D97760 Files:

[Lldb-commits] [lldb] 1432ab1 - [lldb] Add missing include to Cloneable.h

Author: Raphael Isemann Date: 2021-03-02T11:01:08+01:00 New Revision: 1432ab171f9dece77b141d6c11da895275de14be URL: https://github.com/llvm/llvm-project/commit/1432ab171f9dece77b141d6c11da895275de14be DIFF:

[Lldb-commits] [lldb] a63daf6 - [lldb] Remote leftover _llgs from TestGdbRemoteConnection.py

Author: Pavel Labath Date: 2021-03-02T10:59:25+01:00 New Revision: a63daf693ca4b67d8fae8546024d954fb2659c24 URL: https://github.com/llvm/llvm-project/commit/a63daf693ca4b67d8fae8546024d954fb2659c24 DIFF: https://github.com/llvm/llvm-project/commit/a63daf693ca4b67d8fae8546024d954fb2659c24.diff

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

teemperor added inline comments. Comment at: lldb/source/Commands/CommandObjectTrace.cpp:119 lldb::TraceSP trace_sp = traceOrErr.get(); - if (m_options.m_verbose) + if (m_options.m_verbose && trace_sp) result.AppendMessageWithFormat("loading trace with

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5de2d189e6ad: [Diagnose] Unify MCContext and LLVMContext diagnosing (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

labath added a subscriber: nitesh.jain. labath added a comment. Hm I'm very tempted to delete the linux mips implementation -- it uses several techniques which are getting in the way of this patch (and also some others in the past), for a lot of those, we now have different/better ways of

[Lldb-commits] [PATCH] D97486: [lldb/Core] Change large function threshold variable into a setting.

mib added a comment. In D97486#2596523 , @labath wrote: > As the author of this logic, I want to note that the original limit I chose > was very arbitrary, and 32k (or any other small-ish number would work equally > well). The main objective was to

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for working on this. I really like the idea and I think this would be really cool to have. I do have some concerns about the way this is implemented though (see inline

[Lldb-commits] [PATCH] D97498: [LLDB] Support GDB remote g packet partial read

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems reasonable. I think the names like `m_read_all_at_once` and `ReadAllRegisters` will now be somewhat confusing. Maybe it would be worth (in a separate patch) renaming them to something

[Lldb-commits] [PATCH] D97486: [lldb/Core] Change large function threshold variable into a setting.

labath added a comment. In D97486#2596523 , @labath wrote: > I'm not actually opposed to the, just wanting to make sure you're not adding > it on my account. to the **setting** Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D97486: [lldb/Core] Change large function threshold variable into a setting.

labath added a comment. As the author of this logic, I want to note that the original limit I chose was very arbitrary, and 32k (or any other small-ish number would work equally well). The main objective was to disable accidental multi-megabyte disassemblies (which can happen when the object

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

labath added a comment. In D95712#2566203 , @JDevlieghere wrote: > In D95712#2563091 , @labath wrote: > >> Unfortunately I don't have the bandwidth to review this, though I feel that >> this should have a wider

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-line-strp.s:51-54 + .uleb128 0x3# (DIE (0x4c) DW_TAG_base_type) + .byte 0x4 #