[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

2021-08-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileSaver.cpp:19 +#include "lldb/lldb-types.h" +#include "llvm/Analysis/ModuleSummaryAnalysis.h" +#include "llvm/Support/Error.h" this doesn't seem relevant

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

2021-08-09 Thread Jakob Johnson via Phabricator via lldb-commits
jj10306 added a comment. A more comprehensive test for this logic was added in https://reviews.llvm.org/D107674 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

2021-08-09 Thread Jakob Johnson via Phabricator via lldb-commits
jj10306 updated this revision to Diff 365346. jj10306 added a comment. - fix comment style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107674/new/ https://reviews.llvm.org/D107674 Files: lldb/docs/htr.rst lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

2021-08-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/TraceExporter/common/TraceHTR.cpp:394-419 +/* +name: load address of the first instruction of the block and the name +of

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

2021-08-09 Thread Jakob Johnson via Phabricator via lldb-commits
jj10306 updated this revision to Diff 365341. jj10306 added a comment. - move documentation to plugin directory - remove unnecessary checks in tests and remove test that wasn't testing anything different than the others - nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107674/new/

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

2021-08-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp:267-281 +llvm::Expected> PostMortemThreadDecoder::GetRawTrace() { + FileSpec trace_file = m_trace_thread->GetTraceFile(); + ErrorOr> trace_or_error = +

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

2021-08-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:75 + virtual llvm::Error SaveToDisk(FileSpec directory, + lldb::ProcessSP _sp) = 0; + clayborg wrote: > This class will already have a process in

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add a more comprehensive test for `thread trace export ctf` command

2021-08-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace added inline comments. Comment at: lldb/test/API/commands/trace/TestTraceExport.py:68-69 + +if os.path.exists(ctf_test_file): +remove_file(ctf_test_file) +self.expect(f"thread trace export ctf --file {ctf_test_file}") you

[Lldb-commits] [PATCH] D107669: [trace] [intel pt] Create a "process trace save" command

2021-08-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Target/Trace.h:75 + virtual llvm::Error SaveToDisk(FileSpec directory, + lldb::ProcessSP

[Lldb-commits] [PATCH] D107674: [tests] [trace] Add more comprehensive for `thread trace export ctf` command

2021-08-09 Thread walter erquinigo via Phabricator via lldb-commits
wallace added a comment. Thank you, this is much more understandable Comment at: lldb/docs/htr.rst:1 Hierarchical Trace Representation (HTR) == I'd be good to put these documentation files next in

[Lldb-commits] [PATCH] D107625: Add a stack-memory-only style for Darwin process save-core

2021-08-09 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda updated this revision to Diff 365319. jasonmolenda added a comment. Have debugserver report malloc memory regions too, aka heap. I don't know how to use this in lldb yet, but it was easy to add so I thought I'd add it. Maybe we'll come up with an idea for it later. On Darwin,

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/source/Core/IOHandler.cpp:374 + if (got_line) { +goto gotLine; + } A `goto` is not warranted here, using `if (!got_line && !in` is perfectly fine and less lines. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D107700: [lldb] [cmake] Add LLVM_LIT_ARGS override support for standalone builds

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG614c7d03877f: [lldb] [cmake] Add LLVM_LIT_ARGS override support for standalone builds (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 614c7d0 - [lldb] [cmake] Add LLVM_LIT_ARGS override support for standalone builds

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T23:36:01+02:00 New Revision: 614c7d03877fd99c2de47429b15be3f00306a3bd URL: https://github.com/llvm/llvm-project/commit/614c7d03877fd99c2de47429b15be3f00306a3bd DIFF: https://github.com/llvm/llvm-project/commit/614c7d03877fd99c2de47429b15be3f00306a3bd.diff

[Lldb-commits] [PATCH] D107700: [lldb] [cmake] Add LLVM_LIT_ARGS override support for standalone builds

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Well, I actually find it useful to be able to override lit args per project. Maybe some future solution would be to have it declared as a cache variable from some LLVM CMake file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107700/new/

[Lldb-commits] [PATCH] D107700: [lldb] [cmake] Add LLVM_LIT_ARGS override support for standalone builds

2021-08-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A possible alternative would be to export LLVM_LIT_ARGS from the llvm build so that lldb inherits it. I'm pretty much on the fence: on the one hand this doesn't really seems like

[Lldb-commits] [PATCH] D107700: [lldb] [cmake] Add LLVM_LIT_ARGS override support for standalone builds

2021-08-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D107700#2935385 , @mgorny wrote: > @JDevlieghere, could you also look at this one? I'm not really sure if > anybody maintains LLDBStandalone at this point. I think it's pretty much just me these days. I would really

[Lldb-commits] [PATCH] D107700: [lldb] [cmake] Add LLVM_LIT_ARGS override support for standalone builds

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. @JDevlieghere, could you also look at this one? I'm not really sure if anybody maintains LLDBStandalone at this point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107700/new/ https://reviews.llvm.org/D107700 ___

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365267. gAlfonso-bit added a comment. clang-tidy workaround CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/include/lldb/Core/IOHandler.h lldb/source/Core/IOHandler.cpp Index:

[Lldb-commits] [PATCH] D107701: [lldb] [test] Skip Expr/nodefaultlib.cpp test if LD_PRELOAD Is used

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG15cacab73f7e: [lldb] [test] Skip Expr/nodefaultlib.cpp test if LD_PRELOAD Is used (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 15cacab - [lldb] [test] Skip Expr/nodefaultlib.cpp test if LD_PRELOAD Is used

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T21:35:11+02:00 New Revision: 15cacab73f7e36d9dca4a5516ccb360b67bf2dbc URL: https://github.com/llvm/llvm-project/commit/15cacab73f7e36d9dca4a5516ccb360b67bf2dbc DIFF: https://github.com/llvm/llvm-project/commit/15cacab73f7e36d9dca4a5516ccb360b67bf2dbc.diff

[Lldb-commits] [PATCH] D107701: [lldb] [test] Skip Expr/nodefaultlib.cpp test if LD_PRELOAD Is used

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107701/new/ https://reviews.llvm.org/D107701 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. This covers client side only, I'm going to work on the server side `vFile:stat` packet later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107780/new/ https://reviews.llvm.org/D107780 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107780: [lldb] [gdb-remote] Implement fallback to vFile:stat for GetFileSize()

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, jasonmolenda, emaste, JDevlieghere. mgorny requested review of this revision. Implement a fallback to getting the file size via vFile:stat packet when the remote server does not implement vFile:size. This makes it

[Lldb-commits] [PATCH] D107701: [lldb] [test] Skip Expr/nodefaultlib.cpp test if LD_PRELOAD Is used

2021-08-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107701/new/ https://reviews.llvm.org/D107701 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365220. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Ok, I've reverted my previous attempts and just marked the tests for skipping on Windows. Hopefully this'll work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107475/new/ https://reviews.llvm.org/D107475

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365218. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp

[Lldb-commits] [lldb] 27b238a - [lldb] [test] Skip all vFile tests on Windows

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T19:38:05+02:00 New Revision: 27b238af163e52b9f575f854a3f391514412b25c URL: https://github.com/llvm/llvm-project/commit/27b238af163e52b9f575f854a3f391514412b25c DIFF: https://github.com/llvm/llvm-project/commit/27b238af163e52b9f575f854a3f391514412b25c.diff

[Lldb-commits] [lldb] 816aa9a - Revert "[lldb] [test] Mark new vFile tests as XFAIL on Windows"

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T19:38:05+02:00 New Revision: 816aa9a5d794d0556bbe59770659aa50fbebd6c5 URL: https://github.com/llvm/llvm-project/commit/816aa9a5d794d0556bbe59770659aa50fbebd6c5 DIFF: https://github.com/llvm/llvm-project/commit/816aa9a5d794d0556bbe59770659aa50fbebd6c5.diff

[Lldb-commits] [lldb] 4c830b5 - Revert "[lldb] [test] Use Windows-friendly modes in vFile O_CREAT tests"

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T19:38:05+02:00 New Revision: 4c830b5f35f0f4058d84732fafcc38c12a7969b3 URL: https://github.com/llvm/llvm-project/commit/4c830b5f35f0f4058d84732fafcc38c12a7969b3 DIFF: https://github.com/llvm/llvm-project/commit/4c830b5f35f0f4058d84732fafcc38c12a7969b3.diff

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365217. gAlfonso-bit added a comment. Simplify function even further CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

2021-08-09 Thread Omar Emara via Phabricator via lldb-commits
OmarEmaraDev added a comment. @clayborg This is unrelated to D107761 , so it should be safe to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llvm.org/D107386

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. In D107475#2934924 , @stella.stamenova wrote: > This change is causing failures on the Windows lldb bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/9098 I've already attempted to fix this, I'll try more. It doesn't

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

2021-08-09 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. This change is causing failures on the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/9098 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107475/new/ https://reviews.llvm.org/D107475

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

2021-08-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D107659#2934245 , @jankratochvil wrote: > Thanks for checking it but ... > > In D107659#2931836 , @clayborg > wrote: > >> Can we not just grab the skeleton unit when/if needed

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

2021-08-09 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just fix the possible crash when SetText gets a NULL string pointer, and this is good to go. We also need to get the "is_pad(...)" fix in before this can be submitted right?

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for the patch! I think we can actually simplify that code even more by just removing the `!got_line` checks in both ifs? There is really no reason to have them from

[Lldb-commits] [lldb] 3240000 - [lldb][NFC] Remove never read member variable IOHandler::m_editing

2021-08-09 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-08-09T18:05:53+02:00 New Revision: 32454652d47467d23b73ada5c8a599087167 URL: https://github.com/llvm/llvm-project/commit/32454652d47467d23b73ada5c8a599087167 DIFF:

[Lldb-commits] [lldb] 52d89d2 - [lldb] [test] Mark vFile tests as LLGS-specific

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T17:43:37+02:00 New Revision: 52d89d26aa29d983aa7842829370be2ee5f8c76a URL: https://github.com/llvm/llvm-project/commit/52d89d26aa29d983aa7842829370be2ee5f8c76a DIFF: https://github.com/llvm/llvm-project/commit/52d89d26aa29d983aa7842829370be2ee5f8c76a.diff

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107767/new/ https://reviews.llvm.org/D107767 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG875a16bcfc28: [lldb] Fix break introduced in 14735ca (authored by rgiese, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 875a16b - [lldb] Fix break introduced in 14735ca

2021-08-09 Thread Raphael Isemann via lldb-commits
Author: Robin Giese Date: 2021-08-09T17:34:57+02:00 New Revision: 875a16bcfc28ba4959d67e2a4ad853f909d4ab83 URL: https://github.com/llvm/llvm-project/commit/875a16bcfc28ba4959d67e2a4ad853f909d4ab83 DIFF: https://github.com/llvm/llvm-project/commit/875a16bcfc28ba4959d67e2a4ad853f909d4ab83.diff

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I'm landing this to unbreak Green Dragon. @mgorny Just a heads up, I think this also broke one test with debugserver:

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Robin Giese via Phabricator via lldb-commits
rgiese added a comment. @teemperor please hold while I figure out how to update the patch with @mgorny 's cleaner suggestion. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107767/new/ https://reviews.llvm.org/D107767

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. I'm sorry about missing this. Comment at: lldb/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm:428-431 if ((oflag & O_RDWR) || (oflag & O_RDONLY)) -file_options |= File::eOpenOptionRead; +

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks. I assume you don't have commit access so I'll land this for you in a minute :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D107767: Fix break introduced in 14735ca

2021-08-09 Thread Robin Giese via Phabricator via lldb-commits
rgiese created this revision. rgiese requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `File::OpenOptions` were renamed; this fixes up a callsite that breaks for macOS builds. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 116b112 - [lldb] [test] Use Windows-friendly modes in vFile O_CREAT tests

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T15:43:08+02:00 New Revision: 116b112bbfe043aba16d732c2eec783f0b817bb4 URL: https://github.com/llvm/llvm-project/commit/116b112bbfe043aba16d732c2eec783f0b817bb4 DIFF: https://github.com/llvm/llvm-project/commit/116b112bbfe043aba16d732c2eec783f0b817bb4.diff

[Lldb-commits] [lldb] 0dc57a6 - [lldb] [test] Mark new vFile tests as XFAIL on Windows

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T15:43:08+02:00 New Revision: 0dc57a66a0b1aa2cac88e236f7748b022666bdc5 URL: https://github.com/llvm/llvm-project/commit/0dc57a66a0b1aa2cac88e236f7748b022666bdc5 DIFF: https://github.com/llvm/llvm-project/commit/0dc57a66a0b1aa2cac88e236f7748b022666bdc5.diff

[Lldb-commits] [PATCH] D107761: [LLDB][GUI] Refactor form drawing using subsurfaces

2021-08-09 Thread Omar Emara via Phabricator via lldb-commits
OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. This is a reimplementation of D107182 , which was committed and then reverted because the `is_pad` function is not universally supported. The updated patch adds an explicit type member to

[Lldb-commits] [PATCH] D107761: [LLDB][GUI] Refactor form drawing using subsurfaces

2021-08-09 Thread Omar Emara via Phabricator via lldb-commits
OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new method SubSurface to the Surface class. The

[Lldb-commits] [lldb] d6bf9dc - [lldb] [test] Fix TestGdbRemotePlatformFile with non-022 umask

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T14:12:06+02:00 New Revision: d6bf9dcbd5d4b198ed55c311be27fee927d8721c URL: https://github.com/llvm/llvm-project/commit/d6bf9dcbd5d4b198ed55c311be27fee927d8721c DIFF: https://github.com/llvm/llvm-project/commit/d6bf9dcbd5d4b198ed55c311be27fee927d8721c.diff

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

2021-08-09 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. Thanks for checking it but ... In D107659#2931836 , @clayborg wrote: > Can we not just grab the skeleton unit when/if needed instead of asserting in > many places? ... I am not sure @clayborg likes the assertions.

[Lldb-commits] [PATCH] D107659: [nfc] [lldb] Assertions for D106270 - [DWARF5] Fix offset check when using .debug_names

2021-08-09 Thread Kim-Anh Tran via Phabricator via lldb-commits
kimanh accepted this revision. kimanh added a comment. This revision is now accepted and ready to land. LGTM, I also support that assertions are added. This gives confidence in what's expected and also makes it easier to read/understand whether it's a skeleton/non-skeleton unit that we are

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

2021-08-09 Thread Kim-Anh Tran via Phabricator via lldb-commits
kimanh added a comment. Thanks for the review! Landing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106270/new/ https://reviews.llvm.org/D106270 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 0dda542 - [DWARF5] Fix offset check when using .debug_names

2021-08-09 Thread Kim-Anh Tran via lldb-commits
Author: Kim-Anh Tran Date: 2021-08-09T13:15:14+02:00 New Revision: 0dda5425318a5785e3e19cfe369a43b221b9642d URL: https://github.com/llvm/llvm-project/commit/0dda5425318a5785e3e19cfe369a43b221b9642d DIFF: https://github.com/llvm/llvm-project/commit/0dda5425318a5785e3e19cfe369a43b221b9642d.diff

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

2021-08-09 Thread Kim-Anh Tran via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0dda5425318a: [DWARF5] Fix offset check when using .debug_names (authored by kimanh). Changed prior to commit:

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

2021-08-09 Thread Omar Emara via Phabricator via lldb-commits
OmarEmaraDev added a comment. @jingham I see. Thanks! Here is how it looks now: F18450643: 20210809-130123.png <https://reviews.llvm.org/F18450643> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

2021-08-09 Thread Omar Emara via Phabricator via lldb-commits
OmarEmaraDev updated this revision to Diff 365145. OmarEmaraDev added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. - Address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9929cfbcd5bf: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packats for GDB compliance (authored by mgorny). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D106985: [lldb] [gdb-remote] Sync vFile:open mode constants with GDB

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bbef4f9afd8: [lldb] [gdb-remote] Sync vFile:open mode constants with GDB (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [PATCH] D106984: [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat

2021-08-09 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14735cab6554: [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat (authored by mgorny). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] 9929cfb - [lldb] [gdb-remote] Use hexadecimal numbers in vFile packats for GDB compliance

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T12:07:33+02:00 New Revision: 9929cfbcd5bf5402fbb180e5bb3f917f50bbdf94 URL: https://github.com/llvm/llvm-project/commit/9929cfbcd5bf5402fbb180e5bb3f917f50bbdf94 DIFF: https://github.com/llvm/llvm-project/commit/9929cfbcd5bf5402fbb180e5bb3f917f50bbdf94.diff

[Lldb-commits] [lldb] 8bbef4f - [lldb] [gdb-remote] Sync vFile:open mode constants with GDB

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T12:07:18+02:00 New Revision: 8bbef4f9afd8b5f6b4435d5bab48b75f048f353c URL: https://github.com/llvm/llvm-project/commit/8bbef4f9afd8b5f6b4435d5bab48b75f048f353c DIFF: https://github.com/llvm/llvm-project/commit/8bbef4f9afd8b5f6b4435d5bab48b75f048f353c.diff

[Lldb-commits] [lldb] 14735ca - [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat

2021-08-09 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-08-09T12:06:59+02:00 New Revision: 14735cab655441ba45c4b88ad82f11267e5fe916 URL: https://github.com/llvm/llvm-project/commit/14735cab655441ba45c4b88ad82f11267e5fe916 DIFF: https://github.com/llvm/llvm-project/commit/14735cab655441ba45c4b88ad82f11267e5fe916.diff

[Lldb-commits] [lldb] 8813bc0 - [LLDB] Skip random fails on Arm/AArch64 Linux buildbot

2021-08-09 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2021-08-09T13:53:48+05:00 New Revision: 8813bc02b40c90eeca0b30ec46aa898bd49e1522 URL: https://github.com/llvm/llvm-project/commit/8813bc02b40c90eeca0b30ec46aa898bd49e1522 DIFF: