[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

labath added a comment. I fear this is going to be an endless whack-a-mole. There's no way every contributor will remember to (correctly) add this feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109834/new/ https://reviews.llvm.org/D109834 __

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

vsk added inline comments. Comment at: lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py:19 +@skipUnlessDarwin +@skipIf(archs=['i386','x86_64']) # exception codes not yet supported for Intel macs +def test(self): jasonmol

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

jasonmolenda added a comment. very nice. Comment at: lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py:19 +@skipUnlessDarwin +@skipIf(archs=['i386','x86_64']) # exception codes not yet supported for Intel macs +def test(self): -

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

vsk updated this revision to Diff 372836. vsk added a comment. - Add a test (thanks @jasonmolenda!). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109795/new/ https://reviews.llvm.org/D109795 Files: lldb/include/lldb/Target/AppleArm64ExceptionCl

[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h:130 - // Given a mangled function name, calculates some alternative manglings since - // the compiler mangling may not line up with the symbol we are expecting - static ui

[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h:130 - // Given a mangled function name, calculates some alternative manglings since - // th

[Lldb-commits] [PATCH] D109633: [lldb-vscode] Fix focus thread when previous thread exits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17589538aaef: [lldb-vscode] Fix focus thread when previous thread exits (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 1758953 - [lldb-vscode] Fix focus thread when previous thread exits

Author: Ted Woodward Date: 2021-09-15T18:09:32-05:00 New Revision: 17589538aaef2b5ae27a0bfeb4346aff433aa59d URL: https://github.com/llvm/llvm-project/commit/17589538aaef2b5ae27a0bfeb4346aff433aa59d DIFF: https://github.com/llvm/llvm-project/commit/17589538aaef2b5ae27a0bfeb4346aff433aa59d.diff

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

ted added a comment. In D109738#3000608 , @jingham wrote: > BTW, do you know what change made this stop working? https://github.com/llvm-mirror/lldb/commit/43793406 in the old multirepo. In the monorepo, it's https://github.com/llvm/llvm-project/commit/

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

vsk added a comment. FTR, I was able to write a test using `process save-core`, but even with `-s dirty` this is generating gigabytes of data and would presumably be super-flaky on the bots. I also tried `-s stack`, but for the test program I passed in (just some 2-line .c file that dereference

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp:112 + auto exception_class = + static_cast(esr_val >> 26); + if (exception_class != vsk wrote: > jasonmolenda wrote: > > shafik

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

vsk added inline comments. Comment at: lldb/include/lldb/Target/AppleArm64ExceptionClass.h:14 + +enum class AppleArm64ExceptionClass : unsigned { +#define APPLE_ARM64_EXCEPTION_CLASS(Name, Code) Name = Code, shafik wrote: > We should use fixed sized integer types

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

vsk updated this revision to Diff 372809. vsk marked 3 inline comments as done. vsk added a comment. Address review feedback: - Include far register in output, which now looks like e.g.: (lldb) bt all * thread #1, stop reason = ESR_EC_DABORT_EL0 (fault address: 0x6261747563657860) * fra

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. Hi Jim, I think there's a bit of confusion going on here: The original bug was opened by Ted Woodward, and I think his scenario was motivated by embedded debugging. He also provided that example with a breakpoint being set in main. I've rediscovered this bug independent

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

jingham added a comment. In D109738#3001122 , @vadimcn wrote: >> In the future, can you generate patches with context (i.e. pass -U to >> "git diff" or "git show"), it's a lot easier to read patches with context. > > Sure thing, will do. > > This does

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

thakis created this revision. thakis added a reviewer: amccarth. thakis requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Before this change, running check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO would fail ~25 tests. This change adds a lit

[Lldb-commits] [PATCH] D109832: [lldb/win] Fix TestIRMemoryMapWindows.test when running tests in git bash

thakis created this revision. thakis added a reviewer: amccarth. Herald added a subscriber: pengfei. thakis requested review of this revision. lit.util.which('link') picks up the wrong link.exe in git bash, leading to this error: 1. command stderr: /usr/bin/link: extra operand '/LIBPATH:C:\\Progr

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 372711. emrekultursay added a comment. Applied clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: lldb/source/Plugins/DynamicLoader/POSIX-DYL

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

DavidSpickett added a comment. > I don't have a formal source for that one, but compiling a __debugbreak() > with MSVC produces that opcode. As Windows is thumb-only, we can always do a > breakpoint with that single opcode (even if the targeted instruction happens > to be a wide thumb2 instruct

[Lldb-commits] [PATCH] D109778: [lldb] [Windows] Fix an incorrect assert in NativeRegisterContextWindows_arm

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4133a21cef4: [lldb] [Windows] Fix an incorrect assert in NativeRegisterContextWindows_arm (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] b4133a2 - [lldb] [Windows] Fix an incorrect assert in NativeRegisterContextWindows_arm

Author: Martin Storsjö Date: 2021-09-15T15:03:20+03:00 New Revision: b4133a21cef49edb57cf96bb7d7518099d61e910 URL: https://github.com/llvm/llvm-project/commit/b4133a21cef49edb57cf96bb7d7518099d61e910 DIFF: https://github.com/llvm/llvm-project/commit/b4133a21cef49edb57cf96bb7d7518099d61e910.diff

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

mstorsjo added a comment. In D109777#3001429 , @DavidSpickett wrote: > https://docs.microsoft.com/en-us/cpp/intrinsics/debugbreak?view=msvc-160 > confirms the AArch64 breakpoint instruction, were you able to find a source > for the Arm/Thumb one? I do

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

mgorny added a comment. Ok, I don't see any obvious regressions while testing, so LGTM modulo formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 _

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. https://docs.microsoft.com/en-us/cpp/intrinsics/debugbreak?view=msvc-160 confirms the AArch64 breakpoint instruction, were you able to find a source for the Arm/Thumb one? Otherwise the logic seems fine. It would be g

[Lldb-commits] [PATCH] D109778: [lldb] [Windows] Fix an incorrect assert in NativeRegisterContextWindows_arm

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109778/new/ https://reviews.llvm.org/D109778 _

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny added a comment. @labath, could you look at my inline comments before I start moving stuff? ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

mgorny added a comment. I'm going to test this on FreeBSD in a minute. Could you fix clang-formatting in the meantime? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797

[Lldb-commits] [PATCH] D109691: [lldb] [ABI/AArch64] Recognize special regs by their xN names too

mgorny added a comment. @labath, the tests here require D109272 , as otherwise LLDB won't recognize the architecture correctly. If you review that one, I can rebase its tests not to require other patches and merge these two. CHANGES SINCE LAST ACTION https:/