[Lldb-commits] [lldb] 08f4b56 - [lldb] Include unistd.h for sleep in profile_vrs_detach

2021-10-21 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-10-21T17:32:15-07:00 New Revision: 08f4b56fb9795b5d271378fb62c3fed67ab1b754 URL: https://github.com/llvm/llvm-project/commit/08f4b56fb9795b5d271378fb62c3fed67ab1b754 DIFF:

[Lldb-commits] [lldb] 09b95b9 - [lldb] Always set the minimum OS version in the Darwin builder

2021-10-21 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-10-21T17:03:06-07:00 New Revision: 09b95b9dc9afb0c12e7d10faea17ed0cb6920b9f URL: https://github.com/llvm/llvm-project/commit/09b95b9dc9afb0c12e7d10faea17ed0cb6920b9f DIFF:

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

2021-10-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. The new output looks like: (lldb) statistics dump { "expressionEvaluation": { "failures": 0, "successes": 0 }, "firstStopTime": 0.3503082920002, "frameVariable": { "failures": 0, "successes": 0 },

[Lldb-commits] [PATCH] D112279: Add modules stats into the "statistics dump" command.

2021-10-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: JDevlieghere, labath, wallace, aadsm, jdoerfert. Herald added a subscriber: emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. The new module stats adds the

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

2021-10-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Fixed buildbots with: commit 910838f07da7872d2b7cca5b07d64ea9915b6767 (HEAD -> main, origin/main, origin/HEAD) Author: Greg Clayton Date: Thu Oct 21 14:21:36 2021 -0700 Fix buildbots after

[Lldb-commits] [lldb] 910838f - Fix buildbots after https://reviews.llvm.org/D111686

2021-10-21 Thread Greg Clayton via lldb-commits
Author: Greg Clayton Date: 2021-10-21T14:21:36-07:00 New Revision: 910838f07da7872d2b7cca5b07d64ea9915b6767 URL: https://github.com/llvm/llvm-project/commit/910838f07da7872d2b7cca5b07d64ea9915b6767 DIFF: https://github.com/llvm/llvm-project/commit/910838f07da7872d2b7cca5b07d64ea9915b6767.diff

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

2021-10-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D111686#3079352 , @teemperor wrote: > In D111686#3079248 , @clayborg > wrote: > >> So there is a buildbot failure due to an expression which succeeds, but >> because the

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

2021-10-21 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D111686#3079248 , @clayborg wrote: > So there is a buildbot failure due to an expression which succeeds, but > because the "expression" command options don't apply cleanly to the > expression result the "expression"

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

2021-10-21 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D112212#3078681 , @dblaikie wrote: > Does this sort of thing itself get tested? (like this one had a test: > https://reviews.llvm.org/D111978 but not sure how much that > generalizes/whether there are different parts of

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

2021-10-21 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. So there is a buildbot failure due to an expression which succeeds, but because the "expression" command options don't apply cleanly to the expression result the "expression" command fails. Question: do we want "expressionEvaluation" to truly track expression

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning updated this revision to Diff 381372. puremourning added a comment. Add some tests for dodgy inputs. Handle invalid cases more consistently. Factor out some copy paste code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/

[Lldb-commits] [lldb] 64f002c - Follow-up fixes for aee49255074fd4ef38d97e6e70cbfbf2f9fd0fa7

2021-10-21 Thread David Blaikie via lldb-commits
Author: David Blaikie Date: 2021-10-21T13:00:56-07:00 New Revision: 64f002c6d36d674a924c6116ec0b2d731cc3981c URL: https://github.com/llvm/llvm-project/commit/64f002c6d36d674a924c6116ec0b2d731cc3981c DIFF: https://github.com/llvm/llvm-project/commit/64f002c6d36d674a924c6116ec0b2d731cc3981c.diff

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning added a comment. In D11#3078896 , @shafik wrote: > It looks good to me but can we verify it behaves nicely with undefined > behavior cases e.g.: > > std::string s = "Hellooo "; > std::string_view sv = s + "World\n";

[Lldb-commits] [lldb] d7b3385 - Modify "statistics dump" to dump JSON.

2021-10-21 Thread Greg Clayton via lldb-commits
Author: Greg Clayton Date: 2021-10-21T12:14:21-07:00 New Revision: d7b338537cf360568474d31c2be86110ac22dc32 URL: https://github.com/llvm/llvm-project/commit/d7b338537cf360568474d31c2be86110ac22dc32 DIFF: https://github.com/llvm/llvm-project/commit/d7b338537cf360568474d31c2be86110ac22dc32.diff

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

2021-10-21 Thread Greg Clayton via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd7b338537cf3: Modify statistics dump to dump JSON. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111686/new/

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning updated this revision to Diff 381357. puremourning added a comment. Revert some formatting lost in rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 Files:

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. It looks good to me but can we verify it behaves nicely with undefined behavior cases e.g.: std::string s = "Hellooo "; std::string_view sv = s + "World\n"; and a case like the one that was fixed in D108228 I am not

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning added a comment. Thanks for the review! Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py:62 +ns = self.namespace +self.expect( +"frame variable",

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning updated this revision to Diff 381344. puremourning added a comment. Use expect_var_path rather than just expect in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 Files:

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

2021-10-21 Thread David Blaikie via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd723ad5bcf71: Enable libc++ in the build for libcxx initializerlist pretty printers (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d723ad5 - Enable libc++ in the build for libcxx initializerlist pretty printers

2021-10-21 Thread David Blaikie via lldb-commits
Author: David Blaikie Date: 2021-10-21T11:35:59-07:00 New Revision: d723ad5bcf7133c3f3950ebb63edf4ddfee56581 URL: https://github.com/llvm/llvm-project/commit/d723ad5bcf7133c3f3950ebb63edf4ddfee56581 DIFF: https://github.com/llvm/llvm-project/commit/d723ad5bcf7133c3f3950ebb63edf4ddfee56581.diff

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

2021-10-21 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. Does this sort of thing itself get tested? (like this one had a test: https://reviews.llvm.org/D111978 but not sure how much that generalizes/whether there are different parts of the infrastructure are more or less testable) Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D111686: Modify "statistics dump" to dump JSON.

2021-10-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I'm not super happy with the debugger stats as they are right here. Given that it only affects a subset of this patch and I don't want to block other work that depends on this,

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Jim Ingham via Phabricator via lldb-commits
jingham added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py:62 +ns = self.namespace +self.expect( +"frame variable", We have

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning updated this revision to Diff 381295. puremourning added a comment. RE-post with clang-format in path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 Files:

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning updated this revision to Diff 381293. puremourning added a comment. Remove change to the formatting of empty u16 and u32 strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 Files:

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning added a comment. > I would actually prefer if we could split this into a separate change :) > (Sorry!) No problem, that was my gut feeling at the time too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D11#3077988 , @puremourning wrote: > I'm happy to revert/split out the change for empty strings, as this is > perhaps contentious (and not exactly minimal for this patch). I would actually prefer if we could split

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning added a comment. I'm happy to revert/split out the change for empty strings, as this is perhaps contentious (and not exactly minimal for this patch). Also, I'm only implementing libcxx (for now). We can follow up with libstdc++ in another patch if this is accepted. This is my

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-10-21 Thread Ben Jackson via Phabricator via lldb-commits
puremourning created this revision. puremourning requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When printing a std::string_view, print the referenced string as the summary. Support string_view, u32string_view, u16string_view and

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

2021-10-21 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1422 +def runBuildCommands(self, commands): +for cmd in commands: +self.trace(shlex.join(cmd)) Is this ever going to have more than one

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

2021-10-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 381226. mgorny added a comment. This revision is now accepted and ready to land. Ok, this turned out to be a little bit harder than I anticipated — in particular I needed to add a copy constructor and assignment operator. @labath, do you think it's fine or

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

2021-10-21 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for working on this! Some notes/nits: - nit: The patch seems to have a bunch of unrelated clang-format changes for CPlusPlusLanguage.cpp in it. You can prevent that by

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1284 compiler = self.getCompilerBinary() -version_output = system([[compiler, "--version"]]) -for line in version_output.split(os.linesep): -m =

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 381223. labath added a comment. Respond to reviewer comments (thanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112212/new/ https://reviews.llvm.org/D112212 Files:

[Lldb-commits] [lldb] 6c88086 - [lldb] Fix a thinko in 2ace1e57

2021-10-21 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2021-10-21T14:05:49+02:00 New Revision: 6c88086ba8046884bb30a72ae1a8bea95e46f022 URL: https://github.com/llvm/llvm-project/commit/6c88086ba8046884bb30a72ae1a8bea95e46f022 DIFF: https://github.com/llvm/llvm-project/commit/6c88086ba8046884bb30a72ae1a8bea95e46f022.diff

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

2021-10-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny planned changes to this revision. mgorny added a comment. Something's broken. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

2021-10-21 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1284 compiler = self.getCompilerBinary() -version_output = system([[compiler, "--version"]]) -for line in

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

2021-10-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 381209. mgorny added a comment. Add explicit test for use in a `for` loop. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535 Files: lldb/source/Host/common/File.cpp

[Lldb-commits] [lldb] 3972415 - [lldb] Silence -Wpessimizing-move warning

2021-10-21 Thread Benjamin Kramer via lldb-commits
Author: Benjamin Kramer Date: 2021-10-21T12:59:00+02:00 New Revision: 39724158d38766f7d8683f78f54d80d174cae96a URL: https://github.com/llvm/llvm-project/commit/39724158d38766f7d8683f78f54d80d174cae96a DIFF:

[Lldb-commits] [PATCH] D112061: [lldb] Remove ConstString from GetPluginNameStatic of some plugins

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2ace1e5753a4: [lldb] Remove ConstString from GetPluginNameStatic of some plugins (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2ace1e5 - [lldb] Remove ConstString from GetPluginNameStatic of some plugins

2021-10-21 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2021-10-21T12:58:45+02:00 New Revision: 2ace1e5753a49195ca17f3e175c7e189cf147760 URL: https://github.com/llvm/llvm-project/commit/2ace1e5753a49195ca17f3e175c7e189cf147760 DIFF: https://github.com/llvm/llvm-project/commit/2ace1e5753a49195ca17f3e175c7e189cf147760.diff

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1425 +try: +proc = run(cmd, stdin=DEVNULL, stdout=PIPE, stderr=STDOUT, +check=True) PSA: this function is available from

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: teemperor, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. Running tests with -t prints all lldb commands being run. It makes sense to print all the build commands as well. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

2021-10-21 Thread Jaroslav Sevcik via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5a3556aa5563: [lldb] Add omitted abstract formal parameters in DWARF symbol files (authored by Jaroslav Sevcik ja...@chromium.org, committed by jarin). Changed prior to commit:

[Lldb-commits] [lldb] 5a3556a - [lldb] Add omitted abstract formal parameters in DWARF symbol files

2021-10-21 Thread Jaroslav Sevcik via lldb-commits
Author: Jaroslav Sevcik Date: 2021-10-21T12:33:42+02:00 New Revision: 5a3556aa5563fb89693935303463881df44094de URL: https://github.com/llvm/llvm-project/commit/5a3556aa5563fb89693935303463881df44094de DIFF:

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

2021-10-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 381189. mgorny added a comment. Update LLDB call sites again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535 Files: lldb/source/Host/common/File.cpp

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

2021-10-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 381187. mgorny edited the summary of this revision. mgorny added a comment. Restored support for `char Separator` — after all, it isn't hard and the cost is negligible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

2021-10-21 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. There is one on Green Dragon with a few Clang versions and I there is my Linux one with a all GCC/Clang versions Repository: rG LLVM Github

[Lldb-commits] [lldb] b8c3683 - [lldb] [Host/SerialPort] Add std::moves for better compatibility

2021-10-21 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-21T11:08:05+02:00 New Revision: b8c3683d46f92a693746217542ab4895562fa36c URL: https://github.com/llvm/llvm-project/commit/b8c3683d46f92a693746217542ab4895562fa36c DIFF: https://github.com/llvm/llvm-project/commit/b8c3683d46f92a693746217542ab4895562fa36c.diff

[Lldb-commits] [lldb] cbe7898 - [lldb] [Host/Terminal] Add missing #ifdef for baudRateToConst()

2021-10-21 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-21T11:00:17+02:00 New Revision: cbe789844703fe72d45b15614fa3b350e76f8570 URL: https://github.com/llvm/llvm-project/commit/cbe789844703fe72d45b15614fa3b350e76f8570 DIFF: https://github.com/llvm/llvm-project/commit/cbe789844703fe72d45b15614fa3b350e76f8570.diff

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D112163#3077124 , @dblaikie wrote: > In D112163#3077112 , @teemperor > wrote: > >> LGTM, thanks! >> >> Tests with libc++ as a category are not run on Windows or when GCC is the >>

[Lldb-commits] [lldb] 4745e41 - [lldb] [unittest] Disable SetParity() tests on Linux entirely

2021-10-21 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-21T10:55:02+02:00 New Revision: 4745e4178397b387263f2547e13018e3c8ee396c URL: https://github.com/llvm/llvm-project/commit/4745e4178397b387263f2547e13018e3c8ee396c DIFF: https://github.com/llvm/llvm-project/commit/4745e4178397b387263f2547e13018e3c8ee396c.diff

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

2021-10-21 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4a7b4beac759: [lldb] Add serial:// protocol for connecting to serial port (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 4a7b4be - [lldb] Add serial:// protocol for connecting to serial port

2021-10-21 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-21T10:46:45+02:00 New Revision: 4a7b4beac759ad9001671a61846ee2bfc9076eec URL: https://github.com/llvm/llvm-project/commit/4a7b4beac759ad9001671a61846ee2bfc9076eec DIFF: https://github.com/llvm/llvm-project/commit/4a7b4beac759ad9001671a61846ee2bfc9076eec.diff

[Lldb-commits] [PATCH] D111030: [lldb] [Host] Add setters for common teletype properties to Terminal

2021-10-21 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG92fb574c9f20: [lldb] [Host] Add setters for common teletype properties to Terminal (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 92fb574 - [lldb] [Host] Add setters for common teletype properties to Terminal

2021-10-21 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-21T10:33:38+02:00 New Revision: 92fb574c9f20aef56948c51f4921a92efbb72a5b URL: https://github.com/llvm/llvm-project/commit/92fb574c9f20aef56948c51f4921a92efbb72a5b DIFF: https://github.com/llvm/llvm-project/commit/92fb574c9f20aef56948c51f4921a92efbb72a5b.diff

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a reviewer: jasonmolenda. labath added a comment. This revision now requires changes to proceed. I don't think this is a scalable way to fix this, and should get more discussion. Jason what do you make of this? Repository: rG LLVM

[Lldb-commits] [lldb] 46fb5d5 - [lldb][NFC] clang-format CPlusPlusLanguage.cpp

2021-10-21 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-10-21T10:01:18+02:00 New Revision: 46fb5d5ddffdccbd14a09c7dcff63de6fef63c07 URL: https://github.com/llvm/llvm-project/commit/46fb5d5ddffdccbd14a09c7dcff63de6fef63c07 DIFF:

[Lldb-commits] [PATCH] D111030: [lldb] [Host] Add setters for common teletype properties to Terminal

2021-10-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/source/Host/common/Terminal.cpp:117 + switch (baud_rate) { +#if defined(B0) + case 0: labath wrote: > Out of curiosity: how does a baud rate of zero work? It triggers a "hang up" signal to the modem. To be honest,

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

2021-10-21 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D112163#3077112 , @teemperor wrote: > LGTM, thanks! > > Tests with libc++ as a category are not run on Windows or when GCC is the > test compiler, so those decorators are redundant. Removing the Clang XFAIL > also seems

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I'm fine with either option, and it doesn't seem to me like @joerg has a particularly strong more opinion either, so maybe you can cast the deciding vote? I consider it more important to fix the equality operator and the name capitalization (in that order). CHANGES

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/common/File.cpp:847 +: NativeFile(fd, options, transfer_ownership), m_state(fd) {} +Status SerialPort::Close() { + m_state.Restore();

[Lldb-commits] [PATCH] D112163: Enable libc++ in the build for libcxx initializerlist pretty printers

2021-10-21 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Tests with libc++ as a category are not run on Windows or when GCC is the test compiler, so those decorators are redundant. Removing the Clang XFAIL also seems fine, I

[Lldb-commits] [PATCH] D111030: [lldb] [Host] Add setters for common teletype properties to Terminal

2021-10-21 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/common/Terminal.cpp:117 + switch (baud_rate) { +#if defined(B0) + case 0: Out of curiosity: how does a baud rate of zero

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

2021-10-21 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 381158. mgorny added a comment. Make the test verify that (potentially large) `target.xml` can be successfully transferred. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111964/new/ https://reviews.llvm.org/D111964 Files:

[Lldb-commits] [lldb] d531e5c - [LLDB] [NFC] Typo fix in usage text for "type filter" command

2021-10-21 Thread Shivam Gupta via lldb-commits
Author: Daniel Jalkut Date: 2021-10-21T12:22:52+05:30 New Revision: d531e5cf58413e34dc006a580d2c109863bddaa1 URL: https://github.com/llvm/llvm-project/commit/d531e5cf58413e34dc006a580d2c109863bddaa1 DIFF: https://github.com/llvm/llvm-project/commit/d531e5cf58413e34dc006a580d2c109863bddaa1.diff

[Lldb-commits] [PATCH] D112199: [LLDB] [NFC] Typo fix in usage text for "type filter" command

2021-10-21 Thread Shivam Gupta via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd531e5cf5841: [LLDB] [NFC] Typo fix in usage text for type filter command (authored by Daniel Jalkut jal...@red-sweater.com, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE