[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1120 +else + llvm::consumeError(expected_value.takeError()); + } err, i'm not a

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:33-37 ConstString NormalizePath(ConstString path) { // If we use "path" to construct a FileSpec, it will normalize the path for // us. We then grab the string and turn it back

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

clayborg created this revision. clayborg added reviewers: JDevlieghere, wallace, aadsm, labath, jingham. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds breakpoints to each target's statistics so we can track how

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

ljmf00 created this revision. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The patch [1] introduced this FIXME but ended up not being removed when fixed. [1]:

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 added a comment. https://bugs.llvm.org/show_bug.cgi?id=52324 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112564/new/ https://reviews.llvm.org/D112564 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112501: Add new key/value pairs to the module statistics for "statistics dump".

This revision was automatically updated to reflect the committed changes. Closed by commit rG2887d9fd864c: Add new key/value pairs to the module statistics for statistics dump. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2887d9f - Add new key/value pairs to the module statistics for "statistics dump".

Author: Greg Clayton Date: 2021-10-26T15:09:31-07:00 New Revision: 2887d9fd864c9302608ecd7ff58b28ad181ede9d URL: https://github.com/llvm/llvm-project/commit/2887d9fd864c9302608ecd7ff58b28ad181ede9d DIFF: https://github.com/llvm/llvm-project/commit/2887d9fd864c9302608ecd7ff58b28ad181ede9d.diff

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

wallace added a comment. Pushed upstream as 566bfbb740bb0ffef827ce983d7aa899236fcb88 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG566bfbb740bb: [formatters] Add a libstdcpp formatter for bitset

[Lldb-commits] [lldb] 566bfbb - [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

Author: Danil Stefaniuc Date: 2021-10-26T14:49:50-07:00 New Revision: 566bfbb740bb0ffef827ce983d7aa899236fcb88 URL: https://github.com/llvm/llvm-project/commit/566bfbb740bb0ffef827ce983d7aa899236fcb88 DIFF:

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

wallace accepted this revision. wallace added a comment. great! I'll land it for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

danilashtefan updated this revision to Diff 382463. danilashtefan added a comment. Reactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files:

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace added a comment. Besides, given that you are using the same python implementation for map and set, better rename the class to StdSeOrMapSynthProvider and add a comment mentioning that it works both for set and maps because they have the same underlying structure Repository: rG LLVM

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace added a comment. just some minor things left Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:941-942 new StringSummaryFormat(stl_summary_flags, "size=${svar%#}"))); + TypeSummaryImpl::Flags stl_set_summary_flags = stl_summary_flags;

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for bitset and unify tests across stdlibs

danilashtefan updated this revision to Diff 382456. danilashtefan added a comment. Refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files:

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382453. danilashtefan added a comment. With this changes I substitute the verbose long printed check with ValueCheck approach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/

[Lldb-commits] [PATCH] D112357: [lldb] [Host] Move port predicate-related logic to gdb-remote

mib added a comment. In D112357#3088505 , @mgorny wrote: > In D112357#3088305 , @mib wrote: > >> Hi @mgorny, this broke green-dragon >>

[Lldb-commits] [PATCH] D112357: [lldb] [Host] Move port predicate-related logic to gdb-remote

mgorny added a comment. In D112357#3088305 , @mib wrote: > Hi @mgorny, this broke green-dragon > (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/37098/consoleText). > You should be able to reproduce by running `$ ninja check-lldb-unit` I'm

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 added a comment. I will also create an issue and cross-reference this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112564/new/ https://reviews.llvm.org/D112564 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 added a comment. I can reproduce this with LDC (D LLVM-based compiler), but I don't know a way to do it with clang. Probably I need to manually write a .ll file for this. Can someone guide me on adding tests for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 801cf36 - [lldb] [unittests] Fix TcpListen() call in RNBSocketTest

Author: Michał Górny Date: 2021-10-26T21:08:03+02:00 New Revision: 801cf36a23bd17eefa7b8b344693b5691675128c URL: https://github.com/llvm/llvm-project/commit/801cf36a23bd17eefa7b8b344693b5691675128c DIFF: https://github.com/llvm/llvm-project/commit/801cf36a23bd17eefa7b8b344693b5691675128c.diff

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

jingham accepted this revision. jingham added a comment. There's one comment typo, but you can fix that on submission. Otherwise, LGTM. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:654 +Test breakpoint or breakpoint location. +Breakpoint resolved count

[Lldb-commits] [PATCH] D112357: [lldb] [Host] Move port predicate-related logic to gdb-remote

mib added a comment. Herald added a subscriber: JDevlieghere. Hi @mgorny, this broke green-dragon (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/37098/consoleText). You should be able to reproduce by running `$ ninja check-lldb-unit` Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 created this revision. ljmf00 added projects: LLDB, LLVM. Herald added a subscriber: JDevlieghere. ljmf00 requested review of this revision. Herald added a subscriber: lldb-commits. Currently for UTF-16 and UTF-32 types that are recognized by the DWARF encoding tags without `char16_t`

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

JDevlieghere added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:33-37 ConstString NormalizePath(ConstString path) { // If we use "path" to construct a FileSpec, it will normalize the path for // us. We then grab the string and turn it back

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382370. danilashtefan added a comment. Fixing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files: lldb/source/Plugins/Language/CPlusPlus/CMakeLists.txt

[Lldb-commits] [PATCH] D112180: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. I think you messed up when updating the diffs. I don't see the bitset diff anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112537: Set synthetic children

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. I think you messed up when updating the diffs. I don't see the bitset diff anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382354. DavidSpickett added a comment. Set SP not FP based on the sigcontext. Before, the SP of the frame before sigcontext would be incorrect. (noticed while testing alt signal stacks) This was already done in the libunwind change but I got them

[Lldb-commits] [PATCH] D112537: Set synthetic children

danilashtefan updated this revision to Diff 382348. danilashtefan added a comment. Deleted libcxx tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files:

[Lldb-commits] [PATCH] D112537: Set synthetic children. I have dove the generic tests for set. I have considered Libcxx tests as the one covering all the edge cases (including pointer and reference va

danilashtefan updated this revision to Diff 382336. danilashtefan added a comment. Set synthetic child Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files:

[Lldb-commits] [PATCH] D112537: Set synthetic children. I have dove the generic tests for set. I have considered Libcxx tests as the one covering all the edge cases (including pointer and reference va

danilashtefan updated this revision to Diff 382330. danilashtefan added a comment. Set synthetic children Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files:

[Lldb-commits] [PATCH] D112180: Libcpp bitset syntethic children and tests

danilashtefan updated this revision to Diff 382325. danilashtefan added a comment. Minor corrections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112180/new/ https://reviews.llvm.org/D112180 Files:

[Lldb-commits] [PATCH] D112537: Set synthetic children. I have dove the generic tests for set. I have considered Libcxx tests as the one covering all the edge cases (including pointer and reference va

danilashtefan created this revision. Herald added a subscriber: mgorny. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ...properties. However, I have decided to vhange them only when applying the set summary provider, and

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp:258 + UnwindPlanSP unwind_plan_sp; + if (name != "__kernel_rt_sigreturn") +return unwind_plan_sp; PlatformLinux lists 3 handlers: * _sigtramp *

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382287. DavidSpickett added a comment. Set ValidAtAllInstructions. Move building unwind plan into PlatformLinux and add a platform method to lookup unwind plans for signal handlers. I'm still checking architecture in PlatformLinux but it does move the

[Lldb-commits] [PATCH] D112357: [lldb] [Host] Move port predicate-related logic to gdb-remote

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4373f3595f8e: [lldb] [Host] Move port predicate-related logic to gdb-remote (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [lldb] 4373f35 - [lldb] [Host] Move port predicate-related logic to gdb-remote

Author: Michał Górny Date: 2021-10-26T13:53:08+02:00 New Revision: 4373f3595f8e37f6183d9880ee5b4eb59cba3852 URL: https://github.com/llvm/llvm-project/commit/4373f3595f8e37f6183d9880ee5b4eb59cba3852 DIFF: https://github.com/llvm/llvm-project/commit/4373f3595f8e37f6183d9880ee5b4eb59cba3852.diff

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

This revision was automatically updated to reflect the committed changes. Closed by commit rG58d28b931f92: [lldb] [lldb-gdbserver] Unify listen/connect code to use… (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 58d28b9 - [lldb] [lldb-gdbserver] Unify listen/connect code to use ConnectionFileDescriptor

Author: Michał Górny Date: 2021-10-26T13:06:19+02:00 New Revision: 58d28b931f92f5ea2a6a01e088b794ee6ebd05e7 URL: https://github.com/llvm/llvm-project/commit/58d28b931f92f5ea2a6a01e088b794ee6ebd05e7 DIFF: https://github.com/llvm/llvm-project/commit/58d28b931f92f5ea2a6a01e088b794ee6ebd05e7.diff

[Lldb-commits] [lldb] 93c7ed8 - [lldb] Fix PlatformAppleSimulator for a458ef4f

Author: Pavel Labath Date: 2021-10-26T13:03:47+02:00 New Revision: 93c7ed8c3f8e2b2966e565758d0992ec1b07a11f URL: https://github.com/llvm/llvm-project/commit/93c7ed8c3f8e2b2966e565758d0992ec1b07a11f DIFF: https://github.com/llvm/llvm-project/commit/93c7ed8c3f8e2b2966e565758d0992ec1b07a11f.diff

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

This revision was automatically updated to reflect the committed changes. Closed by commit rGf279e50fd0f0: [lldb] [Communication] Add a WriteAll() method that resumes writing (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f279e50 - [lldb] [Communication] Add a WriteAll() method that resumes writing

Author: Michał Górny Date: 2021-10-26T12:45:45+02:00 New Revision: f279e50fd0f0035e0205f4d36e7e5a8e0112fc24 URL: https://github.com/llvm/llvm-project/commit/f279e50fd0f0035e0205f4d36e7e5a8e0112fc24 DIFF: https://github.com/llvm/llvm-project/commit/f279e50fd0f0035e0205f4d36e7e5a8e0112fc24.diff

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 added a comment. I've added the unit test. The "FindFile" method requires the FileSystem, so I added a new file rather then put these code into exist PathMappingListTest.cpp Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 382237. xujuntwt95329 added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Target/PathMappingList.cpp

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 382235. xujuntwt95329 added a comment. Herald added a subscriber: mgorny. add unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files:

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a39a9c2cb43: Modernize and simplify HostInfo::GetOSKernelDescription (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112457/new/

[Lldb-commits] [lldb] 0a39a9c - Modernize and simplify HostInfo::GetOSKernelDescription

Author: Pavel Labath Date: 2021-10-26T11:17:02+02:00 New Revision: 0a39a9c2cb43f93c82908cabdf73fdd4918a26e5 URL: https://github.com/llvm/llvm-project/commit/0a39a9c2cb43f93c82908cabdf73fdd4918a26e5 DIFF: https://github.com/llvm/llvm-project/commit/0a39a9c2cb43f93c82908cabdf73fdd4918a26e5.diff

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

mgorny added inline comments. Comment at: lldb/unittests/Core/CommunicationTest.cpp:80 + std::vector data(1024 * 1024, 0x80); + EXPECT_EQ(write_comm.WriteAll(data.data(), data.size(), conn_status, ), +data.size()); If we want to be super-strict, I

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

mgorny accepted this revision. mgorny added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112457/new/ https://reviews.llvm.org/D112457 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

mgorny added inline comments. Comment at: lldb/source/Core/Communication.cpp:200 +total_written += written; +if (status != eConnectionStatusSuccess || total_written >= src_len) + break; labath wrote: > It looks like this could be a do-while loop.

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

mgorny updated this revision to Diff 382227. mgorny marked 2 inline comments as done. mgorny added a comment. Implemented requested changes. Added a minimal-ish unittest. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112169/new/ https://reviews.llvm.org/D112169 Files:

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

labath added inline comments. Comment at: lldb/source/Host/posix/HostInfoPosix.cpp:44 + + ::memset(, 0, sizeof(utsname)); + mgorny wrote: > I'm somewhat surprised that you need to do that. I wonder if there was a real > reason why it's done or just someone

[Lldb-commits] [PATCH] D112457: Modernize and simplify HostInfo::GetOSKernelDescription

labath updated this revision to Diff 382223. labath marked 2 inline comments as done. labath added a comment. Remove memset Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112457/new/ https://reviews.llvm.org/D112457 Files:

[Lldb-commits] [lldb] a458ef4 - [lldb] Remove ConstString from Platform plugin names

Author: Pavel Labath Date: 2021-10-26T10:04:35+02:00 New Revision: a458ef4f732b27312d8a5d20d2843d8bff35daeb URL: https://github.com/llvm/llvm-project/commit/a458ef4f732b27312d8a5d20d2843d8bff35daeb DIFF: https://github.com/llvm/llvm-project/commit/a458ef4f732b27312d8a5d20d2843d8bff35daeb.diff

[Lldb-commits] [lldb] b69564d - [lldb/DWARF] Move a declaration closer to its use

Author: Pavel Labath Date: 2021-10-26T09:58:10+02:00 New Revision: b69564d94d90b83ccdcc501f811959c23aeec52a URL: https://github.com/llvm/llvm-project/commit/b69564d94d90b83ccdcc501f811959c23aeec52a DIFF: https://github.com/llvm/llvm-project/commit/b69564d94d90b83ccdcc501f811959c23aeec52a.diff

[Lldb-commits] [PATCH] D112310: [lldb/DWARF] Don't create lldb_private::Functions for gc'ed DW_TAG_subprograms

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:866 + // discontiguous) + AddressRange func_range; + lldb::addr_t lowest_func_addr = ranges.GetMinRangeBase(0); shafik wrote: > You declare `func_range` here

[Lldb-commits] [PATCH] D112169: [lldb] [Communication] Add a WriteAll() method that resumes writing

labath added a comment. Maybe a quick unit test which send like 1MB of data in a single call or something similar? Comment at: lldb/include/lldb/Core/Communication.h:195 /// The actual write function that attempts to write to the communications /// protocol. ///

[Lldb-commits] [lldb] 4c8ea90 - [LLDB] Fix LLDB buildbots break due to --image-base

Author: Muhammad Omair Javaid Date: 2021-10-26T12:07:16+05:00 New Revision: 4c8ea90b252eeead9a6943f67444a229147949fb URL: https://github.com/llvm/llvm-project/commit/4c8ea90b252eeead9a6943f67444a229147949fb DIFF: