[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna added a comment. @JDevlieghere That approach would work great for my purposes, i'll update like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 __

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

2021-11-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. I reverted this patch locally and try building with clang modules (`-DLLVM_ENABLE_MODULE=On`) which confirmed it was causing the build failure on the bots. I had to revert your patch upstream to fix our bots. If you need some help to reproduce the build failure, let me kno

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

2021-11-02 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. I would do this: lldb --print-script-interpreter-info python making the interpreter the argument for this option. That seems clearer than having to provide two flags. language is overloaded anyway, because it can be a source language or a script interpreter languag

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

2021-11-02 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. I was talking to Jim about this offline and one potential solution would be to have a flag that asks the current script interpreter for some of this relevant information. What that means would be different for every language, so the output would have to be able to

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

2021-11-02 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D112165#3102055 , @teemperor wrote: > In D112165#3100929 , @dblaikie > wrote: > >> In D112165#3100608 , @teemperor >> wrote: >> >>> Small no

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-02 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added inline comments. Comment at: lldb/test/Shell/Settings/TestEchoCommands.test:4 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out -# RUN: %lldb -x -b --so

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7f01f78593d6: [lldb] update TestEchoCommands (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.or

[Lldb-commits] [lldb] 7f01f78 - [lldb] update TestEchoCommands

2021-11-02 Thread Lawrence D'Anna via lldb-commits
Author: Lawrence D'Anna Date: 2021-11-02T14:30:08-07:00 New Revision: 7f01f78593d68741f1a26911e8cecca9805b3fa4 URL: https://github.com/llvm/llvm-project/commit/7f01f78593d68741f1a26911e8cecca9805b3fa4 DIFF: https://github.com/llvm/llvm-project/commit/7f01f78593d68741f1a26911e8cecca9805b3fa4.dif

[Lldb-commits] [PATCH] D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`

2021-11-02 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG50b40b051890: [lldb] Improve error reporting in `lang objc tagged-pointer info` (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 50b40b0 - [lldb] Improve error reporting in `lang objc tagged-pointer info`

2021-11-02 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-11-02T14:25:42-07:00 New Revision: 50b40b0518900f60ec2712384f6ce40341ed7484 URL: https://github.com/llvm/llvm-project/commit/50b40b0518900f60ec2712384f6ce40341ed7484 DIFF: https://github.com/llvm/llvm-project/commit/50b40b0518900f60ec2712384f6ce40341ed7484.d

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-02 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047 ___

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna added a comment. In D112988#3103992 , @stella.stamenova wrote: > It looks like some of the tests need to be updated after this change (at > least on Windows, the Windows LLDB bot is broken now): > > https://lab.llvm.org/buildbot/#/builder

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham, stella.stamenova. lawrence_danna requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Followup to https://reviews.llvm.org/D112988 Sorry

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. It looks like some of the tests need to be updated after this change (at least on Windows, the Windows LLDB bot is broken now): https://lab.llvm.org/buildbot/#/builders/83/builds/11623/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`

2021-11-02 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Excellent, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112945/new/ https://reviews.llvm.org/D112945 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D113019: [lldb][NFC] Inclusive Language: rename master plan to primary plan

2021-11-02 Thread Quinn Pham via Phabricator via lldb-commits
quinnp added a comment. In D113019#3103511 , @jingham wrote: > I have no problem with adopting more inclusive language, but "Primary" > doesn't express the right concept. The "master" plan is one that coordinates > other plans. There can be many "mast

[Lldb-commits] [PATCH] D113019: [lldb][NFC] Inclusive Language: rename master plan to primary plan

2021-11-02 Thread Quinn Pham via Phabricator via lldb-commits
quinnp updated this revision to Diff 384202. quinnp added a comment. Addressing feedback. Changing Primary to Controlling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113019/new/ https://reviews.llvm.org/D113019 Files: lldb/docs/use/python-ref

[Lldb-commits] [PATCH] D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`

2021-11-02 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 384193. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112945/new/ https://reviews.llvm.org/D112945 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/test/Shell/Driver/TestQuiet.test:8 +CHECK: 42 \ No newline at end of file > No newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/

[Lldb-commits] [lldb] 797b50d - Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM"

2021-11-02 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2021-11-02T19:11:44+01:00 New Revision: 797b50d4be873b4662983413a06806fca544c276 URL: https://github.com/llvm/llvm-project/commit/797b50d4be873b4662983413a06806fca544c276 DIFF: https://github.com/llvm/llvm-project/commit/797b50d4be873b4662983413a06806fca544c276.

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe2a6c08bbc38: [lldb] fix --source-quietly (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/ https://reviews.llvm.org/D

[Lldb-commits] [lldb] e2a6c08 - [lldb] fix --source-quietly

2021-11-02 Thread Lawrence D'Anna via lldb-commits
Author: Lawrence D'Anna Date: 2021-11-02T11:01:55-07:00 New Revision: e2a6c08bbc385b38e02f4e5d31d1cf6d4403f066 URL: https://github.com/llvm/llvm-project/commit/e2a6c08bbc385b38e02f4e5d31d1cf6d4403f066 DIFF: https://github.com/llvm/llvm-project/commit/e2a6c08bbc385b38e02f4e5d31d1cf6d4403f066.dif

[Lldb-commits] [PATCH] D113019: [lldb][NFC] Inclusive Language: rename master plan to primary plan

2021-11-02 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Or Coordinating? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113019/new/ https://reviews.llvm.org/D113019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

2021-11-02 Thread John Ericson via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6fd2db04d0f2: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1008

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

2021-11-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. Hi @Ericson2314, I think this patch broke our macOS lldb-incremental bot on GreenDragon (https://green.lab.llvm.org/green/job/lldb-cmake/37560/console). Could you please take a look ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

2021-11-02 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: llvm/CMakeLists.txt:289 +set(LLVM_TOOLS_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}" CACHE STRING +"Path for binary subdirectory (defaults to 'bin')") mark_

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

2021-11-02 Thread John Ericson via Phabricator via lldb-commits
Ericson2314 updated this revision to Diff 383961. Ericson2314 added a comment. Fix last comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libclc/CMak

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

2021-11-02 Thread John Ericson via Phabricator via lldb-commits
Ericson2314 updated this revision to Diff 383962. Ericson2314 added a comment. Simple rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt clang-

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

2021-11-02 Thread John Ericson via Phabricator via lldb-commits
Ericson2314 updated this revision to Diff 383602. Ericson2314 added a comment. Simple rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libclc/CMakeLi

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

2021-11-02 Thread John Ericson via Phabricator via lldb-commits
Ericson2314 updated this revision to Diff 383603. Ericson2314 added a comment. Rebase, and catch two more `DESTINATION bin` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-d

[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

2021-11-02 Thread Louis Dionne via Phabricator via lldb-commits
ldionne added a comment. Herald added a project: Flang. If there is no plan to move forward with generating `.docx` documentation, can we please abandon this review? I'm trying to clean up libc++'s review queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna added a comment. In D112988#3103574 , @jingham wrote: > Ha! It was apparently so easy to add the test that it wasn't noticeable (at > least by me!). > > This isn't directly relevant to your patch, since this wasn't behavior you > changed

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Ha! It was apparently so easy to add the test that it wasn't noticeable (at least by me!). This isn't directly relevant to your patch, since this wasn't behavior you changed, but it seems

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna marked an inline comment as done. lawrence_danna added a comment. In D112988#3103463 , @jingham wrote: > There was one typo I pointed out, and it would be good to add a test. I'm > sure this worked at some point, but wasn't tested so it w

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna updated this revision to Diff 384155. lawrence_danna added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112988/new/ https://reviews.llvm.org/D112988 Files: lldb/docs/man/lldb.rst lldb/test/Shell/Driver/TestQ

[Lldb-commits] [PATCH] D113019: [lldb][NFC] Inclusive Language: rename master plan to primary plan

2021-11-02 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Maybe "Controlling" plan would be better? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113019/new/ https://reviews.llvm.org/D113019 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D113019: [lldb][NFC] Inclusive Language: rename master plan to primary plan

2021-11-02 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. I have no problem with adopting more inclusive language, but "Primary" doesn't express the right concept. The "master" plan is one that coordinates other plans. There can be many "master plans" on the stack at any one time during a complex set of stepping operations,

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. This is great, thanks! There was one typo I pointed out, and it would be good to add a test. I'm sure this worked at some point, but wasn't tested so it was broken without anybody noticing. We want to make sure that doesn't happen again... It should be easy to write

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

2021-11-02 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. I still don't think adding python specific ways of getting at generic ScriptInterpreter features (e.g. the path to the lldb module for that script interpreter - not your fault but... - and the path to the script's native script runner binary) with language specific affo

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

2021-11-02 Thread Ted Woodward via Phabricator via lldb-commits
ted added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.c:11-18 +int main(int argc, char **argv) +{ + int i; + + for (i=0; i < 10; ++i) ; + + return 0; labath wrote: > ted wrote: > > labath wrote: > > > ted wrote: > > > > clay

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

2021-11-02 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

2021-11-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.c:11-18 +int main(int argc, char **argv) +{ + int i; + + for (i=0; i < 10; ++i) ; + + return 0; ted wrote: > labath wrote: > > ted wrote: > > > clayborg wrote: > > > >

[Lldb-commits] [lldb] adf5e9c - [lldb] Remove ConstString from TypeSystem and REPL plugin names

2021-11-02 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2021-11-02T16:13:52+01:00 New Revision: adf5e9c9b67a60727e02a4e83a3d7a9373579574 URL: https://github.com/llvm/llvm-project/commit/adf5e9c9b67a60727e02a4e83a3d7a9373579574 DIFF: https://github.com/llvm/llvm-project/commit/adf5e9c9b67a60727e02a4e83a3d7a9373579574.diff

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

2021-11-02 Thread Ted Woodward via Phabricator via lldb-commits
ted added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.c:11-18 +int main(int argc, char **argv) +{ + int i; + + for (i=0; i < 10; ++i) ; + + return 0; labath wrote: > ted wrote: > > clayborg wrote: > > > are we guaranteed to

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

2021-11-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Actually, I've successfully purged most of this from my memory. However, what Raphael said is consistent with what little I remember. It would be better if the gmodules tests had their own (semi-)dedicated tests that were independent of the system libraries. Then, they c

[Lldb-commits] [lldb] 6fd2db0 - Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

2021-11-02 Thread John Ericson via lldb-commits
Author: John Ericson Date: 2021-11-02T10:23:30-04:00 New Revision: 6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 URL: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 DIFF: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73.diff

[Lldb-commits] [PATCH] D113019: [lldb][NFC] Inclusive Language: rename master plan to primary plan

2021-11-02 Thread Quinn Pham via Phabricator via lldb-commits
quinnp created this revision. quinnp requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. [NFC] As part of using inclusive language within the llvm project, this patch renames master plan to primary plan in lldb. Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

2021-11-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.c:11-18 +int main(int argc, char **argv) +{ + int i; + + for (i=0; i < 10; ++i) ; + + return 0; ted wrote: > clayborg wrote: > > are we guaranteed to get some debug in

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Xu Jun via Phabricator via lldb-commits
xujuntwt95329 marked 7 inline comments as done. xujuntwt95329 added a comment. I have submitted a new patch here: https://reviews.llvm.org/D113011 Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439

[Lldb-commits] [PATCH] D113011: [lldb] make the code prettier in FindFileTest.cpp

2021-11-02 Thread Xu Jun via Phabricator via lldb-commits
xujuntwt95329 added a comment. Thanks to @teemperor's comments in https://reviews.llvm.org/D112439 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113011/new/ https://reviews.llvm.org/D113011 ___ lldb-comm

[Lldb-commits] [PATCH] D113011: [lldb] make the code prettier in FindFileTest.cpp

2021-11-02 Thread Xu Jun via Phabricator via lldb-commits
xujuntwt95329 created this revision. xujuntwt95329 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113011 Files: lldb/unittests/Target/FindFileTest.cpp Index: lldb/unitte

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D112439#3102752 , @xujuntwt95329 wrote: > Thanks a lot for your comments, they are very useful and I learned a lot > about C++ by talking with you. > > I'll address these comments and submit a patch and request your review.

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Xu Jun via Phabricator via lldb-commits
xujuntwt95329 added a comment. Thanks a lot for your comments, they are very useful and I learned a lot about C++ by talking with you. I'll address these comments and submit a patch and request your review. Much appreciated! Comment at: lldb/unittests/Target/FindFileTest.cpp

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Fixed in 58dd658583eec9af24ca1262e1bce9f884d65487 (Also left some nits in the test because I anyway looked over the code.) Comment at: lldb/unittests/Target/FindFileTest.cpp:27 +

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Xu Jun via Phabricator via lldb-commits
xujuntwt95329 added a comment. In D112439#3102600 , @teemperor wrote: > In D112439#3102559 , @xujuntwt95329 > wrote: > >> In D112439#3102548 , @teemperor >> wrote: >> >>

[Lldb-commits] [lldb] 58dd658 - [lldb] Fix a use-after-free in FindFileTest.cpp

2021-11-02 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-11-02T12:39:26+01:00 New Revision: 58dd658583eec9af24ca1262e1bce9f884d65487 URL: https://github.com/llvm/llvm-project/commit/58dd658583eec9af24ca1262e1bce9f884d65487 DIFF: https://github.com/llvm/llvm-project/commit/58dd658583eec9af24ca1262e1bce9f884d65487.dif

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D112439#3102559 , @xujuntwt95329 wrote: > In D112439#3102548 , @teemperor > wrote: > >> In D112439#3102533 , >> @xujuntwt95329 wrote: >> >

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Xu Jun via Phabricator via lldb-commits
xujuntwt95329 added a comment. In D112439#3102548 , @teemperor wrote: > In D112439#3102533 , @xujuntwt95329 > wrote: > >> In D112439#3102506 , @teemperor >> wrote: >> >>

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D112439#3102533 , @xujuntwt95329 wrote: > In D112439#3102506 , @teemperor > wrote: > >> In D112439#3098307 , >> @xujuntwt95329 wrote: >> >

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Xu Jun via Phabricator via lldb-commits
xujuntwt95329 added a comment. In D112439#3102506 , @teemperor wrote: > In D112439#3098307 , @xujuntwt95329 > wrote: > >> Seems that patch can't build by CI because it is based on this patch. In my >> understand

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

2021-11-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D112439#3098307 , @xujuntwt95329 wrote: > Seems that patch can't build by CI because it is based on this patch. In my > understanding we need to merge this patch firstly and rebase that NFC patch > to let CI work, right?

[Lldb-commits] [lldb] cd2e66e - [lldb][gmodules] Fix TestDataFormatterGlobals under gmodules

2021-11-02 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-11-02T10:14:11+01:00 New Revision: cd2e66efa65fd63cf6f48112f49c09489a1baac0 URL: https://github.com/llvm/llvm-project/commit/cd2e66efa65fd63cf6f48112f49c09489a1baac0 DIFF: https://github.com/llvm/llvm-project/commit/cd2e66efa65fd63cf6f48112f49c09489a1baac0.dif

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

2021-11-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. I think this was just fixed by 48677f58b06cfb8715902173c5bc3d1764d7c8c6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

2021-11-02 Thread Jan Svoboda via Phabricator via lldb-commits
jansvoboda11 added a comment. This breaks our build: https://green.lab.llvm.org/green/job/lldb-cmake/37529/console Can you take a look? If the fix is not obvious, please revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ htt

Re: [Lldb-commits] [lldb] 48677f5 - [lldb] Unbreak the macOS build after dfd499a61c45778b7f01458d50ccc384343f53d5

2021-11-02 Thread Raphael Isemann via lldb-commits
Thanks! Am Di., 2. Nov. 2021 um 09:48 Uhr schrieb Benjamin Kramer via lldb-commits : > > > Author: Benjamin Kramer > Date: 2021-11-02T09:47:44+01:00 > New Revision: 48677f58b06cfb8715902173c5bc3d1764d7c8c6 > > URL: > https://github.com/llvm/llvm-project/commit/48677f58b06cfb8715902173c5bc3d1764d7

[Lldb-commits] [lldb] 48677f5 - [lldb] Unbreak the macOS build after dfd499a61c45778b7f01458d50ccc384343f53d5

2021-11-02 Thread Benjamin Kramer via lldb-commits
Author: Benjamin Kramer Date: 2021-11-02T09:47:44+01:00 New Revision: 48677f58b06cfb8715902173c5bc3d1764d7c8c6 URL: https://github.com/llvm/llvm-project/commit/48677f58b06cfb8715902173c5bc3d1764d7c8c6 DIFF: https://github.com/llvm/llvm-project/commit/48677f58b06cfb8715902173c5bc3d1764d7c8c6.dif

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

2021-11-02 Thread Lawrence D'Anna via Phabricator via lldb-commits
lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added subscribers: dang, pengfei. lawrence_danna requested review of this revision. Herald added a project: LLDB. Jim says: lldb has a -Q or --source-quietly option, which supposedly

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

2021-11-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a subscriber: labath. teemperor added a comment. In D112165#3100929 , @dblaikie wrote: > In D112165#3100608 , @teemperor > wrote: > >> Small note: gmodules test are never run on Linux, so you actu