[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added a comment. In D112973#3122496 , @stella.stamenova wrote: > Windows buildbot is broken: > > https://lab.llvm.org/buildbot/#/builders/83/builds/11865 eek, sorry. fix is here: https://reviews.llvm.org/D113650 Repository: rG LLVM

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. lawrence_danna requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Apparently "{sys.prefix}/bin/python3" isn't where you find the python

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

dblaikie added a comment. In D110578#3123164 , @ljmf00 wrote: > @dblaikie Maybe you can land this? Nah, might need someone with more lldb context than me - I don't seem to have a clean check-lldb build right now (so don't have a good baseline to

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

jingham added inline comments. Comment at: lldb/source/Target/Process.cpp:2496-2497 Module *exe_module = GetTarget().GetExecutableModulePointer(); - if (!exe_module) { -error.SetErrorString("executable module does not exist"); -return error; - } - char

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

jingham updated this revision to Diff 386375. jingham added a comment. Address Greg's review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113521/new/ https://reviews.llvm.org/D113521 Files:

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

ljmf00 planned changes to this revision. ljmf00 added a comment. I still need to add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113634/new/ https://reviews.llvm.org/D113634 ___ lldb-commits

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113634 Files: lldb/include/lldb/Symbol/Type.h

[Lldb-commits] [PATCH] D113605: [lldb] Fix documentation for EncodingDataType

ljmf00 updated this revision to Diff 386362. ljmf00 retitled this revision from "[lldb] Add documentation for eEncodingIsSyntheticUID" to "[lldb] Fix documentation for EncodingDataType". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113605/new/ https://reviews.llvm.org/D113605 Files:

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

jingham added a comment. In D113521#3123051 , @clayborg wrote: > In D113521#3122654 , @jingham wrote: > >> In D113521#3120703 , @labath wrote: >> >>> I have two

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 added a comment. Can you check now? If looks good, can you land it please? Comment at: lldb/include/lldb/Symbol/Type.h:86 eEncodingIsAtomicUID, ///< This type is the type whose UID is /// m_encoding_uid as an atomic

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 updated this revision to Diff 386361. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 Files: lldb/include/lldb/Symbol/Type.h Index: lldb/include/lldb/Symbol/Type.h ===

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

ljmf00 added a subscriber: dblaikie. ljmf00 added a comment. @dblaikie Maybe you can land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/new/ https://reviews.llvm.org/D110578 ___

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar added a comment. Apologies in advance - this may be a repeat message. Our server went down for maintenance mid-send. So, looking at https://llvm.org/docs/HowToAddABuilder.html, I think I need some clarification on your request regarding a build bot. Are you asking for dedicated

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:268-269 + exe_module_sp = target->GetExecutableModule(); +if (!exe_module_sp) { + result.AppendError("Could not get executable module after launch."); +

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

jingham updated this revision to Diff 386339. jingham added a comment. Address Pavel's review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113521/new/ https://reviews.llvm.org/D113521 Files:

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

clayborg added a comment. In D113521#3122654 , @jingham wrote: > In D113521#3120703 , @labath wrote: > >> I have two high-level questions about this: >> >> - what should be the relative priority of executable

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

teemperor added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:86 eEncodingIsAtomicUID, ///< This type is the type whose UID is /// m_encoding_uid as an atomic type. eEncodingIsSyntheticUID

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I guess that's just clang-format ran over the file? If yes, then LGTM Comment at: lldb/include/lldb/Symbol/Type.h:86 eEncodingIsAtomicUID, ///< This type

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG676576b6f027: [lldb/Plugins] Refactor ScriptedThread register context creation (authored by mib). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 676576b - [lldb/Plugins] Refactor ScriptedThread register context creation

Author: Med Ismail Bennani Date: 2021-11-11T00:13:58+01:00 New Revision: 676576b6f027516c8ea1b45f6da3cd1b94a851a2 URL: https://github.com/llvm/llvm-project/commit/676576b6f027516c8ea1b45f6da3cd1b94a851a2 DIFF:

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:330-331 + /// NB: This implementation is mutually recursive with + /// GetSupportedArchitectureAtIndex. Subclasses should implement at least one + /// of them. + virtual std::vector

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

jingham added a comment. In D113521#3120703 , @labath wrote: > I have two high-level questions about this: > > - what should be the relative priority of executable ModuleSP vs the launch > info? IIUC, in the current implementation the module takes

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

labath added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:332 + /// of them. + virtual std::vector GetSupportedArchitectures(); If all platforms (as I expect them to) implement this by maintaining a vector of supported architectures,

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

labath created this revision. labath added reviewers: JDevlieghere, jasonmolenda. Herald added subscribers: krytarowski, arichardson, emaste. labath requested review of this revision. Herald added a project: LLDB. The GetSupportedArchitectureAtIndex pattern forces the use of complicated patterns

[Lldb-commits] [PATCH] D113605: [lldb] Add documentation for eEncodingIsSyntheticUID

ljmf00 created this revision. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113605 Files: lldb/include/lldb/Symbol/Type.h Index: lldb/include/lldb/Symbol/Type.h

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 created this revision. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113604 Files: lldb/include/lldb/Symbol/Type.h Index: lldb/include/lldb/Symbol/Type.h

[Lldb-commits] [lldb] 0d62e31 - [LLDB][NFC] Fix test that broke due to libc++ std::vector changes

Author: Shafik Yaghmour Date: 2021-11-10T12:29:08-08:00 New Revision: 0d62e31c458526e1db37d11da947e61768c7b522 URL: https://github.com/llvm/llvm-project/commit/0d62e31c458526e1db37d11da947e61768c7b522 DIFF:

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

stella.stamenova added a comment. Windows buildbot is broken: https://lab.llvm.org/buildbot/#/builders/83/builds/11865 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973

Re: [Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

Hi Jonas, Apologies for the non-build - I did a fetch/rebase this morning before creating the patch. Do I need to be on a different branch re StringRef vs ConstString? (Have seen that discussion in passing but confess I did not follow it in detail.) Any pointers appreciated. Re testing,

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112167/new/ https://reviews.llvm.org/D112167 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D113598: [debugserver] Remove unused variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG18d883cc0a06: [debugserver] Remove varaible `ldb_set` which is set but not used. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 18d883c - [debugserver] Remove varaible `ldb_set` which is set but not used.

Author: Jonas Devlieghere Date: 2021-11-10T11:56:59-08:00 New Revision: 18d883cc0a0623f6a1b9a4fdbd0c21b3a70a88a0 URL: https://github.com/llvm/llvm-project/commit/18d883cc0a0623f6a1b9a4fdbd0c21b3a70a88a0 DIFF:

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

mib updated this revision to Diff 386274. mib marked an inline comment as done. mib added a comment. Addressed @JDevlieghere & @shafik comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112167/new/ https://reviews.llvm.org/D112167 Files:

[Lldb-commits] [PATCH] D112167: [lldb/Plugins] Refactor ScriptedThread register context creation

mib requested review of this revision. mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:105 + lldb::RegisterContextSP reg_ctx_sp; + Status error; + JDevlieghere wrote: > It

[Lldb-commits] [PATCH] D113598: [debugserver] Remove unused variable

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113598/new/ https://reviews.llvm.org/D113598 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D113598: [debugserver] Remove unused variable

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. JDevlieghere requested review of this revision. https://reviews.llvm.org/D113598 Files: lldb/tools/debugserver/source/RNBRemote.cpp Index: lldb/tools/debugserver/source/RNBRemote.cpp

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc9ced0ed420: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in… (authored by zequanwu). Repository: rG LLVM Github

[Lldb-commits] [lldb] cc9ced0 - [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

Author: Zequan Wu Date: 2021-11-10T11:20:32-08:00 New Revision: cc9ced0ed4202a4f8a550551bbb14584f93f3055 URL: https://github.com/llvm/llvm-project/commit/cc9ced0ed4202a4f8a550551bbb14584f93f3055 DIFF: https://github.com/llvm/llvm-project/commit/cc9ced0ed4202a4f8a550551bbb14584f93f3055.diff

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

zequanwu updated this revision to Diff 386256. zequanwu added a comment. Rebased and add test cases for out of range file/origin index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113330/new/ https://reviews.llvm.org/D113330 Files:

[Lldb-commits] [lldb] 419b471 - [lldb/test] Skip TestScriptedProcess when using system's debugserver (NFC)

Author: Med Ismail Bennani Date: 2021-11-10T20:12:42+01:00 New Revision: 419b4711961216b9c09d06735bb4d442a213fe57 URL: https://github.com/llvm/llvm-project/commit/419b4711961216b9c09d06735bb4d442a213fe57 DIFF:

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

JDevlieghere added a comment. Hi David, this looks really comprehensive. As far as the code is concerned, it has all the parts that we'd want to support another scripting language in LLDB. That leaves us with the last remaining questions: - Testing: having a bot that actually builds & tests

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbf665a0086c: [LLDB][Breakpad] Create a function for each compilation unit. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fbf665a - [LLDB][Breakpad] Create a function for each compilation unit.

Author: Zequan Wu Date: 2021-11-10T10:51:16-08:00 New Revision: fbf665a0086c8d88d62d60320bef4466c590132e URL: https://github.com/llvm/llvm-project/commit/fbf665a0086c8d88d62d60320bef4466c590132e DIFF: https://github.com/llvm/llvm-project/commit/fbf665a0086c8d88d62d60320bef4466c590132e.diff

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

This revision was automatically updated to reflect the committed changes. Closed by commit rG360d901bf047: Revert [lldb] Disable minimal import mode for RecordDecls that back FieldDecls (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 360d901 - Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

Author: Jordan Rupprecht Date: 2021-11-10T10:38:01-08:00 New Revision: 360d901bf0478293d6e57f58bdb63b386f97f531 URL: https://github.com/llvm/llvm-project/commit/360d901bf0478293d6e57f58bdb63b386f97f531 DIFF:

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbef51eb43c2: [lldb] make it easier to find LLDBs python (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/

[Lldb-commits] [lldb] bbef51e - [lldb] make it easier to find LLDB's python

Author: Lawrence D'Anna Date: 2021-11-10T10:33:34-08:00 New Revision: bbef51eb43c2e8f8e36fbbc0d0b4cca75b6f0863 URL: https://github.com/llvm/llvm-project/commit/bbef51eb43c2e8f8e36fbbc0d0b4cca75b6f0863 DIFF:

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht added a comment. In D113449#3121070 , @teemperor wrote: > I actually didn't see that the patch deleted the TestCppReferenceToOuterClass > test. Could you just add a `@skipIf # Crashes` or so above its `def test...` > method? The test itself

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht updated this revision to Diff 386227. rupprecht added a comment. - Use better test APIs, add test back w/ a @expectedFailure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113449/new/ https://reviews.llvm.org/D113449 Files:

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 386198. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files:

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBHostOS.h:23 + const char *GetScriptInterpreterInfo(); + JDevlieghere wrote: > Is still still relevant? nope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d96656c - [lldb] [test] Fix new signal tests to use remote-linux plugin

Author: Michał Górny Date: 2021-11-10T18:08:05+01:00 New Revision: d96656ca9011db77ebbf6e91f380fb8894cbf820 URL: https://github.com/llvm/llvm-project/commit/d96656ca9011db77ebbf6e91f380fb8894cbf820 DIFF: https://github.com/llvm/llvm-project/commit/d96656ca9011db77ebbf6e91f380fb8894cbf820.diff

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

JDevlieghere added a comment. A few small nits but I'm very happy with the approach. Thanks Larry! Comment at: lldb/include/lldb/API/SBHostOS.h:23 + const char *GetScriptInterpreterInfo(); + Is still still relevant? Comment at:

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG976867b513ab: [lldb/test] Update TestScriptedProcess to use skinny corefiles (authored by mib). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG738621d047f2: [lldb/bindings] Change ScriptedThread initializer parameters (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112046/new/

[Lldb-commits] [PATCH] D112107: [lldb] Fix Scripted ProcessLaunchInfo Argument nullptr deref

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mib marked an inline comment as done. Closed by commit rGad0f7d3d4a0c: [lldb] Fix Scripted ProcessLaunchInfo Argument nullptr deref (authored by mib). Changed prior

[Lldb-commits] [lldb] 976867b - [lldb/test] Update TestScriptedProcess to use skinny corefiles

Author: Med Ismail Bennani Date: 2021-11-10T17:43:29+01:00 New Revision: 976867b513abbf72e505506686219efaa7f3520f URL: https://github.com/llvm/llvm-project/commit/976867b513abbf72e505506686219efaa7f3520f DIFF:

[Lldb-commits] [lldb] 738621d - [lldb/bindings] Change ScriptedThread initializer parameters

Author: Med Ismail Bennani Date: 2021-11-10T17:43:28+01:00 New Revision: 738621d047f2c14482509b39f8307967a91e7586 URL: https://github.com/llvm/llvm-project/commit/738621d047f2c14482509b39f8307967a91e7586 DIFF:

[Lldb-commits] [lldb] ad0f7d3 - [lldb] Fix Scripted ProcessLaunchInfo Argument nullptr deref

Author: Med Ismail Bennani Date: 2021-11-10T16:43:19Z New Revision: ad0f7d3d4a0c7ceaa5878494b2ad673287ef6a76 URL: https://github.com/llvm/llvm-project/commit/ad0f7d3d4a0c7ceaa5878494b2ad673287ef6a76 DIFF: https://github.com/llvm/llvm-project/commit/ad0f7d3d4a0c7ceaa5878494b2ad673287ef6a76.diff

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

JDevlieghere added a comment. Some of the formatting in the Python tests seems a little off (can you run it through something like yapf ?). Other than that this LGTM with the inline comments addressed. Comment at:

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib updated this revision to Diff 386176. mib added a comment. Move `stack_core_scripted_process.py` from `examples` to `test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files:

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

d-millar updated this revision to Diff 386169. d-millar added a comment. OK, well, took my some time but I have made an attempt to address the three areas described by Mr. Ingham: //Support for a scripting language in lldb has three distinct pieces. 1. Making the SB API's available to the

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 386170. lawrence_danna added a comment. changed internal apis to use StructuredData instead of char* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files:

[Lldb-commits] [lldb] ff7ce0a - [lldb] DeConstStringify the Property class

Author: Pavel Labath Date: 2021-11-10T15:07:30+01:00 New Revision: ff7ce0af04ae8ef034ea18c8116331c843f36c40 URL: https://github.com/llvm/llvm-project/commit/ff7ce0af04ae8ef034ea18c8116331c843f36c40 DIFF: https://github.com/llvm/llvm-project/commit/ff7ce0af04ae8ef034ea18c8116331c843f36c40.diff

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D112069#3120951 , @DavidSpickett wrote: > - Set locations for all general purpose registers > - Set register type to DWARF due to that > - Add a

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

teemperor added a comment. I actually didn't see that the patch deleted the TestCppReferenceToOuterClass test. Could you just add a `@skipIf # Crashes` or so above its `def test...` method? The test itself is still valid user code that we shouldn't crash on. I left some nits and the test

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht updated this revision to Diff 386114. rupprecht added a comment. - Switch crash repro from shell -> api test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113449/new/ https://reviews.llvm.org/D113449 Files:

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/unwind_signal/main.c:23 + SETREG("24") SETREG("25") SETREG("26") SETREG("27") + SETREG("28") SETREG("29") SETREG("30") /* 31 is xzr/sp */ + /* clang-format on */ In my

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. I'll at least make the floating point/SVE changes children of this review since it'll add some complexity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ https://reviews.llvm.org/D112069

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 386108. DavidSpickett added a comment. - Set locations for all general purpose registers - Set register type to DWARF due to that - Add a new test that sets known register values and compares them between signal catch and handler - Remove changes to

[Lldb-commits] [lldb] e786144 - [lldb] [test] Skip new signal tests on Windows

Author: Michał Górny Date: 2021-11-10T11:31:21+01:00 New Revision: e7861449ea25ccad023054b42eba80dc340a5c83 URL: https://github.com/llvm/llvm-project/commit/e7861449ea25ccad023054b42eba80dc340a5c83 DIFF: https://github.com/llvm/llvm-project/commit/e7861449ea25ccad023054b42eba80dc340a5c83.diff

[Lldb-commits] [PATCH] D113487: [lldb] Refactor Platform::ResolveExecutable

labath added a comment. Thanks, Greg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113487/new/ https://reviews.llvm.org/D113487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D113330#3119254 , @zequanwu wrote: > Use empty callsite_file or name if index is out of range. It'd be nice if you could also extend the test case

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:337 + std::lock_guard guard(GetModuleMutex()); + if (!(name_type_mask &

[Lldb-commits] [PATCH] D113533: [LLDB] Remove access check of decl in TypeSystemClang.cpp

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I'm pretty sure you're trying to solve the same problem as here: D85993 In short: You're calling `CreateFunctionDeclaration` to create a

[Lldb-commits] [PATCH] D113519: [lldb] [gdb-server] Fix fill_clamp to handle signed src types

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG82ce9127436b: [lldb] [gdb-server] Fix fill_clamp to handle signed src types (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3f1372365ac6: [lldb] Support gdbserver signals (authored by mgorny). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [lldb] 82ce912 - [lldb] [gdb-server] Fix fill_clamp to handle signed src types

Author: Michał Górny Date: 2021-11-10T09:38:55+01:00 New Revision: 82ce9127436b316eca6763b926b2cde2e3d4bb8a URL: https://github.com/llvm/llvm-project/commit/82ce9127436b316eca6763b926b2cde2e3d4bb8a DIFF: https://github.com/llvm/llvm-project/commit/82ce9127436b316eca6763b926b2cde2e3d4bb8a.diff

[Lldb-commits] [lldb] 3f13723 - [lldb] Support gdbserver signals

Author: Michał Górny Date: 2021-11-10T09:38:55+01:00 New Revision: 3f1372365ac6c860ff6ecc4cfd3ba131bdf81698 URL: https://github.com/llvm/llvm-project/commit/3f1372365ac6c860ff6ecc4cfd3ba131bdf81698 DIFF: https://github.com/llvm/llvm-project/commit/3f1372365ac6c860ff6ecc4cfd3ba131bdf81698.diff

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

labath added a comment. I have two high-level questions about this: - what should be the relative priority of executable ModuleSP vs the launch info? IIUC, in the current implementation the module takes precedence, but it seems to me it would be more natural if the launch info came out on top.